- 16 Mar, 2017 2 commits
-
-
Johan Hovold authored
Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Fixes: c04148f9 ("Input: add driver for USB VoIP phones with CM109...") Signed-off-by:
Johan Hovold <johan@kernel.org> Cc: stable@vger.kernel.org # 2.6.28 Signed-off-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com>
-
Johan Hovold authored
Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer or accessing memory that lie beyond the end of the endpoint array should a malicious device lack the expected endpoints. Signed-off-by:
-
- 10 Mar, 2017 3 commits
-
-
Matjaz Hegedic authored
EeeBook X205TA is yet another ASUS device with a special touchpad firmware that needs to be accounted for during initialization, or else the touchpad will go into an invalid state upon suspend/resume. Adding the appropriate ic_type and product_id check fixes the problem. Signed-off-by:
Matjaz Hegedic <matjaz.hegedic@gmail.com> Acked-by:
KT Liao <kt.liao@emc.com.tw> Cc: stable@vger.kernel.org Signed-off-by:
-
Dmitry Torokhov authored
TUXEDO BU1406 does not implement active multiplexing mode properly, and takes around 550 ms in i8042_set_mux_mode(). Given that the device does not have external AUX port, there is no downside in disabling the MUX mode. Reported-by:
Paul Menzel <pmenzel@molgen.mpg.de> Suggested-by:
Vojtech Pavlik <vojtech@suse.cz> Reviewed-by:
Marcos Paulo de Souza <marcos.souza.org@gmail.com> Signed-off-by:
-
Benjamin Tissoires authored
If the platform data has f30_data.disable set, f30 in rmi_f30_config() might be null. Prevent a kernel oops by checking for non-null f30. Signed-off-by:
Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by:
-
- 07 Mar, 2017 1 commit
-
-
Kai-Heng Feng authored
The aux port does not get detected without noloop quirk, so external PS/2 mouse cannot work as result. The PS/2 mouse can work with this quirk. BugLink: https://bugs.launchpad.net/bugs/1591053Signed-off-by:
Kai-Heng Feng <kai.heng.feng@canonical.com> Reviewed-by:
-
- 20 Feb, 2017 2 commits
-
-
Dmitry Torokhov authored
Prepare input updates for 4.11 merge window.
-
Javier Martinez Canillas authored
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the device was registered via OF, this means that exporting the OF device ID table device aliases in the module is not needed. But in order to change how the core reports modaliases to user-space, it's better to export it. Before this patch: $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias alias: i2c:zet6223 After this patch: $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias alias: of:N*T*Czeitec,zet6223C* alias: of:N*T*Czeitec,zet6223 alias: i2c:zet6223 Signed-off-by:
Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by:
-
- 15 Feb, 2017 1 commit
-
-
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfdDmitry Torokhov authored
Merge in cros-ec changes applied through MFD branch to resolve conflicts.
-
- 13 Feb, 2017 2 commits
-
-
Gwendal Grignou authored
Add switch to report tablet mode. Signed-off-by:
Gwendal Grignou <gwendal@chromium.org> Signed-off-by:
Enric Balletbo Serra <enric.balletbo@collabora.com> Signed-off-by:
Lee Jones <lee.jones@linaro.org>
-
IHARA Hiroka authored
ELAN0605 has been confirmed to be a variant of ELAN0600, which is blacklisted in the hid-core to be managed by elan_i2c. This device can be found in Lenovo ideapad 310s (80U4000). Signed-off-by:
Hiroka IHARA <ihara_h@live.jp> Cc: stable@vger.kernel.org Signed-off-by:
-
- 12 Feb, 2017 3 commits
-
-
Dmitry Torokhov authored
Instead of supporting legacy platform data (of which we have no mainline users) and OF-based properties, let's switch to generic device properties. This will still allow legacy boards to use the driver (by defining property sets and attaching them to the drivers) and will simplify probe and make driver usable on ACPI-based systems as well. Reviewed-By:
Sebastian Reichel <sre@kernel.org> Signed-off-by:
-
Dmitry Torokhov authored
In case of an optional regulator missing, regulator core will return ERR_PTR(-ENOENT) and not NULL, so the check for missing regulator is incorrect. Also, the regulator is not optional, it may simply be missing from platform description, so let's use devm_regulator_get() and rely on regulator core to give us dummy supply when real one is not available. Fixes: d257f298 ("Input: tsc2005 - convert to gpiod") Acked-By:
-
Dmitry Torokhov authored
To be prepared for SPI module loading using full compatible strings from device tree, let's add OF module device table data. Reviewed-By:
-
- 09 Feb, 2017 6 commits
-
-
Jelle van der Waa authored
This is a basic driver for the Zeitec ZET6223 I2C touchscreen controllers. The driver does not support firmware loading, which is not required for all tablets which contain this chip. Signed-off-by:
Jelle van der Waa <jelle@vdwaa.nl> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Raphael Assenat authored
Postpone axis initialization to the first open instead of doing it in joydev_connect. This is to make sure the generated startup events are representative of the current joystick state rather than what it was when joydev_connect() was called, potentially much earlier. Once the first user is connected to joydev node we'll be updating joydev->abs[] values and subsequent clients will be getting correct initial states as well. This solves issues with joystick driven menus that start scrolling up each time they are started, until the user moves the joystick to generate events. In emulator menu setups where the menu program is restarted every time the game exits, the repeated need to move the joystick to stop the unintended scrolling gets old rather quickly... Signed-off-by:
Raphael Assenat <raph@raphnet.net> Signed-off-by:
-
Benjamin Tissoires authored
On the latest series of ThinkPads, the button events for the TrackPoint are reported through the touchpad itself as opposed to the TrackPoint device. In order to report these buttons properly, we need to forward them to the TrackPoint device and notify psmouse to send the button presses/releases. Signed-off-by:
Lyude Paul <thatslyude@gmail.com> Signed-off-by:
-
Dmitry Torokhov authored
This patch does several cleanup changes to F30 code - switch to using BIT() macro - use DIV_ROUND_UP() where appropriate - factor out code setting up and reporting buttons - use single loop when reporting buttons: arithmetic is cheap compared to conditionals and associated branch misprediction. Tested-By:
-
Dmitry Torokhov authored
Instead of using custom method of "passing" extended buttons from the touchpad to trackstick, let's switch to the newly introduced SERIO_OOB_DATA channel. Tested-By:
-
Benjamin Tissoires authored
The tracksticks on the Lenovo thinkpads have their buttons connected through the touchpad device. We already fixed that in synaptics.c, but when we switch the device into RMI4 mode to have proper support, the pass-through functionality can't deal with them easily. We add a new PS/2 flag and protocol designed for psmouse. The RMI4 F03 pass-through can then emit a special set of commands to notify psmouse the state of the buttons. This patch implements the protocol in psmouse, while an other will do the same for rmi4-f03. Signed-off-by:
-
- 08 Feb, 2017 2 commits
-
-
Douglas Anderson authored
On some newer boards using mkbp we're hooking up non-matrix buttons and switches to the EC but NOT to the main application processor. Let's add kernel support to handle this. Rather than creating a whole new input driver, we'll continue to use cros_ec_keyb and just report the new keys. Signed-off-by:
Douglas Anderson <dianders@chromium.org> Signed-off-by:
-
Douglas Anderson authored
Add the defines for the new buttons and switches connected to the CrosEC. Signed-off-by:
-
- 07 Feb, 2017 3 commits
-
-
Arnd Bergmann authored
With CONFIG_SERIO=m, we get a build error for the rmi4-f03 driver, added in linux-4.10: warning: (HID_RMI) selects RMI4_F03 which has unmet direct dependencies (!UML && INPUT && RMI4_CORE && (SERIO=y || RMI4_CORE=SERIO)) drivers/input/built-in.o: In function `rmi_f03_attention': rmi_f03.c:(.text+0xcfe0): undefined reference to `serio_interrupt' rmi_f03.c:(.text+0xd055): undefined reference to `serio_interrupt' drivers/input/built-in.o: In function `rmi_f03_remove': rmi_f03.c:(.text+0xd115): undefined reference to `serio_unregister_port' drivers/input/built-in.o: In function `rmi_f03_probe': rmi_f03.c:(.text+0xd209): undefined reference to `__serio_register_port' An earlier patch tried to fix this, but missed the HID_RMI driver that does a 'select' on the F03 backend. This adds a hidden Kconfig symbol that enforces 'serio' to be enabled when RMI4-F03 is, which covers all cases. Fixes: d7ddad0a ("Input: synaptics-rmi4 - fix F03 build error when serio is module") Fixes: c5e8848f ("Input: synaptics-rmi4 - add support for F03") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Wei Yongjun authored
Fix to return error code -ENOMEM from the devm_kzalloc() error handling case instead of 0, as done elsewhere in this function. Fixes: 6bd0dcfa ("Input: synaptics-rmi4 - factor out functions from probe") Signed-off-by:
Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by:
-
Cameron Gutman authored
Set the LED_CORE_SUSPENDRESUME flag on our LED device so the LED state will be automatically restored by LED core on resume. Since Xbox One pads stop flashing only when reinitialized, we'll send them the initialization packet so they calm down too. Signed-off-by:
Cameron Gutman <aicommander@gmail.com> Signed-off-by:
-
- 06 Feb, 2017 3 commits
-
-
Dmitry Torokhov authored
Bring in latest RMI4 support in preparation to the merge window.
-
Benjamin Tissoires authored
If a function needs to communicate with an other, it's better to have a way to retrieve this other. Reviewed-by:
Andrew Duggan <aduggan@synaptics.com> Signed-off-by:
-
Cameron Gutman authored
The Xbox One S requires an ack to its mode button report, otherwise it continuously retransmits the report. This makes the mode button appear to be stuck down after it is pressed for the first time. Signed-off-by:
-
- 01 Feb, 2017 3 commits
-
-
Dmitry Torokhov authored
We have a nice macro ensuring that the value is within certain range, let's use it instead of open-coding. Signed-off-by: -
Dmitry Torokhov authored
If device is supposed to send absolute events (i.e. EV_ABS bit is set in dev->evbit) but dev->absinfo is not allocated, then the driver has done something wrong, and we should not register such device. Otherwise we'll crash later, when driver tries to send absolute event. Reviewed-by:
Jiri Kosina <jkosina@suse.cz> Signed-off-by:
-
Dmitry Torokhov authored
If user tries to initialize uinput device mixing old and new style initialization (i.e. using old UI_SET_ABSBIT instead of UI_ABS_SETUP, we forget to allocate input->absinfo and will crash when trying to send absolute events: ioctl(ui, UI_DEV_SETUP, &us); ioctl(ui, UI_SET_PHYS, "Test"); ioctl(ui, UI_SET_EVBIT, EV_ABS); ioctl(ui, UI_SET_ABSBIT, ABS_X); ioctl(ui, UI_SET_ABSBIT, ABS_Y); ioctl(ui, UI_DEV_CREATE, 0); Reported-by:Rodrigo Rivas Costa <rodrigorivascosta@gmail.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=191811 Fixes: fbae10db ("Input: uinput - rework ABS validation") Reviewed-by:
-
- 31 Jan, 2017 7 commits
-
-
Nick Dyer authored
These attributes provide various bits of information which may be enumerated under the RMI4 protocol to user space. This may be useful for displaying the particular version which is in use, or selecting the correct firmware to flash. Signed-off-by:
Nick Dyer <nick@shmanahar.org> Tested-by:
Chris Healy <cphealy@gmail.com> Signed-off-by:
-
Nick Dyer authored
The attribute returns the percentage complete. If the firmware update fails, it reports a negative error code. Signed-off-by:
-
Dmitry Torokhov authored
Evdev interface has been available for many years and by now everyone is switched to using it, so let's stop offering /dev/input/mouseN and /dev/psaux by default. Acked-by:
Peter Hutterer <peter.hutterer@who-t.net> Acked-by:
-
Dmitry Torokhov authored
Let's drop legacy platform data support (there are no users in mainline) and switch to using generic device properties, which will make the driver simpler (non-OF boards can use property sets to describe hardware). Reviewed-by:
Maxime Ripard <maxime.ripard@free-electrons.com> Signed-off-by:
-
Dmitry Torokhov authored
Instead of being OF-specific, let's switch to using generic device properties, which will make this code usable on ACPI, device tree and legacy boards that use property sets. As part of the change let's rename matrix_keypad_parse_of_params() to matrix_keypad_parse_properties(). Signed-off-by: -
Christophe JAILLET authored
These tests are reversed. A warning should be displayed if an error is returned, not on success. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by:
-
Linus Walleij authored
The MPU3050 driver in the input subsystem has been superseded by a proper IIO driver found in drivers/iio/gyro/mpu3050*. Patches have been submitted to remove all defconfig and related references to the old driver and replace this input driver with the IIO driver. So delete the input driver. Input was never a good fit for sensors anyway. Signed-off-by:
Linus Walleij <linus.walleij@linaro.org> Reviewed-by:
Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by:
-
- 24 Jan, 2017 2 commits
-
-
Bhumika Goyal authored
Declare device_type structures as const as they are only stored in the type field of a device structure. This field is of type const, so add const to declaration of device_type structures. File size before: text data bss dec hex filename 17184 1344 80 18608 48b0 drivers/input/input.o File size after: text data bss dec hex filename 17248 1280 80 18608 48b0 drivers/input/input.o File size before: text data bss dec hex filename 2355 384 8 2747 abb drivers/input/rmi4/rmi_bus.o File size after: text data bss dec hex filename 2483 264 8 2755 ac3 drivers/input/rmi4/rmi_bus.o Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Dmitry Torokhov authored
Sync up with mainline to bring up improvements in various subsystems.
-
