- 10 Aug, 2020 7 commits
-
-
Qinglang Miao authored
Get rid of boilerplate code by using module_platform_driver macro for v3d_drm. Signed-off-by:
Qinglang Miao <miaoqinglang@huawei.com> Signed-off-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20200810125931.186456-1-miaoqinglang@huawei.com
-
Qinglang Miao authored
When vkms_init() get into out_put, the unregister call of vkms_device->platform is missing. So add it before return. Fixes: ac19f140 ("drm/vkms: Use drmm_add_final_kfree") Signed-off-by:
-
Qinglang Miao authored
When vgem_init() get into out_put, the unregister call of vgem_device->platform is missing. So add it before return. Fixes: 363de9e7 ("drm/vgem: Use drmm_add_final_kfree") Signed-off-by:
-
Melissa Wen authored
VKMS needs vblank interrupts enabled to capture CRC. When vblank is disabled, tests like kms_cursor_crc and kms_pipe_crc_basic getting stuck waiting for a capture that will not occur until vkms wakes up. This patch adds a helper to set composer and ensure that vblank remains enabled as long as the CRC capture is needed. It clears the execution of the following kms_cursor_crc subtests: 1. pipe-A-cursor-[size,alpha-opaque, NxN-(on-screen, off-screen, sliding, random, fast-moving])] - successful when running individually. 2. pipe-A-cursor-dpms passes again 3. pipe-A-cursor-suspend also passes The issue was initially tracked in the sequential execution of IGT kms_cursor_crc subtests: when running the test sequence or one of its subtests twice, the odd execs complete and the pairs get stuck in an endless wait. In the IGT code, calling a wait_for_vblank on preparing for CRC capture prevented the busy-wait. But the problem persisted in the pipe-A-cursor-dpms and -suspend subtests. Checking the history, the pipe-A-cursor-dpms subtest was successful when, in vkms_atomic_commit_tail, instead of using the flip_done op, it used wait_for_vblanks. Another way to prevent blocking was wait_one_vblank when enabling crtc. However, in both cases, pipe-A-cursor-suspend persisted blocking in the 2nd start of CRC capture, which may indicate that something got stuck in the step of CRC setup. Indeed, wait_one_vblank in the crc setup was able to sync things and free all kms_cursor_crc subtests. Besides, other alternatives to force enabling vblanks or prevent disabling them such as calling drm_crtc_put_vblank or modeset_enables before commit_planes + offdelay = 0, also unlock all subtests executions. Finally, due to vkms's dependence on vblank interruptions to perform tasks, this patch uses refcount to ensure that vblanks happen when enabling composer and while crc capture is needed. Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> Cc: Haneen Mohammed <hamohammed.sa@gmail.com> v2: - extract a vkms_set_composer helper - fix vblank refcounting for the disabling case v3: - make the vkms_set_composer helper static - review the credit tags Co-debugged-by:
Sidong Yang <realwakka@gmail.com> Signed-off-by:
Melissa Wen <melissa.srw@gmail.com> Reviewed-by:
-
Colin Ian King authored
There a handful of spelling mistakes. fix them. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Dave Airlie authored
There is no need for that now since it's embedded. Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200806233459.4057784-3-airlied@gmail.com
-
Dave Airlie authored
Christian suggested this and it makes sense. Reviewed-by:
-
- 08 Aug, 2020 1 commit
-
-
Joe Perches authored
These functions are now empty and no longer useful so remove the functions and their uses. Signed-off-by:
Joe Perches <joe@perches.com> Cc: Bernard Zhao <bernard@vivo.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org>, Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Icenowy Zheng <icenowy@aosc.io>, Cc: Jagan Teki <jagan@amarulasolutions.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Robert Chiras <robert.chiras@nxp.com> Cc: dri-devel@lists.freedesktop.org, Cc: linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com Signed-off-by: Sam Ravnborg <sam@ravnborg.org> # Fixed build and a few warnings Link: https://patchwork.freedesktop.org/patch/msgid/9e13761020750b1ce2f1fabee23ef6e2a2942882.camel@perches.com
-
- 07 Aug, 2020 15 commits
-
-
Sam Ravnborg authored
When building imgag200 for the alpha architecture it fails like this: mgag200_drv.c:233:9: error: implicit declaration of function ‘vmalloc’ 233 | bios = vmalloc(size); | ^~~~~~~ | kmalloc When building for other architectures vmalloc.h is pulled in via some other header file - for example asm-generic/io.h. Use an explicit include of vmalloc.h to fix the build. Signed-off-by:Sam Ravnborg <sam@ravnborg.org> Reviewed-by:
-
Navid Emamdoost authored
in panfrost_perfcnt_enable_locked, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Acked-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Signed-off-by:
Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by:
Rob Herring <robh@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20200614063619.44944-1-navid.emamdoost@gmail.com
-
Clément Péron authored
Some OPP tables specify voltage for each frequency. Devfreq can handle these regulators but they should be get only 1 time to avoid issue and know who is in charge. If OPP table is probe don't init regulator. Reviewed-by:
Steven Price <steven.price@arm.com> Reviewed-by:
Clément Péron <peron.clem@gmail.com> Signed-off-by:
-
Clément Péron authored
We will later introduce regulators managed by OPP. Only alloc regulators when it's needed. This also help use to release the regulators only when they are allocated. Reviewed-by:
-
Clément Péron authored
Later we will introduce devfreq probing regulator if they are present. As regulator should be probe only one time we need to get this logic in the device_init(). panfrost_device is already taking care of devfreq_resume() and devfreq_suspend(), so it's not totally illogic to move the devfreq_init() and devfreq_fini() here. Reviewed-by:
-
Clément Péron authored
Rename goto labels in device_init it will be easier to maintain. Reviewed-by:
-
Clément Péron authored
Introduce a boolean to know if opp table has been added. With this, we can call panfrost_devfreq_fini() in case of error and release what has been initialised. Reviewed-by:
-
Clément Péron authored
Convert busy_count to a simple int protected by spinlock. Reviewed-by:
-
Clément Péron authored
Introduce a proper panfrost_devfreq to deal with devfreq variables. Reviewed-by:
-
Clément Péron authored
This use devfreq variable that will be lock with spinlock in future patches. We should either introduce a function to access this one but as devfreq is optional let's just remove it. Reviewed-by:
-
Clément Péron authored
Don't include not required headers and sort them. Reviewed-by:
-
Clément Péron authored
This declaration can be avoided so change it. Reviewed-by:
-
Tomeu Vizoso authored
Mesa now supports some Bifrost devices, so enable it. Tested-by:
Heiko Stuebner <heiko@sntech.de> Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Signed-off-by:
-
Tomeu Vizoso authored
Bifrost devices do support the flush reduction feature, so on first job submit we were trying to read the register while still powered off. If the GPU is powered off, the feature doesn't bring any benefit, so don't try to read. Tested-by:
-
Christian König authored
We need to allocate that manually now. Signed-off-by:
Michel Dänzer <mdaenzer@redhat.com> Tested-by:
-
- 06 Aug, 2020 17 commits
-
-
Dave Airlie authored
This name better reflects what the object does. I didn't rename all the pointers it seemed too messy. Signed-off-by:
Ben Skeggs <bskeggs@redhat.com> Signed-off-by:
-
Dave Airlie authored
This name makes a lot more sense, since these are about managing driver resources rather than just memory ranges. Acked-by:
-
Dave Airlie authored
The generic manager is called the range manager now, rename the file and some internals. Reviewed-by:
-
Dave Airlie authored
This converts vmwgfx over to using an interface to set the in use and check the in use flag. Reviewed-by:
-
Dave Airlie authored
under driver control, this flag isn't needed anymore, remove the API that used to access it, and consoldiate with the used api. Reviewed-by:
-
Dave Airlie authored
The driver now controls these, the core just controls the system memory one. v2: init sysman explicitly and assign it as a driver manager to simplify the lookup sequence. Reviewed-by:
-
Dave Airlie authored
This link isn't needed anymore, drop it from the init interface. Reviewed-by:
-
Dave Airlie authored
Just store the device in the private so the link can be removed from the manager Reviewed-by:
-
Dave Airlie authored
This isn't needed anymore by any drivers. Reviewed-by:
-
Dave Airlie authored
Reviewed-by:
-
Dave Airlie authored
Reviewed-by:
-
Dave Airlie authored
Reviewed-by:
-
Dave Airlie authored
Reviewed-by:
-
Dave Airlie authored
This makes it easier to move these to a driver allocated system Reviewed-by:
-
Dave Airlie authored
Reviewed-by:
-
Dave Airlie authored
This will get removed eventually and all drivers will use this. Reviewed-by:
-
Dave Airlie authored
Other users of this should notice this change and switch to wrapper. Reviewed-by:
-
