Skip to content

L
linux
Switch branch/tag
  1. 25 Aug, 2007 7 commits
  3. 24 Aug, 2007 27 commits
  5. 23 Aug, 2007 6 commits
    • Mauro Carvalho Chehab's avatar
      V4L/DVB (6070): Fix a warning at dvb_net · 04b35abe
      Mauro Carvalho Chehab authored 
      static function dvb_net_sec declares input arg "pkt" as u8. However, the
same argument at dvb_net_sec_callback is defined as "const u8". When
calling dvb_net_sec, this is casted as just "u8".

gcc 4.2.1 generates a warning about that:

  CC [M]  drivers/media/dvb/dvb-core/dvb_net.o
drivers/media/dvb/dvb-core/dvb_net.c: In function "dvb_net_sec_callback":
drivers/media/dvb/dvb-core/dvb_net.c:905: warning: passing argument 2 of
		"dvb_net_sec" discards qualifiers from pointer target type
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
      04b35abe
    • Trent Piepho's avatar
      V4L/DVB (6042): b2c2-flexcop: fix Airstar HD5000 tuning regression · 6175e487
      Trent Piepho authored 
      Git changeset 6bdcc6e6 dropped the
stand-alone lgh06xf module, whose functionality was absorbed into the
dvb-pll module. However, there was a minor difference between the code
in lgh06xf and dvb-pll, which caused a regression in b2c2-flexcop
devices using the LG-H06xF NIM.

dvb-pll will probe for the presence of an i2c pll chip by performing a
single byte read, the lgh06xf driver did not do this. Unfortunately, the
code in flexcop-i2c.c does not currently support 1 byte or 0 byte reads
as a probe.  Such probes with the current code will always fail.

In order to work around this problem, and restore proper functionality
of the Airstar HD5000 device, this hack was created to make the probe
appear to succeed.  The single byte read in dvb_pll_attach is the only
place where such a probe would ever occur, so this change is safe, and
will not affect any other devices.

Of course, if one knew how to actually perform the read operation, it
would be better to go that route.  In the meantime, however, we must
apply this workaround, in order to prevent the regression that causes
tuning to fail on the Airstar HD5000 ATSC device.

Thanks to Jarod Wilson, who had originally reported this regression, and
to Geoffrey Hausheer, whose original workaround patch led us to find the
actual cause of the problem.
Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
Cc: Geoffrey Hausheer <inli3epy93n@phracturedblue.com>
Acked-by: default avatarJarod Wilson <jwilson@redhat.com>
Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
      6175e487
    • Mariusz Kozlowski's avatar
      9p: fix bad error path in conversion routines · 02881d94
      Mariusz Kozlowski authored 
      When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err))
and it will not be happy about it.
Signed-off-by: default avatarMariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      02881d94
    • Eric Van Hensbergen's avatar
      9p: remove deprecated v9fs_fid_lookup_remove() · fbcb7599
      Eric Van Hensbergen authored 
      This patch removes the v9fs_fid_lookup_remove which is no longer used.

Based on original patch from Adrian Bunk <bunk@stusta.de> which
used #if 0 to isolate the code.
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      fbcb7599
    • Eric Van Hensbergen's avatar
      9p: update maintainers and documentation · 27a2a5ff
      Eric Van Hensbergen authored 
      Updates to the MAINTAINERS file and documentation for 9p to point to the
swik wiki versus the outdated sf.net page.  Also updated some email addresses
and added pointers to papers which better describe the implementation and
application of the Linux 9p client.
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      27a2a5ff
    • Eric Van Hensbergen's avatar
      9p: fix use after free · 1a3cac6c
      Eric Van Hensbergen authored 
      On 7/22/07, Adrian Bunk <bunk@stusta.de> wrote:
     The Coverity checker spotted the following use-after-free
     in net/9p/mux.c:

     <--  snip  -->

     ...
     struct p9_conn *p9_conn_create(struct p9_transport *trans, int msize,
                                         unsigned char *extended)
     {
     ...
             if (!m->tagpool) {
                     kfree(m);
                     return ERR_PTR(PTR_ERR(m->tagpool));
             }
     ...

     <--  snip  -->

Also spotted was a leak of the same structure further down in the function.
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
      1a3cac6c
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7