- 05 Oct, 2023 14 commits
-
-
Philipp Hortmann authored
Remove rtl92e_dm_restore_state() as it is unused. Remove called functions _rtl92e_dm_tx_power_reset_recovery() and _rtl92e_dm_bb_initialgain_restore() as well. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/be2293f1e50993ae473130403b6150d04427576e.1696266964.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
rtl92e_dm_backup_state() is unused. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
Remove r8192_private_handler _rtl92e_wx_force_reset() as driver does not reset. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables priv->reset_count, reset_cnt and reset_cnt_highpwr as those are always 0. All equations result accordingly. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
ieee->is_silent_reset is set to false and never changed. All equations result accordingly. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
Remove unused parameter is_silent_reset from _rtl92e_up(). Signed-off-by:
-
Philipp Hortmann authored
Remove unused parameter is_silent_reset from _rtl92e_sta_up(). Signed-off-by:
-
Philipp Hortmann authored
priv->reset_in_progress is set to false and never changed. All equations result accordingly. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
priv->rst_progress is set to RESET_TYPE_NORESET and never changed. All equations are true. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
When the function _rtl92e_if_silent_reset() is called the variable priv->rst_progress is set to RESET_TYPE_SILENT. Since priv->up is always true the function is left at "if (priv->up) {" without resetting. Now the function _rtl92e_if_silent_reset() is like deactivated because the equation at the very beginning is false: "if (priv->rst_progress == RESET_TYPE_NORESET) {" This leads to a state where the driver hangs in the reset state and cannot go forward. In 30% of the cases the wlan is disconnected and cannot reconnect. The rest of the time it continues working but no reset is done at all. Further requests for reset are ignored. Remove broken function _rtl92e_if_silent_reset() and remove return value of _rtl92e_if_check_reset() to avoid compiler warnings. Signed-off-by: -
Philipp Hortmann authored
ResetType == RESET_TYPE_NORMAL is always false. Remove dead code. Signed-off-by:
-
Philipp Hortmann authored
The return value of _rtl92e_tx_check_stuck() and _rtl92e_rx_check_stuck() can only be RESET_TYPE_SILENT or RESET_TYPE_NORESET. This functions are only used in _rtl92e_if_check_reset(). In _rtl92e_if_check_reset() the return values are checked for RESET_TYPE_NORMAL which cannot occur. Signed-off-by:
-
Philipp Hortmann authored
Remove ibss_maxjoin_chal as it is just set and never evaluated. Signed-off-by:
-
Chengfeng Ye authored
As &priv->tx_dev.tx_dev_lock is also acquired by xmit callback which could be call from timer under softirq context, use spin_lock_bh() on it to prevent potential deadlock. hostif_sme_work() --> hostif_sme_set_pmksa() --> hostif_mib_set_request() --> ks_wlan_hw_tx() --> spin_lock(&priv->tx_dev.tx_dev_lock) ks_wlan_start_xmit() --> hostif_data_request() --> ks_wlan_hw_tx() --> spin_lock(&priv->tx_dev.tx_dev_lock) Signed-off-by:
Chengfeng Ye <dg573847474@gmail.com> Link: https://lore.kernel.org/r/20230926161323.41928-1-dg573847474@gmail.comSigned-off-by:
-
- 26 Sep, 2023 26 commits
-
-
Pavan Bobba authored
variable name "byRFType" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by:
Pavan Bobba <opensource206@gmail.com> Tested-by:
-
Arnd Bergmann authored
The rtllib_rxb structure contains a pointer, so this is not a hardware structure but could benefit from loading the pointer in a single instruction rather than assembling it from four or eight individual bytes. Both structures are allocated as part of larger structure that already enforce at least a 4-byte alignment, so there is no reason to ever have to deal with misaligned definitions. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20230925155413.471287-2-arnd@kernel.orgSigned-off-by:
-
Philipp Hortmann authored
Resolve circular locking from reorder_spinlock with rx_pkt_pending_timer. Signed-off-by:
-
Philipp Hortmann authored
The following command uses the mutex ieee->wx_mutex: cancel_delayed_work_sync(&ieee->associate_retry_wq) Therefore it cannot be canceled with ieee->wx_mutex locked. rtllib_stop_protocol() is always called with ieee->wx_mutex locked so according line can be unlocked. Signed-off-by:
-
Philipp Hortmann authored
The following commands use the mutex ieee->wx_mutex: cancel_delayed_work_sync(&ieee->associate_retry_wq) cancel_delayed_work_sync(&ieee->associate_procedure_wq) cancel_work_sync(&ieee->wx_sync_scan_wq) Therefore they cannot be canceled with ieee->wx_mutex locked. As the work functions are executed time shifted during normal operation of the driver, proper locking can only be done inside the functions. Signed-off-by:
-
Philipp Hortmann authored
To reverse order of initialization put kfree() to the end of rtllib_softmac_free(). Signed-off-by:
-
Philipp Hortmann authored
rtllib_start_send_beacons() is removed so no need for rtllib_stop_send_beacons() anymore. Signed-off-by:
-
Philipp Hortmann authored
Remove delayed_work start_ibss_wq and the related functions which are not needed anymore. Signed-off-by:
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtllib_softmac.c. Signed-off-by:
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtl_cam.c. Signed-off-by:
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtl_core.c and further files. Signed-off-by:
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtllib_rx.c and all related functions and structs. Signed-off-by:
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtllib_tx.c, rtl819x_TSProc.c, rtl819x_HTProc.c, r8192E_dev.c Signed-off-by:
-
Tree Davies authored
Rename variable StatusCode to status_code to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
-
Tree Davies authored
Rename function TSInitialize to rtllib_ts_init to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename function GetTs to rtllib_get_ts to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable Policy to policy to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable pStatusCode to status_code to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable Addr to addr to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable pPendingBA to pending_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable Dst to dst to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable pPendingBa to pending_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable pAdmittedBa to admitted_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable Time to time to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Philipp Hortmann authored
iwe.u.name and proto_name have both 16 bytes of space. But when writing to iwe.u.name the first 10 bytes are used by the fixed string "IEEE802.11". Evaluating the code shows that only the following strings can occur in proto_name: "N-24G", "g", "b", "bg". Therefore it is sufficient to shorten proto_name to 6 bytes. Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309171733.Gl96cmYd-lkp@intel.com/Signed-off-by:
-
Philipp Hortmann authored
Fix alignment of structs to even addresses to support all architectures. Reported-by:
-
