- 06 Sep, 2011 40 commits
-
-
Arend van Spriel authored
Running sparse over the driver sources showed 1356 sparse messages and quite a number are due to missing __iomem attribute in some places. This patch reduces the number significantly. Reported-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Reviewed-by:
Roland Vossen <rvossen@broadcom.com> Reviewed-by:
Pieter-Paul Giesberts <pieterpg@broadcom.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Arend van Spriel authored
Cleanup resulted in merging several files and made several symbols local to a source file. These were found by running sparse as it gave the warning: symbol 'foo' was not declared. Should it be static? Reported-by:
Franky (Zhenhui) Lin <frankyl@broadcom.com> Reviewed-by:
-
Franky Lin authored
Reshuffle function order in dhd_linux of fullmac to get rid of static function declaration Reported-by:
Johannes Berg <johannes@sipsolutions.net> Reviewed-by:
Arend van Spriel <arend@broadcom.com> Signed-off-by:
-
Franky Lin authored
Reshuffle function order in bcmsdh_sdmmc of fullmac to get rid of static function declaration Reported-by:
-
Franky Lin authored
sdioh command type is not used in brcmf_sdioh_request_word. This patch removes the related code. Reviewed-by:
-
Franky Lin authored
sdioh data mode is not used in brcmf_sdioh_request_buffer. The patch removes the related code. Reviewed-by:
-
Franky Lin authored
The address stored in sdiodev can be used directly instead of using the wrapper function brcmf_sdcard_cur_sbwad. Reviewed-by:
-
Franky Lin authored
In fullmac, brcmf_sdbrcm_set_siaddr_window and brcmf_sdcard_set_sbaddr_window have identical fucntionality. Remove the one in dhd_sdio.c Reported-by:
Rafal Milecki <zajec5@gmail.com> Reviewed-by:
-
Franky Lin authored
Use unify config marco for debug info. Related event debug print out can be enabled/disabled by the dedicated event message level. Reported-by:
-
Roland Vossen authored
Code cleanup. Advantage is more readable code and better type checking. Reported-by:
-
Roland Vossen authored
Macros impacting the code flow are sort of frowned upon. No other macro's in the source code impact the code flow. Replaced macro by function. Reported-by:
-
Arend van Spriel authored
Function prototypes for static functions are not strictly needed and considered unwanted by linux community. This patch reorders the functions in brcmsmac/main.c and gets rid of the prototypes. Reported-by:
-
Henry Ptasinski authored
Also eliminate a cast to int that could cause issues with very large values of di->rxbufsize (as suggested by Dan Carpenter). Signed-off-by:
Henry Ptasinski <henryp@broadcom.com> Signed-off-by:
-
Roland Vossen authored
nicpci.c, srom.c and stf.c Reported-by:
-
Roland Vossen authored
Reported-by:
-
Roland Vossen authored
Reported-by:
-
Roland Vossen authored
Reported-by:
-
Roland Vossen authored
Reported-by:
-
Roland Vossen authored
Reported-by:
-
Roland Vossen authored
Reported-by:
-
Roland Vossen authored
Reported-by:
-
Larry Finger authored
Smatch reports the following problems: CHECK drivers/staging/rtl8192e/rtllib_softmac.c drivers/staging/rtl8192e/rtllib_softmac.c +3143 rtllib_softmac_free(4) info: redundant null check on ieee->pDot11dInfo calling kfree() CHECK drivers/staging/rtl8192e/rtllib_module.c drivers/staging/rtl8192e/rtllib_module.c +198 free_rtllib(6) info: redundant null check on ieee->pHTInfo calling kfree() CHECK drivers/staging/rtl8192e/rtl819x_TSProc.c drivers/staging/rtl8192e/rtl819x_TSProc.c +280 SearchAdmitTRStream(52) error: potential null derefence 'pRet'. Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Larry Finger authored
Smatch reports the follwing warnings: CHECK drivers/staging/rtl8192e/rtllib_rx.c drivers/staging/rtl8192e/rtllib_rx.c +552 RxReorderIndicatePacket(6) warn: 'prxbIndicateArray' puts 1024 bytes on stack CHECK drivers/staging/rtl8192e/rtl819x_TSProc.c drivers/staging/rtl8192e/rtl819x_TSProc.c +40 RxPktPendingTimeout(9) warn: 'stats_IndicateArray' puts 1024 bytes on stack CHECK drivers/staging/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/r8192E_phy.c +859 rtl8192_phy_SwChnlStepByStep(11) warn: function puts 797 bytes on stack CHECK drivers/staging/rtl8192e/rtllib_rx.c drivers/staging/rtl8192e/rtllib_rx.c +552 RxReorderIndicatePacket(6) warn: 'prxbIndicateArray' puts 1024 bytes on stack These are fixed by adding the arrays in question as a union in a struct used by nearly all routines. Signed-off-by:
-
Larry Finger authored
Smatch reports the following: CHECK drivers/staging/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/r8192E_phy.c +940 rtl8192_phy_SwChnlStepByStep(92) error: potential null derefence 'CurrentCmd'. Signed-off-by:
-
Larry Finger authored
Smatch outputs the following warning: CHECK drivers/staging/rtl8192e/rtl819x_BAProc.c drivers/staging/rtl8192e/rtl819x_BAProc.c +88 rtllib_ADDBA(12) warn: variable dereferenced before check 'ieee' As ieee cannot be NULL at this point, remove all such checks. Signed-off-by:
-
Larry Finger authored
Smatch outputs the following informational message: CHECK drivers/staging/rtl8192e/r8192E_cmdpkt.c drivers/staging/rtl8192e/r8192E_cmdpkt.c +419 cmpk_message_handle_rx(77) info: ignoring unreachable code. Signed-off-by:
-
Larry Finger authored
Smatch reports the following warning: CHECK drivers/staging/rtl8192e/rtl_wx.c drivers/staging/rtl8192e/rtl_wx.c +262 r8192se_wx_set_radio(16) warn: inconsistent returns sem:&priv->wx_sem: locked (258) unlocked (262) Signed-off-by:
-
Larry Finger authored
Smatch reports the following informational output: CHECK drivers/staging/rtl8192e/r8192E_dev.c drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13) info: ignoring unreachable code. drivers/staging/rtl8192e/r8192E_dev.c +2404 ActUpdateChannelAccessSetting(13) info: ignoring unreachable code. Signed-off-by:
-
Larry Finger authored
Smatch shows the following errors: CHECK drivers/staging/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl_core.c +600 rtl8192_qos_activate(7) warn: variable dereferenced before check 'priv' drivers/staging/rtl8192e/rtl_core.c +1345 rtl8192_init(40) warn: 'dev->irq' was not released on error drivers/staging/rtl8192e/rtl_core.c +2120 rtl8192_alloc_rx_desc_ring(43) error: potential null derefence 'entry'. drivers/staging/rtl8192e/rtl_core.c +3010 rtl8192_pci_probe(153) warn: 'pmem_start' was not released on error Signed-off-by:
-
Larry Finger authored
File rtl_core.c contains the statement "#define MOVE_INTO_HANDLER". As a result, everything inside an "ifndef MOVE_INTO_HANDLER" is dead code and can be removed. Signed-off-by:
-
Mike Sterling authored
If a LUN larger than 2 TB is attached to a Linux VM on Hyper-V, we currently report a maximum size of 2 TB. This patch resolves the issue in hv_storvsc. Thanks to Robert Scheck <robert.scheck@etes.de> for reporting the issue. Reported-by:
Robert Scheck <robert.scheck@etes.de> Signed-off-by:
Mike Sterling <mike.sterling@microsoft.com> Signed-off-by:
K.Y. Srinivasan <kys@microsoft.com> Signed-off-by:
Haiyang Zhang <haiyangz@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by:
-
Michael Hennerich authored
In case the AD7153 is selected we need to make sure we provide channel info for the first capacitance input in both single ended and differential configuration. Signed-off-by:
Michael Hennerich <michael.hennerich@analog.com> Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Michael Hennerich authored
Signed-off-by:
-
Michael Hennerich authored
Use KBUILD_MODNAME Fix indention style Signed-off-by:
-
Michael Hennerich authored
Signed-off-by:
-
Michael Hennerich authored
Signed-off-by:
-
Michael Hennerich authored
Fix channel type handling Signed-off-by:
-
Michael Hennerich authored
Signed-off-by:
-
Michael Hennerich authored
Signed-off-by:
-
Michael Hennerich authored
Signed-off-by:
-
