- 04 Oct, 2015 40 commits
-
-
Tim Sell authored
Registration of visorinput_open() and visorinput_close() for each device allow us to eliminate unnecessary activity when nobody in user-land cares. Signed-off-by:
Tim Sell <Timothy.Sell@unisys.com> Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tim Sell authored
BUS_HOST wasn't really appropriate, so I changed to BUS_VIRTUAL, which is what virtio uses. Signed-off-by:
-
Tim Sell authored
Just a simple search and replace in the comments. Signed-off-by:
-
Tim Sell authored
Multi-line comments were modified to conform to kernel conventions: /* * multi-line * comments */ doc-test /** */ for some comments was removed. Signed-off-by: -
Tim Sell authored
This also gave me a warning with the assignment: visorinput_dev->keycode = visorkbd_keycode; because input_dev->keycode is NOT static but visorkbd_keycode now is, so I went ahead and also added logic to stash away non-static copies of visorkbd_keycode[] and visorkbd_ext_keycode[] within visorinput_devdata, and use the copy to assign to visorinput_dev->keycode. This change is also technically required, because user-space can remap keys, and we don't want this to be shared with the other keyboard devices running on the same system. Signed-off-by: -
Tim Sell authored
In order to be more consistent with kernel conventions used elsewhere, I have re-ordered declarations in visorinput.c to follow this general order (where possible): * #defines * struct/enum/union declarations * static declarations (const if possible for all of them) * forward function declarations where absolutely necessary Exceptions were made for the static declarations like the driver declaration, given that it depends on previously-defined callbacks. So such declarations are at the end of visorinput.c. Signed-off-by:
-
Tim Sell authored
keyboardchannel.h and mousechannel.h are now included within visorinput.c directly. Signed-off-by:
-
Tim Sell authored
This visorhid driver provides a Human Interface Device, but is not at all using HID, the protocol. It's a plain input driver, so for clarity, it is being renamed to visorinput. Signed-off-by:
-
Martin Kletzander authored
Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Signed-off-by:
Martin Kletzander <mkletzan@redhat.com> Signed-off-by:
-
Chaehyun Lim authored
This patch removes blank lines before close brace '}' CHECK: Blank lines aren't necessary before a close brace '}' drivers/staging/wilc1000/host_interface.c:5366: Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch replaces s32Error with result to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch changes return type of host_int_wait_msg_queue_idle from s32 to int. s32Error gets return value from wilc_mq_send that has return type of int. It should be changed return type of host_int_wait_msg_queue_idle by int as well as data type of s32Error. Signed-off-by:
-
Chaehyun Lim authored
This patch replaces hWFIDrv with wfi_drv that is first argument of host_int_set_mac_chnl_num to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch replaces u8ChNum with channel that is second argument of host_int_set_mac_chnl_num to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch replaces s32Error with result to avoid camelcase. Signed-off-by:
-
Chaehyun Lim authored
This patch changes NULL comparison style to use ! operator found by checkpatch.pl CHECK: Comparison to NULL could be written "!pstrWFIDrv" drivers/staging/wilc1000/host_interface.c:5324: Signed-off-by:
-
Chaehyun Lim authored
This patch changes return type of host_int_set_mac_chnl_num from s32 to int. s32Error gets return value from wilc_mq_send function that has return type of int. It should be changed return type of host_int_set_mac_chnl_num function by int as well as data type of s32Error. Signed-off-by:
-
Shraddha Barke authored
Use module_platform_driver for drivers whose init and exit functions only register and unregister, respectively. Thus remove some boilerplate code. A simplified version of Coccinelle patch - @A@ identifier f, x; @@ -static f(...) { return platform_driver_register(&x); } @b depends on a@ identifier e, a.x; @@ -static e(...) { platform_driver_unregister(&x); } @c depends on a && b@ identifier a.f; declarer name module_init; @@ -module_init(f); @d depends on a && b && c@ identifier b.e, a.x; declarer name module_exit; declarer name module_platform_driver; @@ -module_exit(e); +module_platform_driver(x); Signed-off-by:
Shraddha Barke <shraddha.6596@gmail.com> Signed-off-by:
-
Aybuke Ozdemir authored
Use ! operating instead of NULL checks. Addresses "CHECK: Comparison to NULL" from checkpatch.pl. Signed-off-by:
Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
-
Ksenija Stanojevic authored
Replace binary semaphore with mutex because mutex gives better performance. This change is safe because the thread that decrements the value of semaphore is also the one that increments it, and acts like a mutex where owner of the lock is the only one that can release the lock. Signed-off-by:
-
Ksenija Stanojevic authored
Struct timespec will overflow in year 2038, here it will not cause an overflow because it is used with timespec_sub, but still has to be removed as part of y2038 changes. Replace it with ktime_t. Also use monotonic instead of real-time by replacing functions getnstimeofday with ktime_get. Signed-off-by:
-
Salah Triki authored
Reads of dgnc_poll_tick are protected by dgnc_poll_lock spinlock, but the write to dgnc_poll_tick is not. It could theoretically race. Signed-off-by:
Salah Triki <salah.triki@acm.org> Signed-off-by:
-
Sudip Mukherjee authored
The dgnc_init_globals() function is only initializing the timer so initialize it directly and remove dgnc_init_globals() and change the comment appropriately. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Sudip Mukherjee authored
globals variable will be initialied to 0 and the global pointers will be to NULL. No need to initialize them separately. Signed-off-by:
-
Sudip Mukherjee authored
This NULL test is not required as iounmap will validate the argument. Signed-off-by:
-
Sudip Mukherjee authored
Change the NULL comparison style as warned by checkpatch. Signed-off-by:
-
Sudip Mukherjee authored
These variables were only assigned some values but were never used. Signed-off-by:
-
Cristina Moraru authored
Fix 'line over 80 characters' checkpatch warning Signed-off-by:
Cristina Moraru <cristina.moraru09@gmail.com> Signed-off-by:
-
Cristina Moraru authored
Fix 'No description found for parameter' kernel-doc warnings Signed-off-by:
-
Shraddha Barke authored
Remove dump_exports and print_export_data as they are defined but not used anywhere. Signed-off-by:
-
Rocco Folino authored
This patch fixes the warning generated by sparse: "symbol 'nrs_policy_get_info_locked' was not declared. Should it be static?" by declaring the function static. Signed-off-by:
Rocco Folino <rocco@devzen.net> Reviewed-by:
-
Shraddha Barke authored
Declare class_resolve_dev_name as static it is not used anywhere apart from this particular file.Also remove the declaration from header file Signed-off-by:
-
Shraddha Barke authored
Declare class_get_type and class_search_type as static since they are used only in this particular file. Also remove the declaration from header files. Signed-off-by:
-
Shraddha Barke authored
Declare class_add_conn, class_add_profile, class_cleanup, class_config_parse_rec, class_del_conn, class_detach, class_match_param, class_attach, class_setup as static since they are used only in this particular file. Also remove the corresponding declarations from header files. Signed-off-by:
-
Shraddha Barke authored
Declare cl_lock_intransit and cl_lock_extransit as static since they are used only in this particular file. Signed-off-by:
-
Shraddha Barke authored
Declare cl_page_list_assume, cl_io_cancel, cl_io_rw_advance, cl_page_list_del, cl_page_list_discard, cl_page_list_fini as static since they are used only in this particular file. Also remove them from corresponding header files Signed-off-by:
-
Shraddha Barke authored
Declare sptlrpc_parse_rule as static since it is accessed from this particular file only. Also remove its declaration from header file Signed-off-by:
-
