- 29 Oct, 2014 1 commit
-
-
Aya Mahfouz authored
This patch removes the custom printk macros dprintk, zilog_notify, zilog_error, and zilog_info. All the calls to these macros were replaced by dev_dbg, dev_notice, dev_err, and dev_info respectively whenever possible. There were cases in which pr_debug, pr_notice, pr_err and pr_info were used. It was when the calling function did not provide an appropiate dev variable. Applying this patch will trigger the out of memory checkpatch warning for two lines. It will be fixed in a separate patch. Signed-off-by:
Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 28 Oct, 2014 35 commits
-
-
Ebru Akagunduz authored
This patch removes curly braces for single statement blocks using following coccinelle script: @@ expression e1; @@ - if (e1) { + if (e1) return ...; - } Signed-off-by:Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Surya Seetharaman authored
Removed unnecessary braces using checkpatch.pl tool Signed-off-by:
Surya Seetharaman <suryaseetharaman.9@gmail.com> Signed-off-by:
-
Tapasweni Pathak authored
The following semantic patch is used to do this @r exists@ // find anything that might decrement the variable identifier i; expression E; position p; @@ int i@p; ... ( &i | i-- | --i | i-=E | i+=E ) @x disable decl_init@ identifier r.i; expression E; position p1 != r.p; @@ ( volatile int i = 0; | volatile int i; | + unsigned int i@p1 = 0; | + unsigned int i@p1; ) <... when != i = E ( i = 0 | i = 1 ) ...> Signed-off-by:
Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by:
-
Melike Yurtoglu authored
This patch fixes following sparse warnings: drivers/staging/ozwpan/ozhcd.c:1917:35: warning: incorrect type in assignment (different base types) drivers/staging/ozwpan/ozhcd.c:1917:35: expected restricted __le16 [usertype] wHubCharacteristics drivers/staging/ozwpan/ozhcd.c:1917:35: got unsigned short [unsigned] [usertype] <noident> Signed-off-by:
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Tapasweni Pathak authored
'timeval' is used to print timestamps in seconds and millisecond. 32-bit systems using 'struct timeval' will break in the year 2038, So we have to replace that code with more appropriate types. This patch changes the android driver to use timespec64. Since this is a staging driver and the output is only used for a debugfs file, it is fine to slightly change the output and use nanoseconds instead. ktime_to_timespec64, is used which will return seconds and nanoseconds. Signed-off-by:
-
Aya Mahfouz authored
This patch removes the macro PARM_INT after removing all the variables that depended on it. Signed-off-by:
-
Aya Mahfouz authored
This patch removes all of the debug symbols and the variable dgnc_debug since they are not used anywhere in the code. Signed-off-by:
-
Aya Mahfouz authored
This patch removes the variable rawreadok since it is only intialized but not used in any of the driver functions. Signed-off-by:
-
Aya Mahfouz authored
This patch removes the variable trcbuf_size given there is no real use for it anymore. All of the debug variables in this driver is basically dead code. Signed-off-by:
-
Aya Mahfouz authored
This patch removes the macros PARM_STR and PARM_ULONG given that they are not used anywhere in the driver files. Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */", remove comments about adding code, remove commented code (one left there for debugging of the function) Signed-off-by:
Veronika Kabatova <veronicca114@gmail.com> Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */" Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */" Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comment by "/* */" Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comment by "/* */" Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */", remove not needed comments about adding code Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */" Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */", remove blank commented lines Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */", remove not needed comments about adding code Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comment by "/* */" Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */", remove not needed comments (year of adding code, commented code) Signed-off-by:
-
Veronika Kabatova authored
Replace C99 "//" comments by "/* */", remove not needed comments (year of adding code, commented code) Signed-off-by:
-
Surya Seetharaman authored
Removed unwanted braces using checkpatch.pl tool. Signed-off-by:
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
Tina Johnson <tinajohnson.1234@gmail.com> Signed-off-by:
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
-
Tina Johnson authored
Unnecessary parentheses around the right hand side of an assignment is removed using the following semantic patch: @@ identifier x,f; constant C; @@ ( -x = (f / C ); +x = f / C ; | -x = (f % C ); +x = f % C ; ) Signed-off-by:
-
Vaishali Thakkar authored
This patch fixes following sparse warning at number of places in file rtl819x_BAProc.c. Warning: incorrect type in assignment (different base types) expected unsigned short [unsigned] [usertype] tmp got restricted __le16 [usertype] <noident> Here, code before this change is correct. But this change silents sparse warnings and will not harm code too. Signed-off-by:Vaishali Thakkar <vthakkar1994@gmail.com> Reviewed-by:
-
Jiayi Ye authored
Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( (<+...e1++...+>)=e2; | (<+...e1--...+>)=e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by:
Jiayi Ye <yejiayily@gmail.com> Reviewed-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Jiayi Ye authored
Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( (<+...e1++...+>)=e2; | (<+...e1--...+>)=e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by:
-
Surya Seetharaman authored
Removes the following errors generated using checkpatch.pl tool: drivers/staging/lustre/lustre/ldlm/ldlm_internal.h:247: ERROR: space required after that ';' (ctx:VxV) drivers/staging/lustre/lustre/ldlm/ldlm_internal.h:269: ERROR: space required after that ';' (ctx:VxV) Signed-off-by:
-
Jiayi Ye authored
Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( (<+...e1++...+>)=e2; | (<+...e1--...+>)=e2; | (<+...++e1...+>)=e2; | (<+...--e1...+>)=e2; | e1=e2; e1 = <+...e1...+>; | *e1=e2; *e1=e3; ) Signed-off-by:
-
Ebru Akagunduz authored
fc variable type was u16 and it has an assignment from cpu_to_le16() so its type changed as __le16. This bug found by sparse. Signed-off-by:
-
Tapasweni Pathak authored
kfree on NULL pointer is a no-op. This patch used the following semantic patch to find an instance where NULL check is present before kfree // <smpl> @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; // </smpl> Code is made more simpler by breaking up of sequence of kmallocs and adding some more exit labels. Removed unnecessary initialization of buf and fmtbuf to NULL as they are local variables. Suggested-by: -
Tapasweni Pathak authored
The region set by the call to memset, immediately overwritten by the subsequent call to memcpy makes the memset redundant. This patch removes the redundant memset before memcpy using the following coccinelle script: @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by:
-
- 27 Oct, 2014 4 commits
-
-
Tina Ruchandani authored
This patch fixes the following checkpatch error: ERROR: do not use assignment in if condition 2172: FILE: drivers/staging/lustre/lustre/llite/llite_lib.c:2172: if (!inode || !(sbi = ll_i2sbi(inode))) { Signed-off-by:Tina Ruchandani <ruchandani.tina@gmail.com> Suggested-by:
-
Tina Ruchandani authored
This patch makes the following functions static as they are only used in their respective files. These functions were detected by sparse. - lib-md.c : lnet_md_validate - lib-move.c : lnet_ni_* lnet_setpayloadbuffer lnet_peer_alive_locked lnet_msg2bufpool lnet_post_routed_recv_locked lnet_configure / lnet_unconfigure lnet_ioctl init_lnet fini_lnet Signed-off-by: -
Jiayi Ye authored
If net is null and failed path is executed, dereference null may happen. This patch fixes it. The following Coccinelle semantic patch was used. @@ expression E, E1; identifier f; statement S1,S2,S3; @@ * if (E == NULL) { ... when != if (E == NULL) S1 else S2 when != E = E1 * E->f ... when any return ...; } else S3 Signed-off-by: -
Roberta Dobrescu authored
This patch removes duplicated argument to ||, fixing the following warning detected using coccinelle tool: duplicated argument to && or ||. Signed-off-by:
Roberta Dobrescu <roberta.dobrescu@gmail.com> Signed-off-by:
-
