1. 23 Dec, 2011 2 commits
    • Christoph Hellwig's avatar
      xfs: log all dirty inodes in xfs_fs_sync_fs · be4f1ac8
      Christoph Hellwig authored
      Since Linux 2.6.36 the writeback code has introduces various measures for
      live lock prevention during sync().  Unfortunately some of these are
      actively harmful for the XFS model, where the inode gets marked dirty for
      metadata from the data I/O handler.
      
      The older_than_this checks that are now more strictly enforced since
      
          writeback: avoid livelocking WB_SYNC_ALL writeback
      
      by only calling into __writeback_inodes_sb and thus only sampling the
      current cut off time once.  But on a slow enough devices the previous
      asynchronous sync pass might not have fully completed yet, and thus XFS
      might mark metadata dirty only after that sampling of the cut off time for
      the blocking pass already happened.  I have not myself reproduced this
      myself on a real system, but by introducing artificial delay into the
      XFS I/O completion workqueues it can be reproduced easily.
      
      Fix this by iterating over all XFS inodes in ->sync_fs and log all that
      are dirty.  This might log inode that only got redirtied after the
      previous pass, but given how cheap delayed logging of inodes is it
      isn't a major concern for performance.
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
      Tested-by: default avatarMark Tinguely <tinguely@sgi.com>
      Reviewed-by: default avatarMark Tinguely <tinguely@sgi.com>
      Signed-off-by: default avatarBen Myers <bpm@sgi.com>
      be4f1ac8
    • Christoph Hellwig's avatar
      xfs: log the inode in ->write_inode calls for kupdate · 0b8fd303
      Christoph Hellwig authored
      If the writeback code writes back an inode because it has expired we currently
      use the non-blockin ->write_inode path.  This means any inode that is pinned
      is skipped.  With delayed logging and a workload that has very little log
      traffic otherwise it is very likely that an inode that gets constantly
      written to is always pinned, and thus we keep refusing to write it.  The VM
      writeback code at that point redirties it and doesn't try to write it again
      for another 30 seconds.  This means under certain scenarious time based
      metadata writeback never happens.
      
      Fix this by calling into xfs_log_inode for kupdate in addition to data
      integrity syncs, and thus transfer the inode to the log ASAP.
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
      Tested-by: default avatarMark Tinguely <tinguely@sgi.com>
      Reviewed-by: default avatarMark Tinguely <tinguely@sgi.com>
      Signed-off-by: default avatarBen Myers <bpm@sgi.com>
      0b8fd303
  2. 06 Dec, 2011 2 commits
    • Christoph Hellwig's avatar
      xfs: fix the logspace waiting algorithm · 9f9c19ec
      Christoph Hellwig authored
      Apply the scheme used in log_regrant_write_log_space to wake up any other
      threads waiting for log space before the newly added one to
      log_regrant_write_log_space as well, and factor the code into readable
      helpers.  For each of the queues we have add two helpers:
      
       - one to try to wake up all waiting threads.  This helper will also be
         usable by xfs_log_move_tail once we remove the current opportunistic
         wakeups in it.
       - one to sleep on t_wait until enough log space is available, loosely
         modelled after Linux waitqueues.
       
      And use them to reimplement the guts of log_regrant_write_log_space and
      log_regrant_write_log_space.  These two function now use one and the same
      algorithm for waiting on log space instead of subtly different ones before,
      with an option to completely unify them in the near future.
      
      Also move the filesystem shutdown handling to the common caller given
      that we had to touch it anyway.
      
      Based on hard debugging and an earlier patch from
      Chandra Seetharaman <sekharan@us.ibm.com>.
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarChandra Seetharaman <sekharan@us.ibm.com>
      Tested-by: default avatarChandra Seetharaman <sekharan@us.ibm.com>
      Signed-off-by: default avatarBen Myers <bpm@sgi.com>
      9f9c19ec
    • Christoph Hellwig's avatar
      xfs: fix nfs export of 64-bit inodes numbers on 32-bit kernels · c29f7d45
      Christoph Hellwig authored
      The i_ino field in the VFS inode is of type unsigned long and thus can't
      hold the full 64-bit inode number on 32-bit kernels.  We have the full
      inode number in the XFS inode, so use that one for nfs exports.  Note
      that I've also switched the 32-bit file handles types to it, just to make
      the code more consistent and copy & paste errors less likely to happen.
      Reported-by: default avatarGuoquan Yang <ygq51@hotmail.com>
      Reported-by: default avatarHank Peng <pengxihan@gmail.com>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarBen Myers <bpm@sgi.com>
      c29f7d45
  3. 02 Dec, 2011 1 commit
    • Dave Chinner's avatar
      xfs: fix allocation length overflow in xfs_bmapi_write() · a99ebf43
      Dave Chinner authored
      When testing the new xfstests --large-fs option that does very large
      file preallocations, this assert was tripped deep in
      xfs_alloc_vextent():
      
      XFS: Assertion failed: args->minlen <= args->maxlen, file: fs/xfs/xfs_alloc.c, line: 2239
      
      The allocation was trying to allocate a zero length extent because
      the lower 32 bits of the allocation length was zero. The remaining
      length of the allocation to be done was an exact multiple of 2^32 -
      the first case I saw was at 496TB remaining to be allocated.
      
      This turns out to be an overflow when converting the allocation
      length (a 64 bit quantity) into the extent length to allocate (a 32
      bit quantity), and it requires the length to be allocated an exact
      multiple of 2^32 blocks to trip the assert.
      
      Fix it by limiting the extent lenth to allocate to MAXEXTLEN.
      Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
      Signed-off-by: default avatarBen Myers <bpm@sgi.com>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      a99ebf43
  4. 29 Nov, 2011 3 commits
  5. 18 Nov, 2011 1 commit
    • Alex Elder's avatar
      MAINTAINERS: update XFS maintainer entry · c8891329
      Alex Elder authored
      I will no longer be maintaining XFS for SGI.  Ben Myers
      (bpm@sgi.com) has agreed to be the primary maintainer
      for XFS in my place.  I will continue to be able to push
      commits to the SGI XFS tree if required.  As such I will
      continue to be a designated XFS maintainer, but plan to
      serve in more of a backup role.
      Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
      Signed-off-by: default avatarBen Myers <bpm@sgi.com>
      c8891329
  6. 15 Nov, 2011 1 commit
    • Mitsuo Hayasaka's avatar
      xfs: use doalloc flag in xfs_qm_dqattach_one() · db3e74b5
      Mitsuo Hayasaka authored
      The doalloc arg in xfs_qm_dqattach_one() is a flag that indicates
      whether a new area to handle quota information will be allocated
      if needed. Originally, it was passed to xfs_qm_dqget(), but has
      been removed by the following commit (probably by mistake):
      
      	commit 8e9b6e7f
      	Author: Christoph Hellwig <hch@lst.de>
      	Date:   Sun Feb 8 21:51:42 2009 +0100
      
      	xfs: remove the unused XFS_QMOPT_DQLOCK flag
      
      As the result, xfs_qm_dqget() called from xfs_qm_dqattach_one()
      never allocates the new area even if it is needed.
      
      This patch gives the doalloc arg to xfs_qm_dqget() in
      xfs_qm_dqattach_one() to fix this problem.
      Signed-off-by: default avatarMitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
      Cc: Alex Elder <aelder@sgi.com>
      Cc: Christoph Hellwig <hch@infradead.org>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarBen Myers <bpm@sgi.com>
      db3e74b5
  7. 08 Nov, 2011 5 commits
    • Christoph Hellwig's avatar
      xfs: fix force shutdown handling in xfs_end_io · 810627d9
      Christoph Hellwig authored
      Ensure ioend->io_error gets propagated back to e.g. AIO completions.
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarAlex Elder <aelder@sgi.com>
      810627d9
    • Christoph Hellwig's avatar
      xfs: constify xfs_item_ops · 272e42b2
      Christoph Hellwig authored
      The log item ops aren't nessecarily the biggest exploit vector, but marking
      them const is easy enough.  Also remove the unused xfs_item_ops_t typedef
      while we're at it.
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
      Reviewed-by: default avatarAlex Elder <aelder@sgi.com>
      272e42b2
    • Carlos Maiolino's avatar
      xfs: Fix possible memory corruption in xfs_readlink · b52a360b
      Carlos Maiolino authored
      Fixes a possible memory corruption when the link is larger than
      MAXPATHLEN and XFS_DEBUG is not enabled. This also remove the
      S_ISLNK assert, since the inode mode is checked previously in
      xfs_readlink_by_handle() and via VFS.
      
      Updated to address concerns raised by Ben Hutchings about the loose
      attention paid to 32- vs 64-bit values, and the lack of handling a
      potentially negative pathlen value:
       - Changed type of "pathlen" to be xfs_fsize_t, to match that of
         ip->i_d.di_size
       - Added checking for a negative pathlen to the too-long pathlen
         test, and generalized the message that gets reported in that case
         to reflect the change
      As a result, if a negative pathlen were encountered, this function
      would return EFSCORRUPTED (and would fail an assertion for a debug
      build)--just as would a too-long pathlen.
      Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
      Signed-off-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
      Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
      b52a360b
    • Linus Torvalds's avatar
      Linux 3.2-rc1 · 1ea6b8f4
      Linus Torvalds authored
      .. with new name.  Because nothing says "really solid kernel release"
      like naming it after an extinct animal that just happened to be in the
      news lately.
      1ea6b8f4
    • Linus Torvalds's avatar
      Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap · 075cb105
      Linus Torvalds authored
      * 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap: (31 commits)
        ARM: OMAP: Fix export.h or module.h includes
        ARM: OMAP: omap_device: Include linux/export.h
        ARM: OMAP2: Fix H4 matrix keyboard warning
        ARM: OMAP1: Remove unused omap-alsa.h
        ARM: OMAP1: Fix warnings about enabling 32 KiHz timer
        ARM: OMAP2+: timer: Remove omap_device_pm_latency
        ARM: OMAP2+: clock data: Remove redundant timer clkdev
        ARM: OMAP: Devkit8000: Remove double omap_mux_init_gpio
        ARM: OMAP: usb: musb: OMAP: Delete unused function
        MAINTAINERS: Update linux-omap git repository
        ARM: OMAP: change get_context_loss_count ret value to int
        ARM: OMAP4: hsmmc: configure SDMMC1_DR0 properly
        ARM: OMAP4: hsmmc: Fix Pbias configuration on regulator OFF
        ARM: OMAP3: hwmod: fix variant registration and remove SmartReflex from common list
        ARM: OMAP: I2C: Fix omap_register_i2c_bus() return value on success
        ARM: OMAP: dmtimer: Include linux/module.h
        ARM: OMAP2+: l3-noc: Include linux/module.h
        ARM: OMAP2+: devices: Fixes for McPDM
        ARM: OMAP: Fix errors and warnings when building for one board
        ARM: OMAP3: PM: restrict erratum i443 handling to OMAP3430 only
        ...
      075cb105
  8. 07 Nov, 2011 25 commits