1. 01 Oct, 2012 2 commits
    • J. Bruce Fields's avatar
      nfsd4: set cl_minorversion at create time · c116a0af
      J. Bruce Fields authored
      And remove some mostly obsolete comments.
      Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
      c116a0af
    • J. Bruce Fields's avatar
      nfsd4: don't pin clientids to pseudoflavors · 68eb3508
      J. Bruce Fields authored
      I added cr_flavor to the data compared in same_creds without any
      justification, in d5497fc6 "nfsd4: move
      rq_flavor into svc_cred".
      
      Recent client changes then started making
      
      	mount -osec=krb5 server:/export /mnt/
      	echo "hello" >/mnt/TMP
      	umount /mnt/
      	mount -osec=krb5i server:/export /mnt/
      	echo "hello" >/mnt/TMP
      
      to fail due to a clid_inuse on the second open.
      
      Mounting sequentially like this with different flavors probably isn't
      that common outside artificial tests.  Also, the real bug here may be
      that the server isn't just destroying the former clientid in this case
      (because it isn't good enough at recognizing when the old state is
      gone).  But it prompted some discussion and a look back at the spec, and
      I think the check was probably wrong.  Fix and document.
      
      Cc: stable@kernel.org
      Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
      68eb3508
  2. 25 Sep, 2012 1 commit
  3. 10 Sep, 2012 7 commits
  4. 21 Aug, 2012 18 commits
  5. 20 Aug, 2012 10 commits
  6. 16 Aug, 2012 2 commits
    • Linus Torvalds's avatar
      Linux 3.6-rc2 · d9875690
      Linus Torvalds authored
      d9875690
    • Ian Kent's avatar
      autofs4 - fix get_next_positive_subdir() · a45440f0
      Ian Kent authored
      Following a report of a crash during an automount expire I found that
      the locking in fs/autofs4/expire.c:get_next_positive_subdir() was wrong.
      Not only is the locking wrong but the function is more complex than it
      needs to be.
      
      The function is meant to calculate (and dget) the next entry in the list
      of directories contained in the root of an autofs mount point (an autofs
      indirect mount to be precise). The main problem was that the d_lock of
      the owner of the list was not being taken when walking the list, which
      lead to list corruption under load. The only other lock that needs to
      be taken is against the next dentry candidate so it can be checked for
      usability.
      Signed-off-by: default avatarIan Kent <raven@themaw.net>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a45440f0