1. 31 Aug, 2015 2 commits
  2. 30 Aug, 2015 5 commits
  3. 29 Aug, 2015 18 commits
    • Jesse Gross's avatar
      geneve: Use GRO cells infrastructure. · 8e816df8
      Jesse Gross authored
      Geneve can benefit from GRO at the device level in a manner similar
      to other tunnels, especially as hardware offloads are still emerging.
      
      After this patch, aggregated frames are seen on the tunnel interface.
      Single stream throughput nearly doubles in ideal circumstances (on
      old hardware).
      Signed-off-by: default avatarJesse Gross <jesse@nicira.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8e816df8
    • Simon Horman's avatar
      openvswitch: retain parsed IPv6 header fields in flow on error skipping extension headers · c30da497
      Simon Horman authored
      When an error occurs skipping IPv6 extension headers retain the already
      parsed IP protocol and IPv6 addresses in the flow. Also assume that the
      packet is not a fragment in the absence of information to the contrary;
      that is always use the frag_off value set by ipv6_skip_exthdr().
      
      This allows matching on the IP protocol and IPv6 addresses of packets
      with malformed extension headers.
      Signed-off-by: default avatarSimon Horman <simon.horman@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c30da497
    • David S. Miller's avatar
      Merge branch 'for-upstream' of... · f5004a14
      David S. Miller authored
      Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next
      
      Johan Hedberg says:
      
      ====================
      pull request: bluetooth-next 2015-08-28
      
      One more bunch of Bluetooth patches for 4.3:
      
       - Crash fix for hci_bcm driver
       - Enhancements to hci_intel driver (e.g. baudrate configuration)
       - Fix for SCO link type after multiple connect attempts
       - Cleanups & minor fixes in a few other places
      
      Please let me know if there are any issues pulling. Thanks.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f5004a14
    • Tony Lindgren's avatar
      net/smsc911x: Fix deferred probe for interrupt · f892a84c
      Tony Lindgren authored
      The interrupt handler may not be available when smsc911x probes if the
      interrupt handler is a GPIO controller for example. Let's fix that
      by adding handling for -EPROBE_DEFER.
      
      Cc: Steve Glendinning <steve.glendinning@shawell.net>
      Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f892a84c
    • David S. Miller's avatar
      Merge branch 'tnl-ipv4-ipv6' · 6d742324
      David S. Miller authored
      Jiri Benc says:
      
      ====================
      tunnels: fix incorrect IPv4/v6 headers interpretation
      
      With tunneling, it is currently possible to get an IPv6 header and interpret
      it as an IPv4 header, or to interpret an IPv6 address as an IPv4 address
      (and vice versa). This leads to things like sending packets to incorrect
      address, IPv6 flow label being interpreted as IP packet length, etc.
      
      Fix several places where this can happen.
      
      Most of this is net-next only. The third patch affects net, too, but it
      doesn't seem there's anything in user space that sets the attribute at all
      currently, thus net-next is fine.
      
      Changelog:
      v2: fixed geneve after incorrect rebase on top of Pravin's patches
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6d742324
    • Jiri Benc's avatar
      vxlan: do not receive IPv4 packets on IPv6 socket · a43a9ef6
      Jiri Benc authored
      By default (subject to the sysctl settings), IPv6 sockets listen also for
      IPv4 traffic. Vxlan is not prepared for that and expects IPv6 header in
      packets received through an IPv6 socket.
      
      In addition, it's currently not possible to have both IPv4 and IPv6 vxlan
      tunnel on the same port (unless bindv6only sysctl is enabled), as it's not
      possible to create and bind both IPv4 and IPv6 vxlan interfaces and there's
      no way to specify both IPv4 and IPv6 remote/group IP addresses.
      
      Set IPV6_V6ONLY on vxlan sockets to fix both of these issues. This is not
      done globally in udp_tunnel, as l2tp and tipc seems to work okay when
      receiving IPv4 packets on IPv6 socket and people may rely on this behavior.
      The other tunnels (geneve and fou) do not support IPv6.
      Signed-off-by: default avatarJiri Benc <jbenc@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a43a9ef6
    • Jiri Benc's avatar
      fou: reject IPv6 config · b9b6695c
      Jiri Benc authored
      fou does not really support IPv6 encapsulation. After an UDP socket is
      created in fou_create, the encap_rcv callback is set either to fou_udp_recv
      or to gue_udp_recv. Both of those unconditionally assume that the received
      packet has an IPv4 header and access the data at network_header as it was an
      IPv4 header. This leads to IPv6 flow label being interpreted as IP packet
      length, etc.
      
      Disallow fou tunnel to be configured as IPv6 until real IPv6 support is
      added to fou.
      
      CC: Tom Herbert <tom@herbertland.com>
      Signed-off-by: default avatarJiri Benc <jbenc@redhat.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b9b6695c
    • Jiri Benc's avatar
      ip_tunnels: record IP version in tunnel info · 7f9562a1
      Jiri Benc authored
      There's currently nothing preventing directing packets with IPv6
      encapsulation data to IPv4 tunnels (and vice versa). If this happens,
      IPv6 addresses are incorrectly interpreted as IPv4 ones.
      
      Track whether the given ip_tunnel_key contains IPv4 or IPv6 data. Store this
      in ip_tunnel_info. Reject packets at appropriate places if they are supposed
      to be encapsulated into an incompatible protocol.
      Signed-off-by: default avatarJiri Benc <jbenc@redhat.com>
      Acked-by: default avatarAlexei Starovoitov <ast@plumgrid.com>
      Acked-by: default avatarThomas Graf <tgraf@suug.ch>
      Acked-by: default avatarPravin B Shelar <pshelar@nicira.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7f9562a1
    • Jiri Benc's avatar
      ip_tunnels: convert the mode field of ip_tunnel_info to flags · 46fa062a
      Jiri Benc authored
      The mode field holds a single bit of information only (whether the
      ip_tunnel_info struct is for rx or tx). Change the mode field to bit flags.
      This allows more mode flags to be added.
      Signed-off-by: default avatarJiri Benc <jbenc@redhat.com>
      Acked-by: default avatarAlexei Starovoitov <ast@plumgrid.com>
      Acked-by: default avatarThomas Graf <tgraf@suug.ch>
      Acked-by: default avatarPravin B Shelar <pshelar@nicira.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      46fa062a
    • David Ahern's avatar
      net: FIB tracepoints · f6d3c192
      David Ahern authored
      A few useful tracepoints developing VRF driver.
      Signed-off-by: default avatarDavid Ahern <dsa@cumulusnetworks.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f6d3c192
    • Vlad Yasevich's avatar
      sctp: Do not try to search for the transport twice · 73e67420
      Vlad Yasevich authored
      When removing an non-primary transport during ASCONF
      processing, we end up traversing the transport list
      twice: once in sctp_cmd_del_non_primary, and once in
      sctp_assoc_del_peer.  We can avoid the second
      search and call sctp_assoc_rm_peer() instead.
      Found by code inspection during code reviews.
      Signed-off-by: default avatarVladislav Yasevich <vyasevich@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      73e67420
    • Nikolay Aleksandrov's avatar
      bonding: fix bond_poll_controller bh_enable warning · b0d4943e
      Nikolay Aleksandrov authored
      The problem is rcu_read_unlock_bh() which triggers a warning when irqs are
      disabled. ndo_poll_controller should run with irqs disabled always so we
      can drop the rcu_read_lock_bh.
      
      [   98.502922] bond0: making interface eth1 the new active one
      [   98.503039] ------------[ cut here ]------------
      [   98.503039] WARNING: CPU: 0 PID: 1744 at kernel/softirq.c:150 __local_bh_enable_ip+0x96/0xc0()
      [   98.503039] Modules linked in: bonding(OE) rpcsec_gss_krb5 nfsv4 dns_resolver nfs fscache netconsole ppdev joydev parport_pc serio_raw parport i2c_piix4 video acpi_cpufreq nfsd auth_rpcgss nfs_acl lockd grace sunrpc virtio_net e1000 ata_generic pcnet32 mii virtio_pci virtio_ring virtio pata_acpi
      [   98.503039] CPU: 0 PID: 1744 Comm: ifenslave Tainted: G           OE   4.2.0-rc7+ #56
      [   98.503039] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
      [   98.503039]  0000000000000000 00000000e96ba230 ffff880020c236b8 ffffffff8183f105
      [   98.503039]  0000000000000000 0000000000000000 ffff880020c236f8 ffffffff810a9496
      [   98.503039]  ffff88002ea99e08 0000000000000200 ffffffffa02a8e06 ffff88002ea99e08
      [   98.503039] Call Trace:
      [   98.503039]  [<ffffffff8183f105>] dump_stack+0x4c/0x65
      [   98.503039]  [<ffffffff810a9496>] warn_slowpath_common+0x86/0xc0
      [   98.503039]  [<ffffffffa02a8e06>] ? bond_poll_controller+0x146/0x250 [bonding]
      [   98.503039]  [<ffffffff810a95ca>] warn_slowpath_null+0x1a/0x20
      [   98.503039]  [<ffffffff810ae376>] __local_bh_enable_ip+0x96/0xc0
      [   98.503039]  [<ffffffffa02a8e2f>] bond_poll_controller+0x16f/0x250 [bonding]
      [   98.503039]  [<ffffffffa02a8cf3>] ? bond_poll_controller+0x33/0x250 [bonding]
      [   98.503039]  [<ffffffff810feaed>] ? trace_hardirqs_off+0xd/0x10
      [   98.503039]  [<ffffffff81848afb>] ? _raw_spin_unlock_irqrestore+0x5b/0x60
      [   98.503039]  [<ffffffff816ec48e>] netpoll_poll_dev+0x6e/0x350
      [   98.503039]  [<ffffffff816eb977>] ? netpoll_start_xmit+0x137/0x1d0
      [   98.503039]  [<ffffffff816b2e8b>] ? __alloc_skb+0x5b/0x210
      [   98.503039]  [<ffffffff816ec89d>] netpoll_send_skb_on_dev+0x12d/0x2a0
      [   98.503039]  [<ffffffff816eccde>] netpoll_send_udp+0x2ce/0x430
      [   98.503039]  [<ffffffffa0190850>] write_msg+0xb0/0xf0 [netconsole]
      [   98.503039]  [<ffffffff81116b63>] call_console_drivers.constprop.25+0x133/0x260
      [   98.503039]  [<ffffffff81117934>] console_unlock+0x2f4/0x580
      [   98.503039]  [<ffffffff81117ea5>] ? vprintk_emit+0x2e5/0x630
      [   98.503039]  [<ffffffff81117ee5>] vprintk_emit+0x325/0x630
      [   98.503039]  [<ffffffff81118379>] vprintk_default+0x29/0x40
      [   98.503039]  [<ffffffff8183de4f>] printk+0x55/0x6b
      [   98.503039]  [<ffffffff816c754c>] __netdev_printk+0x16c/0x260
      [   98.503039]  [<ffffffff816c7a12>] netdev_info+0x62/0x80
      [   98.503039]  [<ffffffffa02ab464>] bond_change_active_slave+0x134/0x6a0 [bonding]
      [   98.503039]  [<ffffffffa02aba95>] bond_select_active_slave+0xc5/0x310 [bonding]
      [   98.503039]  [<ffffffffa02aeb78>] bond_enslave+0x1088/0x10c0 [bonding]
      [   98.503039]  [<ffffffffa02af46b>] bond_do_ioctl+0x37b/0x400 [bonding]
      [   98.503039]  [<ffffffff81101d8d>] ? trace_hardirqs_on+0xd/0x10
      [   98.503039]  [<ffffffff816dc437>] ? rtnl_lock+0x17/0x20
      [   98.503039]  [<ffffffff816e5fd1>] dev_ifsioc+0x331/0x3e0
      [   98.503039]  [<ffffffff816e62dc>] dev_ioctl+0xec/0x6c0
      [   98.503039]  [<ffffffff816a6c6a>] sock_do_ioctl+0x4a/0x60
      [   98.503039]  [<ffffffff816a7300>] sock_ioctl+0x1c0/0x250
      [   98.503039]  [<ffffffff81271bfe>] do_vfs_ioctl+0x2ee/0x540
      [   98.503039]  [<ffffffff810fd943>] ? up_read+0x23/0x40
      [   98.503039]  [<ffffffff81070993>] ? __do_page_fault+0x1d3/0x420
      [   98.503039]  [<ffffffff8127e246>] ? __fget_light+0x66/0x90
      [   98.503039]  [<ffffffff81271ec9>] SyS_ioctl+0x79/0x90
      [   98.503039]  [<ffffffff8184936e>] entry_SYSCALL_64_fastpath+0x12/0x76
      [   98.503039] ---[ end trace 00cfa804b0670051 ]---
      
      Fixes: 616f4541 ("bonding: implement bond_poll_controller()")
      Signed-off-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
      Acked-by: default avatarMahesh Bandewar <maheshb@google.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b0d4943e
    • Sergei Shtylyov's avatar
      sh_eth: propagate platform_get_irq() error upstream · 7a468ac6
      Sergei Shtylyov authored
      The driver overrides the error returned by platform_get_irq() with -ENODEV
      which e.g. precludes the deferred  probing from working. Propagate the real
      error code to the driver core instead.
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Acked-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7a468ac6
    • Sergei Shtylyov's avatar
      ravb: propagate platform_get_irq() error upstream · f375339e
      Sergei Shtylyov authored
      The driver overrides the error returned by platform_get_irq() with -ENODEV
      which e.g. precludes the deferred  probing from working. Propagate the real
      error code to the driver core instead.
      Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Acked-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f375339e
    • lucien's avatar
      sctp: ASCONF-ACK with Unresolvable Address should be sent · 7c5a9461
      lucien authored
      RFC 5061:
          This is an opaque integer assigned by the sender to identify each
          request parameter.  The receiver of the ASCONF Chunk will copy this
          32-bit value into the ASCONF Response Correlation ID field of the
          ASCONF-ACK response parameter.  The sender of the ASCONF can use this
          same value in the ASCONF-ACK to find which request the response is
          for.  Note that the receiver MUST NOT change this 32-bit value.
      
          Address Parameter: TLV
      
          This field contains an IPv4 or IPv6 address parameter, as described
          in Section 3.3.2.1 of [RFC4960].
      
      ASCONF chunk with Error Cause Indication Parameter (Unresolvable Address)
      should be sent if the Delete IP Address is not part of the association.
      
        Endpoint A                           Endpoint B
        (ESTABLISHED)                        (ESTABLISHED)
      
        ASCONF        ----------------->
        (Delete IP Address)
                      <-----------------      ASCONF-ACK
                                              (Unresolvable Address)
      Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
      Acked-by: default avatarVlad Yasevich <vyasevich@gmail.com>
      Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7c5a9461
    • Ken-ichirou MATSUZAWA's avatar
      netlink: mmap: fix lookup frame position · 7084a315
      Ken-ichirou MATSUZAWA authored
      __netlink_lookup_frame() was always called with the same "pos"
      value in netlink_forward_ring(). It will look at the same ring entry
      header over and over again, every time through this loop. Then cycle
      through the whole ring, advancing ring->head, not "pos" until it
      equals the "ring->head != head" loop test fails.
      Signed-off-by: default avatarKen-ichirou MATSUZAWA <chamas@h4.dion.ne.jp>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      7084a315
    • Christophe Ricard's avatar
      netlink: add NETLINK_CAP_ACK socket option · 0a6a3a23
      Christophe Ricard authored
      Since commit c05cdb1b ("netlink: allow large data transfers from
      user-space"), the kernel may fail to allocate the necessary room for the
      acknowledgment message back to userspace. This patch introduces a new
      socket option that trims off the payload of the original netlink message.
      
      The netlink message header is still included, so the user can guess from
      the sequence number what is the message that has triggered the
      acknowledgment.
      Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
      Signed-off-by: default avatarChristophe Ricard <christophe-h.ricard@st.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0a6a3a23
    • Joe Stringer's avatar
      openvswitch: Fix conntrack compilation without mark. · 0d5cdef8
      Joe Stringer authored
      Fix build with !CONFIG_NF_CONNTRACK_MARK && CONFIG_OPENVSWITCH_CONNTRACK
      
      Fixes: 182e3042 ("openvswitch: Allow matching on conntrack mark")
      Reported-by: default avatarSimon Horman <simon.horman@netronome.com>
      Signed-off-by: default avatarJoe Stringer <joestringer@nicira.com>
      Tested-by: default avatarSimon Horman <simon.horman@netronome.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0d5cdef8
  4. 28 Aug, 2015 15 commits