1. 31 Mar, 2021 14 commits
  2. 26 Mar, 2021 2 commits
    • Sergey Shtylyov's avatar
      pata_ipx4xx_cf: fix IRQ check · e379b40c
      Sergey Shtylyov authored
      The driver's probe() method is written as if platform_get_irq() returns 0
      on error, while actually it returns a negative error code (with all the
      other values considered valid IRQs).  Rewrite the driver's IRQ checking
      code to pass the positive IRQ #s to ata_host_activate(), propagate errors
      upstream, and treat IRQ0 as error, returning -EINVAL, as the libata code
      treats 0  as  an indication that polling should be used anyway...
      
      Fixes: 0df0d0a0 ("[libata] ARM: add ixp4xx PATA driver")
      Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      e379b40c
    • Sergey Shtylyov's avatar
      pata_arasan_cf: fix IRQ check · c7e8f404
      Sergey Shtylyov authored
      The driver's probe() method is written as if platform_get_irq() returns 0
      on error, while actually it returns a negative error code (with all the
      other values considered valid IRQs). Rewrite the driver's IRQ checking code
      to pass the positive IRQ #s to ata_host_activate(), propagate upstream
      -EPROBE_DEFER, and set up the driver to polling mode on (negative) errors
      and IRQ0 (libata treats IRQ #0 as a polling mode anyway)...
      
      Fixes: a480167b ("pata_arasan_cf: Adding support for arasan compact flash host controller")
      Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omprussia.ru>
      Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      c7e8f404
  3. 12 Mar, 2021 24 commits
    • Bhaskar Chowdhury's avatar
    • Lee Jones's avatar
      ata: pata_pdc2027x: Fix some incorrect function names and parameter docs · 1906cf27
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_pdc2027x.c:209: warning: expecting prototype for pdc2027x_pata_cable_detect(). Prototype was for pdc2027x_cable_detect() instead
       drivers/ata/pata_pdc2027x.c:262: warning: expecting prototype for pdc2720x_mode_filter(). Prototype was for pdc2027x_mode_filter() instead
       drivers/ata/pata_pdc2027x.c:513: warning: Function parameter or member 'board_idx' not described in 'pdc_adjust_pll'
       drivers/ata/pata_pdc2027x.c:513: warning: expecting prototype for adjust_pll(). Prototype was for pdc_adjust_pll() instead
       drivers/ata/pata_pdc2027x.c:599: warning: expecting prototype for detect_pll_input_clock(). Prototype was for pdc_detect_pll_input_clock() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Albert Lee <albertcc@tw.ibm.com>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: Frank Tiernan <frankt@promise.com>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      1906cf27
    • Lee Jones's avatar
      ata: pata_optidma: Fix a function misnaming, a formatting issue and a missing description · 92a5e882
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_optidma.c:298: warning: expecting prototype for optidma_make_bits(). Prototype was for optidma_make_bits43() instead
       drivers/ata/pata_optidma.c:319: warning: Function parameter or member 'r_failed' not described in 'optidma_set_mode'
       drivers/ata/pata_optidma.c:361: warning: Function parameter or member 'pdev' not described in 'optiplus_with_udma'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      92a5e882
    • Lee Jones's avatar
      ata: pata_jmicron: Fix incorrectly documented function parameter · efd2cbe8
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_jmicron.c:135: warning: Function parameter or member 'id' not described in 'jmicron_init_one'
       drivers/ata/pata_jmicron.c:135: warning: Excess function parameter 'ent' description in 'jmicron_init_one'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      efd2cbe8
    • Lee Jones's avatar
      ata: pata_marvell: Fix incorrectly documented function parameter · a446e2fb
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_marvell.c:125: warning: Function parameter or member 'id' not described in 'marvell_init_one'
       drivers/ata/pata_marvell.c:125: warning: Excess function parameter 'ent' description in 'marvell_init_one'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      a446e2fb
    • Lee Jones's avatar
      ata: pata_hpt3x2n: Fix possible doc-rotted function name · 2780645c
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_hpt3x2n.c:247: warning: expecting prototype for hpt3x2n_bmdma_end(). Prototype was for hpt3x2n_bmdma_stop() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      2780645c
    • Lee Jones's avatar
      ata: pata_cs5520: Add a couple of missing param descriptions · 4fabc4b6
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_cs5520.c:61: warning: Function parameter or member 'pio' not described in 'cs5520_set_timings'
       drivers/ata/pata_cs5520.c:257: warning: Function parameter or member 'mesg' not described in 'cs5520_pci_device_suspend'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      4fabc4b6
    • Lee Jones's avatar
      ata: pata_atiixp: Fix a function name and supply description for 'pio' · 2d35ba9e
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_atiixp.c:103: warning: Function parameter or member 'pio' not described in 'atiixp_set_pio_timing'
       drivers/ata/pata_atiixp.c:241: warning: expecting prototype for atiixp_dma_stop(). Prototype was for atiixp_bmdma_stop() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: ATI Inc <hyu@ati.com>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      2d35ba9e
    • Lee Jones's avatar
      ata: pata_artop: Repair possible copy/paste issue in 'artop_6210_qc_defer()'s header · 9c7d0b2a
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_artop.c:278: warning: expecting prototype for artop_6210_qc_defer(). Prototype was for artop6210_qc_defer() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: Thibaut VARENE <varenet@parisc-linux.org>
      Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      9c7d0b2a
    • Lee Jones's avatar
      ata: pata_amd: Fix incorrectly named function in the header · f18e1faa
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init(). Prototype was for nv_pre_reset() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      f18e1faa
    • Lee Jones's avatar
      ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param · 764e3bc4
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: CJ <cjtsai@ali.com.tw>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: Alan Cox <alan@redhat.com>
      Cc: Clear Zhang <Clear.Zhang@ali.com.tw>
      Cc: linux-ide@vger.kernel.org
      Cc: and cc <htejun@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      764e3bc4
    • Lee Jones's avatar
      ata: sata_mv: Fix worthy headers and demote others · f3a23c2c
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'ap' not described in 'mv_start_edma'
       drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'port_mmio' not described in 'mv_start_edma'
       drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'protocol' not described in 'mv_start_edma'
       drivers/ata/sata_mv.c:1162: warning: Excess function parameter 'base' description in 'mv_start_edma'
       drivers/ata/sata_mv.c:1535: warning: Function parameter or member 'enable_bmdma' not described in 'mv_bmdma_enable_iie'
       drivers/ata/sata_mv.c:1535: warning: expecting prototype for mv_bmdma_enable(). Prototype was for mv_bmdma_enable_iie() instead
       drivers/ata/sata_mv.c:1930: warning: Function parameter or member 'ap' not described in 'mv_bmdma_stop_ap'
       drivers/ata/sata_mv.c:1930: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead
       drivers/ata/sata_mv.c:2228: warning: Function parameter or member 'ap' not described in 'mv_send_fis'
       drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'hpriv' not described in 'mv6_reset_hc'
       drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'n_hc' not described in 'mv6_reset_hc'
       drivers/ata/sata_mv.c:3541: warning: Function parameter or member 'hpriv' not described in 'soc_is_65n'
       drivers/ata/sata_mv.c:3541: warning: expecting prototype for soc_is_65(). Prototype was for soc_is_65n() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Mark Lord <mlord@pobox.com>
      Cc: ALWAYS copy <linux-ide@vger.kernel.org>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      f3a23c2c
    • Lee Jones's avatar
      ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param · 6864e781
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/ahci_xgene.c:564: warning: Function parameter or member 'host' not described in 'xgene_ahci_handle_broken_edge_irq'
       drivers/ata/ahci_xgene.c:564: warning: Excess function parameter 'ata_host' description in 'xgene_ahci_handle_broken_edge_irq'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Loc Ho <lho@apm.com>
      Cc: Tuan Phan <tphan@apm.com>
      Cc: Suman Tripathi <stripathi@apm.com>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      6864e781
    • Lee Jones's avatar
      ata: pata_hpt37x: Fix some function misnaming and missing param issues · a51746f4
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_hpt37x.c:283: warning: Function parameter or member 'mask' not described in 'hpt370_filter'
       drivers/ata/pata_hpt37x.c:301: warning: Function parameter or member 'mask' not described in 'hpt370a_filter'
       drivers/ata/pata_hpt37x.c:473: warning: expecting prototype for hpt370_bmdma_end(). Prototype was for hpt370_bmdma_stop() instead
       drivers/ata/pata_hpt37x.c:567: warning: expecting prototype for hpt37x_bmdma_end(). Prototype was for hpt37x_bmdma_stop() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      a51746f4
    • Lee Jones's avatar
      ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param · d6c2aaae
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_hpt366.c:200: warning: Function parameter or member 'mask' not described in 'hpt366_filter'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      d6c2aaae
    • Lee Jones's avatar
      ata: pata_amd: Remove superfluous, add missing and fix broken params · 73b90681
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_amd.c:179: warning: Excess function parameter 'adev' description in 'amd_fifo_setup'
       drivers/ata/pata_amd.c:331: warning: Function parameter or member 'link' not described in 'nv_pre_reset'
       drivers/ata/pata_amd.c:331: warning: Function parameter or member 'deadline' not described in 'nv_pre_reset'
       drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init(). Prototype was for nv_pre_reset() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      73b90681
    • Lee Jones's avatar
      ata: pata_artop: Fix a function name and parameter description · 5c16c0ce
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_artop.c:278: warning: expecting prototype for artop_6210_qc_defer(). Prototype was for artop6210_qc_defer() instead
       drivers/ata/pata_artop.c:359: warning: Function parameter or member 'id' not described in 'artop_init_one'
       drivers/ata/pata_artop.c:359: warning: Excess function parameter 'ent' description in 'artop_init_one'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: Thibaut VARENE <varenet@parisc-linux.org>
      Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      5c16c0ce
    • Lee Jones's avatar
      ata: pata_ali: Repair some misnamed kernel-doc issues · 325fe208
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter'
       drivers/ata/pata_ali.c:119: warning: Excess function parameter 'ap' description in 'ali_20_filter'
       drivers/ata/pata_ali.c:322: warning: Function parameter or member 'qc' not described in 'ali_check_atapi_dma'
       drivers/ata/pata_ali.c:322: warning: Excess function parameter 'adev' description in 'ali_check_atapi_dma'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: CJ <cjtsai@ali.com.tw>
      Cc: Andre Hedrick <andre@linux-ide.org>
      Cc: Alan Cox <alan@redhat.com>
      Cc: Clear Zhang <Clear.Zhang@ali.com.tw>
      Cc: linux-ide@vger.kernel.org
      Cc: and cc <htejun@gmail.com>
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      325fe208
    • Lee Jones's avatar
      ata: libata-pmp: Fix misspelling of 'val' · 32db9fad
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/libata-pmp.c:76: warning: Function parameter or member 'val' not described in 'sata_pmp_write'
       drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val' description in 'sata_pmp_write'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Tejun Heo <teheo@suse.de>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      32db9fad
    • Lee Jones's avatar
      ata: libata-sata: Fix function names in header comments · 842a5e58
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/libata-sata.c:1085: warning: expecting prototype for port_alloc(). Prototype was for ata_sas_port_alloc() instead
       drivers/ata/libata-sata.c:1140: warning: expecting prototype for ata_port_stop(). Prototype was for ata_sas_port_stop() instead
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: Tejun Heo <htejun@gmail.com>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      842a5e58
    • Lee Jones's avatar
      ata: libata-transport: Fix some potential doc-rot issues · 882184be
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ata/libata-transport.c:258: warning: Function parameter or member 'ap' not described in 'ata_tport_delete'
       drivers/ata/libata-transport.c:258: warning: Excess function parameter 'port' description in 'ata_tport_delete'
       drivers/ata/libata-transport.c:384: warning: Function parameter or member 'link' not described in 'ata_tlink_delete'
       drivers/ata/libata-transport.c:384: warning: Excess function parameter 'port' description in 'ata_tlink_delete'
       drivers/ata/libata-transport.c:640: warning: Function parameter or member 'ata_dev' not described in 'ata_tdev_delete'
       drivers/ata/libata-transport.c:640: warning: Excess function parameter 'port' description in 'ata_tdev_delete'
      
      Cc: Jens Axboe <axboe@kernel.dk>
      Cc: linux-ide@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      882184be
    • Dinghao Liu's avatar
      sata_dwc_460ex: Fix missing check in sata_dwc_isr · 0ed0283f
      Dinghao Liu authored
      The return value of ata_qc_from_tag() is checked in the whole
      kernel except for two calls in sata_dwc_isr(), which may lead
      to null-pointer-dereference. Add return value checks to avoid
      such case.
      Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      0ed0283f
    • Piyush Mehta's avatar
      ata: ahci: ceva: Update the driver to support xilinx GT phy · 9a9d3abe
      Piyush Mehta authored
      SATA controller used in Xilinx ZynqMP platform uses xilinx GT phy
      which has 4 GT lanes and can be used by 4 peripherals at a time.
      SATA controller uses 1 GT phy lane among the 4 GT lanes. To configure
      the GT lane for the SATA controller, the below sequence is expected.
      
      1. Assert the SATA controller reset.
      2. Configure the xilinx GT phy lane for SATA controller (phy_init).
      3. De-assert the SATA controller reset.
      4. Wait for PLL of the GT lane used by SATA to be locked (phy_power_on).
      
      The ahci_platform_enable_resources() by default does the phy_init()
      and phy_power_on() but the default sequence doesn't work with Xilinx
      platforms. Because of this reason, updated the driver to support the
      new sequence.
      
      Added cevapriv->rst check, for backward compatibility with the older
      sequence. If the reset controller is not available, then the SATA
      controller will configure with the older sequences.
      Signed-off-by: default avatarPiyush Mehta <piyush.mehta@xilinx.com>
      Acked-by: default avatarMichal Simek <michal.simek@xilinx.com>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      9a9d3abe
    • Piyush Mehta's avatar
      dt-bindings: ata: ahci: ceva: Update documentation for CEVA Controller · 3c0198c8
      Piyush Mehta authored
      This patch updates the documentation for the CEVA controller for adding
      the optional properties for 'phys' and 'resets'.
      Signed-off-by: default avatarPiyush Mehta <piyush.mehta@xilinx.com>
      Acked-by: default avatarRob Herring <robh@kernel.org>
      Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
      3c0198c8