In 2.5.63 I get the following compile error in drivers/scsi/sym53c416.c:


<--  snip  -->

...
  gcc -Wp,-MD,drivers/scsi/.sym53c416.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
-DKBUILD_BASENAME=sym53c416 -DKBUILD_MODNAME=sym53c416 -c -o
drivers/scsi/sym53c416.o drivers/scsi/sym53c416.c
drivers/scsi/sym53c416.c: In function `sym53c416_detect':
drivers/scsi/sym53c416.c:682: too many arguments to function
`pnp_activate_dev'
make[2]: *** [drivers/scsi/sym53c416.o] Error 1

<--  snip  -->


The following patch fixes it:

In 2.5.63 I get the following compile error in drivers/scsi/g_NCR5380.c:

<--  snip  -->

...
  gcc -Wp,-MD,drivers/scsi/.g_NCR5380.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include
-DKBUILD_BASENAME=g_NCR5380 -DKBUILD_MODNAME=g_NCR5380 -c -o
drivers/scsi/g_NCR5380.o drivers/scsi/g_NCR5380.c
drivers/scsi/g_NCR5380.c: In function `generic_NCR5380_detect':
drivers/scsi/g_NCR5380.c:326: too many arguments to function
`pnp_activate_dev'
...
make[2]: *** [drivers/scsi/g_NCR5380.o] Error 1

<--  snip  -->


The following patch fixes it:

Patrick pointed out that I could get into a ABBA issue with holding
list_lock while calling scsi_eh_scmd_add which takes host_lock.
A call to scsi_prep_fn already holds the queue_lock and then makes a
call to scsi_get_command which takes list_lock.

-andmike
--
Michael Anderson
andmike@us.ibm.com

=====
name:		00_scsi_set_device_offline.diff
version:	2003-02-26.15:18:19-0800
against:	scsi-misc-2.5

 scsi.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

=====

Against 2.5.63, untested

regards
john

On Wed, Feb 26, 2003 at 08:20:05PM +0100, Christoph Hellwig wrote:
> This patch updates nsp_cs to use scsi_add_host / scsi_remove_host when
> compiledfor Linux 2.5 which allows to get rid of the scsi host list
> walks and is a preparation for allowing to support multiple cards of
> this type.

Sorry, I sent you the wrong paetch, here's the right one:

Against 2.5.63, untested

regards
john

Against 2.5.63, untested

regards
john

Untested, against 2.5.63

regards
john

Untested, 2.5.63

I remember having this submitted a while ago, but here's the code
again, this time with the untested aic79xx bits.

Not tested, against 2.5.63

regards
john

This patch makes sure that there is a "0x" in front of all hex numbers and
makes all outputs use a single style (all %x instead of mixed %x and %X).

Eike

into raven.il.steeleye.com:/home/jejb/BK/scsi-misc-2.5

Same bug as other sym driver.

Spelling fixes! Woo! I gotta get me some of that.

First hunk is unexplained.
Second hunk had the 2.4 changeset comment 'fix warnings'

This made it into 2.4, and aparently fixes
a problem with some tape devices.

>From 2.4

    accomodate -> accommodate
    accomodated -> accommodated
    accomodates -> accommodates

    guarentee -> guarantee
    guarenteed -> guaranteed
    guarentees -> guarantees

    uglyness -> ugliness

    boundry -> boundary
    boundries -> boundaries

    invokation -> invocation

    wether -> whether

(A "wether" is a castrated goat.)

    immediatly -> immediately

    wierd -> weird
    wierdo -> weirdo
    wierdness -> weirdness

This patch replaces its (possessive of it) with it's (it is)
in the following cases where "it is" is meant.

its a   -> it's a
its an  -> it's an
its not -> it's not

except for the files
   arch/cris/boot/rescue/head.S
   arch/cris/kernel/kgdb.c
where the substitution is "its not" -> "it is not"
to avoid possible problems with single quotes in assembly comments.

This patch replaces it's (it is) with its (possessive of it)
in the following cases where the possessive of it is meant.

to it's      -> to its
into it's    -> into its
from it's    -> from its
of it's      -> of its
with it's    -> with its
under it's   -> under its
about it's   -> about its

into home.transmeta.com:/home/torvalds/v2.5/linux

use the standard pr_debug macro instead of TRDBG