1. 19 Jun, 2022 6 commits
    • Ian Rogers's avatar
      perf test: Fix variable length array undefined behavior in bp_account · cc214552
      Ian Rogers authored
      Fix:
      
        tests/bp_account.c:154:9: runtime error: variable length array bound evaluates to non-positive value 0
      
      by switching from a variable length to an allocated array.
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20220610180247.444798-1-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      cc214552
    • Ian Rogers's avatar
      libperf evsel: Open shouldn't leak fd on failure · 94725994
      Ian Rogers authored
      If perf_event_open() fails the fd is opened but it is only freed by
      closing (not by delete).
      
      Typically when an open fails you don't call close and so this results in
      a memory leak. To avoid this, add a close when open fails.
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Reviewed-By: default avatarKajol Jain <kjain@linux.ibm.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Anshuman Khandual <anshuman.khandual@arm.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Rob Herring <robh@kernel.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20220609052355.1300162-2-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      94725994
    • Thomas Richter's avatar
      perf test: Fix "perf stat CSV output linter" test on s390 · ec906102
      Thomas Richter authored
      perf test -F 83 ("perf stat CSV output linter") fails on s390.
      
      Reason is the wrong number of fields for certain CPU core/die/socket
      related output.
      
      On x84_64 the output of command:
      
        # ./perf stat -x, -A -a --no-merge true
        CPU0,1.50,msec,cpu-clock,1502781,100.00,1.052,CPUs utilized
        CPU1,1.48,msec,cpu-clock,1476113,100.00,1.034,CPUs utilized
        ...
      
      results in 8 fields with 7 comma separators.
      
      On s390 the output of command:
      
        #  ./perf stat -x, -A -a --no-merge -- true
        0.95,msec,cpu-clock,949800,100.00,1.060,CPUs utilized
        ...
      
      results in 7 fields with 6 comma separators. Therefore this tests
      fails on s390. Similar issues exist for per-die and per-socket output
      which is not supported on s390.
      
      I have rewritten the python program to count commas in each output line
      into a bash function to achieve the same result. I hope this makes it a
      bit easier.
      
      Output before:
      
        # ./perf test -F 83
        83: perf stat CSV output linter  :
        Checking CSV output: no args [Success]
        Checking CSV output: system wide [Success]
        Checking CSV output: system wide Checking CSV output: \
      	  system wide no aggregation 6.92,msec,cpu-clock,\
      	  6918131,100.00,6.972,CPUs utilized
        ...
        RuntimeError: wrong number of fields. expected 7 in \
      	  6.92,msec,cpu-clock,6918131,100.00,6.972,CPUs utilized
      
        FAILED!
        #
      
      Output after:
      
        # ./perf test -F 83
        83: perf stat CSV output linter             :
        Checking CSV output: no args [Success]
        Checking CSV output: system wide [Success]
        Checking CSV output: system wide Checking CSV output:\
      	  system wide no aggregation [Success]
        Checking CSV output: interval [Success]
        Checking CSV output: event [Success]
        Checking CSV output: per core [Success]
        Checking CSV output: per thread [Success]
        Checking CSV output: per die [Success]
        Checking CSV output: per node [Success]
        Checking CSV output: per socket [Success]
        Ok
        #
      
      Committer notes:
      
      Continues to work on x86_64
      
        $ perf test lint
         89: perf stat CSV output linter                                     : Ok
        $ perf test -v lint
        Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc
         89: perf stat CSV output linter                                     :
        --- start ---
        test child forked, pid 53133
        Checking CSV output: no args [Success]
        Checking CSV output: system wide [Skip] paranoid and not root
        Checking CSV output: system wide [Skip] paranoid and not root
        Checking CSV output: interval [Success]
        Checking CSV output: event [Success]
        Checking CSV output: per core [Skip] paranoid and not root
        Checking CSV output: per thread [Skip] paranoid and not root
        Checking CSV output: per die [Skip] paranoid and not root
        Checking CSV output: per node [Skip] paranoid and not root
        Checking CSV output: per socket [Skip] paranoid and not root
        test child finished with 0
        ---- end ----
        perf stat CSV output linter: Ok
        $
      Signed-off-by: default avatarThomas Richter <tmricht@linux.ibm.com>
      Acked-by: default avatarIan Rogers <irogers@google.com>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Claire Jensen <cjense@google.com>
      Cc: Heiko Carstens <hca@linux.ibm.com>
      Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
      Cc: Sven Schnelle <svens@linux.ibm.com>
      Cc: Vasily Gorbik <gor@linux.ibm.com>
      Cc: linux390-list@tuxmaker.boeblingen.de.ibm.com
      Link: https://lore.kernel.org/r/20220603113034.2009728-1-tmricht@linux.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      ec906102
    • Ian Rogers's avatar
      perf unwind: Fix uninitialized variable · 1d98cdf7
      Ian Rogers authored
      The 'ret' variable may be uninitialized on error goto paths.
      
      Fixes: dc2cf4ca ("perf unwind: Fix segbase for ld.lld linked objects")
      Reported-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
      Reviewed-by: default avatarFangrui Song <maskray@google.com>
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Tested-by: Sedat Dilek <sedat.dilek@gmail.com> # LLVM-14 (x86-64)
      Cc: Fangrui Song <maskray@google.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: llvm@lists.linux.dev
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sebastian Ullrich <sebasti@nullri.ch>
      Link: https://lore.kernel.org/r/20220607000851.39798-1-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      1d98cdf7
    • Linus Torvalds's avatar
      Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 · 354c6e07
      Linus Torvalds authored
      Pull ext4 fixes from Ted Ts'o:
       "Fix a variety of bugs, many of which were found by folks using fuzzing
        or error injection.
      
        Also fix up how test_dummy_encryption mount option is handled for the
        new mount API.
      
        Finally, fix/cleanup a number of comments and ext4 Documentation
        files"
      
      * tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:
        ext4: fix a doubled word "need" in a comment
        ext4: add reserved GDT blocks check
        ext4: make variable "count" signed
        ext4: correct the judgment of BUG in ext4_mb_normalize_request
        ext4: fix bug_on ext4_mb_use_inode_pa
        ext4: fix up test_dummy_encryption handling for new mount API
        ext4: use kmemdup() to replace kmalloc + memcpy
        ext4: fix super block checksum incorrect after mount
        ext4: improve write performance with disabled delalloc
        ext4: fix warning when submitting superblock in ext4_commit_super()
        ext4, doc: remove unnecessary escaping
        ext4: fix incorrect comment in ext4_bio_write_page()
        fs: fix jbd2_journal_try_to_free_buffers() kernel-doc comment
      354c6e07
    • Linus Torvalds's avatar
      Merge tag '5.19-rc2-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6 · ace2045e
      Linus Torvalds authored
      Pull cifs client fixes from Steve French:
       "Two cifs debugging improvements - one found to deal with debugging a
        multichannel problem and one for a recent fallocate issue
      
        This does include the two larger multichannel reconnect (dynamically
        adjusting interfaces on reconnect) patches, because we recently found
        an additional problem with multichannel to one server type that I want
        to include at the same time"
      
      * tag '5.19-rc2-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6:
        cifs: when a channel is not found for server, log its connection id
        smb3: add trace point for SMB2_set_eof
      ace2045e
  2. 18 Jun, 2022 9 commits
  3. 17 Jun, 2022 25 commits