- 29 Dec, 2023 13 commits
-
-
Maxime Ripard authored
The code to upload infoframes to the controller uses a weird construct which, based on the previous function call return code, will either disable or enable that infoframe. In order to get rid of that argument, let's split the function to disable the infoframe into a separate function and make it obvious what we are doing in the error path. Signed-off-by:
Maxime Ripard <mripard@kernel.org> Tested-by:
Alex Bee <knaerzche@gmail.com> Signed-off-by:
Heiko Stuebner <heiko@sntech.de> Link: https://patchwork.freedesktop.org/patch/msgid/20231222174220.55249-15-knaerzche@gmail.com
-
Maxime Ripard authored
The HDMI vendor infoframe is only meant to be sent with 4k60 modes and higher, but the controller doesn't support them. Let's drop them from the kernel. Suggested-by:
Johan Jonker <jbx6244@gmail.com> Signed-off-by:
-
Maxime Ripard authored
The tmds_rate field in the inno_hdmi structure is used mostly to configure the internal i2c controller divider through a call to the inno_hdmi_i2c_init() function. We can simply make that rate an argument to that function, which also removes a workaround to initialize the divider at probe time when we don't have a mode yet. Signed-off-by:
-
Alex Bee authored
Now that the unneeded support for YUV based input formats is gone, the csc coefficients for those formats can be dropped as well. Signed-off-by:
-
Maxime Ripard authored
The driver has a lot of logic to deal with multiple input formats, but hardcodes it to RGB. This means that most of that code has been dead code, so let's get rid of it. Signed-off-by:
-
Maxime Ripard authored
The sink_has_audio flag is not used anywhere in the driver so let's get rid of it. It's redundant with drm_display_info.has_audio anyway. Signed-off-by:
-
Maxime Ripard authored
The mode's VIC is only ever used in the inno_hdmi_setup() function so there's no need to store it in the main structure. Signed-off-by:
-
Maxime Ripard authored
We're not doing anything special in atomic_mode_set so we can simply merge it into atomic_enable. Signed-off-by:
-
Maxime Ripard authored
The inno_hdmi encoder still uses the !atomic variants of enable, disable and modeset. Convert to their atomic equivalents. Signed-off-by:
-
Maxime Ripard authored
The driver maintains a copy of the adjusted mode but doesn't use it anywhere. Remove it. Signed-off-by:
-
Maxime Ripard authored
The mode_fixup implementation doesn't do anything, so we can simply remove it. Signed-off-by:
-
Alex Bee authored
The controller wants the difference between *total and *sync_start in the HDMI_VIDEO_EXT_*DELAY registers. Otherwise the signal is very unstable for certain non-VIC modes. See downstream commit [0]. [0] https://github.com/rockchip-linux/kernel/commit/8eb559f2502c Fixes: 412d4ae6 ("drm/rockchip: hdmi: add Innosilicon HDMI support") Co-developed-by:
Zheng Yang <zhengyang@rock-chips.com> Signed-off-by:
-
Alex Bee authored
In contrast to RK3036, RK312x SoCs have multiple output channels such as RGB (i.e. LVDS TTL), LVDS, DSI and HDMI. In order to support that, this splits output from RK3036 and defines an separate one for RK3126 with the registers required to enable the appropriate output and setup the correct polarity. Signed-off-by:
-
- 28 Dec, 2023 1 commit
-
-
Philipp Stanner authored
tilcdc currently just ioremaps its iomem, without doing the (a bit more robust) request on the memory first. The devm_ functions provide a handy way to both request and ioremap the memory with automatic cleanup. Replace the manual ioremap with the devm_ version. Suggested-by:
Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by:
Philipp Stanner <pstanner@redhat.com> Reviewed-by:
Jyri Sarha <jyri.sarha@iki.fi> Tested-by:
-
- 22 Dec, 2023 1 commit
-
-
Raphael Gallais-Pou authored
List EDT ETML0700Z9NDHA in the LVDS panel enumeration. Signed-off-by:
Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> Acked-by:
Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20231221124339.420119-2-raphael.gallais-pou@foss.st.comSigned-off-by:
Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231221124339.420119-2-raphael.gallais-pou@foss.st.com
-
- 20 Dec, 2023 2 commits
-
-
Jeffrey Hugo authored
In probe() we create the drm_device, and then register the MHI controller. In remove(), we should unregister the controller first, then remove the drm_device. Update the remove() operations to match. Signed-off-by:
Jeffrey Hugo <quic_jhugo@quicinc.com> Reviewed-by:
Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com> Reviewed-by:
Carl Vanderlip <quic_carlv@quicinc.com> Reviewed-by:
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231208163457.1295993-8-quic_jhugo@quicinc.com
-
Pranjal Ramajor Asha Kanojiya authored
Offload the balancing of init and destroy calls to DRM managed APIs. mutex destroy for ->cntl_mutex is not called during device release and destroy workqueue is not called in error path of create_qdev(). So, use DRM managed APIs to manage the release of resources and avoid such problems. Signed-off-by:
-
- 18 Dec, 2023 14 commits
-
-
Xuxin Xiong authored
Add support for the following 3 panels: 1. BOE NV116WHM-N49 V8.0 2. BOE NV122WUM-N41 3. CSO MNC207QS1-1 Signed-off-by:
Xuxin Xiong <xuxinxiong@huaqin.corp-partner.google.com> Reviewed-by:
Douglas Anderson <dianders@chromium.org> Signed-off-by:
-
Pin-yen Lin authored
These panels are used by Mediatek MT8173 Chromebooks, and they used to work with the downstream v4.19 kernel without any specified delay. Back in the v4.19 kernel, they used the "little white lie" approach, which is making the devicetree claim a specific panel's compatible string for many different panels. That was a common solution before the generic edp-panel driver. After we uprevved the device to a newer kernel and used the edp-panel driver, we saw multiple devices reporting warnings of using an unknown panel and falling back to the conservative timings, which means that they turn on/off much more slowly than they should. We tried to fill in the timings for those panels, but we failed to find all the data sheets for them. Therefore, instead of having them use the default conservative timings, update them with less-conservative timings from other panels of the same vendor. The panels should still work under those timings, and we can save some delays and suppress the warnings. Signed-off-by:
Pin-yen Lin <treapking@chromium.org> Reviewed-by:
-
Pin-yen Lin authored
Add panels used by Mediatek MT8173 Chromebooks. Signed-off-by:
-
Pin-yen Lin authored
Add the support of powered_on_to_enable delay as the minimum time that needs to have passed between the panel powered on and enable may begin. This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8 in the eDP timing diagrams. Signed-off-by:
-
Ville Syrjälä authored
The original rationale for commit cd456f8d ("drm: Restrict stackdepot usage to builtin drm.ko") was that depot_save_stack() (which is what we used back then) wasn't exported. stack_depot_save() (which is what we use now) is exported however, so relax the dependency allow CONFIG_DRM_MM_DEBUG with DRM=m. Signed-off-by:
Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231215111129.9559-1-ville.syrjala@linux.intel.comAcked-by:
Javier Martinez Canillas <javierm@redhat.com>
-
Maxime Ripard authored
The name of the structure drm_atomic_state is confusing. Let's add an entry to our todo list to rename it. Reviewed-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://lore.kernel.org/r/20231214100917.277842-5-mripard@kernel.orgSigned-off-by:
-
Maxime Ripard authored
The current documentation of drm_atomic_state says that it's the "global state object". This is confusing since, while it does contain all the objects affected by an update and their respective states, if an object isn't affected by this update it won't be part of it. Thus, it's not truly a "global state", unlike object state structures that do contain the entire state of a given object. Reviewed-by:
Hamza Mahfooz <hamza.mahfooz@amd.com> Acked-by:
Pekka Paalanen <pekka.paalanen@collabora.com> Link: https://lore.kernel.org/r/20231214100917.277842-4-mripard@kernel.orgSigned-off-by:
-
Maxime Ripard authored
Commits 63e83c1d ("drm: Consolidate connector arrays in drm_atomic_state"), b8b5342b ("drm: Consolidate plane arrays in drm_atomic_state") and 5d943aa6 ("drm: Consolidate crtc arrays in drm_atomic_state") moved the object pointer and their state pointer to an intermediate structure storing both. The CRTC commit didn't update the doc of the crtcs field to reflect that, and the doc for the planes and connectors fields mention that they are pointers to an array of structures with per-$OBJECT data. The private_objs field was added later on by commit b430c27a ("drm: Add driver-private objects to atomic state") reusing the same sentence than the crtcs field, probably due to copy and paste. While these fields are indeed pointers to an array, each item of that array contain a pointer to the object structure affected by the update, and its old and new state. There's no per-object data there, and there's more than just a pointer to the objects. Let's rephrase those fields a bit to better match the current situation. Acked-by:
Sui Jingfeng <sui.jingfeng@linux.dev> Reviewed-by:
-
Maxime Ripard authored
Commit 63e83c1d ("drm: Consolidate connector arrays in drm_atomic_state") removed the connector_states field but didn't remove its mention in the num_connectors documentation. Acked-by:
-
Maxime Ripard authored
Some fields of drm_atomic_state have been documented in-line, but some were documented in the main kerneldoc block before the structure. Since the former is the preferred option in DRM, let's move all the fields to an inline documentation. Acked-by:
-
Thomas Zimmermann authored
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that vesafb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by:
-
Thomas Zimmermann authored
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. Signed-off-by:
-
Thomas Zimmermann authored
Use the screen_info instance from the device instead of dereferencing the global screen_info state. Decouples the driver from per-architecture code. Duplicated the screen_info data, so that efifb can modify it at will. v2: * comment on devm_kmemdup() usage (Javier) Signed-off-by:
-
Thomas Zimmermann authored
Get the global screen_info's address once and access the data via this pointer. Limits the use of global state. v3: * use const screen_info in several places (Sui) * fix build for deferred takeover (kernel test robot) Signed-off-by:
-
- 15 Dec, 2023 9 commits
-
-
Pranjal Ramajor Asha Kanojiya authored
Every time QAIC_MMAP_BO ioctl is called for a BO, drm_gem_create_mmap_offset() is called. Calling drm_gem_create_mmap_offset() more then once for a BO seems redundant. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
Do not free BO explicitly in error path, just drop its reference, cleanup will be taken care by DRM as we have registered for ->free() callback. This patch makes sure that there is only one code path for BO to be freed. Signed-off-by:
-
Jeffrey Hugo authored
The timesync channels have their struct fields out of order with the rest of the channels. Fix them so there is a consistent style in the file. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
->queued field is used to track whether the BO is submitted to hardware for DMA or not. Since same information can be retrieved using ->xfer_list field of same structure remove ->queued as it is redundant. Signed-off-by:
-
Pranjal Ramajor Asha Kanojiya authored
->size in struct qaic_attach_slice_hdr is redundant since we have BO handle and its size can be retrieved from base BO structure. Signed-off-by:
-
Huang Rui authored
This Venus capset definition is used by Qemu, and Qemu imports the kernel protocol header file. Add Venus capset to the VirtIO-GPU protocol. Signed-off-by:
Huang Rui <ray.huang@amd.com> [dmitry.osipenko@collabora.com: edit commit message] Signed-off-by:
Dmitry Osipenko <dmitry.osipenko@collabora.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230915105918.3763061-1-ray.huang@amd.com
-
Dario Binacchi authored
It was useless to check again the "ret" variable if the function register_host() was not called. Signed-off-by:
Dario Binacchi <dario.binacchi@amarulasolutions.com> Reviewed-by:
Frieder Schrempf <frieder.schrempf@kontron.de> Signed-off-by:
Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231207161056.183442-1-dario.binacchi@amarulasolutions.com
-
Alexander Stein authored
Use the register names from the datasheet. No functional change intended. Signed-off-by:
Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by:
-
Alexander Stein authored
This is the single register which clears its value upon read operation. Signed-off-by:
-
