1. 07 Jan, 2024 4 commits
    • Chuck Lever's avatar
      NFSD: Make the file_delayed_close workqueue UNBOUND · ce7df055
      Chuck Lever authored
      workqueue: nfsd_file_delayed_close [nfsd] hogged CPU for >13333us 8
      	times, consider switching to WQ_UNBOUND
      
      There's no harm in closing a cached file descriptor on another core.
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      ce7df055
    • Oleg Nesterov's avatar
      NFSD: use read_seqbegin() rather than read_seqbegin_or_lock() · f3734cc4
      Oleg Nesterov authored
      The usage of read_seqbegin_or_lock() in nfsd_copy_write_verifier()
      is wrong. "seq" is always even and thus "or_lock" has no effect,
      this code can never take ->writeverf_lock for writing.
      
      I guess this is fine, nfsd_copy_write_verifier() just copies 8 bytes
      and nfsd_reset_write_verifier() is supposed to be very rare operation
      so we do not need the adaptive locking in this case.
      
      Yet the code looks wrong and sub-optimal, it can use read_seqbegin()
      without changing the behaviour.
      
      [ cel: Note also that it eliminates this Sparse warning:
      
      fs/nfsd/nfssvc.c:360:6: warning: context imbalance in 'nfsd_copy_write_verifier' -
      	different lock contexts for basic block
      
      ]
      Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
      Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
      Reviewed-by: default avatarNeilBrown <neilb@suse.de>
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      f3734cc4
    • Jeff Layton's avatar
      nfsd: new Kconfig option for legacy client tracking · 74fd4873
      Jeff Layton authored
      We've had a number of attempts at different NFSv4 client tracking
      methods over the years, but now nfsdcld has emerged as the clear winner
      since the others (recoverydir and the usermodehelper upcall) are
      problematic.
      
      As a case in point, the recoverydir backend uses MD5 hashes to encode
      long form clientid strings, which means that nfsd repeatedly gets dinged
      on FIPS audits, since MD5 isn't considered secure. Its use of MD5 is not
      cryptographically significant, so there is no danger there, but allowing
      us to compile that out allows us to sidestep the issue entirely.
      
      As a prelude to eventually removing support for these client tracking
      methods, add a new Kconfig option that enables them. Mark it deprecated
      and make it default to N.
      Acked-by: default avatarNeilBrown <neilb@suse.de>
      Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
      Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
      74fd4873
    • Linus Torvalds's avatar
      Linux 6.7 · 0dd3ee31
      Linus Torvalds authored
      0dd3ee31
  2. 06 Jan, 2024 2 commits
  3. 05 Jan, 2024 25 commits
  4. 04 Jan, 2024 9 commits