1. 26 Mar, 2021 29 commits
    • Lee Jones's avatar
      crypto: nx - Repair some kernel-doc problems · d007bac1
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key'
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key'
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'key_len' not described in 'cbc_aes_nx_set_key'
       drivers/crypto/nx/nx-aes-cbc.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for cbc_aes_nx_set_key() instead
       drivers/crypto/nx/nx_debugfs.c:34: warning: Function parameter or member 'drv' not described in 'nx_debugfs_init'
       drivers/crypto/nx/nx_debugfs.c:34: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_debugfs_init() instead
       drivers/crypto/nx/nx.c:31: warning: Incorrect use of kernel-doc format:  * nx_hcall_sync - make an H_COP_OP hcall for the passed in op structure
       drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'nx_ctx' not described in 'nx_hcall_sync'
       drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'op' not described in 'nx_hcall_sync'
       drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'may_sleep' not described in 'nx_hcall_sync'
       drivers/crypto/nx/nx.c:43: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_hcall_sync() instead
       drivers/crypto/nx/nx.c:209: warning: Function parameter or member 'nbytes' not described in 'trim_sg_list'
      
      Cc: "Breno Leitão" <leitao@debian.org>
      Cc: Nayna Jain <nayna@linux.ibm.com>
      Cc: Paulo Flabiano Smorigo <pfsmorigo@gmail.com>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Kent Yoder <yoder1@us.ibm.com>
      Cc: linux-crypto@vger.kernel.org
      Cc: linuxppc-dev@lists.ozlabs.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      d007bac1
    • Lee Jones's avatar
      crypto: vmx - Source headers are not good kernel-doc candidates · 32c2e6dd
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead
      
      Cc: "Breno Leitão" <leitao@debian.org>
      Cc: Nayna Jain <nayna@linux.ibm.com>
      Cc: Paulo Flabiano Smorigo <pfsmorigo@gmail.com>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Henrique Cerri <mhcerri@br.ibm.com>
      Cc: linux-crypto@vger.kernel.org
      Cc: linuxppc-dev@lists.ozlabs.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      32c2e6dd
    • Lee Jones's avatar
      crypto: caam - Provide the name of the function and provide missing descriptions · 0beb2b60
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead
       drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx'
       drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx'
      
      Cc: "Horia Geantă" <horia.geanta@nxp.com>
      Cc: Aymen Sghaier <aymen.sghaier@nxp.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarHoria Geantă <horia.geanta@nxp.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      0beb2b60
    • Lee Jones's avatar
      crypto: atmel-ecc - Struct headers need to start with keyword 'struct' · 71057841
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/atmel-ecc.c:41: warning: cannot understand function prototype: 'struct atmel_ecdh_ctx '
      
      Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
      Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
      Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
      Cc: linux-crypto@vger.kernel.org
      Cc: linux-arm-kernel@lists.infradead.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarTudor Ambarus <tudor.ambarus@microchip.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      71057841
    • Lee Jones's avatar
      crypto: keembay - Fix incorrectly named functions/structs · e2dcca6a
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
       drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead
       drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead
       drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead
      
      Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
      Cc: Declan Murphy <declan.murphy@intel.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Reviewed-by: default avatarDaniele Alessandrelli <daniele.alessandrelli@intel.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      e2dcca6a
    • Lee Jones's avatar
      crypto: ux500/hash - Fix worthy kernel-doc headers and remove others · 0368853e
      Lee Jones authored
      The ones remove here not only fail to conform to kernel-doc, but also
      provide no value, so let's remove them completely in this case.
      
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/ux500/hash/hash_core.c:368: warning: Function parameter or member 'ctx' not described in 'hash_get_device_data'
       drivers/crypto/ux500/hash/hash_core.c:368: warning: Excess function parameter 'hash_ctx' description in 'hash_get_device_data'
       drivers/crypto/ux500/hash/hash_core.c:551: warning: expecting prototype for hash_init(). Prototype was for ux500_hash_init() instead
       drivers/crypto/ux500/hash/hash_core.c:592: warning: Function parameter or member 'length' not described in 'hash_processblock'
       drivers/crypto/ux500/hash/hash_core.c:1302: warning: expecting prototype for hash_update(). Prototype was for ahash_update() instead
       drivers/crypto/ux500/hash/hash_core.c:1322: warning: expecting prototype for hash_final(). Prototype was for ahash_final() instead
       drivers/crypto/ux500/hash/hash_core.c:1622: warning: Function parameter or member 'device_data' not described in 'ahash_algs_register_all'
       drivers/crypto/ux500/hash/hash_core.c:1622: warning: expecting prototype for hash_algs_register_all(). Prototype was for ahash_algs_register_all() instead
       drivers/crypto/ux500/hash/hash_core.c:1647: warning: Function parameter or member 'device_data' not described in 'ahash_algs_unregister_all'
       drivers/crypto/ux500/hash/hash_core.c:1647: warning: expecting prototype for hash_algs_unregister_all(). Prototype was for ahash_algs_unregister_all() instead
       drivers/crypto/ux500/cryp/cryp.c:19: warning: Incorrect use of kernel-doc format:  * cryp_wait_until_done - wait until the device logic is not busy
       drivers/crypto/ux500/cryp/cryp.c:22: warning: Function parameter or member 'device_data' not described in 'cryp_wait_until_done'
       drivers/crypto/ux500/cryp/cryp.c:22: warning: expecting prototype for ST(). Prototype was for cryp_wait_until_done() instead
       drivers/crypto/ux500/cryp/cryp.c:292: warning: Function parameter or member 'cryp_mode' not described in 'cryp_save_device_context'
       drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'device_data' not described in 'cryp_enable_irq_src'
       drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: Function parameter or member 'irq_src' not described in 'cryp_enable_irq_src'
       drivers/crypto/ux500/cryp/cryp_irq.c:21: warning: expecting prototype for ST(). Prototype was for cryp_enable_irq_src() instead
       drivers/crypto/ux500/cryp/cryp_core.c:42: warning: expecting prototype for ST(). Prototype was for CRYP_MAX_KEY_SIZE() instead
       drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'key' not described in 'cryp_ctx'
       drivers/crypto/ux500/cryp/cryp_core.c:91: warning: Function parameter or member 'session_id' not described in 'cryp_ctx'
      
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Shujuan Chen <shujuan.chen@stericsson.com>
      Cc: Joakim Bech <joakim.xx.bech@stericsson.com>
      Cc: Berne Hebark <berne.herbark@stericsson.com>
      Cc: Niklas Hernaeus <niklas.hernaeus@stericsson.com>
      Cc: Jonas Linde <jonas.linde@stericsson.com>
      Cc: Andreas Westin <andreas.westin@stericsson.com>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      0368853e
    • Lee Jones's avatar
      crypto: chelsio - Fix some kernel-doc issues · 29e5b878
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/chelsio/chcr_core.c:2: warning: wrong kernel-doc identifier on line:
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Function parameter or member 'wrparam' not described in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'req' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'ctx' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'qid' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:806: warning: Excess function parameter 'op_type' description in 'create_cipher_wr'
       drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'req' not described in 'create_hash_wr'
       drivers/crypto/chelsio/chcr_algo.c:1566: warning: Function parameter or member 'param' not described in 'create_hash_wr'
      
      Cc: Ayush Sawal <ayush.sawal@chelsio.com>
      Cc: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
      Cc: Rohit Maheshwari <rohitm@chelsio.com>
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Manoj Malviya <manojmalviya@chelsio.com>
      Cc: Atul Gupta <atul.gupta@chelsio.com>
      Cc: Jitendra Lulla <jlulla@chelsio.com>
      Cc: M R Gowda <yeshaswi@chelsio.com>
      Cc: Harsh Jain <harsh@chelsio.com>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      29e5b878
    • Lee Jones's avatar
      crypto: bcm - Fix a whole host of kernel-doc misdemeanours · 85a557cb
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'from_nents' not described in 'spu_msg_sg_add'
       drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'length' not described in 'spu_msg_sg_add'
       drivers/crypto/bcm/spu.c:464: warning: Excess function parameter 'Return' description in 'spum_gcm_ccm_pad_len'
       drivers/crypto/bcm/spu.c:524: warning: Function parameter or member 'iv_len' not described in 'spum_aead_ivlen'
       drivers/crypto/bcm/spu.c:524: warning: expecting prototype for spu_aead_ivlen(). Prototype was for spum_aead_ivlen() instead
       drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg_digest_size' not described in 'spum_digest_size'
       drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg' not described in 'spum_digest_size'
       drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'htype' not described in 'spum_digest_size'
       drivers/crypto/bcm/spu.c:583: warning: bad line:
       drivers/crypto/bcm/spu.c:927: warning: Function parameter or member 'is_inbound' not described in 'spum_cipher_req_finish'
       drivers/crypto/bcm/spu.c:927: warning: Excess function parameter 'isInbound' description in 'spum_cipher_req_finish'
       drivers/crypto/bcm/spu2.c:557: warning: Function parameter or member 'fmd' not described in 'spu2_fmd_init'
       drivers/crypto/bcm/spu2.c:557: warning: Function parameter or member 'spu2_type' not described in 'spu2_fmd_init'
       drivers/crypto/bcm/spu2.c:557: warning: Excess function parameter 'spu2_cipher_type' description in 'spu2_fmd_init'
       drivers/crypto/bcm/spu2.c:615: warning: Function parameter or member 'auth_first' not described in 'spu2_fmd_ctrl0_write'
       drivers/crypto/bcm/spu2.c:615: warning: Excess function parameter 'authFirst' description in 'spu2_fmd_ctrl0_write'
       drivers/crypto/bcm/spu2.c:666: warning: Function parameter or member 'is_inbound' not described in 'spu2_fmd_ctrl1_write'
       drivers/crypto/bcm/spu2.c:803: warning: expecting prototype for spu_payload_length(). Prototype was for spu2_payload_length() instead
       drivers/crypto/bcm/spu2.c:825: warning: Function parameter or member 'is_hash' not described in 'spu2_response_hdr_len'
       drivers/crypto/bcm/spu2.c:825: warning: expecting prototype for spu_response_hdr_len(). Prototype was for spu2_response_hdr_len() instead
       drivers/crypto/bcm/spu2.c:843: warning: expecting prototype for spu_hash_pad_len(). Prototype was for spu2_hash_pad_len() instead
       drivers/crypto/bcm/spu2.c:855: warning: Function parameter or member 'cipher_mode' not described in 'spu2_gcm_ccm_pad_len'
       drivers/crypto/bcm/spu2.c:855: warning: Function parameter or member 'data_size' not described in 'spu2_gcm_ccm_pad_len'
       drivers/crypto/bcm/spu2.c:855: warning: expecting prototype for spu2_gcm_ccm_padlen(). Prototype was for spu2_gcm_ccm_pad_len() instead
       drivers/crypto/bcm/spu2.c:872: warning: expecting prototype for spu_assoc_resp_len(). Prototype was for spu2_assoc_resp_len() instead
       drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'alg_digest_size' not described in 'spu2_digest_size'
       drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'alg' not described in 'spu2_digest_size'
       drivers/crypto/bcm/spu2.c:919: warning: Function parameter or member 'htype' not described in 'spu2_digest_size'
       drivers/crypto/bcm/spu2.c:945: warning: expecting prototype for spu_create_request(). Prototype was for spu2_create_request() instead
       drivers/crypto/bcm/spu2.c:1122: warning: expecting prototype for spu_cipher_req_init(). Prototype was for spu2_cipher_req_init() instead
       drivers/crypto/bcm/spu2.c:1182: warning: Function parameter or member 'is_inbound' not described in 'spu2_cipher_req_finish'
       drivers/crypto/bcm/spu2.c:1182: warning: expecting prototype for spu_cipher_req_finish(). Prototype was for spu2_cipher_req_finish() instead
       drivers/crypto/bcm/spu2.c:1243: warning: expecting prototype for spu_request_pad(). Prototype was for spu2_request_pad() instead
       drivers/crypto/bcm/spu2.c:1321: warning: expecting prototype for spu_status_process(). Prototype was for spu2_status_process() instead
       drivers/crypto/bcm/cipher.c:1048: warning: Function parameter or member 'req' not described in 'spu_aead_rx_sg_create'
       drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'cipher' not described in 'rfc4543_gcm_esp_setkey'
       drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'key' not described in 'rfc4543_gcm_esp_setkey'
       drivers/crypto/bcm/cipher.c:2966: warning: Function parameter or member 'keylen' not described in 'rfc4543_gcm_esp_setkey'
      
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Rob Rice <rob.rice@broadcom.com>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      85a557cb
    • Lee Jones's avatar
      crypto: hisilicon/sec - Supply missing description for 'sec_queue_empty()'s 'queue' param · 45394566
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/crypto/hisilicon/sec/sec_drv.c:843: warning: Function parameter or member 'queue' not described in 'sec_queue_empty'
      
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Zaibo Xu <xuzaibo@huawei.com>
      Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      45394566
    • Bhaskar Chowdhury's avatar
    • Milan Djurovic's avatar
      crypto: jitterentropy - Put constants on the right side of the expression · 36c25011
      Milan Djurovic authored
      This patch fixes the following checkpatch.pl warnings:
      
      crypto/jitterentropy.c:600: WARNING: Comparisons should place the constant on the right side of the test
      crypto/jitterentropy.c:681: WARNING: Comparisons should place the constant on the right side of the test
      crypto/jitterentropy.c:772: WARNING: Comparisons should place the constant on the right side of the test
      crypto/jitterentropy.c:829: WARNING: Comparisons should place the constant on the right side of the test
      Signed-off-by: default avatarMilan Djurovic <mdjurovic@zohomail.com>
      Reviewed-by: default avatarStephan Mueller <smueller@chronox.de>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      36c25011
    • Zihao Tang's avatar
      hwrng: core - convert sysfs sprintf/snprintf family to sysfs_emit · 91253022
      Zihao Tang authored
      Fix the following coccicheck warning:
      
      drivers/char/hw_random/core.c:399:8-16: WARNING: use scnprintf or sprintf.
      Signed-off-by: default avatarZihao Tang <tangzihao1@hisilicon.com>
      Signed-off-by: default avatarJay Fang <f.fangjian@huawei.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      91253022
    • Xiang Chen's avatar
      crypto: allwinner - Fix the parameter of dma_unmap_sg() · 884b93c5
      Xiang Chen authored
      For function dma_unmap_sg(), the <nents> parameter should be number of
      elements in the scatterlist prior to the mapping, not after the mapping.
      So fix this usage.
      Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
      Acked-by: default avatarCorentin LABBE <clabbe.montjoie@gmail.com>
      Tested-by: default avatarCorentin LABBE <clabbe.montjoie@gmail.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      884b93c5
    • Xiang Chen's avatar
      crypto: ux500 - Fix the parameter of dma_unmap_sg() · ade18fb4
      Xiang Chen authored
      For function dma_unmap_sg(), the <nents> parameter should be number of
      elements in the scatterlist prior to the mapping, not after the mapping.
      So fix this usage.
      Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      ade18fb4
    • Xiang Chen's avatar
      crypto: cavium - Fix the parameter of dma_unmap_sg() · c114ecd3
      Xiang Chen authored
      For function dma_unmap_sg(), the <nents> parameter should be number of
      elements in the scatterlist prior to the mapping, not after the mapping.
      So fix this usage.
      Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      c114ecd3
    • Xiang Chen's avatar
      crypto: amlogic - Fix the parameter of dma_unmap_sg() · 5595d0dc
      Xiang Chen authored
      For function dma_unmap_sg(), the <nents> parameter should be number of
      elements in the scatterlist prior to the mapping, not after the mapping.
      So fix this usage.
      Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      5595d0dc
    • Rijo Thomas's avatar
      crypto: ccp - fix command queuing to TEE ring buffer · 00aa6e65
      Rijo Thomas authored
      Multiple threads or clients can submit a command to the TEE ring
      buffer. This patch helps to synchronize command submission to the
      ring.
      
      One thread shall write a command to a TEE ring buffer entry only if:
      
       - Trusted OS has notified that the TEE command for the given entry
         has been processed and driver has copied the TEE response into
         client buffer.
      
       - The command entry is empty and can be written into.
      
      After a command has been written to the TEE ring buffer, the global
      wptr (mutex protected) shall be incremented for use by next client.
      
      If PSP became unresponsive while processing TEE request from a
      client, then further command submission to queue will be disabled.
      
      Fixes: 33960acc (crypto: ccp - add TEE support for Raven Ridge)
      Reviewed-by: default avatarDevaraj Rangasamy <Devaraj.Rangasamy@amd.com>
      Signed-off-by: default avatarRijo Thomas <Rijo-john.Thomas@amd.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      00aa6e65
    • Rijo Thomas's avatar
      crypto: ccp - reduce tee command status polling interval from 5ms to 1ms · 4a5eed17
      Rijo Thomas authored
      The PSP TEE device driver polls the command status variable every
      5ms to check for command completion. Reduce this time to 1ms so that
      there is an improvement in driver response time to clients which submit
      TEE commands.
      Reviewed-by: default avatarDevaraj Rangasamy <Devaraj.Rangasamy@amd.com>
      Signed-off-by: default avatarRijo Thomas <Rijo-john.Thomas@amd.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      4a5eed17
    • Tian Tao's avatar
      hwrng: intel - Fix included header from 'asm · e656459b
      Tian Tao authored
      This commit fixes the checkpatch warning:
      WARNING: Use #include <linux/io.h> instead of <asm/io.h>
      34: FILE: drivers/char/hw_random/intel-rng.c:34:
      Signed-off-by: default avatarTian Tao <tiantao6@hisilicon.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      e656459b
    • Herbert Xu's avatar
      Merge branch 'ecc' · 3877869d
      Herbert Xu authored
      This pulls in the NIST P384/256/192 x509 changes.
      3877869d
    • Saulo Alessandre's avatar
      x509: Add OID for NIST P384 and extend parser for it · 2a8e6154
      Saulo Alessandre authored
      Prepare the x509 parser to accept NIST P384 certificates and add the
      OID for ansip384r1, which is the identifier for NIST P384.
      
      Summary of changes:
      
      * crypto/asymmetric_keys/x509_cert_parser.c
        - prepare x509 parser to load NIST P384
      
      * include/linux/oid_registry.h
        - add OID_ansip384r1
      Signed-off-by: default avatarSaulo Alessandre <saulo.alessandre@tse.jus.br>
      Tested-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      2a8e6154
    • Stefan Berger's avatar
      ima: Support EC keys for signature verification · 947d7059
      Stefan Berger authored
      Add support for IMA signature verification for EC keys. Since SHA type
      of hashes can be used by RSA and ECDSA signature schemes we need to
      look at the key and derive from the key which signature scheme to use.
      Since this can be applied to all types of keys, we change the selection
      of the encoding type to be driven by the key's signature scheme rather
      than by the hash type.
      
      Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
      Cc: linux-integrity@vger.kernel.org
      Cc: David Howells <dhowells@redhat.com>
      Cc: keyrings@vger.kernel.org
      Signed-off-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Reviewed-by: default avatarVitaly Chikunov <vt@altlinux.org>
      Reviewed-by: default avatarTianjia Zhang <tianjia.zhang@linux.alibaba.com>
      Acked-by: default avatarMimi Zohar <zohar@linux.ibm.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      947d7059
    • Stefan Berger's avatar
      x509: Add support for parsing x509 certs with ECDSA keys · 299f561a
      Stefan Berger authored
      Add support for parsing of x509 certificates that contain ECDSA keys,
      such as NIST P256, that have been signed by a CA using any of the
      current SHA hash algorithms.
      
      Cc: David Howells <dhowells@redhat.com>
      Cc: keyrings@vger.kernel.org
      Signed-off-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      299f561a
    • Stefan Berger's avatar
      x509: Detect sm2 keys by their parameters OID · d1a303e8
      Stefan Berger authored
      Detect whether a key is an sm2 type of key by its OID in the parameters
      array rather than assuming that everything under OID_id_ecPublicKey
      is sm2, which is not the case.
      
      Cc: David Howells <dhowells@redhat.com>
      Cc: keyrings@vger.kernel.org
      Signed-off-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Reviewed-by: default avatarTianjia Zhang <tianjia.zhang@linux.alibaba.com>
      Tested-by: default avatarTianjia Zhang <tianjia.zhang@linux.alibaba.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      d1a303e8
    • Saulo Alessandre's avatar
      crypto: ecdsa - Register NIST P384 and extend test suite · c12d448b
      Saulo Alessandre authored
      Register NIST P384 as an akcipher and extend the testmgr with
      NIST P384-specific test vectors.
      
      Summary of changes:
      
      * crypto/ecdsa.c
        - add ecdsa_nist_p384_init_tfm
        - register and unregister P384 tfm
      
      * crypto/testmgr.c
        - add test vector for P384 on vector of tests
      
      * crypto/testmgr.h
        - add test vector params for P384(sha1, sha224, sha256, sha384
          and sha512)
      Signed-off-by: default avatarSaulo Alessandre <saulo.alessandre@tse.jus.br>
      Tested-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Acked-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      c12d448b
    • Saulo Alessandre's avatar
      crypto: ecc - Add math to support fast NIST P384 · 149ca161
      Saulo Alessandre authored
      Add the math needed for NIST P384 and adapt certain functions'
      parameters so that the ecc_curve is passed to vli_mmod_fast. This
      allows to identify the curve by its name prefix and the appropriate
      function for fast mmod calculation can be used.
      
      Summary of changes:
      
      * crypto/ecc.c
        - add vli_mmod_fast_384
        - change some routines to pass ecc_curve forward until vli_mmod_fast
      
      * crypto/ecc.h
        - add ECC_CURVE_NIST_P384_DIGITS
        - change ECC_MAX_DIGITS to P384 size
      Signed-off-by: default avatarSaulo Alessandre <saulo.alessandre@tse.jus.br>
      Tested-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      149ca161
    • Saulo Alessandre's avatar
      crypto: ecc - Add NIST P384 curve parameters · 703c748d
      Saulo Alessandre authored
      Add the parameters for the NIST P384 curve and define a new curve ID
      for it. Make the curve available in ecc_get_curve.
      
      Summary of changes:
      
      * crypto/ecc_curve_defs.h
        - add nist_p384 params
      
      * include/crypto/ecdh.h
        - add ECC_CURVE_NIST_P384
      
      * crypto/ecc.c
        - change ecc_get_curve to accept nist_p384
      Signed-off-by: default avatarSaulo Alessandre <saulo.alessandre@tse.jus.br>
      Tested-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Acked-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      703c748d
    • Stefan Berger's avatar
      crypto: ecdsa - Add support for ECDSA signature verification · 4e660291
      Stefan Berger authored
      Add support for parsing the parameters of a NIST P256 or NIST P192 key.
      Enable signature verification using these keys. The new module is
      enabled with CONFIG_ECDSA:
        Elliptic Curve Digital Signature Algorithm (NIST P192, P256 etc.)
        is A NIST cryptographic standard algorithm. Only signature verification
        is implemented.
      
      Cc: Herbert Xu <herbert@gondor.apana.org.au>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: linux-crypto@vger.kernel.org
      Signed-off-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      4e660291
    • Stefan Berger's avatar
      oid_registry: Add OIDs for ECDSA with SHA224/256/384/512 · 7547738d
      Stefan Berger authored
      Add OIDs for ECDSA with SHA224/256/384/512.
      Signed-off-by: default avatarStefan Berger <stefanb@linux.ibm.com>
      Acked-by: default avatarJarkko Sakkinen <jarkko@kernel.org>
      Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
      7547738d
  2. 19 Mar, 2021 10 commits
  3. 12 Mar, 2021 1 commit