- 25 Jan, 2022 40 commits
-
-
Martin Kaiser authored
The ODM_MAC_EDCA_TURBO flag is always set for chips that are supported by this driver. Remove the flag and the one place where it's checked. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220108124959.313215-2-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Minghao Chi authored
Return value from ips_netdrv_open() directly instead of taking this in another redundant variable. Reported-by:
Zeal Robot <zealci@zte.com.cn> Signed-off-by:
Minghao Chi <chi.minghao@zte.com.cn> Signed-off-by:
CGEL ZTE <cgel.zte@gmail.com> Link: https://lore.kernel.org/r/20220110013240.644190-1-chi.minghao@zte.com.cnSigned-off-by:
-
Michael Straube authored
Merge rtw_os_recv_resource_alloc() into _rtw_init_recv_priv() and remove rtw_os_recv_resource_alloc(). Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20220108082736.16788-6-straube.linux@gmail.comSigned-off-by:
-
Michael Straube authored
The function rtw_os_recv_resource_init() just returns _SUCCESS and the return value is not checked by the caller. Remove the function. Signed-off-by:
-
Michael Straube authored
The function rtw_os_recv_resource_free() is empty. Remove it. Signed-off-by:
-
Michael Straube authored
The 'switch (GetFrameSubType(pframe))' in mgt_dispatcher() has only one case that does something different than the default case. Convert the switch to an if statement to improve readability. Signed-off-by:
-
Michael Straube authored
The function rtw_hostapd_mlme_rx() is empty. Remove it. Signed-off-by:
-
Phillip Potter authored
Convert DBG_88E macro calls in os_dep/usb_ops_linux.c to use netdev_dbg when they may display useful information, and remove erroneous DBG_88E calls entirely. Signed-off-by:
Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20220108005550.26264-6-phil@philpotter.co.ukSigned-off-by:
-
Phillip Potter authored
Convert the DBG_88E macro call in core/rtw_cmd.c to use netdev_dbg as its information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Signed-off-by:
-
Phillip Potter authored
Remove the single DBG_88E macro call from os_dep/osdep_service.c, as it is unreachable anyway. This gets the driver closer to the eventual removal of DBG_88E itself. Signed-off-by:
-
Phillip Potter authored
Convert three DBG_88E macro calls in core/rtw_ap.c to use netdev_dbg as their information may be useful to observers, and this gets the driver closer to the point of being able to remove DBG_88E itself. Signed-off-by:
-
Phillip Potter authored
Convert DBG_88E macro calls in core/rtw_ap.c to use netdev_dbg when they may display useful information, and remove erroneous DBG_88E calls entirely. This leaves six empty static functions which only had DBG_88E calls, so just remove them: update_bcn_fixed_ie update_bcn_htcap_ie update_bcn_htinfo_ie update_bcn_rsn_ie update_bcn_wpa_ie update_bcn_wmm_ie also modifying the if blocks/switch cases that invoke them to no longer do so. This goes further towards the goal of removing this non-standard debugging code. Signed-off-by:
-
Michael Straube authored
SetHwReg8188EU() and GetHwReg8188EU() are never called with HW_VAR_APFM_ON_MAC. Remove that case from both functions. Signed-off-by:
-
Michael Straube authored
The field EfuseUsedBytes of struct hal_data_8188e is set but never used. Remove it. Signed-off-by:
-
Michael Straube authored
GetHwReg8188EU() is never called with HW_VAR_EFUSE_BYTES. Remove that case from the function. Signed-off-by:
-
Michael Straube authored
GetHwReg8188EU() is never called with HW_VAR_CURRENT_ANTENNA. Remove that case from the function. Signed-off-by:
-
Michael Straube authored
SetHwReg8188EU() and GetHwReg8188EU() are never called with HW_VAR_TXPAUSE. Remove that case from both functions. Signed-off-by:
-
Michael Straube authored
GetHwReg8188EU() is never called with HW_VAR_BASIC_RATE. Remove that case from the function. Signed-off-by:
-
Michael Straube authored
Move firmware related macros from rtl8188e_hal.h to rtw_fw.h. Signed-off-by:
-
Michael Straube authored
Add spaces around & operator in the macro IS_FW_HEADER_EXIST to improve readability and follow kernel coding style. Signed-off-by:
-
Michael Straube authored
Rename _pFwHdr in the macro IS_FW_HEADER_EXIST to avoid camel case. _pFwHdr -> _fwhdr Signed-off-by:
-
Michael Straube authored
Move the firmware loading functions from rtl8188e_hal_init.c into the new file core/rtw_fw.c. Signed-off-by:
-
Michael Straube authored
Rename the variables pFirmwareBuf and FirmwareLen in rtl8188e_firmware_download() to avoid camel case. pFirmwareBuf -> fw_data FirmwareLen -> fw_size Signed-off-by:
-
Michael Straube authored
Rename the variable pFwHdr in rtl8188e_firmware_download() to avoid camel case. pFwHdr -> fwhdr Signed-off-by:
-
Michael Straube authored
Rename the variable writeFW_retry in rtl8188e_firmware_download() to avoid camel case. writeFW_retry -> write_fw_retry Signed-off-by:
-
Michael Straube authored
Rename FWDL_ChkSum_rpt to avoid camel case. FWDL_ChkSum_rpt -> FWDL_CHKSUM_RPT Signed-off-by:
-
Michael Straube authored
Rename the variable rtStatus in rtl8188e_firmware_download() to avoid camel case. rtStatus -> ret Signed-off-by:
-
Michael Straube authored
Rename the Exit label in rtl8188e_firmware_download() to avoid camel case. Exit -> exit Signed-off-by:
-
Michael Straube authored
Convert the return type of fw_free_to_go() and rtl8188e_firmware_download() from s32 to the more common int. Signed-off-by:
-
Michael Straube authored
Rename the local variable u1bTmp in rtw_reset_8051() to avoid camel case and remove a call to DBG_88E that contains no important information. Signed-off-by:
-
Michael Straube authored
Rename firmware related functions to avoid camel case. rtl8188e_FirmwareDownload -> rtl8188e_firmware_download _FWDownloadEnable -> fw_download_enable _8051Reset88E -> rtw_reset_8051 _FWFreeToGo -> fw_free_to_go _BlockWrite -> block_write _PageWrite -> page_write _WriteFW -> write_fw Signed-off-by:
-
Michael Straube authored
Use kmemdup instead of kzalloc and memcpy in load_firmware(). Signed-off-by:
-
Michael Straube authored
Rename fields of struct rt_firmware to avoid camel case. szFwBuffer -> data ulFwLength -> size Signed-off-by:
-
Michael Straube authored
Rename the parameter pFirmware of load_firmware() to avoid camel case. pFirmware -> rtfw Signed-off-by:
-
Michael Straube authored
The return type of load_firmware() is int. Change the type of the return variable from s32 to int to match the function return type. Signed-off-by:
-
Michael Straube authored
Rename the local variable rtStatus in load_firmware() to avoid camel case. rtStatus -> ret Signed-off-by:
-
Michael Straube authored
Rename Exit label in load_firmware() to avoid camel case. Exit -> exit Signed-off-by:
-
Michael Straube authored
In function load_firmware() release_firmware() is not called if the allocation of pFirmware->szFwBuffer fails or if fw->size is greater than FW_8188E_SIZE. Move the call to release_firmware() to the exit label at the end of the function to fix this. Fixes: 8cd574e6 ("staging: r8188eu: introduce new hal dir for RTL8188eu driver") Signed-off-by:
-
Michael Straube authored
Merge rtl8188e_InitializeFirmwareVars() into rtl8188eu_hal_init() and remove rtl8188e_InitializeFirmwareVars(). Signed-off-by:
-
Michael Straube authored
The fields FirmwareVersion, FirmwareSubVersion and FirmwareSignature of struct hal_data_8188e are only used in the function rtl8188e_FirmwareDownload(). Use local variables in that function and remove the fields from struct hal_data_8188e. FirmwareVersionRev is not used at all, remove it as well. Signed-off-by:
-
