An error occurred fetching the project authors.
  1. 04 Oct, 2018 2 commits
  2. 11 Sep, 2018 1 commit
  3. 18 Jun, 2018 1 commit
  4. 15 Jun, 2018 1 commit
  5. 05 Jun, 2018 1 commit
  6. 28 May, 2018 1 commit
    • Akinobu Mita's avatar
      media: pxa_camera: avoid duplicate s_power calls · 94ae1d6b
      Akinobu Mita authored
      The open() operation for the pxa_camera driver always calls s_power()
      operation to put its subdevice sensor in normal operation mode, and the
      release() operation always call s_power() operation to put the subdevice
      in power saving mode.
      
      This requires the subdevice sensor driver to keep track of its power
      state in order to avoid putting the subdevice in power saving mode while
      the device is still opened by some users.
      
      Many subdevice drivers handle it by the boilerplate code that increments
      and decrements an internal counter in s_power() like below:
      
      	/*
      	 * If the power count is modified from 0 to != 0 or from != 0 to 0,
      	 * update the power state.
      	 */
      	if (sensor->power_count == !on) {
      		ret = ov5640_set_power(sensor, !!on);
      		if (ret)
      			goto out;
      	}
      
      	/* Update the power count. */
      	sensor->power_count += on ? 1 : -1;
      
      However, some subdevice drivers don't handle it and may cause a problem
      with the pxa_camera driver if the video device is opened by more than
      two users at the same time.
      
      Instead of propagating the boilerplate code for each subdevice driver
      that implement s_power, this introduces an trick that many V4L2 drivers
      are using with v4l2_fh_is_singular_file().
      Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
      94ae1d6b
  7. 29 Dec, 2017 1 commit
  8. 18 Dec, 2017 1 commit
  9. 14 Dec, 2017 1 commit
  10. 13 Dec, 2017 1 commit
  11. 30 Nov, 2017 1 commit
    • Mauro Carvalho Chehab's avatar
      media: pxa_camera: get rid of kernel_doc warnings · 8fd87479
      Mauro Carvalho Chehab authored
      Get rid of the following warnings:
          drivers/media/platform/pxa_camera.c:247: warning: No description found for parameter 'layout'
          drivers/media/platform/pxa_camera.c:867: warning: No description found for parameter 'buf'
          drivers/media/platform/pxa_camera.c:867: warning: No description found for parameter 'sg'
          drivers/media/platform/pxa_camera.c:867: warning: No description found for parameter 'sglen'
          drivers/media/platform/pxa_camera.c:867: warning: Excess function parameter 'vb' description in 'pxa_init_dma_channel'
          drivers/media/platform/pxa_camera.c:867: warning: Excess function parameter 'dma' description in 'pxa_init_dma_channel'
          drivers/media/platform/pxa_camera.c:867: warning: Excess function parameter 'cibr' description in 'pxa_init_dma_channel'
          drivers/media/platform/pxa_camera.c:1029: warning: No description found for parameter 'last_submitted'
          drivers/media/platform/pxa_camera.c:1029: warning: No description found for parameter 'last_issued'
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      8fd87479
  12. 31 Oct, 2017 1 commit
  13. 20 Aug, 2017 2 commits
  14. 08 Aug, 2017 1 commit
  15. 19 Jul, 2017 2 commits
  16. 06 Jun, 2017 5 commits
  17. 19 May, 2017 1 commit
    • Mauro Carvalho Chehab's avatar
      [media] media drivers: annotate fall-through · 06eeefe8
      Mauro Carvalho Chehab authored
      Avoid warnings like those:
      
      drivers/media/pci/ddbridge/ddbridge-core.c: In function 'dvb_input_detach':
      drivers/media/pci/ddbridge/ddbridge-core.c:787:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
         if (input->fe) {
            ^
      drivers/media/pci/ddbridge/ddbridge-core.c:792:2: note: here
        case 4:
        ^~~~
      ...
      
      On several cases, it is just that gcc 7.1 is not capable of
      understanding the comment, but on other places, we need an
      annotation.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      06eeefe8
  18. 18 May, 2017 1 commit
    • Petr Cvek's avatar
      [media] pxa_camera: fix module remove codepath for v4l2 clock · e3b4d10c
      Petr Cvek authored
      The conversion from soc_camera omitted a correct handling of the clock
      gating for a sensor. When the pxa_camera driver module was removed it
      tried to unregister clk, but this caused a similar warning:
      
        WARNING: CPU: 0 PID: 6740 at drivers/media/v4l2-core/v4l2-clk.c:278
        v4l2_clk_unregister(): Refusing to unregister ref-counted 0-0030 clock!
      
      The clock was at time still refcounted by the sensor driver. Before
      the removing of the pxa_camera the clock must be dropped by the sensor
      driver. This should be triggered by v4l2_async_notifier_unregister() call
      which removes sensor driver module too, calls unbind() function and then
      tries to probe sensor driver again. Inside unbind() we can safely
      unregister the v4l2 clock as the sensor driver got removed. The original
      v4l2_clk_unregister() should be put inside test as the clock can be
      already unregistered from unbind(). If there was not any bound sensor
      the clock is still present.
      
      The codepath is practically a copy from the old soc_camera. The bug was
      tested with a pxa_camera+ov9640 combination during the conversion
      of the ov9640 from the soc_camera.
      Signed-off-by: default avatarPetr Cvek <petr.cvek@tul.cz>
      Tested-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      e3b4d10c
  19. 24 Oct, 2016 1 commit
  20. 21 Oct, 2016 1 commit
    • Mauro Carvalho Chehab's avatar
      [media] platform: don't break long lines · 759a4ed4
      Mauro Carvalho Chehab authored
      Due to the 80-cols restrictions, and latter due to checkpatch
      warnings, several strings were broken into multiple lines. This
      is not considered a good practice anymore, as it makes harder
      to grep for strings at the source code.
      
      As we're right now fixing other drivers due to KERN_CONT, we need
      to be able to identify what printk strings don't end with a "\n".
      It is a way easier to detect those if we don't break long lines.
      
      So, join those continuation lines.
      
      The patch was generated via the script below, and manually
      adjusted if needed.
      
      </script>
      use Text::Tabs;
      while (<>) {
      	if ($next ne "") {
      		$c=$_;
      		if ($c =~ /^\s+\"(.*)/) {
      			$c2=$1;
      			$next =~ s/\"\n$//;
      			$n = expand($next);
      			$funpos = index($n, '(');
      			$pos = index($c2, '",');
      			if ($funpos && $pos > 0) {
      				$s1 = substr $c2, 0, $pos + 2;
      				$s2 = ' ' x ($funpos + 1) . substr $c2, $pos + 2;
      				$s2 =~ s/^\s+//;
      
      				$s2 = ' ' x ($funpos + 1) . $s2 if ($s2 ne "");
      
      				print unexpand("$next$s1\n");
      				print unexpand("$s2\n") if ($s2 ne "");
      			} else {
      				print "$next$c2\n";
      			}
      			$next="";
      			next;
      		} else {
      			print $next;
      		}
      		$next="";
      	} else {
      		if (m/\"$/) {
      			if (!m/\\n\"$/) {
      				$next=$_;
      				next;
      			}
      		}
      	}
      	print $_;
      }
      </script>
      Acked-by: default avatarRobert Jarzmik <robert.jarzmik@free.fr>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      759a4ed4
  21. 19 Sep, 2016 3 commits
  22. 12 Sep, 2016 1 commit
    • Hans Verkuil's avatar
      [media] pxa_camera: merge soc_mediabus.c into pxa_camera.c · 34b27b13
      Hans Verkuil authored
      Linking soc_mediabus into this driver causes multiple definition linker warnings
      if soc_camera is also enabled:
      
         drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_image_size+0x0): multiple definition of `__ksymtab_soc_mbus_image_size'
         drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_image_size+0x0): first defined here
      >> drivers/media/platform/soc_camera/built-in.o:(___ksymtab+soc_mbus_samples_per_pixel+0x0): multiple definition of `__ksymtab_soc_mbus_samples_per_pixel'
         drivers/media/platform/soc_camera/soc_mediabus.o:(___ksymtab+soc_mbus_samples_per_pixel+0x0): first defined here
         drivers/media/platform/soc_camera/built-in.o: In function `soc_mbus_config_compatible':
         (.text+0x3840): multiple definition of `soc_mbus_config_compatible'
         drivers/media/platform/soc_camera/soc_mediabus.o:(.text+0x134): first defined here
      
      Since we really don't want to have to use any of the soc-camera code this patch
      copies the relevant code and data structures from soc_mediabus and renames it to pxa_mbus_*.
      
      The large table of formats has been culled a bit, removing formats that are not supported
      by this driver.
      Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
      Cc: Robert Jarzmik <robert.jarzmik@free.fr>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
      34b27b13
  23. 09 Sep, 2016 9 commits