1. 13 Mar, 2021 30 commits
    • Geliang Tang's avatar
      mptcp: remove multi addresses in PM · d0b698ca
      Geliang Tang authored
      This patch dropped the member rm_id of struct mptcp_pm_data. Use
      rm_list_rx in mptcp_pm_nl_rm_addr_received instead of using rm_id.
      
      In mptcp_pm_nl_rm_addr_received, iterated each address id from
      pm.rm_list_rx, then shut down and closed each address id's subsocket.
      Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
      Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d0b698ca
    • Geliang Tang's avatar
      mptcp: add rm_list_rx in mptcp_pm_data · b5c55f33
      Geliang Tang authored
      This patch added a new member rm_list_rx for struct mptcp_pm_data as an
      list of the removing address ids on the incoming direction. Initialized
      its nr field to zero in mptcp_pm_data_init.
      
      In mptcp_pm_rm_addr_received, set it as the input rm_list.
      Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
      Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b5c55f33
    • Geliang Tang's avatar
      mptcp: add rm_list in mptcp_options_received · 5c4a824d
      Geliang Tang authored
      This patch changed the member rm_id in struct mptcp_options_received as a
      list of the removing address ids, and renamed it to rm_list.
      
      In mptcp_parse_option, parsed the RM_ADDR suboption and filled them into
      the rm_list in struct mptcp_options_received.
      
      In mptcp_incoming_options, passed this rm_list to the function
      mptcp_pm_rm_addr_received.
      
      It also changed the parameter type of mptcp_pm_rm_addr_received.
      Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
      Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5c4a824d
    • Geliang Tang's avatar
      mptcp: add rm_list_tx in mptcp_pm_data · cbde2787
      Geliang Tang authored
      This patch added a new member rm_list_tx for struct mptcp_pm_data as the
      removing address list on the outgoing direction. Initialize its nr field
      to zero in mptcp_pm_data_init.
      
      In mptcp_pm_remove_anno_addr, put the single address id into an removing
      list, and passed it to mptcp_pm_remove_addr.
      
      In mptcp_pm_remove_addr, save the input rm_list to rm_list_tx in struct
      mptcp_pm_data.
      Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
      Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      cbde2787
    • Geliang Tang's avatar
      mptcp: add rm_list in mptcp_out_options · 6445e17a
      Geliang Tang authored
      This patch defined a new struct mptcp_rm_list, the ids field was an
      array of the removing address ids, the nr field was the valid number of
      removing address ids in the array. The array size was definced as a new
      macro MPTCP_RM_IDS_MAX. Changed the member rm_id of struct
      mptcp_out_options to rm_list.
      
      In mptcp_established_options_rm_addr, invoked mptcp_pm_rm_addr_signal to
      get the rm_list. According the number of addresses in it, calculated
      the padded RM_ADDR suboption length. And saved the ids array in struct
      mptcp_out_options's rm_list member.
      
      In mptcp_write_options, iterated each address id from struct
      mptcp_out_options's rm_list member, set the invalid ones as TCPOPT_NOP,
      then filled them into the RM_ADDR suboption.
      
      Changed TCPOLEN_MPTCP_RM_ADDR_BASE from 4 to 3.
      Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
      Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6445e17a
    • David S. Miller's avatar
      Merge branch 'resil-nhgroups-netdevsim-selftests' · e9e90a70
      David S. Miller authored
      Petr Machata says:
      
      ====================
      net: Resilient NH groups: netdevsim, selftests
      
      Support for resilient next-hop groups was added in a previous patch set.
      Resilient next hop groups add a layer of indirection between the SKB hash
      and the next hop. Thus the hash is used to reference a hash table bucket,
      which is then used to reference a particular next hop. This allows the
      system more flexibility when assigning SKB hash space to next hops.
      Previously, each next hop had to be assigned a continuous range of SKB hash
      space. With a hash table as an intermediate layer, it is possible to
      reassign next hops with a hash table bucket granularity. In turn, this
      mends issues with traffic flow redirection resulting from next hop removal
      or adjustments in next-hop weights.
      
      This patch set introduces mock offloading of resilient next hop groups by
      the netdevsim driver, and a suite of selftests.
      
      - Patch #1 adds a netdevsim-specific lock to protect next-hop hashtable.
        Previously, netdevsim relied on RTNL to maintain mutual exclusion.
        Patch #2 extracts a helper to make the following patches clearer.
      
      - Patch #3 implements the support for offloading of resilient next-hop
        groups.
      
      - Patch #4 introduces a new debugfs interface to set activity on a selected
        next-hop bucket. This simulates how HW can periodically report bucket
        activity, and buckets thus marked are expected to be exempt from
        migration to new next hops when the group changes.
      
      - Patches #5 and #6 clean up the fib_nexthop selftests.
      
      - Patches #7, #8 and #9 add tests for resilient next hop groups. Patch #7
        adds resilient-hashing counterparts to fib_nexthops.sh. Patch #8 adds a
        new traffic test for resilient next-hop groups. Patch #9 adds a new
        traffic test for tunneling.
      
      - Patch #10 actually leverages the netdevsim offload to implement a suite
        of algorithmic tests that verify how and when buckets are migrated under
        various simulated workload scenarios.
      
      The overall plan is to contribute approximately the following patchsets:
      
      1) Nexthop policy refactoring (already pushed)
      2) Preparations for resilient next hop groups (already pushed)
      3) Implementation of resilient next hop group (already pushed)
      4) Netdevsim offload plus a suite of selftests (this patchset)
      5) Preparations for mlxsw offload of resilient next-hop groups
      6) mlxsw offload including selftests
      
      Interested parties can look at the complete code at [2].
      
      [1] https://tools.ietf.org/html/rfc2992
      [2] https://github.com/idosch/linux/commits/submit/res_integ_v1
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e9e90a70
    • Ido Schimmel's avatar
      selftests: netdevsim: Add test for resilient nexthop groups offload API · b8a07c4c
      Ido Schimmel authored
      Test various aspects of the resilient nexthop group offload API on top
      of the netdevsim implementation. Both good and bad flows are tested.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Co-developed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b8a07c4c
    • Ido Schimmel's avatar
      selftests: forwarding: Add resilient multipath tunneling nexthop test · 902280ca
      Ido Schimmel authored
      Add a resilient nexthop objects version of gre_multipath_nh.sh. Test
      that both IPv4 and IPv6 overlays work with resilient nexthop groups
      where the nexthops are two GRE tunnels.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      902280ca
    • Ido Schimmel's avatar
      selftests: forwarding: Add resilient hashing test · 386e3792
      Ido Schimmel authored
      Verify that IPv4 and IPv6 multipath forwarding works correctly with
      resilient nexthop groups and with different weights.
      
      Test that when the idle timer is not zero, the resilient groups are not
      rebalanced - because the nexthop buckets are considered active - and the
      initial weights (1:1) are used.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      386e3792
    • Ido Schimmel's avatar
      selftests: fib_nexthops: Test resilient nexthop groups · 557205f4
      Ido Schimmel authored
      Add test cases for resilient nexthop groups. Exhaustive forwarding tests
      are added separately under net/forwarding/.
      
      Examples:
      
       # ./fib_nexthops.sh -t basic_res
      
      Basic resilient nexthop group functional tests
      ----------------------------------------------
      TEST: Add a nexthop group with default parameters                   [ OK ]
      TEST: Get a nexthop group with default parameters                   [ OK ]
      TEST: Get a nexthop group with non-default parameters               [ OK ]
      TEST: Add a nexthop group with 0 buckets                            [ OK ]
      TEST: Replace nexthop group parameters                              [ OK ]
      TEST: Get a nexthop group after replacing parameters                [ OK ]
      TEST: Replace idle timer                                            [ OK ]
      TEST: Get a nexthop group after replacing idle timer                [ OK ]
      TEST: Replace unbalanced timer                                      [ OK ]
      TEST: Get a nexthop group after replacing unbalanced timer          [ OK ]
      TEST: Replace with no parameters                                    [ OK ]
      TEST: Get a nexthop group after replacing no parameters             [ OK ]
      TEST: Replace nexthop group type - implicit                         [ OK ]
      TEST: Replace nexthop group type - explicit                         [ OK ]
      TEST: Replace number of nexthop buckets                             [ OK ]
      TEST: Get a nexthop group after replacing with invalid parameters   [ OK ]
      TEST: Dump all nexthop buckets                                      [ OK ]
      TEST: Dump all nexthop buckets in a group                           [ OK ]
      TEST: Dump all nexthop buckets with a specific nexthop device       [ OK ]
      TEST: Dump all nexthop buckets with a specific nexthop identifier   [ OK ]
      TEST: Dump all nexthop buckets in a non-existent group              [ OK ]
      TEST: Dump all nexthop buckets in a non-resilient group             [ OK ]
      TEST: Dump all nexthop buckets using a non-existent device          [ OK ]
      TEST: Dump all nexthop buckets with invalid 'groups' keyword        [ OK ]
      TEST: Dump all nexthop buckets with invalid 'fdb' keyword           [ OK ]
      TEST: Get a valid nexthop bucket                                    [ OK ]
      TEST: Get a nexthop bucket with valid group, but invalid index      [ OK ]
      TEST: Get a nexthop bucket from a non-resilient group               [ OK ]
      TEST: Get a nexthop bucket from a non-existent group                [ OK ]
      
      Tests passed:  29
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv4_large_res_grp
      
      IPv4 large resilient group (128k buckets)
      -----------------------------------------
      TEST: Dump large (x131072) nexthop buckets                          [ OK ]
      
      Tests passed:   1
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv6_large_res_grp
      
      IPv6 large resilient group (128k buckets)
      -----------------------------------------
      TEST: Dump large (x131072) nexthop buckets                          [ OK ]
      
      Tests passed:   1
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv4_res_torture
      
      IPv4 runtime resilient nexthop group torture
      --------------------------------------------
      TEST: IPv4 resilient nexthop group torture test                     [ OK ]
      
      Tests passed:   1
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv6_res_torture
      
      IPv6 runtime resilient nexthop group torture
      --------------------------------------------
      TEST: IPv6 resilient nexthop group torture test                     [ OK ]
      
      Tests passed:   1
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv4_res_grp_fcnal
      
      IPv4 resilient groups functional
      --------------------------------
      TEST: Nexthop group updated when entry is deleted                   [ OK ]
      TEST: Nexthop buckets updated when entry is deleted                 [ OK ]
      TEST: Nexthop group updated after replace                           [ OK ]
      TEST: Nexthop buckets updated after replace                         [ OK ]
      TEST: Nexthop group updated when entry is deleted - nECMP           [ OK ]
      TEST: Nexthop buckets updated when entry is deleted - nECMP         [ OK ]
      TEST: Nexthop group updated after replace - nECMP                   [ OK ]
      TEST: Nexthop buckets updated after replace - nECMP                 [ OK ]
      
      Tests passed:   8
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv6_res_grp_fcnal
      
      IPv6 resilient groups functional
      --------------------------------
      TEST: Nexthop group updated when entry is deleted                   [ OK ]
      TEST: Nexthop buckets updated when entry is deleted                 [ OK ]
      TEST: Nexthop group updated after replace                           [ OK ]
      TEST: Nexthop buckets updated after replace                         [ OK ]
      TEST: Nexthop group updated when entry is deleted - nECMP           [ OK ]
      TEST: Nexthop buckets updated when entry is deleted - nECMP         [ OK ]
      TEST: Nexthop group updated after replace - nECMP                   [ OK ]
      TEST: Nexthop buckets updated after replace - nECMP                 [ OK ]
      
      Tests passed:   8
      Tests failed:   0
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Co-developed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      557205f4
    • Ido Schimmel's avatar
      selftests: fib_nexthops: List each test case in a different line · a8f9952d
      Ido Schimmel authored
      The lines with the IPv4 and IPv6 test cases are already very long and
      more test cases will be added in subsequent patches.
      
      List each test case in a different line to make it easier to extend the
      test with more test cases.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a8f9952d
    • Ido Schimmel's avatar
      selftests: fib_nexthops: Declutter test output · 8e815284
      Ido Schimmel authored
      Before:
      
       # ./fib_nexthops.sh -t ipv4_torture
      
      IPv4 runtime torture
      --------------------
      TEST: IPv4 torture test                                             [ OK ]
      ./fib_nexthops.sh: line 213: 19376 Killed                  ipv4_del_add_loop1
      ./fib_nexthops.sh: line 213: 19377 Killed                  ipv4_grp_replace_loop
      ./fib_nexthops.sh: line 213: 19378 Killed                  ip netns exec me ping -f 172.16.101.1 > /dev/null 2>&1
      ./fib_nexthops.sh: line 213: 19380 Killed                  ip netns exec me ping -f 172.16.101.2 > /dev/null 2>&1
      ./fib_nexthops.sh: line 213: 19381 Killed                  ip netns exec me mausezahn veth1 -B 172.16.101.2 -A 172.16.1.1 -c 0 -t tcp "dp=1-1023, flags=syn" > /dev/null 2>&1
      
      Tests passed:   1
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv6_torture
      
      IPv6 runtime torture
      --------------------
      TEST: IPv6 torture test                                             [ OK ]
      ./fib_nexthops.sh: line 213: 24453 Killed                  ipv6_del_add_loop1
      ./fib_nexthops.sh: line 213: 24454 Killed                  ipv6_grp_replace_loop
      ./fib_nexthops.sh: line 213: 24456 Killed                  ip netns exec me ping -f 2001:db8:101::1 > /dev/null 2>&1
      ./fib_nexthops.sh: line 213: 24457 Killed                  ip netns exec me ping -f 2001:db8:101::2 > /dev/null 2>&1
      ./fib_nexthops.sh: line 213: 24458 Killed                  ip netns exec me mausezahn -6 veth1 -B 2001:db8:101::2 -A 2001:db8:91::1 -c 0 -t tcp "dp=1-1023, flags=syn" > /dev/null 2>&1
      
      Tests passed:   1
      Tests failed:   0
      
      After:
      
       # ./fib_nexthops.sh -t ipv4_torture
      
      IPv4 runtime torture
      --------------------
      TEST: IPv4 torture test                                             [ OK ]
      
      Tests passed:   1
      Tests failed:   0
      
       # ./fib_nexthops.sh -t ipv6_torture
      
      IPv6 runtime torture
      --------------------
      TEST: IPv6 torture test                                             [ OK ]
      
      Tests passed:   1
      Tests failed:   0
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8e815284
    • Ido Schimmel's avatar
      netdevsim: Allow reporting activity on nexthop buckets · c6385c0b
      Ido Schimmel authored
      A key component of the resilient hashing algorithm is the hash buckets'
      activity. If a bucket is active, it will not be populated with a new
      nexthop in order not to break existing flows. Therefore, in order to
      easily and thoroughly test the algorithm, we need to be in full control
      over the reported activity.
      
      Add a debugfs interface that allows user space to have netdevsim report
      a nexthop bucket within a resilient nexthop group as active. For
      example:
      
       # echo 10 23 > /sys/kernel/debug/netdevsim/netdevsim10/fib/nexthop_bucket_activity
      
      Will mark bucket 23 in nexthop group 10 as active.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c6385c0b
    • Ido Schimmel's avatar
      netdevsim: Add support for resilient nexthop groups · d8eaa4fa
      Ido Schimmel authored
      Allow resilient nexthop groups to be programmed and account their
      occupancy according to their number of buckets. The nexthop group itself
      as well as its buckets are marked with hardware flags (i.e.,
      'RTNH_F_TRAP').
      
      Replacement of a single nexthop bucket can fail using the following
      debugfs knob:
      
       # cat /sys/kernel/debug/netdevsim/netdevsim10/fib/fail_nexthop_bucket_replace
       N
       # echo 1 > /sys/kernel/debug/netdevsim/netdevsim10/fib/fail_nexthop_bucket_replace
       # cat /sys/kernel/debug/netdevsim/netdevsim10/fib/fail_nexthop_bucket_replace
       Y
      
      Replacement of a resilient nexthop group can fail using the following
      debugfs knob:
      
       # cat /sys/kernel/debug/netdevsim/netdevsim10/fib/fail_res_nexthop_group_replace
       N
       # echo 1 > /sys/kernel/debug/netdevsim/netdevsim10/fib/fail_res_nexthop_group_replace
       # cat /sys/kernel/debug/netdevsim/netdevsim10/fib/fail_res_nexthop_group_replace
       Y
      
      This enables testing of various error paths.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      d8eaa4fa
    • Ido Schimmel's avatar
      netdevsim: Create a helper for setting nexthop hardware flags · 40ff8371
      Ido Schimmel authored
      Instead of calling nexthop_set_hw_flags(), call a helper. It will be
      used to also set nexthop bucket flags in a subsequent patch.
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      40ff8371
    • Petr Machata's avatar
      netdevsim: fib: Introduce a lock to guard nexthop hashtable · 86927c9c
      Petr Machata authored
      Currently netdevsim relies on RTNL to maintain exclusivity in accessing the
      nexthop hash table. However, bucket notification may be called without RTNL
      having been held. Instead, introduce a custom lock to guard the table.
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      86927c9c
    • David S. Miller's avatar
      Merge branch 'ptp-warnings' · b202923d
      David S. Miller authored
      Lee Jones says:
      
      ====================
      Rid W=1 warnings from PTP
      
      This set is part of a larger effort attempting to clean-up W=1
      kernel builds, which are currently overwhelmingly riddled with
      niggly little warnings.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b202923d
    • Lee Jones's avatar
      ptp: ptp_p: Demote non-conformant kernel-doc headers and supply a param description · 287f93de
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'control' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'event' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'addend' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'accum' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'test' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ts_compare' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rsystime_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rsystime_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'systime_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'systime_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'trgt_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'trgt_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'asms_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'asms_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'amms_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'amms_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ch_control' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ch_event' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'tx_snap_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'tx_snap_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rx_snap_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'rx_snap_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'src_uuid_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'src_uuid_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'can_status' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'can_snap_lo' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'can_snap_hi' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ts_sel' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'ts_st' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'reserve1' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'stl_max_set_en' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'stl_max_set' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'reserve2' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:78: warning: Function parameter or member 'srst' not described in 'pch_ts_regs'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'regs' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'ptp_clock' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'caps' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'exts0_enabled' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'exts1_enabled' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'mem_base' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'mem_size' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'irq' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'pdev' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:121: warning: Function parameter or member 'register_lock' not described in 'pch_dev'
       drivers/ptp/ptp_pch.c:128: warning: Function parameter or member 'station' not described in 'pch_params'
       drivers/ptp/ptp_pch.c:291: warning: Function parameter or member 'pdev' not described in 'pch_set_station_address'
      
      Cc: Richard Cochran <richardcochran@gmail.com>
      Cc: LAPIS SEMICONDUCTOR <tshimizu818@gmail.com>
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      287f93de
    • Lee Jones's avatar
      ptp: ptp_clockmatrix: Demote non-kernel-doc header to standard comment · 9ec04c71
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand  * @brief Maximum absolute value for write phase offset in picoseconds
       drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand  * @brief Maximum absolute value for write phase offset in picoseconds
       drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand  * @brief Maximum absolute value for write phase offset in picoseconds
       drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand  * @brief Maximum absolute value for write phase offset in picoseconds
       drivers/ptp/ptp_clockmatrix.c:1408: warning: Cannot understand  * @brief Maximum absolute value for write phase offset in picoseconds
      
      Cc: Richard Cochran <richardcochran@gmail.com>
      Cc: IDT-support-1588@lm.renesas.com
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9ec04c71
    • Lee Jones's avatar
      ptp_pch: Move 'pch_*()' prototypes to shared header · f90fc37f
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmissing-prototypes]
       drivers/ptp/ptp_pch.c:201:5: warning: no previous prototype for ‘pch_ch_event_read’ [-Wmissing-prototypes]
       drivers/ptp/ptp_pch.c:212:6: warning: no previous prototype for ‘pch_ch_event_write’ [-Wmissing-prototypes]
       drivers/ptp/ptp_pch.c:220:5: warning: no previous prototype for ‘pch_src_uuid_lo_read’ [-Wmissing-prototypes]
       drivers/ptp/ptp_pch.c:231:5: warning: no previous prototype for ‘pch_src_uuid_hi_read’ [-Wmissing-prototypes]
       drivers/ptp/ptp_pch.c:242:5: warning: no previous prototype for ‘pch_rx_snap_read’ [-Wmissing-prototypes]
       drivers/ptp/ptp_pch.c:259:5: warning: no previous prototype for ‘pch_tx_snap_read’ [-Wmissing-prototypes]
       drivers/ptp/ptp_pch.c:300:5: warning: no previous prototype for ‘pch_set_station_address’ [-Wmissing-prototypes]
      
      Cc: Richard Cochran <richardcochran@gmail.com> (maintainer:PTP HARDWARE CLOCK SUPPORT)
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Flavio Suligoi <f.suligoi@asem.it>
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f90fc37f
    • Lee Jones's avatar
      ptp_pch: Remove unused function 'pch_ch_control_read()' · 257382c5
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes]
      
      Cc: Richard Cochran <richardcochran@gmail.com> (maintainer:PTP HARDWARE CLOCK SUPPORT)
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Flavio Suligoi <f.suligoi@asem.it>
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      257382c5
    • Rafał Miłecki's avatar
      net: dsa: bcm_sf2: setup BCM4908 internal crossbar · a9349f08
      Rafał Miłecki authored
      On some SoCs (e.g. BCM4908, BCM631[345]8) SF2 has an integrated
      crossbar. It allows connecting its selected external ports to internal
      ports. It's used by vendors to handle custom Ethernet setups.
      
      BCM4908 has following 3x2 crossbar. On Asus GT-AC5300 rgmii is used for
      connecting external BCM53134S switch. GPHY4 is usually used for WAN
      port. More fancy devices use SerDes for 2.5 Gbps Ethernet.
      
                    ┌──────────┐
      SerDes ─── 0 ─┤          │
                    │   3x2    ├─ 0 ─── switch port 7
       GPHY4 ─── 1 ─┤          │
                    │ crossbar ├─ 1 ─── runner (accelerator)
       rgmii ─── 2 ─┤          │
                    └──────────┘
      
      Use setup data based on DT info to configure BCM4908's switch port 7.
      Right now only GPHY and rgmii variants are supported. Handling SerDes
      can be implemented later.
      Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
      Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a9349f08
    • Rafał Miłecki's avatar
      net: dsa: bcm_sf2: store PHY interface/mode in port structure · 01488a0c
      Rafał Miłecki authored
      It's needed later for proper switch / crossbar setup.
      Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
      Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      01488a0c
    • Shubhankar Kuranagatti's avatar
      net: ipv4: route.c: Fix indentation of multi line comment. · 6ad08600
      Shubhankar Kuranagatti authored
      All comment lines inside the comment block have been aligned.
      Every line of comment starts with a * (uniformity in code).
      Signed-off-by: default avatarShubhankar Kuranagatti <shubhankarvk@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      6ad08600
    • Rafał Miłecki's avatar
      net: broadcom: bcm4908_enet: support TX interrupt · 12bb508b
      Rafał Miłecki authored
      It appears that each DMA channel has its own interrupt and both rings
      can be configured (the same way) to handle interrupts.
      
      1. Make ring interrupts code generic (make it operate on given ring)
      2. Move napi to ring (so each has its own)
      3. Make IRQ handler generic (match ring against received IRQ number)
      4. Add (optional) support for TX interrupt
      Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      12bb508b
    • Rafał Miłecki's avatar
      dt-bindings: net: bcm4908-enet: add optional TX interrupt · ab4dda7a
      Rafał Miłecki authored
      I discovered that hardware actually supports two interrupts, one per DMA
      channel (RX and TX).
      Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ab4dda7a
    • David S. Miller's avatar
      Merge branch 'macb-fixed-link-fixes' · 26d2e042
      David S. Miller authored
      Robert Hancock says:
      
      ====================
      macb SGMII fixed-link fixes
      
      Some fixes to the macb driver for use in SGMII mode with a fixed-link (such as
      for chip-to-chip connectivity).
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      26d2e042
    • Robert Hancock's avatar
      net: macb: Disable PCS auto-negotiation for SGMII fixed-link mode · e276e5e4
      Robert Hancock authored
      When using a fixed-link configuration in SGMII mode, it's not really
      sensible to have auto-negotiation enabled since the link settings are
      fixed by definition. In other configurations, such as an SGMII
      connection to a PHY, it should generally be enabled.
      Signed-off-by: default avatarRobert Hancock <robert.hancock@calian.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e276e5e4
    • Robert Hancock's avatar
      net: macb: poll for fixed link state in SGMII mode · 8fab174b
      Robert Hancock authored
      When using a fixed-link configuration with GEM in SGMII mode, such as
      for a chip-to-chip interconnect, the link state was always showing as
      established regardless of the actual connectivity state. We can monitor
      the pcs_link_state bit in the Network Status register to determine
      whether the PCS link state is actually up.
      Signed-off-by: default avatarRobert Hancock <robert.hancock@calian.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8fab174b
    • David S. Miller's avatar
      Merge tag 'mlx5-updates-2021-03-12' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux · c232f81b
      David S. Miller authored
      Saeed Mahameed says:
      
      ====================
      mlx5-updates-2021-03-12
      
      1) TC support for ICMP parameters
      2) TC connection tracking with mirroring
      3) A round of trivial fixups and cleanups
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c232f81b
  2. 12 Mar, 2021 10 commits