- 12 Mar, 2016 40 commits
-
-
Dilek Uzulmez authored
Problem found using checkpatch.pl CHECK: Unnecessary parentheses around chip->ms_card Signed-off-by:
Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bhaktipriya Shridhar authored
Replace all instances of bit shifting on 1 with the BIT(x) macro. This was done using Coccinelle. @@ int c; @@ - (1 << c) + BIT(c) Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch removes unnecessary return variables in switch statements. This was done with Coccinelle: @@ local idexpression ret; expression e1,e2; identifier label; @@ switch ( ... ) { case label : ... - ret = e1; - break; + return e1; ... default: ... - ret = e2; + return e2; ... } ... when != ret - return ret; @@ type T; identifier x; @@ - T x; ... when != x Signed-off-by: -
Bhaktipriya Shridhar authored
This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: -
Bhaktipriya Shridhar authored
This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: -
Sandhya Bankar authored
Remove unnecessary goto. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(...); if ( ( + ! x - == NULL | + ! - NULL == x ) ) Z Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Unnecessary platform_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @@ struct platform_device *pdev; @@ - platform_set_drvdata(pdev, NULL); //</smpl> Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Bhumika Goyal authored
The function r8712_setptm_cmd and r8712_gettssi_cmd are not used anywhere in the kernel so remove them. Also, remove their function prototypes. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: -
Sandhya Bankar authored
Avoid multiple assignments.This isssue is found by checkpatch.pl script. Signed-off-by:
-
G Pooja Shamili authored
The unnecessary parantheses on the right side of assignments were removed, as in most cases (expect for ==, >=, <=, !=), they are futile. This was done using Coccinelle, the semantic patch being: @@ expression E1,E2,E3; binary operator bin_op = {==,>=,<=,!=}; @@ E1 = ( ( E2 bin_op E3 ) | -( E2 -) ) ; Signed-off-by:G Pooja Shamili <poojashamili@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
In this file, function names are otherwise used as pointers without &. The Coccinelle semantic patch that is used to make this change is as follows: // <smpl> @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f @M@ type T; identifier f; @@ T f(...); @@ identifier m.f; @@ - &f + f // </smpl> Signed-off-by: -
Bhaktipriya Shridhar authored
Change null comparisons of the form x == NULL to !x. This was done using Coccinelle. @@ expression e; @@ - e == NULL + !e Signed-off-by:
-
Bhaktipriya Shridhar authored
Delete unnecessary local variable whose value is always 0 and return 0 as the result. The following Coccinelle script was used: @@ identifier ret; expression E; type T; @@ ( - T ret; | - T ret = 0; ) ... when != \(ret=E \|ret--\|ret++\|--ret\|++ret\|ret-=E\|ret+=E\|ret|=E\|ret&=E\) ( ?-ret = 0; ) ... when != \(ret=E \|ret--\|ret++\|--ret\|++ret\|ret-=E\|ret+=E\|ret|=E\|ret&=E\) ( return - ret + 0 ; ) Signed-off-by:
-
Bhumika Goyal authored
Some functions like kmalloc/usb_alloc_urb/kmalloc_array returns NULL as their return value on failure. !x is generally preferred over x==NULL or NULL==x so make use of !x if the value returned on failure by these functions is NULL. Done using coccinelle: @@ expression e; statement S; @@ e = \(kmalloc\|devm_kzalloc\|kmalloc_array \|devm_ioremap\|usb_alloc_urb\|alloc_netdev\)(...); - if(e==NULL) + if(!e) S Signed-off-by: -
Bhaktipriya Shridhar authored
Removed parantheses on the right hand side of assignments as they are not needed. This was done with Coccinelle: @@ expression a, b; @@ a = - ( b - ) ; Signed-off-by:
-
Bhaktipriya Shridhar authored
Simplified the multiline check to a single return statement. Signed-off-by:
Daniel Baluta <daniel.baluta@intel.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove exceptional '&' operator in front of a function name. The Coccinelle semantic patch that is used to make this change is as follows: // <smpl> @r@ identifier f; @@ f(...) { ... } @@ identifier r.f; @@ - &f + f @M@ type T; identifier f; @@ T f(...); @@ identifier m.f; @@ - &f + f // </smpl> Signed-off-by: -
Bhaktipriya Shridhar authored
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by:
-
Bhaktipriya Shridhar authored
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Eva Rachel Retuya authored
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(...); if ( ( + ! x - == NULL | + ! - NULL == x ) ) Z Signed-off-by:
-
Dilek Uzulmez authored
Add space around operator '/'. Problem found using checkpatch.pl CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by:
-
Laura Garcia Liebana authored
Braces should be used on all arms of the if statement. Checkpatch detected this issue. Signed-off-by:
Laura Garcia Liebana <nevola@gmail.com> Signed-off-by:
-
Laura Garcia Liebana authored
Avoid the use of multiple blank lines. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
The lines should be adjusted to 80 characters. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Blank lines are not necessary after an open brace. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Remove commented source code. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Comparison to NULL should be avoided in conditions. Chackpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Blank line is inserted after a struct declaration. Checkpatch detected these issues. Signed-off-by:
-
Laura Garcia Liebana authored
Logical continuations should be on the previous line. Checkpatch detected this issue. Signed-off-by:
-
Bhaktipriya Shridhar authored
With conccurency managed workqueues, use of dedicated workqueues can be replaced by system_wq. Drop cvm_oct_poll_queue by using system_wq. There are multiple work items per cvm_oct_poll_queue (viz. cvm_oct_rx_refill_work, port_periodic_work) and different cvm_oct_poll_queues need not be be ordered. Hence, concurrency can be increased by switching to system_wq. All work items are sync canceled in cvm_oct_remove() so it is guaranteed that no work is in flight by the time exit path runs. Signed-off-by:
Tejun Heo <tj@kernel.org> Signed-off-by:
-
Ben Marsh authored
This is a patch to slicoss.c to change the style of NULL comparisons in order to remove checkpatch.pl warnings. Signed-off-by:
Ben Marsh <bmarsh94@gmail.com> Signed-off-by:
-
Ben Marsh authored
This is a patch to slicoss.c to remove unnecessary blank lines as found by checkpatch.pl Signed-off-by:
-
Ben Marsh authored
This is a patch to slicoss.c to change the memory allocation style in slicoss.c as found by checkpatch.pl Signed-off-by:
-
Ben Marsh authored
This is a patch to slicoss.c to change the memory allocation style as identified by checkpatch.pl Signed-off-by:
-
Ben Marsh authored
This is a patch to slicoss.c that changes the memory allocation style as identified by checkpatch.pl Signed-off-by:
-
Ben Marsh authored
This is a patch to slicoss.c to change the memory allocation style as identified by checkpatch.pl Signed-off-by:
-
Janani Ravichandran authored
Remove commented out code to reduce code clutter. Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by:
-
