- 08 Jan, 2014 40 commits
-
-
Ralph Mueck authored
This corrects the position of (opening) braces in if-conditionals to make checkpatch shut up. Signed-off-by:
Ralph Mueck <linux-kernel@rmueck.de> Signed-off-by:
Matthias Oefelein <ma.oefelein@arcor.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Ralph Mueck authored
This patch adds spaces before the opening parentheses of if-conditionals to comply with offical code styling guidelines. Signed-off-by:
-
Ralph Mueck authored
This patch takes care of the following issues: - missing spaces at variable assignments - missing spaces between function arguments - spaces at the beginning of a line where tabs should be - prohibited spaces before a (semi)colon Signed-off-by:
-
Laura Abbott authored
Instead of manually checking the bounds of VMALLOC_START and VMALLOC_END, just use is_vmalloc_addr. That's what the function was designed for. Signed-off-by:
Laura Abbott <lauraa@codeaurora.org> Signed-off-by:
-
Ben Hutchings authored
There seems to be no reason why it can't be a module; in fact that is currently supposed to be the default. Signed-off-by:
Ben Hutchings <ben@decadent.org.uk> Signed-off-by:
-
Masanari Iida authored
This patch fixed "WARNING: braces {} are not necessary for single statement blocks" found by checkpatch.pl in kernel_user_comm.c Signed-off-by:Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Masanari Iida authored
This patch fixed "ERROR: do not use C99 // comments" found by checkpatch.pl in lcommon_cl.c Signed-off-by:
-
Masanari Iida authored
This patch fixed "WARNING: space prohibited between function name and open parenthesis '(' found by checkpatch.pl, in lustre/lclient/lcommon_cl.c Signed-off-by: -
Masanari Iida authored
This patch fixed "ERROR: do not use C99 // comments" found by checkpatch.pl in lustre/lustre/mgc_request.c Signed-off-by:
-
Masanari Iida authored
This patch fixed "WARNING: braces {} are not necessary for single statement blocks" in lustre/lustre/mgc_request.c Signed-off-by: -
Masanari Iida authored
This patch fixed "ERROR: space required before the open parenthesis'('" found by checkpatch.pl in lustre/lustre/mgc/mgc_request.c Signed-off-by: -
Rashika Kheria authored
Include appropriate header file dgnc/dgnc_trace.h in dgnc_trace.c because function dgnc_tracer_free() has its prototype declaration in the header file. This eliminates the following warning in dgnc_trace.c: drivers/staging/dgnc/dgnc_trace.c:180:6: warning: no previous prototype for ‘dgnc_tracer_free’ [-Wmissing-prototypes] Signed-off-by:
Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by:
-
Rashika Kheria authored
Remove unused function PropagateCalParamsFromEEPROMToMemory() in nvm.c. This eliminates the following warning in nvm.c: drivers/staging/bcm/nvm.c:1369:5: warning: no previous prototype for ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes] Signed-off-by:
-
Rashika Kheria authored
Mark functions MatchSrcIpAddress(), MatchDestIpAddress() and MatchTos() as static in Qos.c because they are not used outside this file. This eliminates the following warnings in Qos.c: drivers/staging/bcm/Qos.c:27:6: warning: no previous prototype for ‘MatchSrcIpAddress’ [-Wmissing-prototypes] drivers/staging/bcm/Qos.c:61:6: warning: no previous prototype for ‘MatchDestIpAddress’ [-Wmissing-prototypes] drivers/staging/bcm/Qos.c:94:6: warning: no previous prototype for ‘MatchTos’ [-Wmissing-prototypes] Signed-off-by:
Josh Triplett <josh@joshtriplett.org> Signed-off-by:
-
Rashika Kheria authored
Mark functions t3e3_set_loopback(), t3e3_reg_read(), t3e3_reg_write(), t3e3_port_get(), t3e3_port_set(), t3e3_port_get_stats() and t3e3_port_del_stats() as static in ctrl.c because they are not used outside this file. This eliminates the following warnings in ctrl.c: drivers/staging/sbe-2t3e3/ctrl.c:34:6: warning: no previous prototype for ‘t3e3_set_loopback’ [-Wmissing-prototypes] drivers/staging/sbe-2t3e3/ctrl.c:98:6: warning: no previous prototype for ‘t3e3_reg_read’ [-Wmissing-prototypes] drivers/staging/sbe-2t3e3/ctrl.c:135:6: warning: no previous prototype for ‘t3e3_reg_write’ [-Wmissing-prototypes] drivers/staging/sbe-2t3e3/ctrl.c:167:6: warning: no previous prototype for ‘t3e3_port_get’ [-Wmissing-prototypes] drivers/staging/sbe-2t3e3/ctrl.c:172:6: warning: no previous prototype for ‘t3e3_port_set’ [-Wmissing-prototypes] drivers/staging/sbe-2t3e3/ctrl.c:219:6: warning: no previous prototype for ‘t3e3_port_get_stats’ [-Wmissing-prototypes] drivers/staging/sbe-2t3e3/ctrl.c:285:6: warning: no previous prototype for ‘t3e3_port_del_stats’ [-Wmissing-prototypes] Signed-off-by:
-
Rashika Kheria authored
Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not used outside this file. This eliminates the following warning in sm7xxfb.c: drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes] Signed-off-by:
Javier M. Mellid <jmunhoz@igalia.com> Signed-off-by:
-
Rashika Kheria authored
Include appropriate header file in dgap/dgap_parse.h in dgap_parse.c because functions dgap_parsefile(), dgap_config_get_useintr(), dgap_config_get_altpin(), dgap_find_config(), dgap_config_get_number_of_ports(), dgap_create_config_string() and dgap_get_config_letters() have their prototype declarations in the header file. This eliminates the following warnings in dgap_parse.c: drivers/staging/dgap/dgap_parse.c:125:5: warning: no previous prototype for ‘dgap_parsefile’ [-Wmissing-prototypes] drivers/staging/dgap/dgap_parse.c:1101:6: warning: no previous prototype for ‘dgap_config_get_useintr’ [-Wmissing-prototypes] drivers/staging/dgap/dgap_parse.c:1128:6: warning: no previous prototype for ‘dgap_config_get_altpin’ [-Wmissing-prototypes] drivers/staging/dgap/dgap_parse.c:1157:15: warning: no previous prototype for ‘dgap_find_config’ [-Wmissing-prototypes] drivers/staging/dgap/dgap_parse.c:1223:6: warning: no previous prototype for ‘dgap_config_get_number_of_ports’ [-Wmissing-prototypes] drivers/staging/dgap/dgap_parse.c:1252:7: warning: no previous prototype for ‘dgap_create_config_string’ [-Wmissing-prototypes] drivers/staging/dgap/dgap_parse.c:1311:7: warning: no previous prototype for ‘dgap_get_config_letters’ [-Wmissing-prototypes] Signed-off-by:
-
Rashika Kheria authored
Include appropriate header file dgap/dgap_trace.h in dgap_trace.c because function dgap_tracer_free() have its prototype declaration in the header file. This eliminates the following warning in dgap_trace.c: drivers/staging/dgap/dgap_trace.c:181:6: warning: no previous prototype for ‘dgap_tracer_free’ [-Wmissing-prototypes] Signed-off-by:
-
Liu Ying authored
This patch declares the function of_get_tve_mode as a static one to fix this sparse warning: drivers/staging/imx-drm/imx-tve.c:563:11: warning: \ symbol 'of_get_tve_mode' was not declared. \ Should it be static? Acked-by:
Shawn Guo <shawn.guo@linaro.org> Signed-off-by:
Liu Ying <Ying.Liu@freescale.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Merge tag 'iio-for-3.14c' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next Jonathan writes: Third round of new drivers, features and cleanups for IIO in the 3.14 cycle. One new driver a spot of new functionality and a cleanup. * New driver for the Capella CM32181 ambient light sensor. This is the first driver directly from Kevin at Capella with more already in the pipeline. * Support for configurable predividers on the mxs lradc * Convert a field to a bitmap in mxs lradc instead of using an array of unsigned longs to store boolean values.
-
Martin Hofmann authored
This patch fixes the usage of printk in wpactl.c concering one missing log level occurence and some whitespaces before a newline. Signed-off-by:
Martin Hofmann <martin.hofmann@studium.uni-erlangen.de> Signed-off-by:
Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de> Signed-off-by:
-
Martin Hofmann authored
wpactl.h contained some typedefs for enums. These were removed in this patch. Also, a typedef for a type "unsigned long long" that was only instantiated in one place was removed and its declaration altered. Signed-off-by:
-
Martin Hofmann authored
This patch fixes indentation style belonging to function calls as well as some run-away closing parentheses when calling functions. Signed-off-by:
-
Martin Hofmann authored
This patch removes some unnecessary braces concerning if-statements in the file wroute.c Signed-off-by:
-
Martin Hofmann authored
The file wroute.c contained some silly casts. This patch removes them. Signed-off-by:
-
Martin Hofmann authored
The file 80211hdr.h contained the macro WLAN_GET_FC_PRVER(n). The big endian fashion of this macro had unbalanced parentheses. This patch removes the parentheses in question. Signed-off-by:
-
Dan Carpenter authored
We dereference "param->u.wpa_key.key" on the next line so the check here is inconsistent. This is only called from iwctl_siwencodeext() and "param->u.wpa_key.key" is a valid pointer. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
key_len == MAX_KEY_LEN is valid but we return an error. Introduced-by: 6b7200fe ('Staging: vt6655: memory corruption in check in wpa_set_wpadev()') Signed-off-by:
-
Malcolm Priestley authored
uBeaconInterval becomes u32 get next TBTT value using vendor's equation as shown. This patch was checked against the original code and yields exactly the same value. Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
value uLowNextTBTT yields wrong value. ULL is needed with qwTSF Signed-off-by:
-
Simon Schuster authored
Long lines are split into multiple ones to reduce the line length. Additionally some alignment fixes are made that previous patches missed. Unfortunately, due to the high indentation levels present in parts of bssdb.c, this patch leaves some lines which are longer than 80 characters. Signed-off-by:
Sebastian Rachuj <sebastian.rachuj@studium.uni-erlangen.de> Signed-off-by:
Simon Schuster <linux@rationality.eu> Signed-off-by:
-
Sebastian Rachuj authored
Explicit comparisons of pointers agains NULL (like if (p != NULL) ...) are not as readable as the implicit comparison (like if (p) ...). This patch converts all these explicit comparisons to implicit ones. Signed-off-by:
-
Sebastian Rachuj authored
Removes unrequired parentheses around comparisons in complex conditions. Signed-off-by:
-
Simon Schuster authored
This patch reduces the level of indentation in bssdb.c of the vt6656 driver by transforming nested conditions to a series of logical conjunctions. E.g. if (cond1) { if (cond2) { block(); } } is transformed to if (cond1 && cond2) { block(); } Signed-off-by: -
Simon Schuster authored
Conforming to the linux coding style guidelines, a single line block of an if statement does not require curly braces unless another block of the if cascade requires them. Therefore unnecessary curly braces are removed by this patch and missing ones are added. Signed-off-by:
-
Simon Schuster authored
This patch combines single ifs within the block of an else to a single else if statement. Therefore code that looks like that else { if (cond) { statements; } else { other_statements; } } is converted to code that looks like that else if (cond) { statements; } else { other_statements; } Signed-off-by: -
Simon Schuster authored
A space in a format string is unnecessary if it is followed by a line feed. These spaces are removed by this patch. Signed-off-by:
-
Simon Schuster authored
An else belongs in the same line as the closing curly brace of the previous block. Hence, this patch removes line feeds separating a curly brace from the corresponding else. Signed-off-by:
-
Simon Schuster authored
Adds missing spaces between an if-statement and its condition as well as between the condition and the following curly brace. At casts there is also a space added between the type and the variable. Spaces that either follow an opening parenthese or the sizeof operator or that preceed semicolons are removed as well. Signed-off-by:
-
Simon Schuster authored
Adds spaces around operators (like &&, ||, !=, +, ...) and removes spaces before postfix increment and decrement operators. Parentheses around return values are removed, too. Signed-off-by:
-
