1. 19 Jan, 2022 3 commits
    • Rob Herring's avatar
      dt-bindings: rtc: st,stm32-rtc: Make each example a separate entry · d9dfab09
      Rob Herring authored
      Each independent example should be a separate entry. This allows for
      'interrupts' to have different cell sizes.
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://lore.kernel.org/r/20220106182518.1435497-7-robh@kernel.org
      d9dfab09
    • Rob Herring's avatar
      dt-bindings: mmc: arm,pl18x: Make each example a separate entry · 59449e5d
      Rob Herring authored
      Each independent example should be a separate entry. This and dropping
      'interrupt-parent' allows for 'interrupts' to have different cell sizes.
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Link: https://lore.kernel.org/r/20220106182518.1435497-6-robh@kernel.org
      59449e5d
    • Rob Herring's avatar
      dt-bindings: display: Add SPI peripheral schema to SPI based displays · c476d430
      Rob Herring authored
      With 'unevaluatedProperties' support enabled, several SPI based display
      binding examples have warnings:
      
      Documentation/devicetree/bindings/display/panel/samsung,ld9040.example.dt.yaml: lcd@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
      Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.example.dt.yaml: panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 'spi-3wire' were unexpected)
      Documentation/devicetree/bindings/display/panel/ilitek,ili9322.example.dt.yaml: display@0: Unevaluated properties are not allowed ('reg' was unexpected)
      Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.example.dt.yaml: display@0: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
      Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml: panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
      Documentation/devicetree/bindings/display/panel/sony,acx565akm.example.dt.yaml: panel@2: Unevaluated properties are not allowed ('spi-max-frequency', 'reg' were unexpected)
      Documentation/devicetree/bindings/display/panel/tpo,td.example.dt.yaml: panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
      Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.example.dt.yaml: panel@0: Unevaluated properties are not allowed ('reg', 'spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
      Documentation/devicetree/bindings/display/panel/innolux,ej030na.example.dt.yaml: panel@0: Unevaluated properties are not allowed ('spi-max-frequency' was unexpected)
      Documentation/devicetree/bindings/display/panel/sitronix,st7789v.example.dt.yaml: panel@0: Unevaluated properties are not allowed ('spi-max-frequency', 'spi-cpol', 'spi-cpha' were unexpected)
      
      Fix all of these by adding a reference to spi-peripheral-props.yaml.
      With this, the description that the binding must follow
      spi-controller.yaml is both a bit out of date and redundant, so remove
      it.
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
      Acked-by: default avatarPaul Cercueil <paul@crapouillou.net>
      Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
      Link: https://lore.kernel.org/r/20211221125209.1195932-1-robh@kernel.org
      c476d430
  2. 17 Jan, 2022 9 commits
  3. 12 Jan, 2022 2 commits
  4. 11 Jan, 2022 19 commits
  5. 10 Jan, 2022 4 commits
    • Rob Herring's avatar
      dt-bindings: net: Add missing properties used in examples · 8650381f
      Rob Herring authored
      With 'unevaluatedProperties' support implemented, the following warnings
      are generated in the net bindings:
      
      Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: ethernet@19000000: Unevaluated properties are not allowed ('qca,ethcfg' was unexpected)
      Documentation/devicetree/bindings/net/stm32-dwmac.example.dt.yaml: ethernet@40028000: Unevaluated properties are not allowed ('reg-names', 'snps,pbl' were unexpected)
      Documentation/devicetree/bindings/net/ti,cpsw-switch.example.dt.yaml: mdio@1000: Unevaluated properties are not allowed ('clocks', 'clock-names' were unexpected)
      Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.example.dt.yaml: mdio@f00: Unevaluated properties are not allowed ('clocks', 'clock-names' were unexpected)
      
      Add the missing properties/nodes as necessary.
      
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: "Andreas Färber" <afaerber@suse.de>
      Cc: Manivannan Sadhasivam <mani@kernel.org>
      Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
      Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
      Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
      Cc: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
      Cc: "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>
      Cc: Oleksij Rempel <o.rempel@pengutronix.de>
      Cc: Christophe Roullier <christophe.roullier@foss.st.com>
      Cc: Grygorii Strashko <grygorii.strashko@ti.com>
      Cc: netdev@vger.kernel.org
      Cc: linux-arm-kernel@lists.infradead.org
      Cc: linux-actions@lists.infradead.org
      Cc: linux-stm32@st-md-mailman.stormreply.com
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://lore.kernel.org/r/20211206174153.2296977-1-robh@kernel.org
      8650381f
    • Rob Herring's avatar
      dt-bindings: net: snps,dwmac: Enable burst length properties for more compatibles · 1d01efaf
      Rob Herring authored
      With 'unevaluatedProperties' support implemented, the properties
      'snps,pbl', 'snps,txpbl', and 'snps,rxpbl' are not allowed in the
      examples for some of the DWMAC versions:
      
      Documentation/devicetree/bindings/net/intel,dwmac-plat.example.dt.yaml: ethernet@3a000000: Unevaluated properties are not allowed ('snps,pbl', 'mdio0' were unexpected)
      Documentation/devicetree/bindings/net/stm32-dwmac.example.dt.yaml: ethernet@5800a000: Unevaluated properties are not allowed ('reg-names', 'snps,pbl' were unexpected)
      Documentation/devicetree/bindings/net/stm32-dwmac.example.dt.yaml: ethernet@40028000: Unevaluated properties are not allowed ('reg-names', 'snps,pbl' were unexpected)
      Documentation/devicetree/bindings/net/stm32-dwmac.example.dt.yaml: ethernet@40027000: Unevaluated properties are not allowed ('reg-names', 'snps,pbl' were unexpected)
      Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.example.dt.yaml: ethernet@28000000: Unevaluated properties are not allowed ('snps,txpbl', 'snps,rxpbl', 'mdio0' were unexpected)
      
      This appears to be an oversight, so fix it by allowing the properties
      on the v3.50a, v4.10a, and v4.20a versions of the DWMAC.
      
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
      Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
      Cc: Jose Abreu <joabreu@synopsys.com>
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
      Link: https://lore.kernel.org/r/20211206174147.2296770-1-robh@kernel.org
      1d01efaf
    • Rob Herring's avatar
      dt-bindings: net: mdio: Allow any child node name · ad31ce56
      Rob Herring authored
      An MDIO bus can have devices other than ethernet PHYs on it, so it
      should allow for any node name rather than just 'ethernet-phy'.
      
      Cc: Andrew Lunn <andrew@lunn.ch>
      Cc: Heiner Kallweit <hkallweit1@gmail.com>
      Cc: Russell King <linux@armlinux.org.uk>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jakub Kicinski <kuba@kernel.org>
      Cc: Florian Fainelli <f.fainelli@gmail.com>
      Cc: netdev@vger.kernel.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Reviewed-by: default avatarThierry Reding <treding@nvidia.com>
      Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Link: https://lore.kernel.org/r/20211206174139.2296497-1-robh@kernel.org
      ad31ce56
    • Qin Jian's avatar
  6. 08 Jan, 2022 3 commits
    • Stephen Boyd's avatar
      of/fdt: Don't worry about non-memory region overlap for no-map · da17d690
      Stephen Boyd authored
      In commit 8a5a75e5 ("of/fdt: Make sure no-map does not remove
      already reserved regions") we returned -EBUSY when trying to mark
      regions as no-map when they intersect with reserved memory. The goal was
      to find bad no-map reserved memory DT nodes that would unmap the kernel
      text/data sections.
      
      The problem is the reserved memory check will still trigger if the DT
      has a /memreserve/ that completely subsumes the no-map memory carveouts
      in the reserved memory node _and_ that region is also not part of the
      memory reg property. For example in sc7180.dtsi we have the following
      reserved-memory and memory node:
      
            memory@80000000 {
                /* We expect the bootloader to fill in the size */
                reg = <0 0x80000000 0 0>;
            };
      
            smem_mem: memory@80900000 {
                    reg = <0x0 0x80900000 0x0 0x200000>;
                    no-map;
            };
      
      and the memreserve filled in by the bootloader is
      
            /memreserve/ 0x80800000 0x400000;
      
      while the /memory node is transformed into
      
            memory@80000000 {
                /* The bootloader fills in the size, and adds another region */
                reg = <0 0x80000000 0 0x00800000>,
                      <0 0x80c00000 0 0x7f200000>;
            };
      
      The smem region is doubly reserved via /memreserve/ and by not being
      part of the /memory reg property. This leads to the following warning
      printed at boot.
      
       OF: fdt: Reserved memory: failed to reserve memory for node 'memory@80900000': base 0x0000000080900000, size 2 MiB
      
      Otherwise nothing really goes wrong because the smem region is not going
      to be mapped by the kernel's direct linear mapping given that it isn't
      part of the memory node. Therefore, let's only consider this to be a
      problem if we're trying to mark a region as no-map and it is actually
      memory that we're intending to keep out of the kernel's direct mapping
      but it's already been reserved.
      Acked-by: default avatarMike Rapoport <rppt@kernel.org>
      Cc: Douglas Anderson <dianders@chromium.org>
      Cc: Nicolas Boichat <drinkcat@chromium.org>
      Cc: Quentin Perret <qperret@google.com>
      Cc: Jan Kiszka <jan.kiszka@siemens.com>
      Fixes: 8a5a75e5 ("of/fdt: Make sure no-map does not remove already reserved regions")
      Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://lore.kernel.org/r/20220107194233.2793146-1-swboyd@chromium.org
      da17d690
    • Yang Li's avatar
      of: unittest: remove unneeded semicolon · 2b35e968
      Yang Li authored
      Eliminate the following coccicheck warning:
      ./drivers/of/unittest.c:1961:2-3: Unneeded semicolon
      Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
      Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://lore.kernel.org/r/20220107002826.77939-1-yang.lee@linux.alibaba.com
      2b35e968
    • Baruch Siach's avatar
      of: base: Improve argument length mismatch error · 5d05b811
      Baruch Siach authored
      The cells_name field of of_phandle_iterator might be NULL. Use the
      phandle name instead. With this change instead of:
      
        OF: /soc/pinctrl@1000000: (null) = 3 found 2
      
      We get:
      
        OF: /soc/pinctrl@1000000: phandle pinctrl@1000000 needs 3, found 2
      
      Which is a more helpful messages making DT debugging easier.
      
      In this particular example the phandle name looks like duplicate of the
      same node name. But note that the first node is the parent node
      (it->parent), while the second is the phandle target (it->node). They
      happen to be the same in the case that triggered this improvement. See
      commit 72cb4c48 ("arm64: dts: qcom: ipq6018: Fix gpio-ranges
      property").
      Signed-off-by: default avatarBaruch Siach <baruch@tkos.co.il>
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Link: https://lore.kernel.org/r/f6a68e0088a552ea9dfd4d8e3b5b586d92594738.1640881913.git.baruch@tkos.co.il
      5d05b811