- 17 Sep, 2013 40 commits
-
-
Larry Finger authored
Smatch reports the following warning: CHECK drivers/staging/rtl8188eu/os_dep/usb_intf.c drivers/staging/rtl8188eu/os_dep/usb_intf.c:740 rtw_usb_if1_init() info: redundant null check on padapter->HalData calling kfree() Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Larry Finger authored
Smatch reports the following warning: "drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8328 mlme_evt_hdl() error: buffer overflow 'wlanevents' 24 <= 24" 8321 /* checking if event code is valid */ 8322 if (evt_code >= MAX_C2HEVT) { ^^^^^^^^^^^^^^^^^^^^^^ 8323 RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\nEvent Code(%d) mismatch!\n", evt_code)); 8324 goto _abort_event_; 8325 } 8326 8327 /* checking if event size match the event parm size */ 8328 if ((wlanevents[evt_code].parmsize != 0) && ^^^^^^^^^^^^^^^^^^^^ 8329 (wlanevents[evt_code].parmsize != evt_sz)) { 8330 RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, 8331 ("\nEvent(%d) Parm Size mismatch (%d vs %d)!\n", 8332 evt_code, wlanevents[evt_code].parmsize, evt_sz)); 8333 goto _abort_event_; 8334 } This warning results because the number of items in "enum rtw_c2h_event", which determines the value of MAX_C2HEVT, is one more than in "struct wlanevents". Adding an extra dummy event to the latter fixes the problem. Reported-by:Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Larry Finger authored
Smatch reports the following warning: "drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c:2008 Hal_ReadPowerValueFromPROM_8188E() error: buffer overflow 'pwrInfo24G->IndexBW40_Base[rfPath]' 5 <= 5" drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c 2005 /* 2.4G default value */ 2006 for (group = 0; group < MAX_CHNL_GROUP_24G; group++) { 2007 pwrInfo24G->IndexCCK_Base[rfPath][group] = EEPROM_DEFAULT_24G_INDEX; 2008 pwrInfo24G->IndexBW40_Base[rfPath][group] = EEPROM_DEFAULT_24G_INDEX; The reason is that IndexCCK_Base[] has MAX_CHNL_GROUP_24G elements, but IndexBW40_Base is smaller by 1. Make them both have MAX_CHNL_GROUP_24G elements. Reported by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: -
Joe Perches authored
compare_ether_addr is being removed so remove even the commented out code referring to it. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Joe Perches authored
Preliminary to removing compare_ether_addr altogether: Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Additionally: Used is_zero_ether_addr, removed now unused variable Converted uses of &foo[0] to foo Done via cocci script: (and a little typing) $ cat compare_ether_addr.cocci @@ expression a,b; @@ - !compare_ether_addr(a, b) + ether_addr_equal(a, b) @@ expression a,b; @@ - compare_ether_addr(a, b) + !ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) == 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) != 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) == 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) != 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !!ether_addr_equal(a, b) + ether_addr_equal(a, b) Signed-off-by:
-
Avinash Kumar authored
replaced printk functions used for debug messages by respective netdev_warn netdev_err functions. Signed-off-by:
Avinash Kumar <avi.kp.137@gmail.com> Signed-off-by:
-
Avinash Kumar authored
replaced the printk debug lines with respective netdev_warn()/netdev_err() Signed-off-by:
-
Jon Bernard authored
This is a patch to fwserial.c that wraps a line which previously exceeded the 80 character limit warning found by checkpatch.pl. This driver is now warning and error free, according to checkpatch.pl Signed-off-by:
Jon Bernard <jbernard@tuxion.com> Reviewed-by:
Peter Hurley <peter@hurleysoftware.com> Signed-off-by:
-
Aldo Iljazi authored
Fixed space prohibition before semicolon, particularly: nvm.c:106: WARNING: space prohibited before semicolon nvm.c:1098: WARNING: space prohibited before semicolon nvm.c:1279: WARNING: space prohibited before semicolon nvm.c:2834: WARNING: space prohibited before semicolon nvm.c:3361: WARNING: space prohibited before semicolon nvm.c:4453: WARNING: space prohibited before semicolon Signed-off-by:
Aldo Iljazi <neonsync1@gmail.com> Signed-off-by:
-
Faris de Haan authored
Fixed a few of the coding style issues reported by checkpatch.pl Signed-off-by:
Faris de Haan <farisdehaan@gmail.com> Acked-by:
-
Jingoo Han authored
Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language. Signed-off-by:
Jingoo Han <jg1.han@samsung.com> Signed-off-by:
-
Faris de Haan authored
Fixed some of the coding style issues reported by checkpatch.pl Signed-off-by:
-
Avinash Kumar authored
fixed styling issue in pointer typecast. Signed-off-by:
-
Mark Einon authored
Adding some trivial formatting suggestions made by Dan Carpenter to the TODO. Signed-off-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Mark Einon authored
Remove braces from a few single line if statements. Signed-off-by:
-
Mark Einon authored
The rcv_pend_lock spinlock isn't used anymore. remove it. Signed-off-by:
-
Mark Einon authored
phy_lock is no longer used in any useful code, it's all been moved into a phy_device. Remove the lock definition and init. Signed-off-by:
-
Lidza Louina authored
This patch removes parentheses around return statements. They aren't needed. Signed-off-by:
Lidza Louina <lidza.louina@gmail.com> Signed-off-by:
-
Lidza Louina authored
This patch renames the struct board_t to dgnc_board. board_t wasn't a good name for it since the _t suffix is for typedefs. Signed-off-by:
-
Jingoo Han authored
Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language. Signed-off-by:
-
Sachin Kamat authored
Code should be for the kernel version it is merged in. Version check is not necessary. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
-
Sachin Kamat authored
Code should be for the kernel version it is merged in. Version check is not necessary. Signed-off-by:
-
H Hartley Sweeten authored
Change the MODULE_DESCRIPTION to something useful instead of the generic "Comedi low-level driver". Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
H Hartley Sweeten authored
Use the dev->read_subdev to get the comedi_subdevice instead of accessing the dev->subdevices array directly. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetic reasons, rename this function. Signed-off-by:
-
H Hartley Sweeten authored
For aesthetic reasons, reorder the #include list. Signed-off-by:
-
H Hartley Sweeten authored
Tidy up the multi-line comments to follow the CodingStyle. Signed-off-by:
-
H Hartley Sweeten authored
Add some whitespace to tidy up the subdevice init. Signed-off-by:
-
H Hartley Sweeten authored
Interrupt support in this driver is optional. Don't fail the attach of the board if the request_irq() fails. Only allocate and setup the subdevice for the interrupt if the request_irq() was successful. Signed-off-by:
-
H Hartley Sweeten authored
The enabled state of the interrupt can be checked by reading the control register. Remove 'enabled_irq' from the private data. Since the private data is now empty, remove it completely and remove the allocation of it in parport_attach(). Signed-off-by:
-
H Hartley Sweeten authored
The control register for the parallel port is readable so there is no need to cache the current value in the private data. Signed-off-by:
-
H Hartley Sweeten authored
Rename this function to better describe it's use. Use comedi_dio_update_state() to handle the boilerplate code to update the subdevice s->state. Signed-off-by:
-
H Hartley Sweeten authored
Rename this function to better describe it's use. Tidy it up to follow the normal comedi (*insn_bits) for DI subdevices. Signed-off-by:
-
H Hartley Sweeten authored
This is the (*insn_config) function for a DIO subdevice. It should be using the data[0] value as the "instruction" to perform on the subdevice. Use the comedi_dio_insn_config() helper to properly handle instructions. Also, rename the function to better describe it's use. Signed-off-by:
-
H Hartley Sweeten authored
Rename this function to better describe it's use. Use comedi_dio_update_state() to handle the boilerplate code to update the subdevice s->state. Signed-off-by:
-
H Hartley Sweeten authored
Use the subdevice s->state to hold the current state of the data register outputs instead of carrying it in the private data. Signed-off-by:
-
H Hartley Sweeten authored
Rename the register map defines to better describe the hardware. Add defines for the control register bits that enable the irq and change the direction of the data register. This gets rid of the "magic" numbers. Remove PARPORT_SIZE, it's only used when requesting the i/o region with comedi_request_region(). Signed-off-by:
-
H Hartley Sweeten authored
The extra mask used to only update the channels configured as outputs is not necessary in this driver. Remove it and use comedi_dio_update_state() to handle the boilerplate code to update the subdevice s->state. Signed-off-by:
-
H Hartley Sweeten authored
The extra mask used to only update the channels configured as outputs is not necessary in this driver. Remove it and use comedi_dio_update_state() to handle the boilerplate code to update the subdevice s->state. Signed-off-by:
-
H Hartley Sweeten authored
The extra mask used to only update the channels configured as outputs is not necessary in this driver. Remove it and use comedi_dio_update_state() to handle the boilerplate code to update the subdevice s->state. Signed-off-by:
-
