1. 01 Aug, 2009 1 commit
  2. 28 Jul, 2009 1 commit
    • David Rientjes's avatar
      slub: use size and objsize orders to disable debug flags · 3de47213
      David Rientjes authored
      This patch moves the masking of debugging flags which increase a cache's
      min order due to metadata when `slub_debug=O' is used from
      kmem_cache_flags() to kmem_cache_open().
      
      Instead of defining the maximum metadata size increase in a preprocessor
      macro, this approach uses the cache's ->size and ->objsize members to
      determine if the min order increased due to debugging options.  If so,
      the flags specified in the more appropriately named DEBUG_METADATA_FLAGS
      are masked off.
      
      This approach was suggested by Christoph Lameter
      <cl@linux-foundation.org>.
      
      Cc: Christoph Lameter <cl@linux-foundation.org>
      Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
      Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
      3de47213
  3. 10 Jul, 2009 8 commits
    • David Rientjes's avatar
      slub: add option to disable higher order debugging slabs · fa5ec8a1
      David Rientjes authored
      When debugging is enabled, slub requires that additional metadata be
      stored in slabs for certain options: SLAB_RED_ZONE, SLAB_POISON, and
      SLAB_STORE_USER.
      
      Consequently, it may require that the minimum possible slab order needed
      to allocate a single object be greater when using these options.  The
      most notable example is for objects that are PAGE_SIZE bytes in size.
      
      Higher minimum slab orders may cause page allocation failures when oom or
      under heavy fragmentation.
      
      This patch adds a new slub_debug option, which disables debugging by
      default for caches that would have resulted in higher minimum orders:
      
      	slub_debug=O
      
      When this option is used on systems with 4K pages, kmalloc-4096, for
      example, will not have debugging enabled by default even if
      CONFIG_SLUB_DEBUG_ON is defined because it would have resulted in a
      order-1 minimum slab order.
      Reported-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Tested-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Cc: Christoph Lameter <cl@linux-foundation.org>
      Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
      Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
      fa5ec8a1
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6 · c2cc49a2
      Linus Torvalds authored
      * git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6:
        cifs: when ATTR_READONLY is set, only clear write bits on non-directories
        cifs: remove cifsInodeInfo->inUse counter
        cifs: convert cifs_get_inode_info and non-posix readdir to use cifs_iget
        [CIFS] update cifs version number
        cifs: add and use CIFSSMBUnixSetFileInfo for setattr calls
        cifs: make a separate function for filling out FILE_UNIX_BASIC_INFO
        cifs: rename CIFSSMBUnixSetInfo to CIFSSMBUnixSetPathInfo
        cifs: add pid of initiating process to spnego upcall info
        cifs: fix regression with O_EXCL creates and optimize away lookup
        cifs: add new cifs_iget function and convert unix codepath to use it
      c2cc49a2
    • Linus Torvalds's avatar
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6 · e864561c
      Linus Torvalds authored
      * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (29 commits)
        cxgb3: Fix crash caused by stashing wrong netdev_queue
        ixgbe: Fix coexistence of FCoE and Flow Director in 82599
        memory barrier: adding smp_mb__after_lock
        net: adding memory barrier to the poll and receive callbacks
        netpoll: Fix carrier detection for drivers that are using phylib
        includecheck fix: include/linux, rfkill.h
        p54: tx refused but queue active
        Atheros Kconfig needs to be dependent on WLAN_80211
        mac80211: fix docbook
        mac80211_hwsim: avoid NULL access
        ssb: Add support for 4318E
        b43: Add support for 4318E
        zd1211rw: adding SONY IFU-WLM2 (054c:0257) as a zd1211b device
        zd1211rw: 07b8:6001 is a ZD1211B
        r6040: bump driver version to 0.24 and date to 08 July 2009
        r6040: restore MIER register correctly when IRQ line is shared
        ipv4: Fix fib_trie rebalancing, part 4 (root thresholds)
        davinci_emac: fix kernel oops when changing MAC address while interface is down
        igb: set lan id prior to configuring phy
        mac80211: minstrel: avoid accessing negative indices in rix_to_ndx()
        ...
      e864561c
    • Dave Jones's avatar
      Fix compile error in bmac.c · 42359da4
      Dave Jones authored
      Looks like the change in ad361c98
      wasn't compile tested.
      Signed-off-by: default avatarDave Jones <davej@redhat.com>
      Acked-by: default avatarDavid S. Miller <davem@davemloft.net>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      42359da4
    • Roland Dreier's avatar
      cxgb3: Fix crash caused by stashing wrong netdev_queue · e594e96e
      Roland Dreier authored
      Commit c3a8c5b6 ("cxgb3: move away from LLTX") exposed a bug in how
      cxgb3 looks up the netdev_queue it stashes away in a qset during
      initialization.  For multiport devices, the TX queue index it uses is
      offset by the first_qset index of each port.  This leads to a crash
      once LLTX is removed, since hard_start_xmit is called with one TX
      queue lock held, while the TX reclaim timer task grabs a different
      (wrong) TX queue lock when it frees skbs.
      
      Fix this by removing the first_qset offset used to look up the TX
      queue passed into t3_sge_alloc_qset() from setup_sge_qsets().
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      Acked-by: default avatarDivy Le Ray <divy@chelsio.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e594e96e
    • Yi Zou's avatar
      ixgbe: Fix coexistence of FCoE and Flow Director in 82599 · 8faa2a78
      Yi Zou authored
      Fix coexistence of Fiber Channel over Ethernet (FCoE) and Flow Director (FDIR)
      in 82599 and remove the disabling of FDIR when FCoE is enabled.
      
      Currently, FDIR is turned off when FCoE is enabled under the assumption that
      FCoE is always enabled with DCB being turned on. However, FDIR does not have
      to be turned off all the time when FCoE is enabled since FCoE can be enabled
      without DCB being turned on, e.g., use link pause only. This patch makes sure
      that when DCB is turned on or off, FDIR is turned on or off correspondingly;
      and when FCoE is enabled, it does not disable FDIR, rather, it will have FDIR
      set up properly so FCoE and FDIR can coexist regardless of DCB being on or off.
      Signed-off-by: default avatarYi Zou <yi.zou@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      8faa2a78
    • Jiri Olsa's avatar
      memory barrier: adding smp_mb__after_lock · ad462769
      Jiri Olsa authored
      Adding smp_mb__after_lock define to be used as a smp_mb call after
      a lock.
      
      Making it nop for x86, since {read|write|spin}_lock() on x86 are
      full memory barriers.
      Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ad462769
    • Jiri Olsa's avatar
      net: adding memory barrier to the poll and receive callbacks · a57de0b4
      Jiri Olsa authored
      Adding memory barrier after the poll_wait function, paired with
      receive callbacks. Adding fuctions sock_poll_wait and sk_has_sleeper
      to wrap the memory barrier.
      
      Without the memory barrier, following race can happen.
      The race fires, when following code paths meet, and the tp->rcv_nxt
      and __add_wait_queue updates stay in CPU caches.
      
      CPU1                         CPU2
      
      sys_select                   receive packet
        ...                        ...
        __add_wait_queue           update tp->rcv_nxt
        ...                        ...
        tp->rcv_nxt check          sock_def_readable
        ...                        {
        schedule                      ...
                                      if (sk->sk_sleep && waitqueue_active(sk->sk_sleep))
                                              wake_up_interruptible(sk->sk_sleep)
                                      ...
                                   }
      
      If there was no cache the code would work ok, since the wait_queue and
      rcv_nxt are opposit to each other.
      
      Meaning that once tp->rcv_nxt is updated by CPU2, the CPU1 either already
      passed the tp->rcv_nxt check and sleeps, or will get the new value for
      tp->rcv_nxt and will return with new data mask.
      In both cases the process (CPU1) is being added to the wait queue, so the
      waitqueue_active (CPU2) call cannot miss and will wake up CPU1.
      
      The bad case is when the __add_wait_queue changes done by CPU1 stay in its
      cache, and so does the tp->rcv_nxt update on CPU2 side.  The CPU1 will then
      endup calling schedule and sleep forever if there are no more data on the
      socket.
      
      Calls to poll_wait in following modules were ommited:
      	net/bluetooth/af_bluetooth.c
      	net/irda/af_irda.c
      	net/irda/irnet/irnet_ppp.c
      	net/mac80211/rc80211_pid_debugfs.c
      	net/phonet/socket.c
      	net/rds/af_rds.c
      	net/rfkill/core.c
      	net/sunrpc/cache.c
      	net/sunrpc/rpc_pipe.c
      	net/tipc/socket.c
      Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
      Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a57de0b4
  4. 09 Jul, 2009 12 commits
  5. 08 Jul, 2009 18 commits