- 19 Nov, 2012 13 commits
-
-
Sachin Kamat authored
iwl-trans.h was included twice. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
Johannes Berg <johannes.berg@intel.com>
-
Emmanuel Grumbach authored
This will allow to reduce slightly the number of interrupts without sacrificing too much the latency in the Rx path. Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by:
-
Emmanuel Grumbach authored
It is not used outside pcie/rx.c. Signed-off-by:
-
Emmanuel Grumbach authored
Really trivial clean up. Signed-off-by:
-
Emmanuel Grumbach authored
Also, prefer the if(!X) notation over if(X == 0). Signed-off-by:
-
Johannes Berg authored
When software crypto is enabled, it isn't safe to enable MFP since the firmware interprets some management packets, and with MFP it would do so without proper validation. Reviewed-by:
Assaf Krauss <assaf.krauss@intel.com> Signed-off-by:
-
Emmanuel Grumbach authored
One one just a wrapper of the second, squash them. Signed-off-by:
-
Emmanuel Grumbach authored
Rename static functions. Function moved from trans.c to tx.c. A few could be made static, others had to be exported. Functions that implement the transport API are prefixed by iwl_trans_pcie_, the others by iwl_pcie_. Signed-off-by:
-
Emmanuel Grumbach authored
Functions that implement the transport API are prefixed by iwl_trans_pcie_, the others by iwl_pcie_. Signed-off-by:
-
Emmanuel Grumbach authored
Rename static functions. Function moved from trans.c to rx.c. A few could be made static, others had to be exported. Also, don't use rxb or rxbuf, but rb which stands for receive buffer. Signed-off-by:
-
Emmanuel Grumbach authored
This is its natural place Signed-off-by:
-
Emmanuel Grumbach authored
1) s/tx_queue/txq for the sake of consistency. 2) s/rx_queue/rxq for the sake of consistency. 3) Make all functions begin with iwl_pcie_ iwl_queue_init and iwl_queue_space are an exception since they are not PCIE specific although they are in pcie subdir. 4) s/trans_pcie_get_cmd_string/get_cmd_string it is much shorter and used in debug prints which are long lines. 5) s/iwl_bg_rx_replenish/iwl_pcie_rx_replenish_work this better emphasizes that it is a work 6) remove invalid kernelDOC markers pcie/tx.c and pcie/trans.c still needs to be cleaned up. Signed-off-by:
-
Emmanuel Grumbach authored
Signed-off-by:
-
- 14 Nov, 2012 2 commits
-
-
Emmanuel Grumbach authored
This is not needed, the comment there was wrong, it is only needed when MSI was *not* enabled. Signed-off-by:
-
Emmanuel Grumbach authored
The allocation failure will already be very verbose. Signed-off-by:
-
- 09 Nov, 2012 1 commit
-
-
Johannes Berg authored
When a firmware error occurs, don't just abort synchronous commands but also return an error (-EIO) and block any new commands as well. Currently, an error is only returned if WANT_SKB was set which is confusing and can lead to issues. Blocking is done until a new firmware image is loaded. Reviewed-by:
-
- 07 Nov, 2012 4 commits
-
-
Johannes Berg authored
The printk message should say RX, not TX. Reviewed-by:
-
Johannes Berg authored
There's no need to print the PCI resource length and base address, nor the hardware revision ID (which can be found in lspci) Reviewed-by:
-
Johannes Berg authored
There's no reason to print these all the time, the messages aren't all that interesting. Leave them as DEBUG_INFO though, just in case. Reviewed-by:
-
Johannes Berg authored
If the EEPROM reading was successful, don't print a message by default, the EEPROM version isn't all that interesting. Change the message to DEBUG_INFO priority so it can still be obtained. Reviewed-by:
-
- 05 Nov, 2012 6 commits
-
-
Emmanuel Grumbach authored
People tend not to set the fields they want to leave as 0. So make sure the struct is zeroed properly. Signed-off-by:
-
Emmanuel Grumbach authored
The ALIVE response of new fw inclues the base address of the SCD in SRAM. Until we read it from a prph register, which was set by the fw. Since the fw might well stop updating the prph register, add a WARN when there is an inconsitency between the ALIVE response and the register to catch any change in the behavior. Reviewed-by:
Gregory Greenman <gregory.greenman@intel.com> Reviewed-by:
-
Johannes Berg authored
Instead of open-coding it with a temporary list_head pointer, just use list_first_entry. Reviewed-by:
-
Johannes Berg authored
The flush_control parameter to iwlagn_txfifo_flush is passed as an internal value (context flags) and then sent to the device, that can't be right. Fix the confusion by removing the parameter, always use IWL_DROP_ALL that is redefined according to the firmware API in the flush control. Signed-off-by:
-
Johannes Berg authored
There's no reason to clear the CTL_AMPDU flag on transmitted frame status, it's not used by the driver here and mac80211 only uses it for some rate statistics. Also remove a stray space in the function. Reviewed-by:
-
Johannes Berg authored
The flush command really flushes queues, not FIFOs, and the first 32 bits indicate the queues to flush, not FIFOs. Change the command accordingly. Reviewed-by:
-
- 31 Oct, 2012 2 commits
-
-
Emmanuel Grumbach authored
When we unregister from mac80211 it will down the device anyway. Signed-off-by:
-
Emmanuel Grumbach authored
No HCMD can be sent while RFKILL is asserted. If a SYNC command is running while RFKILL is asserted the fw will silently discard it. This means that the driver needs to wake the process that sleeps on the CMD_SYNC. Since the RFKILL interrupt is handled in the transport layer and the code that sleeps in CMD_SYNC is also in the transport layer, all this logic can be handled there. This simplifies the work of the op_mode. So the transport layer will now return -ERFKILL when a CMD is sent and RFKILL is asserted. This will be the case even when the CMD is SYNC. The transport layer will return -ERFKILL straight away. Signed-off-by:
-
- 29 Oct, 2012 2 commits
-
-
Johannes Berg authored
Clarify the documentation to indicate that these flags can only be used at the end, i.e. after them a copy TFD (no flags set) is invalid. Reported-by:
Inbal Hacohen <inbal.hacohen@intel.com> Reviewed-by:
-
Johannes Berg authored
In addition to the NOCOPY flag, add a DUP flag that tells the transport to kmemdup() the buffer and free it after the command completes. Currently this is only supported for a single buffer in a given command, but that could be extended if it should be needed. Reviewed-by:
-
- 23 Oct, 2012 2 commits
-
-
Assaf Krauss authored
Remove the Kconfig option CONFIG_IWLWIFI_EXPERIMENTAL_MFP, if the firmware doesn't support MFP then the user shouldn't have the option to enable it as it won't work correctly. Signed-off-by:
-
Emmanuel Grumbach authored
Since the queue might not be empty, we need to free the pending Tx packets. Signed-off-by:
-
- 16 Oct, 2012 8 commits
-
-
Emmanuel Grumbach authored
This can happen when we shut down suddenly an interface. Signed-off-by:
-
Emmanuel Grumbach authored
Once in bus enumeration is enough, no need to print it again when the op_mode loads. Signed-off-by:
-
Emmanuel Grumbach authored
Doing the opposite is wrong, the SCD wouldn't like someone to clear its data while the queue is still active. Signed-off-by:
-
Emmanuel Grumbach authored
Instead of hardcoding the expression, use the macro provided in the previous patch. Signed-off-by:
-
Emmanuel Grumbach authored
When we disable a queue, we don't want the SCD to remember anything about this queue (what packet was transmitted but not acked, what packed was acked etc...). Wipe out all this data in its SRAM. Constify the arguments to iwl_write_targ_mem_dwords on the way. Signed-off-by:
-
Johannes Berg authored
Remove a number of variables that are assigned, but not used. Reviewed-by:
-
Johannes Berg authored
When tracing in iwlwifi, we get all data. Most of the time, we don't need it, and it just takes up a lot of extra space in the trace. Make this optional by recording the data into two separate trace events if it is needed. Without it, record only the content of non-data and EAPOL TX frames. As a result, tracing without the data tracepoints will record meta information including the 802.11 headers for all frames but will not record the contents of data frames to reduce trace overhead. Reviewed-by:
-
Johannes Berg authored
When warning about a command that is too large, print out the command name/ID to help figure out which place is attempting to send a command that is too large. Reviewed-by:
-
