1. 08 Jun, 2021 40 commits
    • David S. Miller's avatar
      Merge branch 'ena-updates' · e0eb625a
      David S. Miller authored
      Shay Agroskin says:
      
      ====================
      se build_skb and reorganize some code in ENA
      
      this patchset introduces several changes:
      
      - Use build_skb() on RX side.
        This allows to ensure that the headers are in the linear part
      
      - Batch some code into functions and remove some of the code to make it more
        readable and less error prone
      
      - Fix RST format and outdated description in ENA documentation
      
      - Improve cache alignment in the code
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e0eb625a
    • Shay Agroskin's avatar
      net: ena: re-organize code to improve readability · a01f2cd0
      Shay Agroskin authored
      Restructure some ethtool to a switch-case blocks to make it more uniform
      with other similar functions.
      Also restructure variable declaration to create reversed x-mas tree.
      Signed-off-by: default avatarArthur Kiyanovski <akiyano@amazon.com>
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a01f2cd0
    • Shay Agroskin's avatar
      net: ena: Use dev_alloc() in RX buffer allocation · 947c54c3
      Shay Agroskin authored
      Use dev_alloc() when allocating RX buffers instead of specifying the
      allocation flags explicitly. This result in same behaviour with less
      code.
      
      Also move the page allocation and its DMA mapping into a function. This
      creates a logical block, which may help understanding the code.
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      947c54c3
    • Shay Agroskin's avatar
      net: ena: aggregate doorbell common operations into a function · 9e8afb05
      Shay Agroskin authored
      The ena_ring_tx_doorbell() is introduced to call the doorbell and
      increase the driver's corresponding stat.
      Signed-off-by: default avatarIdo Segev <idose@amazon.com>
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9e8afb05
    • Shay Agroskin's avatar
      net: ena: fix RST format in ENA documentation file · 511c537b
      Shay Agroskin authored
      The documentation file used to be written in markdown format but was
      converted to reStructuredText (rst).
      
      The converted file doesn't keep up with rst format requirements which
      results in hard-to-read text.
      
      This patch fixes the formatting of the file. The patch also
      * Highlights and emphasizes some lines to improve readability
      * Rephrases some hard-to-understand text
      * Updates outdated function descriptions.
      * Removes TSO description which falsely claims the driver supports it
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      511c537b
    • Shay Agroskin's avatar
      net: ena: Remove module param and change message severity · 15efff76
      Shay Agroskin authored
      Remove the module param 'debug' which allows to specify the message
      level of the driver. This value can be specified using ethtool command.
      Also reduce the message level of LLQ support to be a warning since it is
      not an indication of an error.
      Signed-off-by: default avatarArthur Kiyanovski <akiyano@amazon.com>
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      15efff76
    • Shay Agroskin's avatar
      net: ena: add jiffies of last napi call to stats · 0ee251cd
      Shay Agroskin authored
      There are instances when we want to know when the last napi was
      called for debugging.
      
      On stuck / heavy loaded CPUs, the ena napi handler might not be
      called for a long period of time. This stat can help us to
      determine how much time passed since the last execution of napi.
      Signed-off-by: default avatarSameeh Jubran <sameehj@amazon.com>
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0ee251cd
    • Shay Agroskin's avatar
      net: ena: use build_skb() in RX path · 9e5269a9
      Shay Agroskin authored
      This patch converts the RX path to use build_skb() for packets larger
      than copybreak (set to 256 by default). This function makes the first
      descriptor's page to be the linear part of the sk_buff struct buffer.
      
      Also remove the SKB description from the README since most of it no
      longer relevant and the parts that are left don't add information.
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9e5269a9
    • Shay Agroskin's avatar
      net: ena: Improve error logging in driver · 091d0e85
      Shay Agroskin authored
      Add prints to improve logging of driver's errors.
      Signed-off-by: default avatarArthur Kiyanovski <akiyano@amazon.com>
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      091d0e85
    • Shay Agroskin's avatar
      net: ena: Remove unused code · 9912c72e
      Shay Agroskin authored
      The ENA_DEFAULT_MIN_RX_BUFF_ALLOC_SIZE macro,
      ena_xdp_queues_present() function and SUSPEND_RESUME enums aren't used
      in the driver, and so not needed.
      Signed-off-by: default avatarArthur Kiyanovski <akiyano@amazon.com>
      Signed-off-by: default avatarGal Pressman <galpress@amazon.com>
      Signed-off-by: default avatarSameeh Jubran <sameehj@amazon.com>
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9912c72e
    • Shay Agroskin's avatar
      net: ena: optimize data access in fast-path code · e4ac382e
      Shay Agroskin authored
      This tweaks several small places to improve the data access in fast
      path:
      
      * Remove duplicates of first_interrupt flag and surround it with
        WRITE/READ_ONCE macros:
      
        The flag is used to detect HW disorders in its
        interrupt communication with the driver. The flag is set when an
        interrupt is received and used in the health check function
        (ena_timer_service()) to help it find irregularities.
      
      * Reorder some fields in ena_napi struct to take better advantage of
        cache access pattern.
      
      * Move XDP TX queue number to a variable to save its calculation for
        every packet.
      
      * Use likely in a condition to improve branch prediction
      
      The 'first_interrupt' and 'interrupt_masked' flags were moved to reside
      in the same cache line as the first fields of 'napi' struct. This
      placement ensures that all memory accessed during upper-half handler
      reside in the same cacheline (napi_schedule_irqoff() only accesses
      'state' and 'poll_list' fields which are at the beginning of napi
      struct).
      Signed-off-by: default avatarSameeh Jubran <sameehj@amazon.com>
      Signed-off-by: default avatarShay Agroskin <shayagr@amazon.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e4ac382e
    • David S. Miller's avatar
      Merge branch 'mlxsw-various-updates' · fa6d61e9
      David S. Miller authored
      Ido Schimmel says:
      
      ====================
      mlxsw: Various updates
      
      This patchset contains various updates for mlxsw. The most significant
      change is the long overdue removal of the abort mechanism in the first
      two patches.
      
      Patches #1-#2 remove the route abort mechanism. This change is long
      overdue and explained in detail in the commit message.
      
      Patch #3 sets ports down in a few selftests that forgot to do so.
      Discovered using a BPF tool (WIP) that monitors ASIC resources.
      
      Patch #4 fixes an issue introduced by commit 557c4d2f ("selftests:
      devlink_lib: add check for devlink device existence").
      
      Patches #5-#8 modify the driver to read transceiver module's temperature
      thresholds using MTMP register (when supported) instead of directly from
      the module's EEPROM using MCIA register. This is both more reliable and
      more efficient as now the module's temperature and thresholds are read
      using one transaction instead of three.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fa6d61e9
    • Mykola Kostenok's avatar
      mlxsw: thermal: Read module temperature thresholds using MTMP register · 72a64c2f
      Mykola Kostenok authored
      mlxsw_thermal_module_trips_update() is used to update the trip points of
      the module's thermal zone. Currently, this is done by querying the
      thresholds from the module's EEPROM via MCIA register. This data does
      not pass validation and in some cases can be unreliable. For example,
      due to some problem with transceiver module.
      
      Previous patch made it possible to read module's temperature and
      thresholds via MTMP register. Therefore, extend
      mlxsw_thermal_module_trips_update() to use the thresholds queried from
      MTMP, if valid.
      
      This is both more reliable and more efficient than current method, as
      temperature and thresholds are queried in one transaction instead of
      three. This is significant when working over a slow bus such as I2C.
      Signed-off-by: default avatarMykola Kostenok <c_mykolak@nvidia.com>
      Acked-by: default avatarVadim Pasternak <vadimp@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      72a64c2f
    • Mykola Kostenok's avatar
      mlxsw: thermal: Add function for reading module temperature and thresholds · e57977b3
      Mykola Kostenok authored
      Provide new function mlxsw_thermal_module_temp_and_thresholds_get() for
      reading temperature and temperature thresholds by a single operation.
      The motivation is to reduce the number of transactions with the device
      which is important when operating over a slow bus such as I2C.
      
      Currently, the sole caller of the function is only using it to read the
      module's temperature. The next patch will also use it to query the
      module's temperature thresholds.
      Signed-off-by: default avatarMykola Kostenok <c_mykolak@nvidia.com>
      Acked-by: default avatarVadim Pasternak <vadimp@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e57977b3
    • Mykola Kostenok's avatar
      mlxsw: core_env: Read module temperature thresholds using MTMP register · befc2048
      Mykola Kostenok authored
      Currently, module temperature thresholds are obtained from Management
      Cable Info Access (MCIA) register by specifying the thresholds offsets
      within module EEPROM layout. This data does not pass validation and in
      some cases can be unreliable. For example, due to some problem with the
      module.
      
      Add support for a new feature provided by Management Temperature (MTMP)
      register for sanitization of temperature thresholds values.
      
      Extend mlxsw_env_module_temp_thresholds_get() to get temperature
      thresholds through MTMP field 'max_operational_temperature' - if it is
      not zero, feature is supported. Otherwise fallback to old method and get
      the thresholds through MCIA.
      Signed-off-by: default avatarMykola Kostenok <c_mykolak@nvidia.com>
      Acked-by: default avatarVadim Pasternak <vadimp@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      befc2048
    • Mykola Kostenok's avatar
      mlxsw: reg: Extend MTMP register with new threshold field · 314dbb19
      Mykola Kostenok authored
      Extend Management Temperature (MTMP) register with new field specifying
      the maximum temperature threshold.
      
      Extend mlxsw_reg_mtmp_unpack() function with two extra arguments,
      providing high and maximum temperature thresholds. For modules, these
      thresholds correspond to critical and emergency thresholds that are read
      from the module's EEPROM.
      Signed-off-by: default avatarMykola Kostenok <c_mykolak@nvidia.com>
      Acked-by: default avatarVadim Pasternak <vadimp@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      314dbb19
    • Petr Machata's avatar
      selftests: devlink_lib: Fix bouncing of netdevsim DEVLINK_DEV · 0521a262
      Petr Machata authored
      In the commit referenced below, a check was added to devlink_lib that
      asserts the existence of a devlink device referenced by $DEVLINK_DEV.
      Unfortunately, several netdevsim tests point DEVLINK_DEV at a device that
      does not exist at the time that devlink_lib is sourced. Thus these tests
      spuriously fail.
      
      Fix this by introducing an override. By setting DEVLINK_DEV to an empty
      string, the user declares their intention to handle DEVLINK_DEV management
      on their own.
      
      In all netdevsim tests that use devlink_lib and set DEVLINK_DEV, set
      instead an empty DEVLINK_DEV just before sourcing devlink_lib, and set it
      to the correct value right afterwards.
      
      Fixes: 557c4d2f ("selftests: devlink_lib: add check for devlink device existence")
      Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      0521a262
    • Amit Cohen's avatar
      selftests: Clean forgotten resources as part of cleanup() · e67dfb8d
      Amit Cohen authored
      Several tests do not set some ports down as part of their cleanup(),
      resulting in IPv6 link-local addresses and associated routes not being
      deleted.
      
      These leaks were found using a BPF tool that monitors ASIC resources.
      
      Solve this by setting the ports down at the end of the tests.
      Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e67dfb8d
    • Amit Cohen's avatar
      selftests: router_scale: Do not count failed routes · 00190c2b
      Amit Cohen authored
      To check how many routes are installed in hardware, the test runs "ip
      route" and greps for "offload", which includes routes with state
      "offload_failed".
      
      Till now, this wrong check was not found because after one failure in
      route insertion, the driver moved to "abort" mode, which means that user
      cannot try to add more routes.
      
      The previous patch removed the abort mechanism and now failed routes are
      counted as offloaded.
      
      Fix this by not considering routes with "offload_failed" flag as
      offloaded.
      Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      00190c2b
    • Amit Cohen's avatar
      mlxsw: spectrum_router: Remove abort mechanism · a08a6193
      Amit Cohen authored
      The abort mechanism was introduced in commit 8e05fd71 ("fib: hook
      IPv4 fib for hardware offload") with the purpose of falling back to
      software-based routing in case of a route programming error in hardware.
      The process is irreversible and requires users to reload the offloading
      driver or reboot the machine.
      
      While this approach might make sense in theory, it makes very little
      sense in practice. In the case of high speed ASICs such as the Spectrum
      ASIC, the abort mechanism effectively kills the machine upon a non-fatal
      error such as a route programming error.
      
      Such an extreme policy does not belong in the kernel, especially when
      user space can simply try to reprogram the route following the
      RTM_NEWROUTE failure notification.
      
      Therefore, remove the abort mechanism.
      Signed-off-by: default avatarAmit Cohen <amcohen@nvidia.com>
      Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
      Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      a08a6193
    • David S. Miller's avatar
      Merge branch 'dsa-sja1110' · fd5f5ab0
      David S. Miller authored
      Vladimir Oltean says:
      
      ====================
      Add NXP SJA1110 support to the sja1105 DSA driver
      
      The NXP SJA1110 is an automotive Ethernet switch with an embedded Arm
      Cortex-M7 microcontroller. The switch has 11 ports (10 external + one
      for the DSA-style connection to the microcontroller).
      The microcontroller can be disabled and the switch can be controlled
      over SPI, a la SJA1105 - this is how this driver handles things.
      
      There are some integrated NXP PHYs (100base-T1 and 100base-TX). Their
      initialization is handled by their own PHY drivers, the switch is only
      concerned with enabling register accesses to them, by registering two
      MDIO buses.
      
      Changes in v3:
      - Make sure the VLAN retagging port is enabled and functional
      - Dropped SGMII PCS from this series
      
      Changes in v2:
      - converted nxp,sja1105 DT bindings to YAML
      - registered the PCS MDIO bus and forced auto-probing off for all PHY
        addresses for this bus
      - changed the container node name for the 2 MDIO buses from "mdio" to
        "mdios" to avoid matching on the mdio.yaml schema (it's just a
        container node, not an MDIO bus)
      - fixed an uninitialized "offset" variable usage in
        sja1110_pcs_mdio_{read,write}
      - using the mdiobus_c45_addr macro instead of open-coding that operation
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      fd5f5ab0
    • Vladimir Oltean's avatar
      net: dsa: sja1105: register the MDIO buses for 100base-T1 and 100base-TX · 5a8f0974
      Vladimir Oltean authored
      The SJA1110 contains two types of integrated PHYs: one 100base-TX PHY
      and multiple 100base-T1 PHYs.
      
      The access procedure for the 100base-T1 PHYs is also different than it
      is for the 100base-TX one. So we register 2 MDIO buses, one for the
      base-TX and the other for the base-T1. Each bus has an OF node which is
      a child of the "mdio" subnode of the switch, and they are recognized by
      compatible string.
      
      Cc: Russell King <linux@armlinux.org.uk>
      Cc: Heiner Kallweit <hkallweit1@gmail.com>
      Cc: Rob Herring <robh+dt@kernel.org>
      Cc: devicetree@vger.kernel.org
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      5a8f0974
    • Vladimir Oltean's avatar
      net: dsa: sja1105: make sure the retagging port is enabled for SJA1110 · ceec8bc0
      Vladimir Oltean authored
      The SJA1110 has an extra configuration in the General Parameters Table
      through which the user can select the buffer reservation config.
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      ceec8bc0
    • Vladimir Oltean's avatar
      net: dsa: sja1105: add support for the SJA1110 switch family · 3e77e59b
      Vladimir Oltean authored
      The SJA1110 is basically an SJA1105 with more ports, some integrated
      PHYs (100base-T1 and 100base-TX) and an embedded microcontroller which
      can be disabled, and the switch core can be controlled by a host running
      Linux, over SPI.
      
      This patch contains:
      - the static and dynamic config packing functions, for the tables that
        are common with SJA1105
      - one more static config tables which is "unique" to the SJA1110
        (actually it is a rehash of stuff that was placed somewhere else in
        SJA1105): the PCP Remapping Table
      - a reset and clock configuration procedure for the SJA1110 switch.
        This resets just the switch subsystem, and gates off the clock which
        powers on the embedded microcontroller.
      - an RGMII delay configuration procedure for SJA1110, which is very
        similar to SJA1105, but different enough for us to be unable to reuse
        it (this is a pattern that repeats itself)
      - some adaptations to dynamic config table entries which are no longer
        programmed in the same way. For example, to delete a VLAN, you used to
        write an entry through the dynamic reconfiguration interface with the
        desired VLAN ID, and with the VALIDENT bit set to false. Now, the VLAN
        table entries contain a TYPE_ENTRY field, which must be set to zero
        (in a backwards-incompatible way) in order for the entry to be deleted,
        or to some other entry for the VLAN to match "inner tagged" or "outer
        tagged" packets.
      - a similar thing for the static config: the xMII Mode Parameters Table
        encoding for SGMII and MII (the latter just when attached to a
        100base-TX PHY) just isn't what it used to be in SJA1105. They are
        identical, except there is an extra "special" bit which needs to be
        set. Set it.
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      3e77e59b
    • Vladimir Oltean's avatar
      dt-bindings: net: dsa: sja1105: add SJA1110 bindings · 070f5b70
      Vladimir Oltean authored
      There are 4 variations of the SJA1110 switch which have a different set
      of MII protocols supported per port. Document the compatible strings.
      
      Also, the SJA1110 optionally supports 2 internal MDIO buses for 2
      different types of Ethernet PHYs. Document a container node called
      "mdios" which has 2 subnodes "mdio@0" and "mdio@1", identifiable via
      compatible string, under which the driver finds the internal PHYs.
      
      Cc: Rob Herring <robh+dt@kernel.org>
      Cc: devicetree@vger.kernel.org
      Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      070f5b70
    • David S. Miller's avatar
      Merge branch 'wwan-improvements' · 173dbbfe
      David S. Miller authored
      Sergey Ryazanov says:
      
      ====================
      net: WWAN subsystem improvements
      
      While working on WWAN netdev creation support, I notice a few things
      that could be done to make the wwan subsystem more developer and user
      friendly. This series implements them.
      
      The series begins with a WWAN HW simulator designed simplify testing
      and make the WWAN subsystem available for a wider audience. The next two
      patches are intended to make the code a bit more clearer. This is
      followed by a few patches to make the port device naming more
      user-friendly. The series is finishes with a set of changes that allow
      the WWAN AT port to be used with terminal emulation software.
      
      All changes were tested with the HW simulator that was introduced in
      this series, as well as with a Huawei E3372 LTE modem (a CDC-NCM
      device), which I finally found on my desk.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      173dbbfe
    • Sergey Ryazanov's avatar
      net: wwan: core: purge rx queue on port close · 50467203
      Sergey Ryazanov authored
      Purge the rx queue as soon as a user closes the port, just after the
      port stop callback invocation. This is to prevent feeding a user that
      will open the port next time with outdated and possibly unrelated
      data.
      
      While at it also remove the odd skb_queue_purge() call in the port
      device destroy callback. The queue will be purged just before the
      callback is ivoncated in the wwan_remove_port() function.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      50467203
    • Sergey Ryazanov's avatar
      net: wwan: core: implement terminal ioctls for AT port · c230035c
      Sergey Ryazanov authored
      It is not unreasonable to assume that users will use terminal emulation
      software to communicate directly with a WWAN device over the AT port.
      But terminal emulators  will refuse to work with a device that does not
      support terminal IOCTLs (e.g. TCGETS, TCSETS, TIOCMSET, etc.). To make
      it possible to interact with the WWAN AT port using a terminal emulator,
      implement a minimal set of terminal IOCTLs.
      
      The implementation is rather stub, no passed data are actually used to
      control a port behaviour. An obtained configuration is kept inside the
      port structure and returned back by a request. The latter is done to
      fool a program that will test the configuration status by comparing the
      readed back data from the device with earlier configured ones.
      
      Tested with fresh versions of minicom and picocom terminal apps.
      
      MBIM, QMI and other ports for binary protocols can hardly be considered
      a terminal device, so terminal IOCTLs are only implemented for the AT
      port.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      c230035c
    • Sergey Ryazanov's avatar
      net: wwan: core: implement TIOCINQ ioctl · e263c5b2
      Sergey Ryazanov authored
      It is quite common for a userpace program to fetch the buffered amount
      of data in the rx queue to avoid the read block. Implement the TIOCINQ
      ioctl to make the migration to the WWAN port usage smooth.
      
      Despite the fact that the read call will return no more data than the
      size of a first skb in the queue, TIOCINQ returns the entire amount of
      buffered data (sum of all queued skbs). This is done to prevent the
      breaking of programs that optimize reading, avoiding it if the buffered
      amount of data is too small.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Reviewed-by: default avatarLoic Poulain <loic.poulain@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e263c5b2
    • Sergey Ryazanov's avatar
      net: wwan: core: expand ports number limit · 72eedfc4
      Sergey Ryazanov authored
      Currently, we limit the total ports number to 256. It is quite common
      for PBX or SMS gateway to be equipped with a lot of modems. In now days,
      a modem could have 2-4 control ports or even more, what only accelerates
      the ports exhausing rate.
      
      To avoid facing the port number limitation issue reports, increase the
      limit up the maximum number of minors (i.e. up to 1 << MINORBITS).
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Reviewed-by: default avatarLoic Poulain <loic.poulain@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      72eedfc4
    • Sergey Ryazanov's avatar
      net: wwan: core: make port names more user-friendly · f458709f
      Sergey Ryazanov authored
      At the moment, the port name is allocated based on the parent device
      name, port id and the port type. Where the port id specifies nothing but
      the ports registration order and is only used to make the port name
      unique.
      
      Most likely, to configure a WWAN device, the user will look for a port
      of a specific type (e.g. AT port or MBIM port, etc.). The current naming
      scheme can make it difficult to find a port of a specific type.
      
      Consider a WWAN device that has 3 ports: AT port, MBIM port, and another
      one AT port. With the global port index, the port names will be:
      * wwan0p1at
      * wwan0p2mbim
      * wwan0p3at
      
      To find the MBIM port, user should know in advance the device ports
      composition (i.e. the user should know that the MBIM port is the 2nd
      one) or carefully examine the whole ports list. It is not unusual for
      USB modems to have a different composition, even if they are build on a
      same chipset. Moreover, some modems able to change the ports composition
      based on the user's configuration. All this makes port names fully
      unpredictable.
      
      To make naming more user-friendly, remove the global port id and
      enumerate ports by its type. E.g.:
      * wwan0p1at   -> wwan0at0
      * wwan0p2mbim -> wwan0mbim0
      * wwan0p3at   -> wwan0at1
      
      With this naming scheme, the first AT port name will always be wwanXat0,
      the first MBIM port name will always be wwanXmbim0, etc.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f458709f
    • Sergey Ryazanov's avatar
      net: wwan: core: spell port device name in lowercase · 392c26f7
      Sergey Ryazanov authored
      Usually a device name is spelled in lowercase, let us follow this
      practice in the WWAN subsystem as well. The bottom line is that such
      name is easier to type.
      
      To keep the device type attribute contents more natural (i.e., spell
      abbreviations in uppercase), while making the device name lowercase,
      turn the port type strings array to an array of structure that contains
      both the port type name and the device name suffix.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Reviewed-by: default avatarLoic Poulain <loic.poulain@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      392c26f7
    • Sergey Ryazanov's avatar
      net: wwan: core: init port type string array using enum values · 64cc80c0
      Sergey Ryazanov authored
      This array is indexed by port type. Make it self-descriptive by using
      the port type enum values as indices in the array initializer.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Reviewed-by: default avatarLoic Poulain <loic.poulain@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      64cc80c0
    • Sergey Ryazanov's avatar
      net: wwan: make WWAN_PORT_MAX meaning less surprised · b64d76b7
      Sergey Ryazanov authored
      It is quite unusual when some value can not be equal to a defined range
      max value. Also most subsystems defines FOO_TYPE_MAX as a maximum valid
      value. So turn the WAN_PORT_MAX meaning from the number of supported
      port types to the maximum valid port type.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Reviewed-by: default avatarLoic Poulain <loic.poulain@linaro.org>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      b64d76b7
    • Sergey Ryazanov's avatar
      wwan_hwsim: add debugfs management interface · 9ee23f48
      Sergey Ryazanov authored
      wwan_hwsim creates and removes simulated control ports on module loading
      and unloading. It would be helpful to be able to create/remove devices
      and ports at run-time to trigger wwan port (un-)register actions without
      module reloading.
      
      Some simulator objects (e.g. ports) do not have the underling device and
      it is not possible to fully manage the simulator via sysfs. wwan_hsim
      intend for developers, so implement it as a self-contained debugfs based
      management interface.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      9ee23f48
    • Sergey Ryazanov's avatar
      wwan_hwsim: WWAN device simulator · f36a111a
      Sergey Ryazanov authored
      This driver simulates a set of WWAN device with a set of AT control
      ports. It can be used to test WWAN kernel framework as well as user
      space tools.
      Signed-off-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f36a111a
    • David S. Miller's avatar
      Merge branch 'stmmac-25gbps' · 95848099
      David S. Miller authored
      Michael Sit Wei Hong says:
      
      ====================
      Enable 2.5Gbps speed for stmmac
      
      Intel mGbE supports 2.5Gbps link speed by overclocking the clock rate
      by 2.5 times to support 2.5Gbps link speed. In this mode, the serdes/PHY
      operates at a serial baud rate of 3.125 Gbps and the PCS data path and
      GMII interface of the MAC operate at 312.5 MHz instead of 125 MHz.
      This is configured in the BIOS during boot up. The kernel driver is not able
      access to modify the clock rate for 1Gbps/2.5G mode on the fly. The way to
      determine the current 1G/2.5G mode is by reading a dedicated adhoc
      register through mdio bus.
      
      Changes:
      v5 -> v6
       patch 1/3
       - Check if mdio_bus_data is populated to prevent NULL pointer dereferencing
         when accesing mdio_bus_data member
      
      v4 -> v5
       patch 1/3
       - Rebase to latest code changes after Vladimir's code is merged and fix
         build warnings
      
      v3 -> v4
       patch 1/3
       - Rebase to latest code and Initialize 'found' to 0 to avoid build warning
      
       patch 2/3
       - Fix indentation issue from v3
      
      v2 -> v3
       patch 1/3
       -New patch added to restructure the code. enabling reading the dedicated
        adhoc register to determine link speed mode.
      
       patch 2/3
       -Restructure for 2.5G speed to use 2500BaseX configuration as the
        PHY interface.
      
       patch 3/3
       -Restructure to read serdes registers to set max_speed and configure to
        use 2500BaseX in 2.5G speeds.
      
      v1 -> v2
       patch 1/2
       -Remove MAC supported link speed masking
      
       patch 2/2
       -Add supported link speed masking in the PCS
      
      iperf3 and ping for 2.5Gbps and regression test on 10M/100M/1000Mbps
      is done to prevent regresson issues.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      95848099
    • Voon Weifeng's avatar
      net: stmmac: enable Intel mGbE 2.5Gbps link speed · 46682cb8
      Voon Weifeng authored
      The Intel mGbE supports 2.5Gbps link speed by increasing the clock rate by
      2.5 times of the original rate. In this mode, the serdes/PHY operates at a
      serial baud rate of 3.125 Gbps and the PCS data path and GMII interface of
      the MAC operate at 312.5 MHz instead of 125 MHz.
      
      For Intel mGbE, the overclocking of 2.5 times clock rate to support 2.5G is
      only able to be configured in the BIOS during boot time. Kernel driver has
      no access to modify the clock rate for 1Gbps/2.5G mode. The way to
      determined the current 1G/2.5G mode is by reading a dedicated adhoc
      register through mdio bus. In short, after the system boot up, it is either
      in 1G mode or 2.5G mode which not able to be changed on the fly.
      
      Compared to 1G mode, the 2.5G mode selects the 2500BASEX as PHY interface and
      disables the xpcs_an_inband. This is to cater for some PHYs that only
      supports 2500BASEX PHY interface with no autonegotiation.
      
      v2: remove MAC supported link speed masking
      v3: Restructure  to introduce intel_speed_mode_2500() to read serdes registers
          for max speed supported and select the appropritate configuration.
          Use max_speed to determine the supported link speed mask.
      Signed-off-by: default avatarVoon Weifeng <weifeng.voon@intel.com>
      Signed-off-by: default avatarMichael Sit Wei Hong <michael.wei.hong.sit@intel.com>
      Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      46682cb8
    • Voon Weifeng's avatar
      net: pcs: add 2500BASEX support for Intel mGbE controller · f27abde3
      Voon Weifeng authored
      XPCS IP supports 2500BASEX as PHY interface. It is configured as
      autonegotiation disable to cater for PHYs that does not supports 2500BASEX
      autonegotiation.
      
      v2: Add supported link speed masking.
      v3: Restructure to introduce xpcs_config_2500basex() used to configure the
          xpcs for 2.5G speeds. Added 2500BASEX specific information for
          configuration.
      v4: Fix indentation error
      Signed-off-by: default avatarVoon Weifeng <weifeng.voon@intel.com>
      Signed-off-by: default avatarMichael Sit Wei Hong <michael.wei.hong.sit@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      f27abde3
    • Voon Weifeng's avatar
      net: stmmac: split xPCS setup from mdio register · 597a68ce
      Voon Weifeng authored
      This patch is a preparation patch for the enabling of Intel mGbE 2.5Gbps
      link speed. The Intel mGbR link speed configuration (1G/2.5G) is depends on
      a mdio ADHOC register which can be configured in the bios menu.
      As PHY interface might be different for 1G and 2.5G, the mdio bus need be
      ready to check the link speed and select the PHY interface before probing
      the xPCS.
      Signed-off-by: default avatarVoon Weifeng <weifeng.voon@intel.com>
      Signed-off-by: default avatarMichael Sit Wei Hong <michael.wei.hong.sit@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      597a68ce