1. 13 Nov, 2018 12 commits
  2. 09 Nov, 2018 1 commit
    • Kuninori Morimoto's avatar
      ASoC: rsnd: use ring buffer for rsnd_mod_name() · 0246c661
      Kuninori Morimoto authored
      commit c0ea089d ("ASoC: rsnd: rsnd_mod_name() handles both name and
      ID") merged "name" and "ID" on rsnd_mod_name() to handle sub-ID
      (= for CTU/BUSIF).
      Then, it decided to share static char to avoid pointless memory.
      But, it doesn't work correctry in below case, because last called
      name will be used.
      
      	dev_xxx(dev, "%s is connected to %s\n",
      		rsnd_mod_name(mod_a),  /* ssiu[00] */
      		rsnd_mod_name(mod_b)); /* ssi[0]   */
      	->
      	rcar_sound ec500000.sound: ssi[0] is connected to ssi[0]
      	                           ~~~~~~                 ~~~~~~
      We still don't want to have pointless memory, so let's use ring buffer.
      16byte x 5 is very enough for this purpose.
      
      	dev_xxx(dev, "%s is connected to %s\n",
      		rsnd_mod_name(mod_a),  /* ssiu[00] */
      		rsnd_mod_name(mod_b)); /* ssi[0]   */
      	->
      	rcar_sound ec500000.sound: ssiu[00] is connected to ssi[0]
      	                           ~~~~~~~~                 ~~~~~~
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      0246c661
  3. 07 Nov, 2018 1 commit
  4. 06 Nov, 2018 24 commits
  5. 05 Nov, 2018 2 commits
    • Kuninori Morimoto's avatar
      ASoC: rsnd: rsnd_mod_name() handles both name and ID · c0ea089d
      Kuninori Morimoto authored
      Current rsnd driver is using "%s[%d]" for mod name and ID,
      but, this ID portion might confusable.
      For example currently, CTU ID is 0 to 7, but using 00 to 13
      (= 00, 01, 02, 03, 10, 11, 12, 13) is very best matching to datasheet.
      
      In the future, we will support BUSIFn, but it will be more complicated
      numbering. To avoid future confusable code, this patch modify
      rsnd_mod_name() to return understandable name.
      
      To avoid using pointless memory, it uses static char and snprintf,
      thus, rsnd_mod_name() user should use it immediately, and shouldn't keep
      its pointer.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      c0ea089d
    • Kuninori Morimoto's avatar
      ASoC: rsnd: add .get_id/.get_id_sub · c16015f3
      Kuninori Morimoto authored
      ID for CTU and SSIU are confusable.
      1 CTU has 4 sub nodes. This means, CTU0 has CTU01 - CTU03, CTU1 has
      CTU10 - CTU13. SSIU is more confusable. Gen2 SSIU has BUSIF0-3, Gen3
      SSIU has BUSIF0-7, but not for all SSIU.
      In rsnd driver, each mod drivers are assuming rsnd_mod_id() returns
      main device ID (In CTU case CTU0-1, SSIU case SSIU0-9), not serial
      number.
      This patch adds new .id/.id_sub to handling more detail ID.
      Signed-off-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      c16015f3