- 15 Aug, 2012 40 commits
-
-
Julia Lawall authored
[media] drivers/media/usb/{s2255drv.c, tm6000/tm6000-alsa.c, tm6000/tm6000-input.c}: Remove potential NULL dereferences If the NULL test is necessary, the initialization involving a dereference of the tested value should be moved after the NULL test. The sematic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by:Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
Mauro Carvalho Chehab <mchehab@redhat.com>
-
Sachin Kamat authored
devm_* functions are device managed functions and make error handling and cleanup cleaner and simpler. Signed-off-by:
Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by:
Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by:
-
Sachin Kamat authored
Replace printk with pr_* functions to silence checkpatch warnings. Signed-off-by:
-
Sachin Kamat authored
devm_regulator_get() is a device managed function and makes the exit code a bit simpler and cleaner. Signed-off-by:
-
Julia Lawall authored
Using devm_kzalloc simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered after the handler's data argument had been freed. This also introduces some missing initializations of the return variable ret, and uses devm_request_and_ioremap instead of the combination of devm_request_mem_region and devm_ioremap. The problem of a free after a devm_request_irq was found using the following semantic match (http://coccinelle.lip6.fr/) // <smpl> @r exists@ expression e1,e2,x,a,b,c,d; identifier free; position p1,p2; @@ devm_request_irq@p1(e1,e2,...,x) ... when any when != e2 = a when != x = b if (...) { ... when != e2 = c when != x = d free@p2(...,x,...); ... return ...; } // </smpl> Signed-off-by:
-
Hans Verkuil authored
More validation fixes as reported by xmllint. There are still three xmllint errors after this remaining regarding SVG file support. Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
-
Hans Verkuil authored
Signed-off-by:
-
Dan Carpenter authored
"card" is a valid pointer here because we checked snd_card_create() for error returns. Checking after a dereference makes the static checkers complain. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by:
-
Dan Carpenter authored
There are some unlocks missing on error. Signed-off-by:
-
Dan Carpenter authored
We recently added locking to this function, but there was an error path which accidentally returned holding a lock. Also we returned zero on failure on some paths instead of the error code. Signed-off-by:
-
Dan Carpenter authored
We need to move the unlock before the kfree(dev); Signed-off-by:
-
Dan Carpenter authored
This code looks suspicious, but it turns out that "nv" is an array of u8 so sizeof() is the same as ARRAY_SIZE(). Using ARRAY_SIZE() is more readable though. Signed-off-by:
-
Guennadi Liakhovetski authored
Add .get_selection() and .set_selection() soc-camera host driver operations. Additionally check, that the user is not trying to change the output sizes during a running capture. Signed-off-by:
Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by:
-
Javier Martin authored
Add explicit conversions from UYVY and YUYV to YUYV so that csicr1 configuration can be set properly for each format. Signed-off-by:
Javier Martin <javier.martin@vista-silicon.com> Signed-off-by:
-
Fabio Estevam authored
Prepare the clock before enabling it. Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Cc: <linux-media@vger.kernel.org> Signed-off-by:
Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by:
-
Fabio Estevam authored
Prepare the clock before enabling it. Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Cc: <linux-media@vger.kernel.org> Signed-off-by:
-
Laurent Pinchart authored
The sensor starts streaming video as soon as it gets powered or is reset. Disable the output in the reset function. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by:
-
Laurent Pinchart authored
Instead of hardcoding register arrays, compute the values at runtime. Signed-off-by:
-
Laurent Pinchart authored
Signed-off-by:
-
Laurent Pinchart authored
And use them instead of calling SMBus access functions directly. Signed-off-by:
-
Laurent Pinchart authored
Conversion from i2c_client to ov772x_priv is only needed in a single location, while conversion from v4l2_subdev to ov772x_priv is needed in several locations. Perform the former manually, and use to_ov772x for the later. Signed-off-by:
-
Laurent Pinchart authored
If the requested format isn't supported, return a fixed default format instead of the current format. Signed-off-by:
-
Laurent Pinchart authored
Select a default format instead. Signed-off-by:
-
Laurent Pinchart authored
The format and window size are only initialized during the first g_fmt call. This leaves the device in an inconsistent state after initialization, which will cause problems when implementing pad operations. Move the format and window size initialization to probe time. Signed-off-by:
-
Laurent Pinchart authored
The control handler isn't freed if its initialization fails. Fix it. Signed-off-by:
-
Laurent Pinchart authored
Several client drivers access the hardware at probe time, for instance to read the probe chip ID. Such chips need to be powered up when being probed. soc-camera handles this by powering chips up in the soc-camera probe implementation. However, this will break with non soc-camera hosts that don't perform the same operations. Fix the problem by pushing the power up/down from the soc-camera core down to individual drivers on a needs basis. Signed-off-by:
-
Laurent Pinchart authored
Instead of forcing all soc-camera drivers to go through the mid-layer to handle power management, create soc_camera_power_[on|off]() functions that can be called from the subdev .s_power() operation to manage regulators and platform-specific power handling. This allows non soc-camera hosts to use soc-camera-aware clients. Signed-off-by:
-
Laurent Pinchart authored
Powering off a device is a "best effort" task: failure to execute one of the steps should not prevent the next steps to be executed. For instance, an I2C communication error when putting the chip in stand-by mode should not prevent the more agressive next step of turning the chip's power supply off. Signed-off-by:
-
Laurent Pinchart authored
The .s_power() call only covers the .g_mbus_fmt() operation call. Several clients required to be powered on to retrieve the current mbus format but have now been fixed. The .s_power() call is thus not needed anymore and can be removed. Signed-off-by:
-
Mauro Carvalho Chehab authored
The remaining drivers are mostly platform drivers. Name the dir to reflect it. It makes sense to latter break it into a few other dirs. Signed-off-by: -
Mauro Carvalho Chehab authored
Move all soc_camera i2c drivers into drivers/media/i2c/soc_camera/. Signed-off-by: -
Mauro Carvalho Chehab authored
Move ancillary I2C drivers into drivers/media/i2c, in order to better organize them. Signed-off-by: -
Mauro Carvalho Chehab authored
Reorganize the API core changes for them to appear closer to the items that enable them, and not at the drivers part of the menu. Signed-off-by: -
Mauro Carvalho Chehab authored
Signed-off-by: -
Mauro Carvalho Chehab authored
We should keep just the I2C drivers under drivers/media/video, and then rename it to drivers/media/i2c. Signed-off-by: -
Mauro Carvalho Chehab authored
Move meye and sta2x11_vip into the drivers/media/pci subdirs. Signed-off-by: -
Mauro Carvalho Chehab authored
Instead of having them under drivers/media/video, move them to their own directory. Signed-off-by: -
Mauro Carvalho Chehab authored
Rename all PCI drivers with their own directory under drivers/media/video into drivers/media/pci and update the building system. Signed-off-by: -
Mauro Carvalho Chehab authored
Signed-off-by: -
Mauro Carvalho Chehab authored
Move the 3 remaining usb drivers to their proper space. Signed-off-by:
-
