- 28 Jan, 2015 21 commits
-
-
Takashi Iwai authored
The PCM stream buffer allocation and free are identical for both playback and capture streams. Provide single helper functions. These are used only in pcm.c, thus they can be even static. Tested-by:
Chris Rorvick <chris@rorvick.com> Signed-off-by:
Takashi Iwai <tiwai@suse.de>
-
Takashi Iwai authored
This is the last remaining snd_printk() usage in this driver. Tested-by:
-
Takashi Iwai authored
The codes to unlink and sync URBs are identical for both playback and capture streams. Consolidate to single helper functions. Tested-by:
-
Takashi Iwai authored
Introduce a new line6_pcm_stream structure and group individual fields of snd_line6_pcm struct to playback and capture groups. This patch itself just does rename and nothing else. More meaningful cleanups based on these fields shuffling will follow. Tested-by:
-
Takashi Iwai authored
If the problem still really remains, we should fix it instead of papering over it like this... Tested-by:
-
Takashi Iwai authored
Using a decremental loop without particular reasons worsens the readability a lot. Use incremental loops instead. Tested-by:
-
Takashi Iwai authored
The trigger callback is already spinlocked, so we need no more lock here (even for the linked substreams). Let's drop it. Tested-by:
-
Takashi Iwai authored
line6_pcm_acquire() tries to restore the newly obtained resources at the error path. But some flags aren't recorded and released properly when the corresponding buffer is already present. These bits have to be cleared in the error recovery, too. Also, "flags_final" can be initialized to zero since we pass only the subset of "channels" bits. Tested-by:
-
Takashi Iwai authored
Fixed a few places using bits OR wrongly for condition checks. Tested-by:
-
Takashi Iwai authored
Tested-by:
-
Takashi Iwai authored
The midi_transmit_lock is used always inside the send_urb_lock, thus it doesn't play any role. Let's kill it. Also, rename "send_urb_lock" as a more simple name "lock" since this is the only lock for midi. Tested-by:
-
Takashi Iwai authored
The function isn't used any longer after rewriting from sysfs to leds class in toneport.c. Tested-by:
-
Takashi Iwai authored
Fix memory leak at probe error path by rearranging the call order in line6_destruct() so that the common destructor is always called. Also this simplifies the error path to a single goto label. Tested-by:
-
Takashi Iwai authored
Split some codes in the lengthy line6_probe(). Tested-by:
-
Takashi Iwai authored
Instead of non-standard sysfs, reimplement the LED controls on TonePort as LED class devices. Tested-by:
-
Takashi Iwai authored
Tested-by:
-
Takashi Iwai authored
Currently disconnect callback is used as a driver's destructor, and this has to be called not only at the disconnection time but also at the error paths during probe. Tested-by:
-
Takashi Iwai authored
... so that timer_del_sync() in the destructor can be called safely at any time. Also move the mod_timer() call in toneport_setup(), which is a bit clearer place. Tested-by:
-
Takashi Iwai authored
The interface and driver objects are always set when callbacks are called. Drop such superfluous NULL checks in init and disconnect calls of each driver. Tested-by:
-
Takashi Iwai authored
It's utterly unsafe to proceed further the disconnect procedure if the assigned usbdev is inconsistent with the expected object. Better to put a WARN_ON() for more cautions and abort immediately. Tested-by:
-
Takashi Iwai authored
... in line6_disconnect() as well. Tested-by:
-
- 20 Jan, 2015 19 commits
-
-
Chris Rorvick authored
The driver version string was removed in an ealier commit for being useless. These are equally useless. Signed-off-by:
-
Chris Rorvick authored
The correct spelling includes the space. Fix this in strings and comments that refer to the manufacturer. Signed-off-by:
-
Chris Rorvick authored
Signed-off-by:
-
Takashi Iwai authored
Both functions are used nowhere. Tested-by:
-
Takashi Iwai authored
It's used only locally. Tested-by:
-
Takashi Iwai authored
Call line6_pcm_disconnect() at disconnect to make sure that all URBs are cleared. Also reduce the superfluous snd_pcm_stop() calls from the function (and remove the unused function) since the streams are guaranteed to be stopped at this point via snd_card_disconnect(). Tested-by:
-
Takashi Iwai authored
Calling line6_pcm_disconnect() at suspend callback is superfluous and rather confusing. Let's get rid of it. Tested-by:
-
Takashi Iwai authored
Such a macro doesn't improve readability. Tested-by:
-
Takashi Iwai authored
Such a debug is needed in the core code, not in each lowlevel driver. Tested-by:
-
Takashi Iwai authored
This is rather useless for a driver that has been already merged into the official tree. Tested-by:
-
Takashi Iwai authored
This is a fairly big rewrite regarding the card resource management in line6 drivers: - The card creation is moved into line6_probe(). This adds the global destructor to private_free, so that each driver doesn't have to call it any longer. - The USB disconnect callback handles the card release, thus each driver needs to concentrate on only its own resources. No need to snd_card_*() call in the destructor. - Fix the potential stall in disconnection by removing snd_card_free(). It's replaced with snd_card_free_when_closed() for asynchronous release. - The only remaining operation for the card in each driver is the call of snd_card_register(). All the rest are dealt in the common module by itself. - These ended up with removal of audio.[ch] as a result of a reduction of one layer. Each driver just needs to call line6_probe(). Tested-by:
-
Takashi Iwai authored
The PCM trigger callback is guaranteed to be called already in spinlock / irq-disabled context. Tested-by:
-
Takashi Iwai authored
Otherwise it oopses. Tested-by:
-
Takashi Iwai authored
Kernel already shows the error in the common path. Tested-by:
-
Takashi Iwai authored
It's non-standard and rather superfluous. Tested-by:
-
Takashi Iwai authored
The line6 drivers don't support the full resume although they set SNDRV_PCM_INFO_RESUME. These flags have to be dropped to inform properly to the user-space. Also, drop the CONFIG_PM in trigger callbacks, too, which are rather superfluous. Tested-by:
-
Takashi Iwai authored
Like the previous fix for PCM, attach the card-specific resource into rawmidi->private_data instead of handling in a snd_device object. This simplifies the code and structure. Tested-by:
-
Takashi Iwai authored
Instead of handling the card-specific resource in snd_device, attach it into pcm->private_data and release it directly in private_free. This simplifies the code and structure. Tested-by:
-
Takashi Iwai authored
Instead of sysfs and the conditional build with Kconfig, implement the handling of the impulse response controls via control API, and always enable the build. Two new controls, "Impulse Response Volume" and "Impulse Response Period" are added as a replacement for the former sysfs files. Tested-by:
-
