1. 22 Dec, 2010 5 commits
  2. 26 Nov, 2010 8 commits
  3. 21 Nov, 2010 1 commit
  4. 18 Nov, 2010 21 commits
  5. 17 Nov, 2010 5 commits
    • Linus Torvalds's avatar
      Fix build failure due to hwirq.h needing smp_lock.h · 7957f0a8
      Linus Torvalds authored
      Arnd Bergmann did an automated scripting run to find left-over instances
      of <linux/smp_lock.h>, and had made it trigger it on the normal BKL use
      of lock_kernel and unlock_lernel (and apparently release_kernel_lock and
      reacquire_kernel_lock too, used by the scheduler).
      
      That resulted in commit 451a3c24 ("BKL: remove extraneous #include
      <smp_lock.h>").
      
      However, hardirq.h was the only remaining user of the old
      'kernel_locked()' interface, and Arnd's script hadn't checked for that.
      So depending on your configuration and what header files had been
      included, you would get errors like "implicit declaration of function
      'kernel_locked'" during the build.
      
      The right fix is not to just re-instate the smp_lock.h include - it is
      to just remove 'kernel_locked()' entirely, since the only use was this
      one special low-level detail.  Just make hardirq.h do it directly.
      
      In fact this simplifies and clarifies the code, because some trivial
      analysis makes it clear that hardirq.h only ever used _one_ of the two
      definitions of kernel_locked(), so we can remove the other one entirely.
      Reported-by: default avatarZimny Lech <napohybelskurwysynom2010@gmail.com>
      Reported-and-acked-by: default avatarRandy Dunlap <randy.dunlap@oracle.com>
      Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      7957f0a8
    • Avi Kivity's avatar
      KVM: VMX: Fix host userspace gsbase corruption · c8770e7b
      Avi Kivity authored
      We now use load_gs_index() to load gs safely; unfortunately this also
      changes MSR_KERNEL_GS_BASE, which we managed separately.  This resulted
      in confusion and breakage running 32-bit host userspace on a 64-bit kernel.
      
      Fix by
      - saving guest MSR_KERNEL_GS_BASE before we we reload the host's gs
      - doing the host save/load unconditionally, instead of only when in guest
        long mode
      
      Things can be cleaned up further, but this is the minmal fix for now.
      Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
      Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
      c8770e7b
    • Avi Kivity's avatar
      KVM: Correct ordering of ldt reload wrt fs/gs reload · 0a77fe4c
      Avi Kivity authored
      If fs or gs refer to the ldt, they must be reloaded after the ldt.  Reorder
      the code to that effect.
      
      Userspace code that uses the ldt with kvm is nonexistent, so this doesn't fix
      a user-visible bug.
      Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
      Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
      0a77fe4c
    • Dongdong Deng's avatar
      kgdb,ppc: Fix regression in evr register handling · e3839ed8
      Dongdong Deng authored
      Commit ff10b88b (kgdb,ppc: Individual
      register get/set for ppc) introduced a problem where memcpy was used
      incorrectly to read and write the evr registers with a kernel that
      has:
      
      CONFIG_FSL_BOOKE=y
      CONFIG_SPE=y
      CONFIG_KGDB=y
      
      This patch also fixes the following compilation problems:
      
      arch/powerpc/kernel/kgdb.c: In function 'dbg_get_reg':
      arch/powerpc/kernel/kgdb.c:341: error: passing argument 2 of 'memcpy' makes pointer from integer without a cast
      arch/powerpc/kernel/kgdb.c: In function 'dbg_set_reg':
      arch/powerpc/kernel/kgdb.c:366: error: passing argument 1 of 'memcpy' makes pointer from integer without a cast
      
      [jason.wessel@windriver.com: Remove void * casts and fix patch header]
      Reported-by: default avatarMilton Miller <miltonm@bga.com>
      Signed-off-by: default avatarDongdong Deng <dongdong.deng@windriver.com>
      Acked-by: default avatarKumar Gala <galak@kernel.crashing.org>
      Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
      CC: linuxppc-dev@lists.ozlabs.org
      e3839ed8
    • Jason Wessel's avatar
      kgdb,x86: fix regression in detach handling · 10a6e676
      Jason Wessel authored
      The fix from ba773f7c
      (x86,kgdb: Fix hw breakpoint regression) was not entirely complete.
      
      The kgdb_remove_all_hw_break() function also needs to call the
      hw_break_release_slot() or else a breakpoint can get activated again
      after the debugger has detached.
      
      The kgdb test suite exposes the behavior in the form of either a hang
      or repetitive failure.  The kernel config that exposes the problem
      contains all of the following:
      
      CONFIG_DEBUG_RODATA=y
      CONFIG_KGDB_TESTS=y
      CONFIG_KGDB_TESTS_ON_BOOT=y
      CONFIG_KGDB_TESTS_BOOT_STRING="V1F100"
      Reported-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
      Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
      Tested-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
      10a6e676