- 26 Sep, 2023 27 commits
-
-
Pavan Bobba authored
variable name "byRFType" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by:
Pavan Bobba <opensource206@gmail.com> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ZQwyRXFHA9hTLcyv@ubuntu.myguest.virtualbox.orgSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Arnd Bergmann authored
The rtllib_rxb structure contains a pointer, so this is not a hardware structure but could benefit from loading the pointer in a single instruction rather than assembling it from four or eight individual bytes. Both structures are allocated as part of larger structure that already enforce at least a 4-byte alignment, so there is no reason to ever have to deal with misaligned definitions. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20230925155413.471287-2-arnd@kernel.orgSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Resolve circular locking from reorder_spinlock with rx_pkt_pending_timer. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/08ff2088b0264bef60142ca35f7198dd8afa963c.1695582999.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
The following command uses the mutex ieee->wx_mutex: cancel_delayed_work_sync(&ieee->associate_retry_wq) Therefore it cannot be canceled with ieee->wx_mutex locked. rtllib_stop_protocol() is always called with ieee->wx_mutex locked so according line can be unlocked. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/ffe60e8f6e29197f331e239ab38154da97c743be.1695582999.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
The following commands use the mutex ieee->wx_mutex: cancel_delayed_work_sync(&ieee->associate_retry_wq) cancel_delayed_work_sync(&ieee->associate_procedure_wq) cancel_work_sync(&ieee->wx_sync_scan_wq) Therefore they cannot be canceled with ieee->wx_mutex locked. As the work functions are executed time shifted during normal operation of the driver, proper locking can only be done inside the functions. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/a5308876bd8fabcb5f8b25d14dbad2c1f68ce59f.1695582999.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
To reverse order of initialization put kfree() to the end of rtllib_softmac_free(). Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/85b63c62780356af91c30cc63280c5f59cd29210.1695582999.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
rtllib_start_send_beacons() is removed so no need for rtllib_stop_send_beacons() anymore. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/17c5545102ad8f50ca320af17aafa555f8caec2d.1695387832.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Remove delayed_work start_ibss_wq and the related functions which are not needed anymore. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/805447a41feffb9da7d82830868dc1d47f9aa737.1695387832.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtllib_softmac.c. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/4259c06deaf2e3f3cc615e8c55bcf6f70ce4e277.1695387832.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtl_cam.c. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/143345585dfcc0e920b2ba5fa614f626ab3ad8ee.1695387832.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtl_core.c and further files. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/7b9a4790238081736e6530135309e53d36f28574.1695387832.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtllib_rx.c and all related functions and structs. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/5400c68e17b86b1170ac997fae3fe1fb09220af8.1695387832.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Remove unsupported mode IW_MODE_ADHOC from rtllib_tx.c, rtl819x_TSProc.c, rtl819x_HTProc.c, r8192E_dev.c Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/59564ce06fc0a23fd26304b8ecd585abd5ddd82f.1695387832.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable StatusCode to status_code to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-12-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename function TSInitialize to rtllib_ts_init to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-11-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename function GetTs to rtllib_get_ts to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-10-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable Policy to policy to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-9-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable pStatusCode to status_code to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-8-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable Addr to addr to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-7-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable pPendingBA to pending_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-6-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable Dst to dst to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-5-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable pPendingBa to pending_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-4-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable pAdmittedBa to admitted_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-3-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Tree Davies authored
Rename variable Time to time to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230921032515.96152-2-tdavies@darkphysics.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
iwe.u.name and proto_name have both 16 bytes of space. But when writing to iwe.u.name the first 10 bytes are used by the fixed string "IEEE802.11". Evaluating the code shows that only the following strings can occur in proto_name: "N-24G", "g", "b", "bg". Therefore it is sufficient to shorten proto_name to 6 bytes. Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309171733.Gl96cmYd-lkp@intel.com/Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/2caafb8628880570725385e87150c47689474fc4.1695054044.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Fix alignment of structs to even addresses to support all architectures. Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309171733.Gl96cmYd-lkp@intel.com/Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/3140277dca915a1af9f66b1e7b4b47f5c7f6cd77.1695054044.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bragatheswaran Manickavel authored
They are appear to be spelling mistakes, Initially identified in a codespell report and never been addressed so far. ./rtl8723b_phycfg.c:156: Threre ==> There, three ./rtl8723b_phycfg.c:283: Condig ==> Config ./rtl8723b_phycfg.c:328: Tranceiver ==> Transceiver Signed-off-by:
Bragatheswaran Manickavel <bragathemanick0908@gmail.com> Link: https://lore.kernel.org/r/20230917134940.2746-1-bragathemanick0908@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
- 17 Sep, 2023 13 commits
-
-
Jonathan Bergh authored
Fixed various issues relating to comments including: * Lines with '*' in block comments which should be aligned and were not * Corrected comments where closing multiline comment identifier ran over into second newline spuriously * Corrected comment content to correctly reflect hexadecimal for the offsets rather than integers Signed-off-by:
Jonathan Bergh <bergh.jonathan@gmail.com> Link: https://lore.kernel.org/r/20230914200732.47659-1-bergh.jonathan@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jonathan Bergh authored
Removed spurious newlines in define statements so that defines which should be grouped together for readability are grouped as such. Signed-off-by:
Jonathan Bergh <bergh.jonathan@gmail.com> Link: https://lore.kernel.org/r/20230914200536.47619-1-bergh.jonathan@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Pavan Bobba authored
Array names starting with "byVT3253B0_" updated like below: a.type encoding info dropped from names b.camelcase names replaced by snakecase Issue found by checkpatch Signed-off-by:
Pavan Bobba <opensource206@gmail.com> Link: https://lore.kernel.org/r/ZQGiqA2GoDp/WiPK@ubuntu.myguest.virtualbox.orgSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jonathan Bergh authored
Removed unused/commented code from vme_fake.c which was causing spurious checkpatch warnings. Signed-off-by:
Jonathan Bergh <bergh.jonathan@gmail.com> Link: https://lore.kernel.org/r/20230903150623.571984-1-bergh.jonathan@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oliver Crumrine authored
Remove typedef in structs cvmx_pip_port_status_t and cvmx_pko_port_status_t, and rename all instances to cvmx_pip_port_status, and cvmx_pko_port_status, respectively Signed-off-by:
Oliver Crumrine <ozlinux@hotmail.com> Link: https://lore.kernel.org/r/PH7PR11MB76434462A6563C5FBDEE51A8BCE0A@PH7PR11MB7643.namprd11.prod.outlook.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oliver Crumrine authored
Remove typedef in enum cmvx_pko_status_t, and rename all instances to cvmx_pko_status Signed-off-by:
Oliver Crumrine <ozlinux@hotmail.com> Link: https://lore.kernel.org/r/PH7PR11MB7643430B9516797F3870936FBCE0A@PH7PR11MB7643.namprd11.prod.outlook.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oliver Crumrine authored
Remove typedef in struct cvmx_pko_lock_t, and rename all instances to cvmx_pko_lock Signed-off-by:
Oliver Crumrine <ozlinux@hotmail.com> Link: https://lore.kernel.org/r/PH7PR11MB764333C6FB367FBF1C676B43BCE0A@PH7PR11MB7643.namprd11.prod.outlook.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oliver Crumrine authored
Remove typedef in enum cvmx_pow_wait_t, and rename all instances to cvmx_pow_wait Signed-off-by:
Oliver Crumrine <ozlinux@hotmail.com> Link: https://lore.kernel.org/r/PH7PR11MB7643299EE41E05AD6D736416BCE0A@PH7PR11MB7643.namprd11.prod.outlook.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oliver Crumrine authored
Remove typedef in enum cvmx_helper_interface_mode_t, and rename all instances to cvmx_helper_interface_mode Signed-off-by:
Oliver Crumrine <ozlinux@hotmail.com> Link: https://lore.kernel.org/r/PH7PR11MB7643DEB4401AA83A0578087CBCE0A@PH7PR11MB7643.namprd11.prod.outlook.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oliver Crumrine authored
Remove typedef in enum cvmx_spi_mode_t, and rename all instances to cvmx_spi_mode Signed-off-by:
Oliver Crumrine <ozlinux@hotmail.com> Link: https://lore.kernel.org/r/PH7PR11MB764333BA75F5760600A4D08EBCE0A@PH7PR11MB7643.namprd11.prod.outlook.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Alexon Oliveira authored
Fixed all CHECK: No space is necessary after a cast as reported by checkpatch to adhere to the Linux kernel coding-style guidelines. Signed-off-by:
Alexon Oliveira <alexondunkan@gmail.com> Link: https://lore.kernel.org/r/603976b29ad4d9a0e4cbd8452ff674ec70a227a8.1693164540.git.alexondunkan@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Alexon Oliveira authored
Fixed all CHECK: Blank lines aren't necessary before a close brace '}' as reported by checkpatch to adhere to the Linux kernel coding-style guidelines. Signed-off-by:
Alexon Oliveira <alexondunkan@gmail.com> Link: https://lore.kernel.org/r/dde6f13f92a7cb17e01aceaeabe790656078326e.1693164540.git.alexondunkan@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Alexon Oliveira authored
Fixed all CHECK: Lines should not end with a '(' as reported by checkpatch to adhere to the Linux kernel coding-style guidelines. Signed-off-by:
Alexon Oliveira <alexondunkan@gmail.com> Link: https://lore.kernel.org/r/9f3e2facdc4d5e612dc00830c2da0fb19c20f2c5.1693164540.git.alexondunkan@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-