1. 10 Mar, 2021 6 commits
  2. 05 Mar, 2021 30 commits
  3. 03 Mar, 2021 4 commits
    • Lee Jones's avatar
      drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue · 3e3527f5
      Lee Jones authored
      Fixes the following W=1 kernel build warning(s):
      
       In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:59:
       drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58: warning: initialized field overwritten [-Woverride-init]
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:214:16: note: in expansion of macro ‘AUX_SW_DATA__AUX_SW_AUTOINCREMENT_DISABLE__SHIFT’
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:127:2: note: in expansion of macro ‘AUX_SF’
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:177:2: note: in expansion of macro ‘DCE_AUX_MASK_SH_LIST’
       drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10014:58: note: (near initialization for ‘aux_shift.AUX_SW_AUTOINCREMENT_DISABLE’)
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:214:16: note: in expansion of macro ‘AUX_SW_DATA__AUX_SW_AUTOINCREMENT_DISABLE__SHIFT’
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:127:2: note: in expansion of macro ‘AUX_SF’
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:177:2: note: in expansion of macro ‘DCE_AUX_MASK_SH_LIST’
       drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10013:56: warning: initialized field overwritten [-Woverride-init]
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:214:16: note: in expansion of macro ‘AUX_SW_DATA__AUX_SW_AUTOINCREMENT_DISABLE_MASK’
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:127:2: note: in expansion of macro ‘AUX_SF’
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:181:2: note: in expansion of macro ‘DCE_AUX_MASK_SH_LIST’
       drivers/gpu/drm/amd/amdgpu/../include/asic_reg/dce/dce_11_2_sh_mask.h:10013:56: note: (near initialization for ‘aux_mask.AUX_SW_AUTOINCREMENT_DISABLE’)
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:214:16: note: in expansion of macro ‘AUX_SW_DATA__AUX_SW_AUTOINCREMENT_DISABLE_MASK’
       drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.h:127:2: note: in expansion of macro ‘AUX_SF’
      
      Cc: Harry Wentland <harry.wentland@amd.com>
      Cc: Leo Li <sunpeng.li@amd.com>
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: "Christian König" <christian.koenig@amd.com>
      Cc: David Airlie <airlied@linux.ie>
      Cc: Daniel Vetter <daniel@ffwll.ch>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      3e3527f5
    • Dan Carpenter's avatar
      drm/amd/display: Fix off by one in hdmi_14_process_transaction() · 8e6fafd5
      Dan Carpenter authored
      The hdcp_i2c_offsets[] array did not have an entry for
      HDCP_MESSAGE_ID_WRITE_CONTENT_STREAM_TYPE so it led to an off by one
      read overflow.  I added an entry and copied the 0x0 value for the offset
      from similar code in drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c.
      
      I also declared several of these arrays as having HDCP_MESSAGE_ID_MAX
      entries.  This doesn't change the code, but it's just a belt and
      suspenders approach to try future proof the code.
      
      Fixes: 4c283fda ("drm/amd/display: Add HDCP module")
      Reviewed-by: default avatarBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
      Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      8e6fafd5
    • Colin Ian King's avatar
      drm/radeon: fix copy of uninitialized variable back to userspace · 8dbc2cca
      Colin Ian King authored
      Currently the ioctl command RADEON_INFO_SI_BACKEND_ENABLED_MASK can
      copy back uninitialised data in value_tmp that pointer *value points
      to. This can occur when rdev->family is less than CHIP_BONAIRE and
      less than CHIP_TAHITI.  Fix this by adding in a missing -EINVAL
      so that no invalid value is copied back to userspace.
      
      Addresses-Coverity: ("Uninitialized scalar variable)
      Cc: stable@vger.kernel.org # 3.13+
      Fixes: 439a1cff ("drm/radeon: expose render backend mask to the userspace")
      Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      8dbc2cca
    • Chen Li's avatar
      drm/amdgpu: correct DRM_ERROR for kvmalloc_array · 147ab7a1
      Chen Li authored
      This may avoid debug confusion.
      Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
      Signed-off-by: default avatarChen Li <chenli@uniontech.com>
      Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
      147ab7a1