- 29 Aug, 2017 1 commit
-
-
Rob Herring authored
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by:
Rob Herring <robh@kernel.org> Cc: Michal Simek <monstr@monstr.eu>
-
- 25 Aug, 2017 2 commits
-
-
Geert Uytterhoeven authored
Signed-off-by:
Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Andy Shevchenko authored
Use dedicated definition instead of plain -1 where it's appropriate. No functional change intended. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 24 Aug, 2017 2 commits
-
-
Bjorn Andersson authored
of_device_request_module() calls of_device_get_modalias() with "len" 0, to calculate the size of the buffer needed to store the result, but due to integer promotion the ssize_t "len" will be compared as unsigned with strlen(compat) and the loop will generally never break. This results in a call to snprintf() with a negative len, which triggers below warning, followed by a dereference of a invalid pointer: [ 3.060067] WARNING: CPU: 0 PID: 51 at lib/vsprintf.c:2122 vsnprintf+0x348/0x6d8 ... [ 3.060301] [<ffffff800891ede8>] vsnprintf+0x348/0x6d8 [ 3.060308] [<ffffff800891f248>] snprintf+0x48/0x50 [ 3.060316] [<ffffff80086a7c80>] of_device_get_modalias+0x108/0x160 [ 3.060322] [<ffffff80086a7cf8>] of_device_request_module+0x20/0x88 ... Further more of_device_get_modalias() is supposed to return the number of bytes needed to store the entire modalias, so the loop needs to continue accumulate the total size even though the buffer is full. Finally the function is not expected to ensure space for the NUL, nor include it in the returned size, so only 1 should be added to the length of "compat" in the loop (to account for the character 'C'). Fixes: bc575064 ("of/device: use of_property_for_each_string to parse compatible strings") Cc: Rob Herring <robh@kernel.org> Signed-off-by:
Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Bjorn Andersson authored
As of_device_get_modalias() returns the number of bytes that would have been written to the target string, regardless of how much did fit in the buffer, it's possible that the returned index points beyond the buffer passed to of_device_modalias() - causing memory beyond the buffer to be null terminated. Fixes: 0634c295 ("of: Add function for generating a DT modalias with a newline") Cc: Rob Herring <robh@kernel.org> Cc: stable@vger.kernel.org Signed-off-by:
Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 23 Aug, 2017 2 commits
-
-
Klaus Goger authored
TI AMC6821 fan controller and Intersil ISL1208 are trivial devices, so add them to the binding list. Signed-off-by:
Klaus Goger <klaus.goger@theobroma-systems.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Klaus Goger authored
Theobroma Systems is a design house specialized in embedded systems and a manufacturer of system-on-modules. Signed-off-by:
Klaus Goger <klaus.goger@theobroma-systems.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 21 Aug, 2017 4 commits
-
-
Masahiro Yamada authored
Since commit d5d332d3 ("devicetree: Move include prefixes from arch to separate directory"), cross-arch DT reference works well, but only for CPP style #include directives. It makes as much sense to share DT between different architectures by using DTC's /include/ directives. So, scripts/dtc/include-prefixes should be passed to both CPP and DTC. I refactored Makefile.lib a bit to not repeat the same path. Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Masahiro Yamada authored
Having arch/$(SRCARCH)/boot/dts as an include search path is not very useful these days because some architectures such as ARM64, MIPS have no DT in this directory. Instead, they have DT in vendor sub-directories. With some DT files in ARM and PowerPC fixed, we can now drop this include search path. Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Masahiro Yamada authored
This search path was added by commit b5190516 ("of: Move testcase FDT data into drivers/of"). At that time, it was needed for platform DT files to include testcase data. It became unnecessary when commit ae9304c9 ("Adding selftest testdata dynamically into live tree") introduced dynamic addition of testcase data, but it missed to delete this search path. Moreover, the directory drivers/of/testcase-data does not exist since commit 19fd7487 ("of/unittest: Rename selftest.c to unittest.c"). Signed-off-by:
Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sudeep Holla authored
Instead of the callsites choosing between of_cpu_device_node_get if the CPUs are registered as of_node is populated by then and of_get_cpu_node when the CPUs are not yet registered as CPU of_nodes are not yet stashed thereby needing to parse the device tree, we can call of_get_cpu_node in case the CPUs are not yet registered. This will allow to use of_cpu_device_node_get anywhere hiding the details from the caller. Cc: Rob Herring <robh+dt@kernel.org> Cc: Frank Rowand <frowand.list@gmail.com> Signed-off-by:
Sudeep Holla <sudeep.holla@arm.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 17 Aug, 2017 1 commit
-
-
Andreas Klinger authored
add trivial device tree binding "devantech,srf02" and "devantech,srf10" Signed-off-by:
Andreas Klinger <ak@it-klinger.de> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 14 Aug, 2017 1 commit
-
-
Kuninori Morimoto authored
Now, we can use of_graph_get_remote_endpoint(). Let's use it. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 10 Aug, 2017 1 commit
-
-
Alexandru Gagniuc authored
Adaptrum is a manufacturer of TV White Space (TVWS) wireless technology. Using dynamic spectrum access to deliver affordable internet connectivity over non-line-of-sight (NLOS) fixed wireless, Adaptrum is helping close the digital divide worldwide. Signed-off-by:
Alexandru Gagniuc <alex.g@adaptrum.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 09 Aug, 2017 1 commit
-
-
Philipp Zabel authored
The parallel display device tree binding documentation incorrectly lists the interface-pix-fmt property with underscores ("interface_pix_fmt"). This was never supported by any driver, and the DT example in the same file always contained the correct spelling ("interface-pix-fmt"). See commit 19022aaa ("staging: drm/imx: Add parallel display support") and commit 2d62da8e ("staging: drm/imx: Add devicetree binding documentation") for reference. Signed-off-by:
Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 03 Aug, 2017 1 commit
-
-
SZ Lin authored
Update vendor description to be the full name of the corporate entity with this prefix reference: [1]: http://tmsearch.uspto.gov/bin/showfield?f=doc&state=4806:26uh56.2.5Signed-off-by:
SZ Lin <sz.lin@moxa.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 01 Aug, 2017 3 commits
-
-
Rob Herring authored
The mirrors for old, but still referenced OF documents have disappeared. A new mirror has been setup on devicetree.org at: http://devicetree.org/open-firmware/home.html Update the URLs in the binding documents with the new mirror. Cc: Brian Norris <briannorris@chromium.org> Reviewed-by:
Harvey Hunt <harvey.hunt@imgtec.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Rob Herring authored
Convert the interrupts property parsing to use the OF property API instead of open coding the parsing of the raw property value. This saves a number of LoC, and the result is easier to read. Signed-off-by:
Rob Herring <robh@kernel.org>
-
Rob Herring authored
Instead of directly parsing the compatible property, use the of_property_for_each_string() helper to iterate over each compatible string. This reduces the LoC and makes the functions easier to understand. Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 24 Jul, 2017 6 commits
-
-
Icenowy Zheng authored
Allwinner H5 has a Mali-450 MP4 GPU, which has a reset line like other Allwinner SoCs with Mali Utgard, but it's a Mali-450, so it needs a new compatible. Add the new compatible to Mali Utgard binding document. Signed-off-by:
Icenowy Zheng <icenowy@aosc.io> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Kees Cook authored
Document the /chosen/kaslr-seed property (and its interaction with the EFI_RNG_PROTOCOL API). Thanks to Ard for clarifications. Signed-off-by:
Kees Cook <keescook@chromium.org> Acked-by:
Ard Biesheuvel <ard.biesheuvel@linaro.org> Acked-by:
Mark Rutland <mark.rutland@arm.com> Acked-by:
Will Deacon <will.deacon@arm.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sergei Shtylyov authored
of_pci_get_devfn() and of_pci_parse_bus_range() somehow didn't use of_property_read_u32_array() though it was long available, basically open-coding it. Using the modern DT API saves several bytes and also adds some prop sanity checks as a bonus... Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sergei Shtylyov authored
of_get_pci_domain_nr() somehow didn't use of_property_read_u32() though it was long available, basically open-coding it. Using the modern DT API saves several LoCs/bytes and also adds some prop sanity checks as a bonus... Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sergei Shtylyov authored
of_alias_scan() can use of_property_read_string() -- using the modern DT API adds some prop sanity checks as a bonus; it does add couple LoCs but only because the original code violated the 80-column limit... Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sergei Shtylyov authored
of_n_{addr|size}_cells() predate of_property_read_u32(), so they have to basically open-code it. Using the modern DT API saves several LoCs and also adds some prop sanity checks as a bonus... Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 21 Jul, 2017 3 commits
-
-
Shawn Lin authored
It was never used and could be removed, otherwise we could see a warning: drivers/of/address.c: In function 'of_pci_range_parser_one': drivers/of/address.c:277:14: warning: variable 'pci_space' set but not used [-Wunused-but-set-variable] Signed-off-by:
Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sergei Shtylyov authored
The DT interrupt parsing code predates of_property_read_u32(), so it has to basically open-code it. Using the modern DT API saves several LoCs and also adds some prop sanity checks as a bonus... Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sergei Shtylyov authored
The "interrupt-controller" property is boolean, i.e. has no value. The DT interrupt parsing code predates of_property_read_bool(), so it uses either of_get_property() or of_find_property() -- the former isn't quite correct for the boolean props (but works somehow). Use the modern boolean prop API instead. Signed-off-by:
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 20 Jul, 2017 3 commits
-
-
Frank Rowand authored
Add overlay __symbols__ properties to live tree when an overlay is added to the live tree so that the symbols are available to subsequent overlays. Expected test result is new __symbols__ entries for labels from the overlay after this commit. Before this commit: Console error message near end of unittest: ### dt-test ### FAIL of_unittest_overlay_high_level():2296 Adding overlay 'overlay_bad_symbol' failed ### dt-test ### end of unittest - 190 passed, 1 failed The new unittest "fails" because the expected result of loading the new overlay is an error instead of success. $ # node hvac-medium-2 exists because the overlay loaded $ # since the duplicate symbol was not detected $ cd /proc/device-tree/testcase-data-2/substation@100/ $ ls compatible hvac-medium-2 motor-8 reg hvac-large-1 linux,phandle name status hvac-medium-1 motor-1 phandle $ cd /proc/device-tree/__symbols__/ $ ls electric_1 lights_1 name rides_1 spin_ctrl_2 hvac_1 lights_2 retail_1 spin_ctrl_1 After this commit: Previous console error message no longer occurs, but expected error occurs: OF: overlay: Failed to apply prop @/__symbols__/hvac_1 OF: overlay: apply failed '/__symbols__' ### dt-test ### end of unittest - 191 passed, 0 failed $ # node hvac-medium-2 does not exist because the overlay $ # properly failed to load due to the duplicate symbol $ cd /proc/device-tree/testcase-data-2/substation@100/ $ ls compatible hvac-medium-1 motor-1 name reg hvac-large-1 linux,phandle motor-8 phandle status $ cd /proc/device-tree/__symbols__/ $ ls electric_1 lights_1 retail_1 ride_200_right spin_ctrl_2 hvac_1 lights_2 ride_200 rides_1 hvac_2 name ride_200_left spin_ctrl_1 $ cat ride_200; echo /testcase-data-2/fairway-1/ride@200 $ cat ride_200_left ; echo /testcase-data-2/fairway-1/ride@200/track@10 $ cat ride_200_right ; echo /testcase-data-2/fairway-1/ride@200/track@20 Signed-off-by:
Frank Rowand <frank.rowand@sony.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Frank Rowand authored
Correct existing node name detection when overlay node name has a unit-address. Expected test result is overlay will update the nodes and properties for /testcase-data-2/fairway-1/ride@100/ after this commit. Before this commit: Console error message near end of unittest: OF: Duplicate name in fairway-1, renamed to "ride@100#1" $ cd /proc/device-tree/testcase-data-2/fairway-1/ $ # extra node: ride@100#1 $ ls #address-cells linux,phandle phandle ride@200 #size-cells name ride@100 status compatible orientation ride@100#1 $ cd /proc/device-tree/testcase-data-2/fairway-1/ride@100/ $ ls track@30/incline-up ls: track@30/incline-up: No such file or directory $ ls track@40/incline-up ls: track@40/incline-up: No such file or directory After this commit: Console error message no longer occurs $ cd /proc/device-tree/testcase-data-2/fairway-1/ $ # no extra node: ride@100#1 $ ls #address-cells compatible name phandle ride@200 #size-cells linux,phandle orientation ride@100 status $ cd /proc/device-tree/testcase-data-2/fairway-1/ride@100/ $ ls track@30/incline-up track@30/incline-up $ ls track@40/incline-up track@40/incline-up Signed-off-by:
Frank Rowand <frank.rowand@sony.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Frank Rowand authored
Add nodes and properties to overlay_base and overlay dts files to test for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live tree The following console messages will appear near the end of unittest until the code errors are corrected: OF: Duplicate name in fairway-1, renamed to "ride@100#1" ### dt-test ### FAIL of_unittest_overlay_high_level():2296 Adding overlay 'overlay_bad_symbol' failed ### dt-test ### end of unittest - 190 passed, 1 failed Signed-off-by:
Frank Rowand <frank.rowand@sony.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 18 Jul, 2017 1 commit
-
-
Rob Herring authored
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 17 Jul, 2017 5 commits
-
-
Andrea Merello authored
The driver looks for "vib-overdrive-mv" property, while in documentation we have "vib-overdriver-mv". Fix the doc. Cc: Francesco Diotalevi <francesco.diotalevi@iit.it> Signed-off-by:
Andrea Merello <andrea.merello@gmail.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Suman Anna authored
The clock consumer usage description was erroneously referring to couple of dt-binding headers that are no longer valid. The definition and/or usage of these headers is incorrect and the only file present at the moment, dt-bindings/soc/k2g.h is also being cleaned up. The examples in this binding were updated properly, but the update to description was missed out. So, fix this. Fixes: 8f306cfe ("Documentation: dt: Add TI SCI clock driver") Signed-off-by:
Suman Anna <s-anna@ti.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Brian Masney authored
Add device tree documentation for the tsl2x7x IIO driver. Signed-off-by:
Brian Masney <masneyb@onstation.org> CC: Rob Herring <robh+dt@kernel.org> CC: Mark Rutland <mark.rutland@arm.com> CC: devicetree@vger.kernel.org Acked-by:
Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Sean Wang authored
This updates dt-binding documentation for MediaTek MT7622 and MT7623 SoC. For the both SoCs supported all rely on the fallback binding of the generic case with "mediatek,efuse". Signed-off-by:
Sean Wang <sean.wang@mediatek.com> Signed-off-by:
Andrew-CT Chen <andrew-ct.chen@mediatek.com> Reviewed-by:
Matthias Brugger <matthias.bgg@gmail.com> Signed-off-by:
Rob Herring <robh@kernel.org>
-
Brandon Streiff authored
checkpatch.pl doesn't know how to expand "silabs,si5351{a,a-msop,b,c}" and so generates warnings about si5351-compatible devices appearing to be un-documented. Resolve this by documenting the compatible options supported by the clk-si5351 driver individually. Signed-off-by:
Brandon Streiff <brandon.streiff@ni.com> Acked-by:
Stephen Boyd <sboyd@codeaurora.org> Signed-off-by:
Rob Herring <robh@kernel.org>
-
- 15 Jul, 2017 3 commits
-
-
Linus Torvalds authored
-
git://git.lwn.net/linuxLinus Torvalds authored
Pull documentation format standardization from Jonathan Corbet: "This series converts a number of top-level documents to the RST format without incorporating them into the Sphinx tree. The hope is to bring some uniformity to kernel documentation and, perhaps more importantly, have our existing docs serve as an example of the desired formatting for those that will be added later. Mauro has gone through and fixed up a lot of top-level documentation files to make them conform to the RST format, but without moving or renaming them in any way. This will help when we incorporate the ones we want to keep into the Sphinx doctree, but the real purpose is to bring a bit of uniformity to our documentation and let the top-level docs serve as examples for those writing new ones" * tag 'standardize-docs' of git://git.lwn.net/linux: (84 commits) docs: kprobes.txt: Fix whitespacing tee.txt: standardize document format cgroup-v2.txt: standardize document format dell_rbu.txt: standardize document format zorro.txt: standardize document format xz.txt: standardize document format xillybus.txt: standardize document format vfio.txt: standardize document format vfio-mediated-device.txt: standardize document format unaligned-memory-access.txt: standardize document format this_cpu_ops.txt: standardize document format svga.txt: standardize document format static-keys.txt: standardize document format smsc_ece1099.txt: standardize document format SM501.txt: standardize document format siphash.txt: standardize document format sgi-ioc4.txt: standardize document format SAK.txt: standardize document format rpmsg.txt: standardize document format robust-futexes.txt: standardize document format ...
-
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/randomLinus Torvalds authored
Pull random updates from Ted Ts'o: "Add wait_for_random_bytes() and get_random_*_wait() functions so that callers can more safely get random bytes if they can block until the CRNG is initialized. Also print a warning if get_random_*() is called before the CRNG is initialized. By default, only one single-line warning will be printed per boot. If CONFIG_WARN_ALL_UNSEEDED_RANDOM is defined, then a warning will be printed for each function which tries to get random bytes before the CRNG is initialized. This can get spammy for certain architecture types, so it is not enabled by default" * tag 'random_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/random: random: reorder READ_ONCE() in get_random_uXX random: suppress spammy warnings about unseeded randomness random: warn when kernel uses unseeded randomness net/route: use get_random_int for random counter net/neighbor: use get_random_u32 for 32-bit hash random rhashtable: use get_random_u32 for hash_rnd ceph: ensure RNG is seeded before using iscsi: ensure RNG is seeded before use cifs: use get_random_u32 for 32-bit lock random random: add get_random_{bytes,u32,u64,int,long,once}_wait family random: add wait_for_random_bytes() API
-