1. 01 Apr, 2020 3 commits
  2. 22 Mar, 2020 1 commit
  3. 17 Mar, 2020 1 commit
    • Hans de Goede's avatar
      HID: lg-g15: Do not fail the probe when we fail to disable F# emulation · b8a75ead
      Hans de Goede authored
      By default the G1-G12 keys on the Logitech gaming keyboards send
      F1 - F12 when in "generic HID" mode.
      
      The first thing the hid-lg-g15 driver does is disable this behavior.
      
      We have received a bugreport that this does not work when the keyboard
      is connected through an Aten KVM switch. Using a gaming keyboard with
      a KVM is a bit weird setup, but still we can try to fail a bit more
      gracefully here.
      
      On the G510 keyboards the same USB-interface which is used for the gaming
      keys is also used for the media-keys. Before this commit we would call
      hid_hw_stop() on failure to disable the F# emulation and then exit the
      probe method with an error code.
      
      This not only causes us to not handle the gaming-keys, but this also
      breaks the media keys which is a regression compared to the situation
      when these keyboards where handled by the generic hidinput driver.
      
      This commit changes the error handling to clear the hiddev drvdata
      (to disable our .raw_event handler) and then returning from the probe
      method with success.
      
      The net result of this is that, when connected through a KVM, things
      work as well as they did before the hid-lg-g15 driver was introduced.
      
      Fixes: ad4203f5 ("HID: lg-g15: Add support for the G510 keyboards' gaming keys")
      BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1806321Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      b8a75ead
  4. 16 Mar, 2020 2 commits
  5. 13 Mar, 2020 2 commits
  6. 11 Mar, 2020 2 commits
  7. 27 Feb, 2020 3 commits
    • Linus Torvalds's avatar
      Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid · 278de45e
      Linus Torvalds authored
      Pull HID subsystem fixes from Jiri Kosina:
      
       - syzkaller-reported error handling fixes in various drivers, from
         various people
      
       - increase of HID report buffer size to 8K, which is apparently needed
         by certain modern devices
      
       - a few new device-ID-specific fixes / quirks
      
       - battery charging status reporting fix in logitech-hidpp, from Filipe
         Laíns
      
      * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid:
        HID: hid-bigbenff: fix race condition for scheduled work during removal
        HID: hid-bigbenff: call hid_hw_stop() in case of error
        HID: hid-bigbenff: fix general protection fault caused by double kfree
        HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
        HID: alps: Fix an error handling path in 'alps_input_configured()'
        HID: hiddev: Fix race in in hiddev_disconnect()
        HID: core: increase HID report buffer size to 8KiB
        HID: core: fix off-by-one memset in hid_report_raw_event()
        HID: apple: Add support for recent firmware on Magic Keyboards
        HID: ite: Only bind to keyboard USB interface on Acer SW5-012 keyboard dock
        HID: logitech-hidpp: BatteryVoltage: only read chargeStatus if extPower is active
      278de45e
    • Linus Torvalds's avatar
      Merge tag 'docs-5.6-fixes' of git://git.lwn.net/linux · e46bfaba
      Linus Torvalds authored
      Pull documentation fixes from Jonathan Corbet:
       "A pair of docs-build fixes"
      
      * tag 'docs-5.6-fixes' of git://git.lwn.net/linux:
        docs: Fix empty parallelism argument
        docs: remove MPX from the x86 toc
      e46bfaba
    • Linus Torvalds's avatar
      Merge tag 'audit-pr-20200226' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit · ed5fa559
      Linus Torvalds authored
      Pull audit fixes from Paul Moore:
       "Two fixes for problems found by syzbot:
      
         - Moving audit filter structure fields into a union caused some
           problems in the code which populates that filter structure.
      
           We keep the union (that idea is a good one), but we are fixing the
           code so that it doesn't needlessly set fields in the union and mess
           up the error handling.
      
         - The audit_receive_msg() function wasn't validating user input as
           well as it should in all cases, we add the necessary checks"
      
      * tag 'audit-pr-20200226' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit:
        audit: always check the netlink payload length in audit_receive_msg()
        audit: fix error handling in audit_data_to_entry()
      ed5fa559
  8. 26 Feb, 2020 7 commits
    • Linus Torvalds's avatar
      Merge tag 'tag-chrome-platform-fixes-for-v5.6-rc4' of... · bfdc6d91
      Linus Torvalds authored
      Merge tag 'tag-chrome-platform-fixes-for-v5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux
      
      Pull chrome platform fix from Benson Leung:
       "Fix a build warning"
      
      * tag 'tag-chrome-platform-fixes-for-v5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux:
        platform/chrome: wilco_ec: Include asm/unaligned instead of linux/ path
      bfdc6d91
    • Linus Torvalds's avatar
      Merge tag 'trace-v5.6-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace · 91ad64a8
      Linus Torvalds authored
      Pull tracing and bootconfig updates:
       "Fixes and changes to bootconfig before it goes live in a release.
      
        Change in API of bootconfig (before it comes live in a release):
        - Have a magic value "BOOTCONFIG" in initrd to know a bootconfig
          exists
        - Set CONFIG_BOOT_CONFIG to 'n' by default
        - Show error if "bootconfig" on cmdline but not compiled in
        - Prevent redefining the same value
        - Have a way to append values
        - Added a SELECT BLK_DEV_INITRD to fix a build failure
      
        Synthetic event fixes:
        - Switch to raw_smp_processor_id() for recording CPU value in preempt
          section. (No care for what the value actually is)
        - Fix samples always recording u64 values
        - Fix endianess
        - Check number of values matches number of fields
        - Fix a printing bug
      
        Fix of trace_printk() breaking postponed start up tests
      
        Make a function static that is only used in a single file"
      
      * tag 'trace-v5.6-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
        bootconfig: Fix CONFIG_BOOTTIME_TRACING dependency issue
        bootconfig: Add append value operator support
        bootconfig: Prohibit re-defining value on same key
        bootconfig: Print array as multiple commands for legacy command line
        bootconfig: Reject subkey and value on same parent key
        tools/bootconfig: Remove unneeded error message silencer
        bootconfig: Add bootconfig magic word for indicating bootconfig explicitly
        bootconfig: Set CONFIG_BOOT_CONFIG=n by default
        tracing: Clear trace_state when starting trace
        bootconfig: Mark boot_config_checksum() static
        tracing: Disable trace_printk() on post poned tests
        tracing: Have synthetic event test use raw_smp_processor_id()
        tracing: Fix number printing bug in print_synth_event()
        tracing: Check that number of vals matches number of synth event fields
        tracing: Make synth_event trace functions endian-correct
        tracing: Make sure synth_event_trace() example always uses u64
      91ad64a8
    • Linus Torvalds's avatar
      Merge tag 'linux-kselftest-kunit-5.6-rc4' of... · b98cce1e
      Linus Torvalds authored
      Merge tag 'linux-kselftest-kunit-5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
      
      Pull Kunit fixes from Shuah Khan:
       "This Kselftest kunit update consists of fixes to documentation and
        the run-time tool from Brendan Higgins and Heidi Fahim"
      
      * tag 'linux-kselftest-kunit-5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest:
        kunit: run kunit_tool from any directory
        kunit: test: Improve error messages for kunit_tool when kunitconfig is invalid
        Documentation: kunit: fixed sphinx error in code block
      b98cce1e
    • Linus Torvalds's avatar
      Merge tag 'linux-kselftest-5.6-rc4' of... · 2fcc7417
      Linus Torvalds authored
      Merge tag 'linux-kselftest-5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
      
      Pull Kselftest fixes from Shuah Khan:
      
       - fixes to TIMEOUT failures and out-of-tree compilation compilation
         errors from Michael Ellerman.
      
       - declutter git status fix from Christophe Leroy
      
      * tag 'linux-kselftest-5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest:
        selftests/rseq: Fix out-of-tree compilation
        selftests: Install settings files to fix TIMEOUT failures
        selftest/lkdtm: Don't pollute 'git status'
      2fcc7417
    • Christoph Hellwig's avatar
      Revert "KVM: x86: enable -Werror" · cfe2ce49
      Christoph Hellwig authored
      This reverts commit ead68df9.
      
      Using the -Werror flag breaks the build for me due to mostly harmless
      KASAN or similar warnings:
      
        arch/x86/kvm/x86.c: In function ‘kvm_timer_init’:
        arch/x86/kvm/x86.c:7209:1: error: the frame size of 1112 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
      
      Feel free to add a CONFIG_WERROR if you care strong enough, but don't
      break peoples builds for absolutely no good reason.
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      cfe2ce49
    • Linus Torvalds's avatar
      signal: avoid double atomic counter increments for user accounting · fda31c50
      Linus Torvalds authored
      When queueing a signal, we increment both the users count of pending
      signals (for RLIMIT_SIGPENDING tracking) and we increment the refcount
      of the user struct itself (because we keep a reference to the user in
      the signal structure in order to correctly account for it when freeing).
      
      That turns out to be fairly expensive, because both of them are atomic
      updates, and particularly under extreme signal handling pressure on big
      machines, you can get a lot of cache contention on the user struct.
      That can then cause horrid cacheline ping-pong when you do these
      multiple accesses.
      
      So change the reference counting to only pin the user for the _first_
      pending signal, and to unpin it when the last pending signal is
      dequeued.  That means that when a user sees a lot of concurrent signal
      queuing - which is the only situation when this matters - the only
      atomic access needed is generally the 'sigpending' count update.
      
      This was noticed because of a particularly odd timing artifact on a
      dual-socket 96C/192T Cascade Lake platform: when you get into bad
      contention, on that machine for some reason seems to be much worse when
      the contention happens in the upper 32-byte half of the cacheline.
      
      As a result, the kernel test robot will-it-scale 'signal1' benchmark had
      an odd performance regression simply due to random alignment of the
      'struct user_struct' (and pointed to a completely unrelated and
      apparently nonsensical commit for the regression).
      
      Avoiding the double increments (and decrements on the dequeueing side,
      of course) makes for much less contention and hugely improved
      performance on that will-it-scale microbenchmark.
      
      Quoting Feng Tang:
      
       "It makes a big difference, that the performance score is tripled! bump
        from original 17000 to 54000. Also the gap between 5.0-rc6 and
        5.0-rc6+Jiri's patch is reduced to around 2%"
      
      [ The "2% gap" is the odd cacheline placement difference on that
        platform: under the extreme contention case, the effect of which half
        of the cacheline was hot was 5%, so with the reduced contention the
        odd timing artifact is reduced too ]
      
      It does help in the non-contended case too, but is not nearly as
      noticeable.
      Reported-and-tested-by: default avatarFeng Tang <feng.tang@intel.com>
      Cc: Eric W. Biederman <ebiederm@xmission.com>
      Cc: Huang, Ying <ying.huang@intel.com>
      Cc: Philip Li <philip.li@intel.com>
      Cc: Andi Kleen <andi.kleen@intel.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      fda31c50
    • Masami Hiramatsu's avatar
      bootconfig: Fix CONFIG_BOOTTIME_TRACING dependency issue · 2910b5aa
      Masami Hiramatsu authored
      Since commit d8a953dd ("bootconfig: Set CONFIG_BOOT_CONFIG=n by
      default") also changed the CONFIG_BOOTTIME_TRACING to select
      CONFIG_BOOT_CONFIG to show the boot-time tracing on the menu,
      it introduced wrong dependencies with BLK_DEV_INITRD as below.
      
      WARNING: unmet direct dependencies detected for BOOT_CONFIG
        Depends on [n]: BLK_DEV_INITRD [=n]
        Selected by [y]:
        - BOOTTIME_TRACING [=y] && TRACING_SUPPORT [=y] && FTRACE [=y] && TRACING [=y]
      
      This makes the CONFIG_BOOT_CONFIG selects CONFIG_BLK_DEV_INITRD to
      fix this error and make CONFIG_BOOTTIME_TRACING=n by default, so
      that both boot-time tracing and boot configuration off but those
      appear on the menu list.
      
      Link: http://lkml.kernel.org/r/158264140162.23842.11237423518607465535.stgit@devnote2
      
      Fixes: d8a953dd ("bootconfig: Set CONFIG_BOOT_CONFIG=n by default")
      Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Compiled-tested-by: default avatarRandy Dunlap <rdunlap@infradead.org>
      Signed-off-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      2910b5aa
  9. 25 Feb, 2020 5 commits
    • Linus Torvalds's avatar
      Merge tag 'riscv-for-linux-5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux · c5f86891
      Linus Torvalds authored
      Pull RISC-V fixes from Palmer Dabbelt:
       "This contains a handful of RISC-V related fixes that I've collected
        and would like to target for 5.6-rc4:
      
         - A fix to set up the PMPs on boot, which allows the kernel to access
           memory on systems that don't set up permissive PMPs before getting
           to Linux. This only effects machine-mode kernels, which currently
           means only NOMMU kernels.
      
         - A fix to avoid enabling supervisor-mode interrupts when running in
           machine-mode, also only for NOMMU kernels.
      
         - A pair of fixes to our KASAN support to avoid corrupting memory.
      
         - A gitignore fix.
      
        This boots on QEMU's virt board for me"
      
      * tag 'riscv-for-linux-5.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux:
        riscv: adjust the indent
        riscv: allocate a complete page size for each page table
        riscv: Fix gitignore
        RISC-V: Don't enable all interrupts in trap_init()
        riscv: set pmp configuration if kernel is running in M-mode
      c5f86891
    • Linus Torvalds's avatar
      Merge branch 'mips-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux · d67f250e
      Linus Torvalds authored
      Pull MIPS fixes from Paul Burton:
       "Here are a few MIPS fixes, and a MAINTAINERS update to hand over MIPS
        maintenance to Thomas Bogendoerfer - this will be my final pull
        request as MIPS maintainer.
      
        Thanks for your helpful comments, useful corrections & responsiveness
        during the time I've fulfilled the role, and I'm sure I'll pop up
        elsewhere in the tree somewhere down the line"
      
      * 'mips-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux:
        MAINTAINERS: Hand MIPS over to Thomas
        MIPS: ingenic: DTS: Fix watchdog nodes
        MIPS: X1000: Fix clock of watchdog node.
        MIPS: vdso: Wrap -mexplicit-relocs in cc-option
        MIPS: VPE: Fix a double free and a memory leak in 'release_vpe()'
        MIPS: cavium_octeon: Fix syncw generation.
        mips: vdso: add build time check that no 'jalr t9' calls left
        MIPS: Disable VDSO time functionality on microMIPS
        mips: vdso: fix 'jalr t9' crash in vdso code
      d67f250e
    • Kees Cook's avatar
      docs: Fix empty parallelism argument · adc10f5b
      Kees Cook authored
      When there was no parallelism (no top-level -j arg and a pre-1.7
      sphinx-build), the argument passed would be empty ("") instead of just
      being missing, which would (understandably) badly confuse sphinx-build.
      Fix this by removing the quotes.
      Reported-by: default avatarRafael J. Wysocki <rafael@kernel.org>
      Fixes: 51e46c7a ("docs, parallelism: Rearrange how jobserver reservations are made")
      Cc: stable@vger.kernel.org  # v5.5 only
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
      adc10f5b
    • Stephen Kitt's avatar
      docs: remove MPX from the x86 toc · 53ace119
      Stephen Kitt authored
      MPX was removed in commit 45fc24e8 ("x86/mpx: remove MPX from
      arch/x86"), this removes the corresponding entry in the x86 toc.
      
      This was suggested by a Sphinx warning.
      Signed-off-by: default avatarStephen Kitt <steve@sk2.org>
      Fixes: 45fc24e8 ("x86/mpx: remove MPX from arch/x86")
      Acked-by: default avatarDave Hansen <dave.hansen@intel.com>
      Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
      53ace119
    • Paul Burton's avatar
      MAINTAINERS: Hand MIPS over to Thomas · 3234f4ed
      Paul Burton authored
      My time with MIPS the company has reached its end, and so at best I'll
      have little time spend on maintaining arch/mips/.
      
      Ralf last authored a patch over 2 years ago, the last time he committed
      one is even further back & activity was sporadic for a while before
      that. The reality is that he isn't active.
      
      Having a new maintainer with time to do things properly will be
      beneficial all round. Thomas Bogendoerfer has been involved in MIPS
      development for a long time & has offered to step up as maintainer, so
      add Thomas and remove myself & Ralf from the MIPS entry.
      
      Ralf already has an entry in CREDITS to honor his contributions, so this
      just adds one for me.
      Signed-off-by: default avatarPaul Burton <paulburton@kernel.org>
      Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
      Acked-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
      Cc: Ralf Baechle <ralf@linux-mips.org>
      Cc: linux-kernel@vger.kernel.org
      Cc: linux-mips@vger.kernel.org
      3234f4ed
  10. 24 Feb, 2020 9 commits
  11. 23 Feb, 2020 5 commits
    • Linus Torvalds's avatar
      Merge tag 'for-5.6-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux · d2eee258
      Linus Torvalds authored
      Pull btrfs fixes from David Sterba:
       "These are fixes that were found during testing with help of error
        injection, plus some other stable material.
      
        There's a fixup to patch added to rc1 causing locking in wrong context
        warnings, tests found one more deadlock scenario. The patches are
        tagged for stable, two of them now in the queue but we'd like all
        three released at the same time.
      
        I'm not happy about fixes to fixes in such a fast succession during
        rcs, but I hope we found all the fallouts of commit 28553fa9
        ('Btrfs: fix race between shrinking truncate and fiemap')"
      
      * tag 'for-5.6-rc2-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux:
        Btrfs: fix deadlock during fast fsync when logging prealloc extents beyond eof
        Btrfs: fix btrfs_wait_ordered_range() so that it waits for all ordered extents
        btrfs: fix bytes_may_use underflow in prealloc error condtition
        btrfs: handle logged extent failure properly
        btrfs: do not check delayed items are empty for single transaction cleanup
        btrfs: reset fs_root to NULL on error in open_ctree
        btrfs: destroy qgroup extent records on transaction abort
      d2eee258
    • Linus Torvalds's avatar
      Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 · a3163ca0
      Linus Torvalds authored
      Pull ext4 fixes from Ted Ts'o:
       "More miscellaneous ext4 bug fixes (all stable fodder)"
      
      * tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:
        ext4: fix mount failure with quota configured as module
        jbd2: fix ocfs2 corrupt when clearing block group bits
        ext4: fix race between writepages and enabling EXT4_EXTENTS_FL
        ext4: rename s_journal_flag_rwsem to s_writepages_rwsem
        ext4: fix potential race between s_flex_groups online resizing and access
        ext4: fix potential race between s_group_info online resizing and access
        ext4: fix potential race between online resizing and write operations
        ext4: add cond_resched() to __ext4_find_entry()
        ext4: fix a data race in EXT4_I(inode)->i_disksize
      a3163ca0
    • Linus Torvalds's avatar
      Merge tag 'csky-for-linus-5.6-rc3' of git://github.com/c-sky/csky-linux · c6188dff
      Linus Torvalds authored
      Pull csky updates from Guo Ren:
       "Sorry, I missed 5.6-rc1 merge window, but in this pull request the
        most are the fixes and the rests are between fixes and features. The
        only outside modification is the MAINTAINERS file update with our
        mailing list.
      
         - cache flush implementation fixes
      
         - ftrace modify panic fix
      
         - CONFIG_SMP boot problem fix
      
         - fix pt_regs saving for atomic.S
      
         - fix fixaddr_init without highmem.
      
         - fix stack protector support
      
         - fix fake Tightly-Coupled Memory code compile and use
      
         - fix some typos and coding convention"
      
      * tag 'csky-for-linus-5.6-rc3' of git://github.com/c-sky/csky-linux: (23 commits)
        csky: Replace <linux/clk-provider.h> by <linux/of_clk.h>
        csky: Implement copy_thread_tls
        csky: Add PCI support
        csky: Minimize defconfig to support buildroot config.fragment
        csky: Add setup_initrd check code
        csky: Cleanup old Kconfig options
        arch/csky: fix some Kconfig typos
        csky: Fixup compile warning for three unimplemented syscalls
        csky: Remove unused cache implementation
        csky: Fixup ftrace modify panic
        csky: Add flush_icache_mm to defer flush icache all
        csky: Optimize abiv2 copy_to_user_page with VM_EXEC
        csky: Enable defer flush_dcache_page for abiv2 cpus (807/810/860)
        csky: Remove unnecessary flush_icache_* implementation
        csky: Support icache flush without specific instructions
        csky/Kconfig: Add Kconfig.platforms to support some drivers
        csky/smp: Fixup boot failed when CONFIG_SMP
        csky: Set regs->usp to kernel sp, when the exception is from kernel
        csky/mm: Fixup export invalid_pte_table symbol
        csky: Separate fixaddr_init from highmem
        ...
      c6188dff
    • Oliver Upton's avatar
      KVM: nVMX: Check IO instruction VM-exit conditions · 35a57134
      Oliver Upton authored
      Consult the 'unconditional IO exiting' and 'use IO bitmaps' VM-execution
      controls when checking instruction interception. If the 'use IO bitmaps'
      VM-execution control is 1, check the instruction access against the IO
      bitmaps to determine if the instruction causes a VM-exit.
      Signed-off-by: default avatarOliver Upton <oupton@google.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      35a57134
    • Oliver Upton's avatar
      KVM: nVMX: Refactor IO bitmap checks into helper function · e71237d3
      Oliver Upton authored
      Checks against the IO bitmap are useful for both instruction emulation
      and VM-exit reflection. Refactor the IO bitmap checks into a helper
      function.
      Signed-off-by: default avatarOliver Upton <oupton@google.com>
      Reviewed-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      e71237d3