- 01 Sep, 2016 32 commits
-
-
Anson Jacob authored
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Signed-off-by:
Anson Jacob <ansonjacob.aj@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anson Jacob authored
Fix checkpatch.pl warning for trailing */ on a separate line Remove '+' postfix and '-' prefix from the start and end of block comments Signed-off-by:
-
MingChia Chung authored
This patch fixes a minor checkpatch warnings: "WARNING: Block comments use a trailing */ on a separate line" Signed-off-by:
Ming-Chia Chung <Quexint@gmail.com> Signed-off-by:
-
Matthias Beyer authored
This patch removes the pointless `else if` test. Signed-off-by:
Matthias Beyer <mail@beyermatthias.de> Reported-by:
David Binderman <linuxdev.baldrick@gmail.com> Signed-off-by:
-
Binoy Jayan authored
The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it should be written as one. Semaphores are going away in the future. _enter_pwrlock was using down_interruptible(), so the lock could be broken by sending a signal. This could be a bug, because nothing checks the return code here. Hence, using mutex_lock instead of the interruptible version. Removing the now unused _enter_pwrlock and _down_sema. Signed-off-by:
Binoy Jayan <binoy.jayan@linaro.org> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Tested-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Didik Setiawan authored
Fix checkpatch.pl warning about "Alignment should match open parenthesis". Signed-off-by:
Didik Setiawan <ds@didiksetiawan.com> Signed-off-by:
-
Anson Jacob authored
Fix checkpatch.pl 'line over 80 characters' warning Signed-off-by:
-
Johanna Abrahamsson authored
Remove the function ion_handle_buffer since it is not used anywhere. Signed-off-by:
Johanna Abrahamsson <johanna@mjao.org> Acked-by:
Laura Abbott <labbott@redhat.com> Signed-off-by:
-
Johanna Abrahamsson authored
It is not necessary to save the return value of kref_put since it is directly returned. Signed-off-by:
-
Ben LeMasurier authored
This fixes remaining checkpatch.pl "Alignment should match open parenthesis" issues. Signed-off-by:
Ben LeMasurier <ben@crypt.ly> Signed-off-by:
-
Johanna Abrahamsson authored
Alignment should match open parenthesis as per checkpatch.pl. Signed-off-by:
-
Aaro Koskinen authored
Configure rx-delay/tx-delay when available. Signed-off-by:
Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Johanna Abrahamsson authored
It is not neccessary to save the value of ion_handle_validate since it is only used once. Signed-off-by:
-
Johanna Abrahamsson authored
The ion_free_nolock() function should not BUG on a handle client mismatch. Signed-off-by:
-
Colin Ian King authored
trivial fix to spelling mistake in dev_err message Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Julia Lawall authored
Check for ethtool_ops structures that are only stored in the ethtool_ops field of a net_device structure or passed as the second argument to netdev_set_default_ethtool_ops. These contexts are declared const, so ethtool_ops structures that have these properties can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct ethtool_ops i@p = { ... }; @ok1@ identifier r.i; struct net_device e; position p; @@ e.ethtool_ops = &i@p; @ok2@ identifier r.i; expression e; position p; @@ netdev_set_default_ethtool_ops(e, &i@p) @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct ethtool_ops i = { ... }; // </smpl> Suggested-by:
Stephen Hemminger <stephen@networkplumber.org> Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Oleg Drokin authored
%ul definitely was supposed to be %lu in the format string, so we print long unsigned int value, not just unsigned int with a letter l added at the end. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
-
Julia Lawall authored
lmv_proc_target_fops, of type struct file_operations, is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by:
-
Julia Lawall authored
sops, of type struct seq_operations, is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by:
-
Julia Lawall authored
lprocfs_generic_fops, of type struct file_operations, is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by:
-
Julia Lawall authored
obd_psdev_fops, of type struct file_operations, is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by:
-
Arnd Bergmann authored
After a code cleanup, we get a harmless warning about a variable that is unused when CONFIG_FS_POSIX_ACL is disabled: drivers/staging/lustre/lustre/llite/xattr.c: In function 'll_xattr_get_common': drivers/staging/lustre/lustre/llite/xattr.c:312:24: error: unused variable 'lli' [-Werror=unused-variable] This puts the variable declaration into the same #ifdef. Signed-off-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
Arnd Bergmann authored
A patch to change to page accounting code (in v4.8-rc1) conflicts with a change to lustre (in staging-next for v4.9), and fortunately gets detected using a gcc warning: In file included from /git/arm-soc/include/linux/mm.h:1001:0, from /git/arm-soc/include/linux/highmem.h:7, from /git/arm-soc/drivers/staging/lustre/lustre/osc/../../include/linux/libcfs/linux/libcfs.h:46, from /git/arm-soc/drivers/staging/lustre/lustre/osc/../../include/linux/libcfs/libcfs.h:36, from /git/arm-soc/drivers/staging/lustre/lustre/osc/osc_cl_internal.h:45, from /git/arm-soc/drivers/staging/lustre/lustre/osc/osc_page.c:40: drivers/staging/lustre/lustre/osc/osc_page.c: In function 'unstable_page_accounting': include/linux/vmstat.h:117:2: error: array subscript is above array bounds [-Werror=array-bounds] atomic_long_add(x, &vm_zone_stat[item]); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/vmstat.h:117:2: error: array subscript is above array bounds [-Werror=array-bounds] atomic_long_add(x, &vm_zone_stat[item]); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This changes the function to use the correct interface for accounting in the "node" rather than the "zone". Signed-off-by: -
James Simmons authored
Currently it is not possible to send LNet traffic between two nodes using infiniband hardware that have different page sizes for the case when RDMA fragments are used. When two nodes establish a connection they tell the other node the maximum number of RDMA fragments they support. The issue is that the units are pages, and 256 64K pages corresponds to 16MB of data, whereas a 4K page system is limited to messages with 1MB of data. The solution is to report over the wire the maximum number of fragments in 4K unites regardless of the native page size. The recipient then uses its native page size to translate into the maximum number of pages sized fragments it can send to the other node. Signed-off-by:
James Simmons <uja.ornl@yahoo.com> Reviewed-on: http://review.whamcloud.com/21304 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7650Reviewed-by:
Doug Oucharek <doug.s.oucharek@intel.com> Reviewed-by:
Olaf Weber <olaf@sgi.com> Signed-off-by:
-
John L. Hammond authored
In lustre_fill_super() if lustre_start_mgc() fails then call lustre_common_put_super() to release a reference on the MGC device attached to the LSI. Signed-off-by:
John L. Hammond <john.hammond@intel.com> Reviewed-on: http://review.whamcloud.com/20851 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8297Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
Mike Pershin <mike.pershin@intel.com> Signed-off-by:
-
Lokesh Nagappa Jaliminche authored
ll_find_alias is responsible for getting alias for inode which can be reused. Directories are assumed to have unique alias, where in case of non-directories there can be multiple aliases. In case of lustre there can be two type of aliases i.e. discon_alias and invalid_alias. Usage of discon_alias in case of non-directories may corrupt dcache and leads to kernel crash. Changes made to avoid use of discon_alias in case of non-directories. Seagate-bug-id: MRP-2739, MRP-3601 Signed-off-by:
Lokesh Nagappa Jaliminche <lokesh.jaliminche@seagate.com> Reviewed-by:
Ujjwal Lanjewar <ujjwal.lanjewar@seagate.com> Reviewed-by:
Ashish Purkar <ashish.purkar@seagate.com> Reviewed-by:
Andrew Perepechko <andrew.perepechko@seagate.com> Tested-by:
Parinay Vijayprakash Kondekar <parinay.kondekar@seagate.com> Reviewed-on: http://review.whamcloud.com/17732 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7613Reviewed-by:
Niu Yawei <yawei.niu@intel.com> Signed-off-by:
-
Dmitry Eremin authored
Remove useless LASSERT(vma->vm_file) because of if it's NULL it will crash early in file_inode(vma->vm_file). Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-on: http://review.whamcloud.com/21171 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8372Reviewed-by:
Bob Glossman <bob.glossman@intel.com> Signed-off-by:
-
Yang Sheng authored
The return value is ignored in client_common_fill_super. Restore to check it and error out. Signed-off-by:
Yang Sheng <yang.sheng@intel.com> Reviewed-on: http://review.whamcloud.com/21125 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8360Reviewed-by:
Emoly Liu <emoly.liu@intel.com> Reviewed-by:
-
Andrew Perepechko authored
The patch removes find_cbdata callbacks and clear_nlink from dentry_iput path, since this piece of code makes a few races possible. The test case reproduces one of the possible races described in LU-7925: 1) two hard links are created for the same file 2) the test calls stat(2) for link #1 3) in the middle of 2) the test opens and closes link #2 4) in the middle of 2) the test drops the ldlm locks and forces dentry reclaim via vm.drop_caches=2 5) in the middle of 2) ll_d_iput() clears i_nlink for the inode 6) the initial stat(2) continues and copies the wrong i_nlink value into st_nlink Signed-off-by:
Wally Wang <wang@cray.com> Reviewed-by:
Lai Siyao <lai.siyao@intel.com> Signed-off-by:
-
Alexander Boyko authored
Assertion was happened for open request when rq_replay is set to 1. ASSERTION(mod->mod_open_req->rq_replay == 0) But this situation is not fatal for client, and could happened when mdc_close() failed. The fix allow to free such requests. If mdc_close fail, MDS doesn`t receive close request from client. And in a worst case client would be evicted. The test recreates issue when mdc_close failed and client asserts: ASSERTION( mod->mod_open_req->rq_replay == 0 ) failed Signed-off-by:Alexander Boyko <alexander.boyko@seagate.com> Seagate-bug-id: MRP-3156 Reviewed-on: http://review.whamcloud.com/17495 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5282Reviewed-by:
Alex Zhuravlev <alexey.zhuravlev@intel.com> Reviewed-by:
-
John L. Hammond authored
Change the __u64 *cookie parameter of md_ops->set_lock_data() to const struct lustre_handle *lockh. Signed-off-by:
Frank Zago <fzago@cray.com> Reviewed-by:
-
Daeseok Youn authored
The dgnc_maxcps_room() function must be called only for print device. The if-statement for checking print device checks before calling dgnc_maxcps_room() and also this function doesn't need to have any data except channel_t. Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
- 31 Aug, 2016 7 commits
-
-
Anson Jacob authored
Fix checkpath.pl warning: trailing statements should be on next line open brace '{' following function declarations go on the next line Signed-off-by: -
Sudip Mukherjee authored
sparse was warning about incorrect type of argument: drivers/staging/i4l/icn/icn.c:1048:49: warning: incorrect type in argument 2 (different address spaces) drivers/staging/i4l/icn/icn.c:1048:49: expected void const [noderef] <asn:1>*from drivers/staging/i4l/icn/icn.c:1048:49: got unsigned char const [usertype] *buf drivers/staging/i4l/icn/icn.c:1476:38: warning: incorrect type in argument 1 (different address spaces) drivers/staging/i4l/icn/icn.c:1476:38: expected unsigned char const [usertype] *buf drivers/staging/i4l/icn/icn.c:1476:38: got unsigned char const [noderef] [usertype] <asn:1>*buf The function icn_writecmd() was used to copy from userspace and also from the kernelspace. Add another argument to the function to have two separate pointers, one for the userspace and one for the kernelspace. Based on the value of user as passed from the caller we use one of the two pointers. Signed-off-by:
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Signed-off-by:
-
Sudip Mukherjee authored
Blank lines are not needed after starting brace or before a closing brace. Signed-off-by:
-
Sudip Mukherjee authored
No need provide a space after a typecast. Signed-off-by:
-
Sudip Mukherjee authored
The macro EVAL_PLCI and MAKE_PLCI are not being used. Remove them. But keep the comment preceding them as it contains information regarding message format. Signed-off-by:
-
Sudip Mukherjee authored
The macro EVAL_NCCI was only being used in capi.c and the argument controller was not used. Remove the argument and at the same time remove the variable which now becomes unused. Signed-off-by:
-
Sudip Mukherjee authored
Its better to use memdup_user which does the same thing which this code has implemented. Also removed a related warning as we will be warned if allocation fails. Suggested-by:
Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
- 30 Aug, 2016 1 commit
-
-
Anson Jacob authored
Fix checkpatch.pl warning for line over 80 characters Signed-off-by:
-
