1. 29 Jul, 2022 1 commit
  2. 25 Jul, 2022 2 commits
    • Artem Bityutskiy's avatar
      intel_idle: make SPR C1 and C1E be independent · 1548fac4
      Artem Bityutskiy authored
      This patch partially reverts the changes made by the following commit:
      
      da0e58c0 intel_idle: add 'preferred_cstates' module argument
      
      As that commit describes, on early Sapphire Rapids Xeon platforms the C1 and
      C1E states were mutually exclusive, so that users could only have either C1 and
      C6, or C1E and C6.
      
      However, Intel firmware engineers managed to remove this limitation and make C1
      and C1E to be completely independent, just like on previous Xeon platforms.
      
      Therefore, this patch:
       * Removes commentary describing the old, and now non-existing SPR C1E
         limitation.
       * Marks SPR C1E as available by default.
       * Removes the 'preferred_cstates' parameter handling for SPR. Both C1 and
         C1E will be available regardless of 'preferred_cstates' value.
      
      We expect that all SPR systems are shipping with new firmware, which includes
      the C1/C1E improvement.
      
      Cc: v5.18+ <stable@vger.kernel.org> # v5.18+
      Signed-off-by: default avatarArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
      Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
      1548fac4
    • Waiman Long's avatar
      intel_idle: Fix false positive RCU splats due to incorrect hardirqs state · d295ad34
      Waiman Long authored
      Commit 32d4fd57 ("cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE")
      uses raw_local_irq_enable/local_irq_disable() around call to
      __intel_idle() in intel_idle_irq().
      
      With interrupt enabled, timer tick interrupt can happen and a
      subsequently call to __do_softirq() may change the lockdep hardirqs state
      of a debug kernel back to 'on'. This will result in a mismatch between
      the cpu hardirqs state (off) and the lockdep hardirqs state (on) causing
      a number of false positive "WARNING: suspicious RCU usage" splats.
      
      Fix that by using local_irq_disable() to disable interrupt in
      intel_idle_irq().
      
      Fixes: 32d4fd57 ("cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE")
      Signed-off-by: default avatarWaiman Long <longman@redhat.com>
      Cc: 5.16+ <stable@vger.kernel.org> # 5.16+
      Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
      d295ad34
  3. 24 Jul, 2022 6 commits
  4. 23 Jul, 2022 2 commits
  5. 22 Jul, 2022 15 commits
  6. 21 Jul, 2022 14 commits