- 05 Mar, 2024 12 commits
-
-
Philipp Hortmann authored
Remove unused variables bIsQosData and RxIs40MHzPacket as they are set and never evaluated. Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/7a8b579fd3d377fa961fe71e37fe4afa22f2a3b9.1708461563.git.philipp.g.hortmann@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Philipp Hortmann authored
Remove unused variable bShift as it is set and never evaluated. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables Wakeup, Reserved0 and AGC. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables tsf, beacon_time and Antenna. Signed-off-by:
-
Ricardo B. Marliere authored
Since commit 43a7206b ("driver core: class: make class_register() take a const *"), the driver core allows for struct class to be in read-only memory, so move the fieldbus_class structure to be declared at build time placing it into read-only memory, instead of having to be dynamically allocated at boot time. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by:
"Ricardo B. Marliere" <ricardo@marliere.net> Link: https://lore.kernel.org/r/20240301-class_cleanup-staging-v1-1-34db2a5b0eb0@marliere.netSigned-off-by:
-
John Garry authored
The version is same as the default, so don't bother filling it in. Signed-off-by:
John Garry <john.g.garry@oracle.com> Link: https://lore.kernel.org/r/20240222090042.12609-4-john.g.garry@oracle.comSigned-off-by:
-
Moritz C. Weber authored
Reformat function parameters to fix checkpatch check: Increase readability and consistency Signed-off-by:
"Moritz C. Weber" <mo.c.weber@gmail.com> Link: https://lore.kernel.org/r/20240219112234.8673-3-mo.c.weber@gmail.comSigned-off-by:
-
Moritz C. Weber authored
Remove blank line to fix checkpatch check: Increase readability and consistency Signed-off-by:
-
Kees Cook authored
FORTIFY_SOURCE has been ignoring 0-sized destinations while the kernel code base has been converted to flexible arrays. In order to enforce the 0-sized destinations (e.g. with __counted_by), the remaining 0-sized destinations need to be handled. Instead of converting an empty struct into using a flexible array, just directly use a pointer without any additional indirection. Remove struct gb_bootrom_get_firmware_response and struct gb_fw_download_fetch_firmware_response. Signed-off-by:
Kees Cook <keescook@chromium.org> Reviewed-by:
Alex Elder <elder@linaro.org> Link: https://lore.kernel.org/r/20240304211940.it.083-kees@kernel.orgSigned-off-by:
-
Dan Carpenter authored
The get_channel_from_mode() function is supposed to return the channel which matches the mode. But it has a bug where if it doesn't find a matching channel then it returns the last channel. It should return NULL instead. Also remove an unnecessary NULL check on "channel". Fixes: 2870b52b ("greybus: lights: add lights implementation") Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by:
Rui Miguel Silva <rmfrfs@gmail.com> Reviewed-by:
-
Colin Ian King authored
The variable mask is being assigned and bit-set but it is never being used apart from this. The variable is redundant and can be removed. Cleans up clang scan build warning: drivers/staging/greybus/audio_topology.c:764:15: warning: variable 'mask' set but not used [-Wunused-but-set-variable] Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Acked-by:
Vaibhav Agarwal <vaibhav.sr@gmail.com> Link: https://lore.kernel.org/r/20240229120541.219429-1-colin.i.king@gmail.comSigned-off-by:
-
Erick Archer authored
When a struct containing a flexible array is included in another struct, and there is a member after the struct-with-flex-array, there is a possibility of memory overlap. These cases must be audited [1]. See: struct inner { ... int flex[]; }; struct outer { ... struct inner header; int overlap; ... }; This is the scenario for the "struct audio_apbridgea_hdr" structure that is included in the following "struct audio_apbridgea_*_request" structures: struct audio_apbridgea_set_config_request struct audio_apbridgea_register_cport_request struct audio_apbridgea_unregister_cport_request struct audio_apbridgea_set_tx_data_size_request struct audio_apbridgea_prepare_tx_request struct audio_apbridgea_start_tx_request struct audio_apbridgea_stop_tx_request struct audio_apbridgea_shutdown_tx_request struct audio_apbridgea_set_rx_data_size_request struct audio_apbridgea_prepare_rx_request struct audio_apbridgea_start_rx_request struct audio_apbridgea_stop_rx_request struct audio_apbridgea_shutdown_rx_request The pattern is like the one shown below: struct audio_apbridgea_hdr { ... __u8 data[]; } __packed; struct audio_apbridgea_*_request { struct audio_apbridgea_hdr hdr; ... } __packed; In this case, the trailing flexible array can be removed because it is never used. Link: https://github.com/KSPP/linux/issues/202 [1] Signed-off-by:Erick Archer <erick.archer@gmx.com> Reviewed-by:
Mark Greer <mgreer@animalcreek.com> Link: https://lore.kernel.org/r/20240217154758.7965-1-erick.archer@gmx.comSigned-off-by:
-
- 19 Feb, 2024 2 commits
-
-
Marc Dietrich authored
replace old/implemented items with new todo list Signed-off-by:
Marc Dietrich <marvin24@gmx.de> Link: https://lore.kernel.org/r/20240218212557.22836-2-marvin24@gmx.deSigned-off-by:
-
Marc Dietrich authored
Update the comment before the udelay on how to replace it. Signed-off-by:
-
- 17 Feb, 2024 26 commits
-
-
Ricardo B. Marliere authored
Since commit aed65af1 ("drivers: make device_type const"), the driver core can properly handle constant struct device_type. Move the wwan_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Signed-off-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the vme_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the vchiq_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the anybus_bus variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Christophe JAILLET authored
sysfs_read() is anly called from _show() functions declared by DEVICE_ATTR_RW(). Using sysfs_emit() is the preferred style and here, it saves a useless copy and a temporary buffer in the stack. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/588327734f374b5f5cb5c4d5725d884fdc83663e.1707654406.git.christophe.jaillet@wanadoo.frSigned-off-by:
-
Michael Straube authored
Initialize two variables at declaration instead of first declare and then initialize them. This saves a line of code and clears a checkpatch warning. WARNING: Missing a blank line after declarations Signed-off-by:
Michael Straube <straube.linux@gmail.com> Tested-by:
-
Michael Straube authored
Remove return from the void function rtl92e_set_channel. Found by checkpatch. WARNING: void function return statements are not generally useful Signed-off-by:
-
Michael Straube authored
Remove braces from single statement blocks to clear some checkpatch warnings. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Tree Davies authored
Rename variable bForcedBgMode to forced_bg_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-19-tdavies@darkphysics.netSigned-off-by:
-
Tree Davies authored
Rename variable NumRecvBcnInPeriod to num_recv_bcn_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LpsIdleCount to lps_idle_count to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable Octet to octet to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Add a space in front of statement to fix checkpatch warning: Alignment should match open parenthesis Signed-off-by:
-
Tree Davies authored
Remove blank line to fix checkpatch warning: Blank lines aren't necessary before a close brace '}' Signed-off-by:
-
Tree Davies authored
Join broken lines across if statement to fix checkpatch warning: Lines should not end with a '(' Signed-off-by: -
Tree Davies authored
Join 2 lines to fix Warning: Alignment should match open parenthesis Signed-off-by:
-
Tree Davies authored
Rename variable SelfHTCap to self_ht_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LPSAwakeIntvl to lps_awake_intvl to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable PeerHTInfoBuf to peer_ht_info_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable PeerHTCapBuf to peer_ht_cap_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename function MgntQuery_TxRateExcludeCCKRates to mgnt_query_tx_rate_exclude_cck_rates to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename function pointer SetHwRegHandler to set_hw_reg_handler to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LPSDelayCnt to lps_delay_cnt to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LPSAwakeIntvl_tmp to lps_awake_intvl_tmp to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename function rtllib_rx_ADDBARsp to rtllib_rx_add_ba_rsp to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable FirstIe_InScan to first_ie_in_scan to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
