1. 26 Aug, 2006 8 commits
    • Hans de Goede's avatar
      [PATCH] hwmon: abituguru timeout fixes · faf9b616
      Hans de Goede authored
      This patch contains 2 sets of fixes for the abituguru:
       1) Much improved timeout handling, drasticly reducing the amount of
          timeout errors on some motherboards
       2) Fix the exit paths in the bank1 sensor type detect code to always
          restore the original settings even on an error. Without this our
          special test settings could remain seriously confusing the system
          BIOS's setup menu.
      
      Both are very much related and are must haves, to avoid messing up the
      uguru CMOS settings.
      
      Detailed changes:
      - Much improved timeout / wait for status handling. Many thanks to Sunil
        Kumar, for all his testing, ideas and patches! The code now first busy
        waits, polling the uguru for the expected status as this usually
        succeeds pretty quickly (within 90 reads). To avoid unnecessary CPU burn
        in timeout conditions, the amount of busy waiting has been halved from
        previous versions (120 tries instead of 250). This is not a problem,
        because this version goes to sleep after 120 attemps for 1 jiffy and
        then tries again, it does this sleep and try again 5 times before
        finally giving up. This (almost?) completly removes the timeout errors
        some people have seen regulary. Apparently some older uguru versions
        sometimes are distracted for a (relatively) long time. This solves this.
      - These timeout errors not only occur in the sending address part of
        reading the uguru but also in the wait for read state, so errors in
        this state are now handled as retryable just like send address state
        errors and are only logged and reported to userspace if 3 executive
        tries fail.
      - Fix a very nasty bug in the bank1 sensor type detection code, where it
        would not restore the original settings in any of the error paths!
      - Since not successfully restoring the original settings can seriously
        confuse the system BIOS (hang when entering the relevant setup menu),
        we now try restoring them 3 times before giving up.
      Signed-off-by: default avatarHans de Goede <j.w.r.degoede@hhs.nl>
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      faf9b616
    • David Brownell's avatar
      [PATCH] i2c: tps65010 build fixes · 4801bc25
      David Brownell authored
      The tps65010.c driver in the main tree never got updated with
      build fixes since the last batch of I2C driver changes; and the
      genirq trigger flags were updated wierdly too.
      
      This also includes a minor tweak to reduce the frequency used to
      poll for unplug-the-AC-power on the TPS chips that don't provide
      relevant IRQs.  It _would_ be nice to sense whether there's even
      a battery, but that'd normally be an HDQ/1-wire interface to a
      smart battery, and such APIs aren't standardized.
      Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      4801bc25
    • Greg Kroah-Hartman's avatar
    • Mike Christie's avatar
      [SCSI] fix scsi_send_eh_cmnd regression · 0db99e33
      Mike Christie authored
      The callers of scsi_send_eh_cmnd are setting the cmnd buffer,
      and then scsi_send_eh_cmnd is copying that updated buffer to
      the old_cmnd variable. Then after the command runs, we end up
      copying that old_cmnd var which has the new cmnd to the scsi
      command buffer. When this command gets recent, all types of fun
      things happen like getting TUR or START_STOP commands with
      data and scatterlists.
      
      This patch made against scsi-rc-fixes, has the callers of
      scsi_send_eh_cmnd pass in the command so scsi_send_eh_cmnd
      can do the right thing. This should go into 2.6.18 since this
      fixes a regression added when we removed some of the scsi_cmnd
      fields and replaced them with local variables.
      Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      0db99e33
    • Andrew Vasquez's avatar
    • Andrew Vasquez's avatar
      [SCSI] qla2xxx: Properly re-enable EFT support after an ISP abort. · 476e8978
      Andrew Vasquez authored
      Software must explicitely re-enable extended firmware tracing
      after any ISP abort condition.
      Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      476e8978
    • Andrew Vasquez's avatar
      [SCSI] qla2xxx: Correct PLOGI retry logic. · 9c06938a
      Andrew Vasquez authored
      Original code attempts to retry PLOGIs to fcports that are
      FCP_TARGETs only.  If the driver never performed a successful
      PLOGI/PRLI, the port-type would never be assigned, and the
      relogin logic would silently drop the request (and thus the port
      would not be recognized and registered).
      
      The fix is relatively straightforward, drop the FCP_TARGET-only
      check.
      Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      9c06938a
    • Douglas Gilbert's avatar
      [SCSI] sg: fix incorrect page problem · b2155d04
      Douglas Gilbert authored
      There's a problem where sg is executing a ->nopage operation on a
      compound page, it actually calls get_page() on the first page in the
      compound rather than the page which is being mapped.  The fix is to
      select the correct page by indexing into the compound.
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      b2155d04
  2. 25 Aug, 2006 1 commit
  3. 24 Aug, 2006 31 commits