- 07 Mar, 2017 10 commits
-
-
Gargi Sharma authored
The structure is used as an argument to module_param macro. This macro calls a bunch of other macros and finally assigns the instance of the kernel_param_ops structure to the const struct kernel_param_ops* field of a variable of type kernel_param. Hence, const can be added to the structure. Coccinelle Script: @r disable optional_qualifier@ identifier i; position p; @@ static struct kernel_param_ops i@p = { ... }; @ok1@ identifier r.i; expression e; position p; @@ e = i@p @script:python s@ i << r.i; t; @@ coccinelle.t = i[10:]; @ok2@ declarer name module_param; expression e1,e2; position p; @@ module_param(e1,s.t@p,e2); @bad@ position p != {r.p,ok1.p,ok2.p}; identifier r.i; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct kernel_param_ops i = { ... }; Signed-off-by:Gargi Sharma <gs051095@gmail.com> Reviewed-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Mario Bambagini authored
fixed the following sparse warning by adding proper cast: drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: incorrect type in argument 2 (different address spaces) drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: expected char const [noderef] <asn:1>*<noident> drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: got char *[assigned] sval Signed-off-by:
Mario Bambagini <mario.bambagini@gmail.com> Acked-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Using LINUXINCLUDE is a very old hack, and doesn't play well with building objects in a different directory than the kernel source is in. So fix up the include file references to be relative to make it obvious we are pulling in local include files, which need to get fixed up. Reported-by:
kbuild test robot <fengguang.wu@intel.com> Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Cc: Alan Cox <alan@linux.intel.com> Signed-off-by:
-
simran singhal authored
This patch replace "is is " with "is". The replacement couldn't be automated because sometimes the first "is" was meant to be another word. Signed-off-by:
simran singhal <singhalsimran0@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
Jonathan Bowie authored
Fixed incosistent spacing around arithmetic operator. Signed-off-by:
Jonathan Bowie <eudjtb@gmail.com> Reviewed-by:
Johan Hovold <johan@kernel.org> Acked-by:
-
Aishwarya Pant authored
udelay is impelmented using a busy-wait loop and consumes CPU cycles while usleep_range is implemented using interrupts.cls_flush_uart_write() is called after a channel lock is acquired i.e. an atomic context. Hence delay in this method should use udelay instead of usleep_range. Signed-off-by:
Aishwarya Pant <aishpant@gmail.com> Signed-off-by:
-
Gargi Sharma authored
The ktermios structure is a local default termios struct. All ports are initially created with this termios. Since, the structure is never modified, it can be declared as const. Coccinelle Script: @r disable optional_qualifier@ identifier s,i; position p; @@ static struct ktermios i@p = { ... }; @ok1@ identifier r.i; expression e; position p; @@ e = i@p @bad@ position p != {r.p,ok1.p}; identifier r.i; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct ktermios i = { ... }; File Size before: text data bss dec hex filename 25469 2048 256 27773 6c7d drivers/staging/dgnc/dgnc_tty.o File Size after: text data bss dec hex filename 25636 2016 256 27908 6d04 drivers/staging/dgnc/dgnc_tty.o Signed-off-by: -
Arushi Singhal authored
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by:
Arushi Singhal <arushisinghal19971997@gmail.com> Signed-off-by:
-
Arushi Singhal authored
function prototype argument should have an identifier name as reported by checkpatch.pl. Signed-off-by:
-
Arushi Singhal authored
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by:
-
- 06 Mar, 2017 30 commits
-
-
Aishwarya Pant authored
use min_t() macro in place of min() to replace the two typecasts of min. Change suggested by checkpatch script. Signed-off-by:
-
Aishwarya Pant authored
Fix the following checkpatch warning issued on bcm2835-vchiq.c: CHECK: Alignment should match open parenthesis Signed-off-by:
-
Aishwarya Pant authored
fix typo in word receives Signed-off-by:
-
Aishwarya Pant authored
Add braces on all arms of the if-else statements in bcm2835-vchiq.c to comply with kernel coding style. Signed-off-by:
-
Aishwarya Pant authored
Remove instances of unnecessary blank space after cast in bcm2835-vchiq.c Signed-off-by:
-
Aishwarya Pant authored
Use dev_err(... in place of printk(KERN_ERR ... Problem found by checkpatch Signed-off-by:
-
Aishwarya Pant authored
Fix the warning: Blank lines aren't necessary after an open brace '{' issued by checkpatch on bcm2835-ctl.c Signed-off-by: -
Aishwarya Pant authored
Fix block comment formatting to suppress the following warning thrown by checkpatch: Block comments use a trailing */ on a separate line Signed-off-by:
-
Aishwarya Pant authored
Keep logical continuations on the same line to improve code readability Signed-off-by:
-
Aishwarya Pant authored
Remove instances of unnecessary blank space after cast in bcm2835-ctl.c Signed-off-by:
-
Michael Zoran authored
Change the camera's dependency on BCM2835_VCHIQ to a select since camera support is typically more important to people then base VCHIQ(which they may not even know what it's for). Also, with a dependency the camera support would not be visiable until VCHIQ is selected first, and that may not be what most people would expect. Signed-off-by:
Michael Zoran <mzoran@crowfest.net> Signed-off-by:
-
Michael Zoran authored
Change the audio's dependency on BCM2835_VCHIQ to a select since audio support is typically more important to people then base VCHIQ(which they may not even know what it's for). Also, with a dependency the audio support would not be visiable until VCHIQ is selected first, and that may not be what most people would expect. Signed-off-by:
-
Michael Zoran authored
Create a new memuconfig for Broadcom VideoCore services since VideoCore is a general term used by Broadcom for a large family of products that includes more then the BCM2835. Signed-off-by:
-
Aishwarya Pant authored
staging: bcm2835-camera: prefer allocating memory using sizeof(*ptr) instead of sizeof(struct type name) Using sizeof(*ptr) instead of sizeof(struct type name) is more robust to errors. Signed-off-by:
-
Narcisa Ana Maria Vasile authored
This patch fixes the checkpatch.pl issue: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by:
Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com> Signed-off-by:
-
Narcisa Ana Maria Vasile authored
This patch fixes the checkpatch.pl issue: CHECK: spaces preferred around that '<<' (ctx:VxV) Signed-off-by:
-
Narcisa Ana Maria Vasile authored
This patch fixes the checkpatch.pl issue: CHECK: Please don't use multiple blank lines Signed-off-by:
-
Narcisa Ana Maria Vasile authored
Instead of storing the result, make the function return directly Signed-off-by:
-
Alan Cox authored
Certain combinations of compiler and compiler options product an imx.o that calls compiler helpers for a u64 divide. Use the do_div() call instead. Signed-off-by:
Alan Cox <alan@linux.intel.com> Signed-off-by:
-
Greg Kroah-Hartman authored
Merge tag 'iio-for-4.12a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next Jonathan writes: First set of IIO new device support, features and cleanup for the 4.12 cycle. Quite a bit of outreachy activity here with a driver from a current intern and a number of cleanup patches as part of the next round. Getting a pull request in early this cycle as it's looking like another large cycle for IIO. New device support * adxl345 - initial device support. Note, once complete support is done the intent is to superceded the driver in input/misc. - bindings. - conversion from i2c direct calls to regmap and driver split. - spi support. * chromeos light and proximity. - new driver. * devantech srf04 ultrasonic ranger - new driver with device tree bindings. * hid temperature - new driver for environemntal temperature support from hid devices. * max30102 oximeter - new driver with device tree bindings. * st lsm6dsx - refactor and addition of device support for lsm6dsl and lsm6ds3h. Staging graduation * isl29028 including copyright notice update to reflect Brian's work. * lpc32xx_adc. * spear adc. It's not perfect and there are some datasheet disagreements, but it works and is good enough to graduate. New features * documentation - abi docs for in_proximity_sampling_frequency_available. - generalise counting direction ABI docs as a second driver is going to use them. * hid-sensor-prox - Add support for HID_USAGE_SENSOR_HUMAN_PRESENCE if used on a particular device. * isl29028 - runtime pm. * meson-saradc - switch from polling to interrupt mode and improved read_raw_sample function to avoid unnecessary loop. * tmp007 - interrupt and threshold event support. Cleanups and minor fixes * ad2s1210 - permissions to octal. * ad7192 - permissions to octal. - use BIT macro. * ad9832 - merge header definitions into source file. * ad9834 - merge header definitions into source file. * ade7753 - merge header definitions into source file. - cleanup include ordering. * ade7854 - simplify return logic. * adis16201 - merge header definitions into source file. - rename _core.c to .c as there is nothing else. * adis16203 - merge header definitions into source file. - rename _core.c to .c as there is nothing else. * adis16209 - merge header definitions into source file. - rename _core.c to .c as there is nothing else. * adis16240 - permissions to octal. - merge header definitions into source file. - rename _core.c to .c as there is nothing else. * adt7136 - permissions to octal. * cio-dac - set missing parent device. * documentation - update version numbers on sysfs ABI for counter bits that didn't quite. make 4.9. * isl29028 - mdelay to msleep. - incorrrect sleep time when taking first proximity reading. * lmp91000 - set missing parent device. * lpc32xx - Consistent prefixes for defines. - rename local state structure to _state. * max30100 - set missing parent device. * max30102 - set missing parent device. * maxim-thermocouple - set missing parent device. * meter driver header - permissions to octal. * pulsedlight-lidar-lite-v2 - set missing parent device. * quad-8 - set missing parent device. * st104 - set missing parent device. Other * Mailmap - update Matt Ranostay's email address to the Konsolko one.
-
Alan Cox authored
The two drivers were originally merged by tools, and the tools didn't always spot white space only changes. Fix a few of them found by zero-day and clean up some more by hand. Signed-off-by:
-
Varsha Rao authored
Replaced x == NULL with !x, by using the following coccinelle script: @disable is_null@ expression e; @@ -e==NULL +!e This patch fixes the checkpatch issue. Signed-off-by:
Varsha Rao <rvarsha016@gmail.com> Signed-off-by:
-
Varsha Rao authored
Correct the spelling of initialize. This patch fixes the checkpatch issue. Signed-off-by:
-
Varsha Rao authored
Usage of unsigned int is preferred over unsigned and this patch fixes the checkpatch issue. Signed-off-by:
-
Varsha Rao authored
This patch fixes the checkpatch issue by removing the Free Software Foundation's mailing address from the sample GPL notice. Because the FSF has changed address in the past, and may change again. Linux already includes a copy of the GPL. Signed-off-by:
-
Varsha Rao authored
Used kernel preferred block commenting style, to fix the following checkpatch issue: WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
-
Varsha Rao authored
Replaced 'uint32_t' with kernel type u32, to fix the checkpatch issue. Signed-off-by:
-
Varsha Rao authored
Added spaces around arithmetic operators (/, *, +) and bitwise operators (<<, >>), to fix the checkpatch issue. Signed-off-by:
-
Varsha Rao authored
Line over 80 characters are split to fix the following checkpatch issue: WARNING: line over 80 characters Signed-off-by:
-
Varsha Rao authored
Removed parentheses on the right hand side of assignment, as they are not required. The following coccinelle script is used to fix this issue: @@ binary operator op = {<<,>>,+,/}; local idexpression id; expression e1, e2; @@ id = -( e1 op e2 -) Signed-off-by:
-
