1. 13 Apr, 2010 1 commit
    • Sage Weil's avatar
      ceph: queue_cap_snap should always queue dirty context · fc837c8f
      Sage Weil authored
      This simplifies the calling convention, and fixes a bug where we queue a
      capsnap with a context other than i_head_snapc (the one that matches the
      dirty pages).  The result was a BUG at fs/ceph/caps.c:2178 on writeback
      completion when a capsnap matching the writeback snapc could not be found.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      fc837c8f
  2. 12 Apr, 2010 1 commit
  3. 09 Apr, 2010 1 commit
  4. 02 Apr, 2010 1 commit
  5. 01 Apr, 2010 3 commits
    • Sage Weil's avatar
      ceph: fix leaked inode ref due to snap metadata writeback race · 819ccbfa
      Sage Weil authored
      We create a ceph_cap_snap if there is dirty cap metadata (for writeback to
      mds) OR dirty pages (for writeback to osd).  It is thus possible that the
      metadata has been written back to the MDS but the OSD data has not when
      the cap_snap is created.  This results in a cap_snap with dirty(caps) == 0.
      The problem is that cap writeback to the MDS isn't necessary, and a
      FLUSHSNAP cap op gets no ack from the MDS.  This leaves the cap_snap
      attached to the inode along with its inode reference.
      
      Fix the problem by dropping the cap_snap if it becomes 'complete' (all
      pages written out) and dirty(caps) == 0 in ceph_put_wrbuffer_cap_refs().
      
      Also, BUG() in __ceph_flush_snaps() if we encounter a cap_snap with
      dirty(caps) == 0.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      819ccbfa
    • Sage Weil's avatar
      ceph: fix snap context reference leaks · 6298a337
      Sage Weil authored
      The get_oldest_context() helper takes a reference to the returned snap
      context, but most callers weren't dropping that reference.  Fix them.
      
      Also drop the unused locked __get_oldest_context() variant.
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      6298a337
    • Sage Weil's avatar
      ceph: allow writeback of snapped pages older than 'oldest' snapc · 80e755fe
      Sage Weil authored
      On snap deletion, we don't regenerate ceph_cap_snaps for inodes with dirty
      pages because deletion does not affect metadata writeback.  However, we
      did run into problems when we went to write back the pages because the
      'oldest' snapc is determined by the oldest cap_snap, and that may be the
      newer snapc that reflects the deletion.  This caused confusion and an
      infinite loop in ceph_update_writeable_page().
      
      Change the snapc checks to allow writeback of any snapc that is equal to
      OR older than the 'oldest' snapc.
      
      When there are no cap_snaps, we were also using the realm's latest snapc
      for writeback, which complicates ceph_put_wrbufffer_cap_refs().  Instead,
      use i_head_snapc, the most snapc used for the most recent ('head') data.
      This makes the writeback snapc (ceph_osd_request.r_snapc) _always_ match a
      capsnap or i_head_snapc.
      
      Also, in writepags_finish(), drop the snapc referenced by the _page_
      and do not assume it matches the request snapc (it may not anymore).
      Signed-off-by: default avatarSage Weil <sage@newdream.net>
      80e755fe
  6. 30 Mar, 2010 7 commits
  7. 29 Mar, 2010 26 commits