1. 12 Nov, 2020 13 commits
  2. 11 Nov, 2020 10 commits
  3. 10 Nov, 2020 6 commits
  4. 09 Nov, 2020 2 commits
    • Stefano Brivio's avatar
      tunnels: Fix off-by-one in lower MTU bounds for ICMP/ICMPv6 replies · 77a2d673
      Stefano Brivio authored
      Jianlin reports that a bridged IPv6 VXLAN endpoint, carrying IPv6
      packets over a link with a PMTU estimation of exactly 1350 bytes,
      won't trigger ICMPv6 Packet Too Big replies when the encapsulated
      datagrams exceed said PMTU value. VXLAN over IPv6 adds 70 bytes of
      overhead, so an ICMPv6 reply indicating 1280 bytes as inner MTU
      would be legitimate and expected.
      
      This comes from an off-by-one error I introduced in checks added
      as part of commit 4cb47a86 ("tunnels: PMTU discovery support
      for directly bridged IP packets"), whose purpose was to prevent
      sending ICMPv6 Packet Too Big messages with an MTU lower than the
      smallest permissible IPv6 link MTU, i.e. 1280 bytes.
      
      In iptunnel_pmtud_check_icmpv6(), avoid triggering a reply only if
      the advertised MTU would be less than, and not equal to, 1280 bytes.
      
      Also fix the analogous comparison for IPv4, that is, skip the ICMP
      reply only if the resulting MTU is strictly less than 576 bytes.
      
      This becomes apparent while running the net/pmtu.sh bridged VXLAN
      or GENEVE selftests with adjusted lower-link MTU values. Using
      e.g. GENEVE, setting ll_mtu to the values reported below, in the
      test_pmtu_ipvX_over_bridged_vxlanY_or_geneveY_exception() test
      function, we can see failures on the following tests:
      
                   test                | ll_mtu
        -------------------------------|--------
        pmtu_ipv4_br_geneve4_exception |   626
        pmtu_ipv6_br_geneve4_exception |  1330
        pmtu_ipv6_br_geneve6_exception |  1350
      
      owing to the different tunneling overheads implied by the
      corresponding configurations.
      Reported-by: default avatarJianlin Shi <jishi@redhat.com>
      Fixes: 4cb47a86 ("tunnels: PMTU discovery support for directly bridged IP packets")
      Signed-off-by: default avatarStefano Brivio <sbrivio@redhat.com>
      Link: https://lore.kernel.org/r/4f5fc2f33bfdf8409549fafd4f952b008bf04d63.1604681709.git.sbrivio@redhat.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      77a2d673
    • Oliver Herms's avatar
      IPv6: Set SIT tunnel hard_header_len to zero · 8ef9ba4d
      Oliver Herms authored
      Due to the legacy usage of hard_header_len for SIT tunnels while
      already using infrastructure from net/ipv4/ip_tunnel.c the
      calculation of the path MTU in tnl_update_pmtu is incorrect.
      This leads to unnecessary creation of MTU exceptions for any
      flow going over a SIT tunnel.
      
      As SIT tunnels do not have a header themsevles other than their
      transport (L3, L2) headers we're leaving hard_header_len set to zero
      as tnl_update_pmtu is already taking care of the transport headers
      sizes.
      
      This will also help avoiding unnecessary IPv6 GC runs and spinlock
      contention seen when using SIT tunnels and for more than
      net.ipv6.route.gc_thresh flows.
      
      Fixes: c5441932 ("GRE: Refactor GRE tunneling code.")
      Signed-off-by: default avatarOliver Herms <oliver.peter.herms@gmail.com>
      Acked-by: default avatarWillem de Bruijn <willemb@google.com>
      Link: https://lore.kernel.org/r/20201103104133.GA1573211@twsSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      8ef9ba4d
  5. 07 Nov, 2020 5 commits
  6. 06 Nov, 2020 4 commits
    • KP Singh's avatar
      bpf: Update verification logic for LSM programs · 6f64e477
      KP Singh authored
      The current logic checks if the name of the BTF type passed in
      attach_btf_id starts with "bpf_lsm_", this is not sufficient as it also
      allows attachment to non-LSM hooks like the very function that performs
      this check, i.e. bpf_lsm_verify_prog.
      
      In order to ensure that this verification logic allows attachment to
      only LSM hooks, the LSM_HOOK definitions in lsm_hook_defs.h are used to
      generate a BTF_ID set. Upon verification, the attach_btf_id of the
      program being attached is checked for presence in this set.
      
      Fixes: 9e4e01df ("bpf: lsm: Implement attach, detach and execution")
      Signed-off-by: default avatarKP Singh <kpsingh@google.com>
      Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
      Link: https://lore.kernel.org/bpf/20201105230651.2621917-1-kpsingh@chromium.org
      6f64e477
    • Linus Torvalds's avatar
      Merge branch 'mtd/fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux · bf3e7628
      Linus Torvalds authored
      Pull mtd fixes from Miquel Raynal.
      
      * 'mtd/fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux:
        mtd: rawnand: stm32_fmc2: fix broken ECC
        mtd: spi-nor: Fix address width on flash chips > 16MB
        mtd: spi-nor: Don't copy self-pointing struct around
        mtd: rawnand: ifc: Move the ECC engine initialization to the right place
        mtd: rawnand: mxc: Move the ECC engine initialization to the right place
      bf3e7628
    • Linus Torvalds's avatar
      Merge tag 'spi-fix-v5.10-rc2-2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi · 44d80621
      Linus Torvalds authored
      Pull spi fix from Mark Brown:
       "This is an additional fix on top of 5e31ba0c ('spi: bcm2835: fix
        gpio cs level inversion') - when sending my prior pull request I had
        misremembred the status of that patch, apologies for the noise here"
      
      * tag 'spi-fix-v5.10-rc2-2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
        spi: bcm2835: remove use of uninitialized gpio flags variable
      44d80621
    • Linus Torvalds's avatar
      Merge tag 'sound-5.10-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · bb72bbe8
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "Quite a bunch of small fixes that have been gathered since the last
        pull, including changes like below:
      
         - HD-audio runtime PM fixes and refactoring
      
         - HD-audio and USB-audio quirks
      
         - SOF warning fix
      
         - Various ASoC device-specific fixes for Intel, Qualcomm, etc"
      
      * tag 'sound-5.10-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (26 commits)
        ALSA: usb-audio: Add implicit feedback quirk for Qu-16
        ASoC: mchp-spdiftx: Do not set Validity bit(s)
        ALSA: usb-audio: Add implicit feedback quirk for MODX
        ALSA: usb-audio: add usb vendor id as DSD-capable for Khadas devices
        ALSA: hda/realtek - Enable headphone for ASUS TM420
        ALSA: hda: prevent undefined shift in snd_hdac_ext_bus_get_link()
        ASoC: qcom: lpass-cpu: Fix clock disable failure
        ASoC: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions
        ASoC: codecs: wcd9335: Set digital gain range correctly
        ASoC: codecs: wcd934x: Set digital gain range correctly
        ALSA: hda: Reinstate runtime_allow() for all hda controllers
        ALSA: hda: Separate runtime and system suspend
        ALSA: hda: Refactor codec PM to use direct-complete optimization
        ALSA: hda/realtek - Fixed HP headset Mic can't be detected
        ALSA: usb-audio: Add implicit feedback quirk for Zoom UAC-2
        ALSA: make snd_kcontrol_new name a normal string
        ALSA: fix kernel-doc markups
        ASoC: SOF: loader: handle all SOF_IPC_EXT types
        ASoC: cs42l51: manage mclk shutdown delay
        ASoC: qcom: sdm845: set driver name correctly
        ...
      bb72bbe8