• Nirbhay Choubey's avatar
    Bug#16066243 PB2 FAILURES I_MAIN.BUG15912213 AND · 138217a2
    Nirbhay Choubey authored
        I_MAIN.CTYPE_UTF8 FOR MACOSX10.6 FOR 5.1
    
    While converting directory name to filename, a
    file separator (FN_LIBCHAR) might get appended
    to the resulting file name. This can result in
    off-by-one error when length of the input string
    is equal to FN_REFLEN. In this case, the terminating
    '\0' gets written beyond the buffer allocated to store
    the result.
    
    Fixed by incrementing the dst buffer size by 1. As
    extra safety, switched to strnmov() and added a debug
    assert to check the length of the input file name.
    
    No test case added as the scenario is already
    covered by the test cases added for bugs in
    the description.
    138217a2
my_lib.c 15.1 KB