• unknown's avatar
    Making rpl_until more robust if machine is slow. Removing rpl_trunc_binlog · 1a260574
    unknown authored
    which is wrong now that slave recovers gracefully from a crashed binlog (thx Serg).
    stat -> my_stat in my_copy.c so that failing stat() does not hang client connection.
    
    
    BitKeeper/deleted/.del-rpl_trunc_binlog.test~961b1f6ac73d37c8:
      Delete: mysql-test/t/rpl_trunc_binlog.test
    BitKeeper/deleted/.del-rpl_trunc_binlog.result~14b4a61886a332e8:
      Delete: mysql-test/r/rpl_trunc_binlog.result
    mysql-test/std_data/trunc_binlog.000001:
      Rename: BitKeeper/deleted/.del-trunc_binlog.000001~b504d840c7efde25 -> mysql-test/std_data/trunc_binlog.000001
    mysql-test/t/rpl_until.test:
      making test more robust if machine is slow. We still need to sleep before testing if slave SQL thread stopped, because otherwise it may not have started yet when we test for stop, then we would return too early. When we have "START SLAVE" wait a few secs until slave threads actually started well (WL#2688) these "sleep 2" could be removed.
    mysys/my_copy.c:
      Using my_stat() instead of stat(). Reason is that my_stat() reports an error message if wanted (MY_WME),
      which is critical for an error being sent to the client. Before this patch, a failing stat() caused
      the client connection to hang (because error was not set because my_error was never called).
      Adding an assertion to match the comment at the start of the function.
    1a260574
my_copy.c 3.66 KB