• Guilhem Bichot's avatar
    Fix for Valgrind errors when running rt_test and ma_rt_test, and segmentation fault · f89c61f5
    Guilhem Bichot authored
    in ma_rt_test -M (BUG#36321); keyinfo/recinfo/keyseg had non-initialized parts.
    maria_scan() was not wrapped in maria_scan_init()/end() so "ma_rt_test -M" found no rows.
    Preparing for inclusion into ma_test_all-t and ma_test_recovery.pl (still prevented by
    BUG#37307 "Maria: R-tree unit test produces corrupted table").
    
    storage/maria/ma_rt_test.c:
      Some members of keyinfo, recinfo, keyseg had non-initialized parts, led to Valgrind errors,
      and also segmentation fault when running with -M (=BLOCK_RECORD) (BUG#36321).
      We now bzero them like they are in mi_test1.
      Other problems:
      - maria_scan() was not wrapped in maria_scan_init()/end() so "ma_rt_test -M" found no rows.
      - --silent had almost no effect, now it really silences normal output.
      - Some errors were going to stdout, they now go to stderr.
      Added option for testing versioning, to fit well into ma_test_all-t.
    storage/maria/unittest/ma_test_all-t:
      preparing for running ma_rt_test when ma_rt_test remaining bugs are fixed
    storage/maria/unittest/ma_test_recovery.pl:
      preparing for running ma_rt_test when ma_rt_test remaining bugs are fixed
    storage/myisam/rt_test.c:
      Some members of keyinfo, recinfo, keyseg were not initialized, led to Valgrind errors.
      We now bzero them like they are in mi_test1.
    f89c61f5
rt_test.c 11.2 KB