• Michael Widenius's avatar
    Aria issues: · 26565ae1
    Michael Widenius authored
    - Fix for LP#700623 "Aria recovery: ma_blockrec.c:3930: _ma_update_at_original_place: Assertion `block->org_bitmap_value == _ma_bitmap_get_page_bits(info, &info->s->bitmap, page)' failed"
      - Issue was that when deleting a tail page where all index entries where full, the page was marked wrongly in the bitmap.
    - If debug_assert_if_crashed_table is set, we now crash when we find Aria corrupted.
    - Write more information if we find something wrong with the bitmap.
    - Fixed that REPAIR also can fix wrong create_rename_lsn issues (a very unlikely event)
    - Define STATE_CRASHED_FLAGS as set of all CRASHED flags (to simplify code)
    
    
    storage/maria/ha_maria.cc:
      Mark the normal page cache (not the page cache for the logs) so that we can request extra debugging for it.
      Copy the value of debug_assert_if_crashed_table to maria_assert_if_crashed_table so that we can request a crash at exactly the point where we find Aria corrupted.
      Use STATE_CRASHED_FLAGS
    storage/maria/ma_bitmap.c:
      Made bits_to_txt extern so that we can use this in maria_chk
      Added extra information to the log files to be able to easier find bitmap failures in recovery. (When compiling with -DEXTRA_DEBUG_BITMAP)
      Added _ma_get_bitmap_description() to request a clear text description of the bitmap.
      Simplify _ma_check_bitmap_data(), as we know the bitmap pattern in the caller.
    storage/maria/ma_blockrec.c:
      In delete_head_or_tail(), fixed a bug where we sent wrong information to _ma_bitmap_set() if the directory was full for a page that should be freed.
      This fixed LP#700623 (failure in bitmap found during recovery)
    storage/maria/ma_blockrec.h:
      Added definitions for _ma_get_bitmap_description() and bits_to_txt
    storage/maria/ma_check.c:
      Simplify call to _ma_check_bitmap_data().
      Write more information if we find something wrong with the bitmap.
      Moved getting clear text information about the bitmap to ma_bitmap.c::_ma_get_bitmap_description()
    storage/maria/ma_checkpoint.c:
      More asserts
    storage/maria/ma_create.c:
      Fix wrong create_rename_lsn during repair.
      (Create_rename_lsn can be too big if someone restores an old maria_log_file after an Aria file was created)
    storage/maria/ma_delete.c:
      Call _ma_set_fatal_error() in case of crashed file
      Remove not needed test of save_errno == HA_ERR_KEY_NOT_FOUND. (Handled by other code
    storage/maria/ma_extra.c:
      Call _ma_set_fatal_error() in case of crashed file
      Reset share->bitmap.changed_not_flushed to not cause new ASSERTS to trigger.
      Added _ma_file_callback_to_id() for writing share->id to log file in case of DEBUG logging.
    storage/maria/ma_init.c:
      Destroy also translog if it's readonly (as when called by maria_read_log -d)
    storage/maria/ma_key.c:
      Call _ma_set_fatal_error() in case of crashed file
    storage/maria/ma_key_recover.c:
      STATE_CRASHED -> STATE_CRASHED_FLAGS
    storage/maria/ma_keycache.c:
      Call _ma_set_fatal_error() in case of crashed file
    storage/maria/ma_locking.c:
      Call _ma_set_fatal_error() in case of crashed file.
      Added _ma_set_fatal_error()
    storage/maria/ma_open.c:
      Call _ma_set_fatal_error() in case of crashed file
    storage/maria/ma_page.c:
      Call _ma_set_fatal_error() in case of crashed file
    storage/maria/ma_pagecache.c:
      Added extra information to log file to simply debugging of bitmap errors.
    storage/maria/ma_pagecache.h:
      Added extra_debug flag to allow marking of row and index cache for extra logging (for debugging).
    storage/maria/ma_panic.c:
      Flush both data and index blocks in case of HA_PANIC_CLOSE
      Fixed wrong position of 'break'. (Not critical for MariaDB as MariaDB never uses this code)
    storage/maria/ma_recovery_util.c:
      Avoid writing extra not needed \n to DBUG log.
    storage/maria/ma_rkey.c:
      Call _ma_set_fatal_error() in case of crashed file
    storage/maria/ma_search.c:
      Call _ma_set_fatal_error() in case of crashed file
    storage/maria/ma_static.c:
      Define maria_assert_if_crashed_table
    storage/maria/ma_update.c:
      Call _ma_set_fatal_error() in case of crashed file.
      The new code also avoids a problem where we before would print the error twice.
    storage/maria/ma_write.c:
      Call _ma_set_fatal_error() in case of crashed file
    storage/maria/maria_chk.c:
      STATE_CRASHED -> STATE_CRASHED_FLAGS
    storage/maria/maria_def.h:
      Added STATE_CRASHED_PRINTED to avoid giving error message about crash twice.
      Added STATE_CRASHED_FLAGS to be able to easily detect and set all CRASHED related flags.
      Added prototypes for new functions.
    storage/myisam/mi_panic.c:
      Fixed wrong position of 'break'. (Not critical for MariaDB as MariaDB never uses this code)
    26565ae1
ma_recovery_util.c 4.84 KB