• unknown's avatar
    Fixes during review of new code · 306ebf7b
    unknown authored
    - Mostly indentation fixes
    - Added missing test
    - Ensure that Item_func_case() checks for stack overruns
    - Use real_item() instead of (Item_ref*) item
    - Fixed wrong error handling
    
    
    myisam/mi_unique.c:
      Improved comments
    myisam/myisampack.c:
      Updated version number
    mysql-test/r/group_by.result:
      Added test that was lost during earlier merge
    mysql-test/r/information_schema.result:
      Safety fix: Drop procedures before used
    mysql-test/t/group_by.test:
      Added test that was lost during earlier merge
    mysql-test/t/information_schema.test:
      Safety fix: Drop procedures before used
    mysys/hash.c:
      Updated comment
    sql/field.cc:
      false -> FALSE
    sql/ha_ndbcluster.cc:
      Fix some style issues
      - No () around argument to 'case'
      - Space before ( in switch and if
      - Removed 'goto'
      - Added {}
      - Added () to make expressions easier to read
      - my_snprintf -> strmov
    sql/handler.cc:
      if( -> if (
    sql/item.cc:
      Indentation changes
    sql/item.h:
      false -> FALSE
    sql/item_cmpfunc.cc:
      Ensure that Item_func_case() check for stack overrun properly
    sql/item_cmpfunc.h:
      Ensure that Item_func_case() check for stack overrun properly
    sql/item_func.cc:
      Indentation fixes
      Fixed wrong goto label
    sql/mysqld.cc:
      Remove test for opt_disable_networking as this flag can never be set here
    sql/opt_range.cc:
      Simplify code
    sql/sql_class.h:
      Move define out from middle of class definition
    sql/sql_parse.cc:
      Remove extra empty lines
    sql/sql_select.cc:
      use real_item() instead of (Item_ref*) item
      Modifed function comment to be align with others
      Simple optimization
    sql/sql_union.cc:
      Portability fix:
      Don't use 'bool_variable|=...'
    sql/sql_view.cc:
      Move List_iterator_fast out from loops (rewind is faster than creating a new itearator)
    strings/ctype-utf8.c:
      if( -> if (
    strings/ctype.c:
      Remove disabled code
    strings/decimal.c:
      Indentation fixes
    strings/xml.c:
      Indentation fixes
    306ebf7b
item_cmpfunc.h 36.9 KB