• unknown's avatar
    changes to mysqladmin : use queries instead of commands (so that they have a chance to go · 80c1556a
    unknown authored
    into the binlog), SLAVE START -> START SLAVE, error test changes.
    
    
    client/mysqladmin.c:
      Now that FLUSH TABLES and some other FLUSH go into the binlog, the same commands
      issued from mysqladmin should also go into the binlog. How could I explain to
      a user that "mysql -e 'flush tables'" is not exactly the same as "mysqladmin
      flush-tables" ?? So I replace mysql_refresh() by mysql_query().
      Also SLAVE START -> START SLAVE to make this work with 4.1 (it won't work with
      3.23 anymore).
      Also the code tested for mysql_refresh() < 0 for errors, but this cannot happen :
      - mysql_refresh() calls simple_command()
      - in 4.1 the return type of simple_command() is my_bool, and I have checked the 4.1 libmysql
      code and it returns 0 or 1, not negative values.
      - note that in 4.0 libmysql, simple_command() returns int which can be < 0, but we don't
      care here as we link the 4.1 mysqladmin with the 4.1 libmysql.
      Btw, some other parts of the code already checked
      for mysql_refresh() != 0, not < 0. So now it's homogenous : we always test for != 0
      instead of < 0.
    80c1556a
mysqladmin.c 31.7 KB