• Konstantin Osipov's avatar
    Backport of revno 2630.28.10, 2630.28.31, 2630.28.26, 2630.33.1, · 8ec23470
    Konstantin Osipov authored
    2630.39.1, 2630.28.29, 2630.34.3, 2630.34.2, 2630.34.1, 2630.29.29,
    2630.29.28, 2630.31.1, 2630.28.13, 2630.28.10, 2617.23.14 and
    some other minor revisions.
    
    This patch implements: 
    
    WL#4264 "Backup: Stabilize Service Interface" -- all the
    server prerequisites except si_objects.{h,cc} themselves (they can
    be just copied over, when needed).
    
    WL#4435: Support OUT-parameters in prepared statements.
    
    (and all issues in the initial patches for these two
    tasks, that were discovered in pushbuild and during testing).
    
    Bug#39519: mysql_stmt_close() should flush all data
    associated with the statement.
    
    After execution of a prepared statement, send OUT parameters of the invoked
    stored procedure, if any, to the client.
    
    When using the binary protocol, send the parameters in an additional result
    set over the wire.  When using the text protocol, assign out parameters to
    the user variables from the CALL(@var1, @var2, ...) specification.
    
    The following refactoring has been made:
      - Protocol::send_fields() was renamed to Protocol::send_result_set_metadata();
      - A new Protocol::send_result_set_row() was introduced to incapsulate
        common functionality for sending row data.
      - Signature of Protocol::prepare_for_send() was changed: this operation
        does not need a list of items, the number of items is fully sufficient.
    
    The following backward incompatible changes have been made:
      - CLIENT_MULTI_RESULTS is now enabled by default in the client;
      - CLIENT_PS_MULTI_RESUTLS is now enabled by default in the client.
    
    include/mysql.h:
      Add a new flag to MYSQL_METHODS::flush_use_result
      function pointer. This flag determines if all results
      should be flushed or only the first one:
          
      - if flush_all_results is TRUE, then cli_flush_use_result()
        will read/flush all pending results. I.e. it will read
        all packets while server status attribute indicates that
        there are more results. This is a new semantic, required
        to fix the bug.
                  
      - if flush_all_results is FALSE, the old sematic
        is preserved -- i.e. cli_flush_use_result() reads data
        until first EOF-packet.
    include/mysql.h.pp:
      Update the ABI with new calls (compatible changes).
    include/mysql_com.h:
      Add CLIENT_PS_OUT_PARAMS -- a client capability indicating that the client supportsю
    libmysql/libmysql.c:
      Add mysql_stmt_next_result() -- analogue of mysql_next_result() for binary protocol.
      Fix a minor bug in alloc_fields() -- not all members were copied over,
      and some only shallow-copied (catalog).
      Flush all results in mysql_stmt_close() (Bug#39519).
    libmysqld/lib_sql.cc:
      Rename send_fields() -> send_result_set_metadata().
      Refactoring: change prepare_for_send() so that it accepts only 
      what it really needs -- a number of elements in the list.
    mysql-test/r/ps.result:
      Update results: WL#4435.
    mysql-test/t/ps.test:
      WL#4435: A test case for an SQL-part of the problem.
    sql-common/client.c:
      Bug#39519.
      Implement new functionality in cli_flush_use_result():
      if flush_all_delete is TRUE, then it should read/flush
      all pending results.
    sql/Makefile.am:
      Add a new header sql_prepare.h to the list
      of build headers.
    sql/events.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/handler.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/mysql_priv.h:
      Move sql_prepare.cc-specific declarations to a new
      header - sql_prepare.h.
    sql/procedure.h:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/protocol.cc:
      Move the logic responsible for sending of one result
      set row to the Protocol class. Define a template
      for end-of-statement action. 
      Refactoring: change prepare_for_send() so that it accepts 
      only what it really needs -- a number of elements in the list.
      Rename send_fields() to send_result_set_metadata().
    sql/protocol.h:
      Update with new declarations (WL#4435).
      Rename send_fields() -> send_result_set_metadata().
      prepare_for_send() only needs the number of columns to send,
      and doesn't use the item list - update signature to require
      only what's needed.
      Add a new protocol type -- Protocol_local.
    sql/repl_failsafe.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/slave.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_acl.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_base.cc:
      Include sql_prepare.h (for Reprepare_observer).
    sql/sql_cache.cc:
      Extend the query cache flags block to be able
      to store a numeric id for the result format,
      not just a flag binary/non-binary.
    sql/sql_class.cc:
      Update to use the rename of Protocol::send_fields()
      to Protocol::send_result_set_metadata().
      Use Protocol::send_one_result_set_row().
    sql/sql_class.h:
      Move the declaration of Reprepare_observer to the 
      new header - sql_prepare.h.
      Update to the new signature of class Protocol::send_fields().
    sql/sql_connect.cc:
      Use a protocol template method instead of
      raw NET layer API at the end of a statement.
    sql/sql_cursor.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_error.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_handler.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
      Use new method Protocol::send_one_result_set_row().
    sql/sql_help.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_lex.cc:
      Initialize multi_statements variable.
      Add a handy constant for empty lex
      string.
    sql/sql_lex.h:
      Add a separate member for a standalone
      parsing option - multi-statements support.
    sql/sql_list.cc:
      sql_list.h is a standalone header now, 
      no need to include mysql_priv.h.
    sql/sql_list.h:
      Make sql_list.h a stand-alone header.
    sql/sql_parse.cc:
      Include sql_prepare.h for prepared
      statements- related declarations.
      Use a new Protocol template method to end
      each statement (send OK, EOF or ERROR to
      the client).
    sql/sql_prepare.cc:
      Implement Execute Direct API (WL#4264), 
      currently unused. It will be used by the service
      interface (Backup).
      Use a new header - sql_prepare.h.
      Add support for OUT parameters in the 
      binary and text protocol (prepared statements 
      only).
    sql/sql_prepare.h:
      Add a new header to contain (for now)
      all prepared statement- external
      related declarations.
    sql/sql_profile.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_repl.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_select.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_show.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_string.h:
      Add a way to convert a String to LEX_STRING.
    sql/sql_table.cc:
      Rename: Protocol::send_fields() -> 
      Protocol::send_result_set_metadata().
    sql/sql_update.cc:
      Remove an extraneous my_error(). The error
      is already reported in update_non_unique_table_error().
    sql/sql_yacc.yy:
      Support for multi-statements is an independent
      property of parsing, not derived from 
      the protocol type.
    tests/mysql_client_test.c:
      Add tests for WL#4435 (binary protocol).
    8ec23470
sql_show.cc 238 KB