• Jon Olav Hauglid's avatar
    Bug#11853126 RE-ENABLE CONCURRENT READS WHILE CREATING · 9b076952
    Jon Olav Hauglid authored
                 SECONDARY INDEX IN INNODB
    
    The patches for Bug#11751388 and Bug#11784056 enabled concurrent
    reads while creating secondary indexes in InnoDB. However, they
    introduced a regression. This regression occured if ALTER TABLE
    failed after the index had been added, for example during the
    lock upgrade needed to update .FRM. If this happened, InnoDB
    and the server got out of sync with regards to which indexes
    actually existed. Therefore the patch for Bug#11815600 again
    disabled concurrent reads.
    
    This patch re-enables concurrent reads. The original regression
    is fixed by splitting the ADD INDEX operation into two parts.
    First the new index is created but not made active. This is
    done while concurrent reads are allowed. The second part of
    the operation makes the index active (or reverts the change).
    This is done after lock upgrade, which prevents the original
    regression.
    
    In order to implement this change, the patch changes the storage
    API for in-place index creation. handler::add_index() is split
    into two functions, handler_add_index() and
    handler::final_add_index(). The former for creating indexes without
    making them visible and the latter for commiting (i.e. making
    visible) new indexes or reverting the changes.
    
    Large parts of this patch were written by Marko Mäkelä.
    
    Test case added to innodb_mysql_lock.test.
    9b076952
innodb_mysql_sync.test 6.83 KB