• Georgi Kodinov's avatar
    Bug #42116 : Mysql crash on specific query · ac373248
    Georgi Kodinov authored
    Queries with nested outer joins may lead to crashes or 
    bad results because an internal data structure is not handled
    correctly.
    The optimizer uses bitmaps of nested JOINs to determine
    if certain table can be placed at a certain place in the
    JOIN order.
    It does maintain a bitmap describing in which JOINs 
    last placed table is nested.
    When it puts a table it makes sure the bit of every JOIN that
    contains the table in question is set (because JOINs can be nested).
    It does that by recursively setting the bit for the next enclosing
    JOIN when this is the first table in the JOIN and recursively 
    resetting the bit if it's the last table in the JOIN.
    When it removes a table from the join order it should do the
    opposite : recursively unset the bit if it's the only remaining 
    table in this join and and recursively set the bit if it's removing
    the last table of a JOIN.
    There was an error in how the bits was set for the upper levels :
    when removing a table it was setting the bit for all the enclosing 
    nested JOINs even if there were more tables left in the current JOIN
    (which practically means that the upper nested JOINs were not affected).
    Fixed by stopping the recursion at the relevant level.
    
    mysql-test/r/join.result:
      Bug #42116: test case
    mysql-test/t/join.test:
      Bug #42116: test case
    sql/sql_select.cc:
      Bug #41116: don't go up and set the bits if more tables in
      at the current JOIN level
    ac373248
join.test 32.1 KB